AssertThatJava8Optional and AssertThatGuavaOptional inspections do not longer try to fix assertThat(optional).isEqualTo(Optional.fromNullable(expression)) to contains() when expression is not a non-null constant expression.

2019-07-30 20:02:40 +02:00
parent 8fb3ecce95
commit 4420a0a392
9 changed files with 44 additions and 5 deletions
@@ -30,8 +30,14 @@ public class Java8Optional {
        assertThat(opt).isPresent();
        assertThat(opt).isPresent();

+        String possibleNullString = System.getProperty("username");
+        String notNullString = "Narf";
+
        assertThat(opt).as("foo").contains("foo");
        assertThat(opt).contains("foo");
+        assertThat(opt).isEqualTo(Optional.ofNullable(null));
+        assertThat(opt).isEqualTo(Optional.ofNullable(possibleNullString));
+        assertThat(opt).isEqualTo(Optional.ofNullable(notNullString));
        assertThat(opt).isNotEqualTo(Optional.of("foo"));
        assertThat(opt).isNotEqualTo(Optional.ofNullable("foo"));