.idea/saveactions_settings.xml

@@ -18,7 +18,6 @@
     <option name="configurationPath" value="" />
     <option name="exclusions">
       <set>
-        <option value=".*\.md" />
         <option value="src/test/resources/.*" />
       </set>
     </option>

.travis.yml

@@ -1,6 +1,6 @@
 language: java
 jdk:
-  - openjdk11
+  - openjdk8
 
 before_script:
   - chmod +x gradlew

LICENSE.TXT

@@ -1,4 +1,4 @@
-Copyright 2019-2024 Chris Hodges <chrisly@platon42.de>
+Copyright 2019 Chris Hodges <chrisly@platon42.de>
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -10,4 +10,4 @@ Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
-limitations under the License.
+limitations under the License.

README.md

@@ -1,4 +1,4 @@
-# Cajon - Concise AssertJ Optimizing Nitpicker
+# Cajon - Concise AssertJ Optimizing Nitpicker [![Build Status](https://travis-ci.org/chrisly42/cajon-plugin.svg?branch=master)](https://travis-ci.org/chrisly42/cajon-plugin) [![Coverage Status](https://coveralls.io/repos/github/chrisly42/cajon-plugin/badge.svg?branch=master)](https://coveralls.io/github/chrisly42/cajon-plugin?branch=master)
 
 Cajon is an IntelliJ IDEA Plugin for shortening and optimizing [AssertJ](https://assertj.github.io/doc/) assertions.
 
@@ -34,40 +34,28 @@ Then AssertJ would tell you the _actual contents_ of the collection on failure.
 
 The plugin also supports the conversion of the most common JUnit 4 assertions to AssertJ.
 
-## Wrong use of AssertJ
-
-Cajon also warns about bogus or incorrect uses of AssertJ.
-
 ## Lookup and refactoring of string-based extracting()
 
-AssertJ
+AssertJ allows [extracting POJO fields/properties on iterables/arrays](http://joel-costigliola.github.io/assertj/assertj-core-features-highlight.html#extracted-properties-assertion).
-allows [extracting POJO fields/properties on iterables/arrays](http://joel-costigliola.github.io/assertj/assertj-core-features-highlight.html#extracted-properties-assertion).
 
 Using strings is not safe for refactoring (and before Java 8 Lambdas were available,
 creating extractor functions just for testing purpose was a bit too tedious).
 
-This plugin adds support for referencing these fields (so you can ctrl(/cmd)-click on the
+This plugin adds support for referencing these fields (so you can ctrl(/cmd)-click on the 
-string to go to the definition) and allows safe refactoring on the
+string to go to the definition) and also allows safe refactoring on the 
-fields (refactoring a getter method without a corresponding field will not work
+fields (refactoring a getter method without a corresponding field will not work 
-correctly right now) too.
+correctly right now).
 
 ## Usage
 
-Cajon (though written in Kotlin) *only works with Java projects*.
-There does not seem too much demand for AssertJ within Kotlin projects
-and although possible, it would require a complete rewrite as the PSI
-stuff in IntelliJ is very Java focused. Almost zero feedback is also not helping.
-Enough bickering.
-
 The plugin will report inspections in your opened editor file as warnings.
 You can then quick-fix these with your quick-fix hotkey (usually Alt-Return or Opt-Return).
 
 Or, you can use the "Run Inspection by Name..." action to run one inspection on a bigger scope (e.g. the whole project).
-Applying a quick fix might result in further optimization possibilities, so
+Applying a quick fix might result in further optimization possibilities, so 
 you might need to perform a couple of fixes before you get to the final result.
 
 Check out this example where every line represents the result after a Cajon quickfix:
-
 ```
 assertFalse(!(array.length == collection.size()));
 
@@ -85,7 +73,7 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
 ## Implemented inspections and quickfixes
 
 - JoinAssertThatStatements
-
+  
   Joins multiple ```assertThat()``` statements with same actual expression together.
 
   ```
@@ -95,21 +83,21 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
                             .anotherCondition();
   ```
   Joining will work on actual expressions inside ```assertThat()``` that are equivalent expressions,
-  except for method calls with known side effect methods such as ```Iterator.next()``` and
+  except for method calls with known side-effect methods such as ```Iterator.next()``` and
   pre/post-increment/decrement operations -- please notify me about others.
 
   The comments of the statements will be preserved. When using ```extracting()``` or similar,
   the statements will not be merged.
-
+  
   The behavior regarding the insertion of line breaks between the expressions can be configured in the
   inspection settings.
 
 - JoinVarArgsContains
 
-  Looks for ```.contains()```, ```.doesNotContain()```, and .```containsOnlyOnce()``` calls for iterables
+  Looks for ```.contains()```, ```.doesNotContain()```, and .```containsOnlyOnce()``` calls for iterables 
   within the same statement. The available quickfix can join the arguments to variadic version of the call
   and remove the surplus one.
-
+  
   ```
   from: assertThat(expected).contains("foo").doesNotContain("bar").contains("etc").doesNotContain("huh");
     to: assertThat(expected).contains("foo", "etc").doesNotContain("bar", "huh");
@@ -118,7 +106,7 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
   changing semantics or losing descriptions.
 
   Note that the quickfix does not handle comments very well and might remove them during the operation.
-
+  
   You may need to perform some manual reformatting, if the line gets too long after applying the fix.
 
 - AssertThatObjectIsNullOrNotNull
@@ -144,25 +132,18 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
 
 - AssertThatInvertedBooleanCondition
 
-  Inverts the boolean condition in either ```assertThat()``` or ```isEqualTo()```/```isNotEqualTo()```
+  Inverts the boolean condition to make it more readable.
-  to make it more readable.
+  
-
   ```
   from: assertThat(!booleanValue).isEqualTo(true/false/Boolean.TRUE/Boolean.FALSE);  
   from: assertThat(!booleanValue).isTrue()/isFalse();  
     to: assertThat(booleanValue).isFalse()/isTrue();
-
-  from: assertThat(booleanValue).isEqualTo(!primitiveBooleanExpression);  
-    to: assertThat(booleanValue).isNotEqualTo(primitiveBooleanExpression);
-
-  from: assertThat(booleanValue).isNotEqualTo(!primitiveBooleanExpression);  
-    to: assertThat(booleanValue).isEqualTo(primitiveBooleanExpression);
   ```
 
 - AssertThatInstanceOf
 
   Moves ```instanceof``` expressions out of ```assertThat()```.
-
+  
   ```
   from: assertThat(object instanceof classname).isEqualTo(true);
   from: assertThat(object instanceof classname).isTrue();
@@ -173,23 +154,6 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
     to: assertThat(object).isNotInstanceOf(classname.class);
   ```
 
-- AssertThatIsZeroOne
-
-  Uses ```isZero()```, ```isNotZero()``` and ```isOne()``` instead.
-  Works with shorts, integers, longs, floats and doubles, and tries to evaluate
-  constant expressions, too.
-
-  ```
-  from: assertThat(numeric).isEqualTo(0);
-    to: assertThat(numeric).isZero();
-
-  from: assertThat(numeric).isNotEqualTo(0);
-    to: assertThat(numeric).isNotZero();
-
-  from: assertThat(numeric).isEqualTo(1);
-    to: assertThat(numeric).isOne();
-  ```
-
 - AssertThatStringIsEmpty
 
   Uses ```isEmpty()``` for empty string assertions.
@@ -203,9 +167,9 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
   The ```assertThat(string.length()).isEqualTo(0);``` case is handled in the AssertThatSize inspection.
 
 - AssertThatStringExpression
-
+  
   Moves string operations inside ```assertThat()``` out.
-
+  
   ```
   from: assertThat(stringActual.isEmpty()).isTrue();
     to: assertThat(stringActual).isEmpty();
@@ -230,7 +194,7 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
     to: assertThat(stringActual).matches(stringExpected);
   ```
   Analogously with ```isFalse()```.
-
+  
   More funny stuff (excerpt):
 
   ```
@@ -258,7 +222,7 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
 - AssertThatObjectExpression
 
   Handles ```equals()```, ```toString()``` and ```hashCode()``` inside an expected expression.
-
+  
   ```
   from: assertThat(objActual.equals(objExpected)).isTrue();
     to: assertThat(objActual).isEqualTo(objExpected);
@@ -270,35 +234,6 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
     to: assertThat(objActual).hasSameHashCodeAs(objExpected);
   ```
 
-- AssertThatComparableExpression
-
-  Handles ```compareTo()``` inside an expected expression.
-
-  ```
-  from: assertThat(obj1.compareTo(obj2)).isEqualTo(0);
-    to: assertThat(obj1).isEqualByComparingTo(obj2);
-
-  from: assertThat(obj1.compareTo(obj2)).isNotZero();
-    to: assertThat(obj1).isNotEqualByComparingTo(obj2);
-
-  from: assertThat(obj1.compareTo(obj2)).isNotEqualTo(-1);
-  from: assertThat(obj1.compareTo(obj2)).isGreaterThanOrEqualTo(0);
-  from: assertThat(obj1.compareTo(obj2)).isGreaterThan(-1);
-  from: assertThat(obj1.compareTo(obj2)).isNotNegative();
-    to: assertThat(obj1).isGreaterThanOrEqualTo(obj2);
-
-  from: assertThat(obj1.compareTo(obj2)).isOne();
-    to: assertThat(obj1).isGreaterThan(obj2);
-
-  from: assertThat(obj1.compareTo(obj2)).isNotPositive();
-    to: assertThat(obj1).isLessThanOrEqualTo(obj2);
-  
-  from: assertThat(obj1.compareTo(obj2)).isLessThan(0);
-    to: assertThat(obj1).isLessThan(obj2);
-  ```
-
-  Several more combinations omitted...
-
 - AssertThatCollectionOrMapExpression
 
   Moves ```Collection``` and ```Map``` operations inside ```assertThat()``` out.
@@ -339,11 +274,11 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
   from: assertThat(map.get(key)).isNull();
     to: assertThat(map).doesNotContainKey(key);
   ```
-
+  
-  The last transformation is the default, but may not be 100% equivalent depending upon the map
+  The last transformation is the default, but may not be 100% equivalent depending whether the map
-  being a degenerated case with ```null``` values, where ```map.get(key)``` returns ```null```,
+  is a degenerated case with ```null``` values, where ```map.get(key)``` returns ```null```,
   but ```containsKey(key)``` is ```true```.
-  For that special case (which is usually the result of a bad design decision!)
+  For that special case (which usually is the result of a bad design decision!)
   the quickfix should rather generate ```assertThat(map).containsEntry(key, null)```.
   Therefore, the behavior can be configured in the settings for this inspection to either
   create the default case (```doesNotContainKey```), the degenerated case (```containsEntry```),
@@ -398,64 +333,13 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
     to: assertThat(file).isNotEmptyDirectory();
   ```
 
-  and additionally with AssertJ 3.14.0 or later
-
-  ```
-  from: assertThat(file.length()).isEqualTo(0);
-  from: assertThat(file.length()).isZero();
-    to: assertThat(file).isEmpty();
-
-  from: assertThat(file.length()).isNotEqualTo(0);
-  from: assertThat(file.length()).isNotZero();
-    to: assertThat(file).isNotEmpty();
-
-  from: assertThat(file.length()).isEqualTo(len);
-    to: assertThat(file).hasSize(len);
-  ```
-
-- AssertThatPathExpression
-
-  Moves ```Path``` method calls inside ```assertThat()``` out.
-  Note: Uses hasParentRaw() instead of hasParent() for quickfixes, because it is semantically
-  equivalent. For most cases though, hasParent() will show identical behavior.
-
-  ```
-  from: assertThat(path.isAbsolute()).isTrue();
-    to: assertThat(path).isAbsolute();
-
-  from: assertThat(path.isAbsolute()).isFalse();
-    to: assertThat(path).isRelative();
-
-  from: assertThat(path.getParent()).isEqualTo(pathname);
-    to: assertThat(path).hasParentRaw(pathname);
-
-  from: assertThat(path.getParent()).isNull();
-    to: assertThat(path).hasNoParentRaw();
-
-  from: assertThat(path.startsWith(otherPath)).isTrue();
-    to: assertThat(path).startsWithRaw(otherPath);
-
-  from: assertThat(path.endsWith(otherPath)).isTrue();
-    to: assertThat(path).endsWithRaw(otherPath);
-  ```
-
 - AssertThatEnumerableIsEmpty
 
-  Uses ```isEmpty()``` for ```hasSize(0)```, ```hasSizeLessThanOrEqualTo(0)```, and
+  Uses ```isEmpty()``` for ```hasSize(0)``` iterable assertions instead.
-  ```hasSizeLessThan(1)``` iterable (enumerable) assertions instead.
+  
-
-  Also suggests ```isNotEmpty()``` for ```hasSizeGreaterThan(0)``` and
-  ```hasSizeGreaterThanOrEqualTo(1)```.
-
   ```
   from: assertThat(enumerable).hasSize(0);
-  from: assertThat(enumerable).hasSizeLessThanOrEqualTo(0);
-  from: assertThat(enumerable).hasSizeLessThan(1);
     to: assertThat(enumerable).isEmpty();
-
-  from: assertThat(enumerable).hasSizeGreaterThan(0);
-  from: assertThat(enumerable).hasSizeGreaterThanOrEqualTo(1);
-    to: assertThat(enumerable).isNotEmpty();
   ```
 
 - AssertThatSize
@@ -530,84 +414,6 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
   ```
   ...and many, many more combinations (more than 150).
 
-- TwistedAssertion
-
-  Examines the actual expression for common mistakes such as mixing expected and actual expression.
-  For simple cases, a quick fix is offered to swap them. Otherwise, only a warning is issued.
-
-  ```
-  from: assertThat(5).isEqualTo(variable);
-    to: assertThat(variable).isEqualTo(5);
-
-  from: assertThat(8.0).isGreaterThan(variable);
-    to: assertThat(variable).isLessOrEqualTo(8.0);
-  ```
-
-  There are, of course, more variations of the theme.
-
-  If both sides of an assertion are constant expressions, the problem will only appear as
-  a weak warning without a quick fix.
-
-  Constants used on the actual side of ```.matches()``` and ```doesNotMatch()``` will not be
-  reported for regular expression testing.
-
-  Neither will a ```Class``` type be considered a constant in the classic sense, so
-  ```assertThat(SomeClass.class).isAssignableFrom(SomeOtherClass.class)``` will not be reported.
-
-- BogusAssertion
-
-  Sometimes programmers make copy and paste or logical errors writing down assertions
-  that will never fail due to the same actual and expected assertions.
-  This inspection will warn about obvious cases such as the following ones.
-
-  ```
-  assertThat(object).isEqualTo(object);
-  assertThat(object).isSameAs(object);
-  assertThat(object).hasSameClassAs(object);
-  assertThat(object).hasSameHashCodeAs(object);
-
-  assertThat(array).hasSameSizeAs(array);
-  assertThat(array).contains(array);
-  assertThat(array).containsAnyOf(array);
-  assertThat(array).containsExactly(array);
-  assertThat(array).containsExactlyInAnyOrder(array);
-  assertThat(array).containsExactlyInAnyOrder(array);
-  assertThat(array).containsOnly(array);
-  assertThat(array).containsSequence(array);
-  assertThat(array).containsSubsequence(array);
-  assertThat(array).startsWith(array);
-  assertThat(array).endsWith(array);
-  
-  assertThat(enumerable).hasSameSizeAs(enumerable);
-
-  assertThat(iterable).hasSameElementsAs(iterable);
-  assertThat(iterable).containsAll(iterable);
-  assertThat(iterable).containsAnyElementOf(iterable);
-  assertThat(iterable).containsOnlyElementsOf(iterable);
-  assertThat(iterable).containsExactlyElementsOf(iterable);
-  assertThat(iterable).containsSequence(iterable);
-  assertThat(iterable).containsSubsequence(iterable);
-
-  assertThat(charSeq).isEqualToIgnoringCase(charSeq);
-  assertThat(charSeq).startsWith(charSeq);
-  assertThat(charSeq).endsWith(charSeq);
-  assertThat(charSeq).containsSequence(charSeq);
-  assertThat(charSeq).containsSubsequence(charSeq);
-
-  assertThat(map).containsAllEntriesOf(map);
-  assertThat(map).containsExactlyEntriesOf(map);
-  assertThat(map).containsExactlyInAnyOrderEntriesOf(map);
-  assertThat(map).hasSameSizeAs(map);
-  ```
-
-  Note that expressions with method calls will not cause a warning as the method call might have side effects
-  that result in the assertion not being bogus at all.
-
-  If the assertions is either ```isEqualTo()``` or ```hasSameHashCodeAs()``` it may be checking custom
-  ```equals()``` or ```hashCode()``` behavior. If the test method name containing the statement has a
-  name that contains 'equal' or 'hashcode' (case-insensitive), the warning will be weakened to information
-  level.
-
 - ImplicitAssertion
 
   Detects and removes implicit use of ```isNotNull()```, ```isNotEmpty()``` and
@@ -629,9 +435,9 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
 - AssertThatJava8Optional
 
   Examines the statement for Java 8 ```Optional``` type and whether the statement
-  effectively tries to assert the presence, absence or content and then
+  effectively tries to assert the presence, absence or content and then 
   replaces the statement by better assertions.
-
+  
   ```
   from: assertThat(opt.isPresent()).isEqualTo(true);
   from: assertThat(opt.isPresent()).isNotEqualTo(false);
@@ -669,7 +475,7 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
 - AssertThatGuavaOptional
 
   Examines the statement for Google Guava ```Optional``` type and whether the statement
-  effectively tries to assert the presence, absence or content and then
+  effectively tries to assert the presence, absence or content and then 
   replaces the statement by better assertions.
 
   ```
@@ -708,26 +514,26 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
 - AssumeThatInsteadOfReturn
 
   Tries to detect bogus uses of return statements in test methods and replaces them by ```assumeThat()``` calls.
-
+  
   Novices will use these to skip test execution by bailing out early on some preconditions not met.
   However, this suggests that the test has actually been run and passed instead of showing the test
   as being skipped.
 
-  Return statements in ```if``` statements in main test methods (must be annotated with JUnit 4 or
+  Return statements in ```if``` statements in main test methods (must be annotated with JUnit 4 or 
   Jupiter ```@Test``` annotations) will be verified to have at least one ```assertThat()``` statement in the code flow.
   Method calls within the same class will be examined for ```assertThat()``` statements, too.
   However, at most 50 statements and down to five recursions will be tolerated before giving up.
-
+  
   Currently, the quickfix may lose some comments during operation. The other branch of the ```if``` statement
   will be inlined (blocks with declarations will remain a code block due to variable scope).
   The quickfix will only work with AssertJ >= 2.9.0 (for 2.x releases) or >= 3.9.0 (for 3.x releases).
-
+  
   The generated ```assumeThat()``` statement could be optimized further (similar to ```assertThat()```), but
   there is currently no support in Cajon for this (you could rename the method to ```assertThat()``` optimize it
   and turn it back into ```assumeThat()``` in the end).
 
   Example:
-
+  
   ```
       @Test
       public void check_fuel_emission() {
@@ -751,14 +557,14 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
 - JUnitAssertToAssertJ
 
   Tries to convert most of the JUnit 4 assertions and assumptions to AssertJ format.
-  Sometimes the expected and actual expressions are specified in wrong order --
+  Sometimes the expected and actual expressions are specified in wrong order -- 
   Cajon tries to swap these when it detects the supposed actual expression to be a
   constant while the expected one is not.
 
   Does not support Hamcrest-Matchers.
   If you need that kind of conversion, you might want to check out the
   [Assertions2AssertJ plugin](https://plugins.jetbrains.com/plugin/10345-assertions2assertj) by Ric Emery.
-
+  
   ```
   assertTrue(condition);
   assertTrue(message, condition);
@@ -796,9 +602,8 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
 
 ### Implemented referencing
 
-You can ctrl-click on references inside .extracting() method parameters to go the
+  You can ctrl-click on references inside .extracting() method parameters to go the
-referencing method definition.
+  referencing method definition.
-
   ```
   .extracting("field")
   .extracting("outerField.fieldInsideObjectTypeOfOuterField.andSoOn")
@@ -812,100 +617,32 @@ referencing method definition.
   .flatExtracting(Extractors.byName("fieldOrPropertyOrBareMethod.orAPathLikeAbove")
   .flatExtracting(Extractors.resultOf("bareMethod")
   ```
-
+  This works on both POJOs and ```Iterable```s/```Array```s. 
-This works on both POJOs and ```Iterable```s/```Array```s.
+  Implementation is very basic though and does not work with fancy cascaded ```.extracting()``` sequences.
-Implementation is very basic though and does not work with fancy cascaded ```.extracting()``` sequences.
+  If there's demand, I could add it.
-If there's demand, I could add it.
 
 ## Development notice
 
-Cajon is written in Kotlin 1.7.
+Cajon is written in Kotlin 1.3.
 
-Cajon is probably the only plugin that uses JUnit 5 Jupiter for unit testing so far (or at least the only one I'm aware of ;) ).
+Cajon is probably the only plugin that uses JUnit 5 Jupiter for unit testing so far (or at least the only one that I'm aware of ;) ).
-The IntelliJ framework actually uses the JUnit 3 TestCase for plugin testing, and it took me quite a while to make it work with JUnit 5.
+The IntelliJ framework actually uses the JUnit 3 TestCase for plugin testing and it took me quite a while to make it work with JUnit 5.
 Feel free to use the code (in package ```de.platon42.intellij.jupiter```) for your projects (with attribution).
 
 ## Planned features
-
 - More Optional fixes such as ```opt1.get() == opt2.get()``` etc.
-- More moving out of methods for LocalDate/Time etc.
+- More moving out of methods for Path, LocalDate/Time etc.
-- assertThat(foo.toLowerCase()/toUpperCase()).isEqualTo("foo") -> assertThat(foo).isEqualToIgnoringCase()
+- Converting ```foo.compareTo(bar) == 0``` to ```isEqualTo()``` (yes, I've *really* seen code like that)
 - Extraction with property names to lambda/method reference with Java 8
 
   ```
   from: assertThat(object).extracting("propOne", "propNoGetter", "propTwo.innerProp")...
     to: assertThat(object).extracting(type::getPropOne, it -> it.propNoGetter, it -> it.getPropTwo().getInnerProp())...
   ```
-- Support primitives in assertThat(map.containsKey(1)).isTrue();
 
 ## Changelog
 
-### V1.14 (19-Feb-24)
-
-- Now requires minimum version 2022.2.
-- Maintenance. Updated various dependencies (Kotlin 1.9.22) and AssertJ 3.25.3 and AssertJ-Guava 3.25.3.
-- Reworked JUnit 5 test framework to work again. However, all the tests are broken.
-  I spent several days trying to figure out what is going on, but I'm giving up on this pile of crap called IntelliJ.
-  Jetbrains keeps breaking the APIs and implementations every year and I just cannot be bothered anymore.
-- This is very likely the last version.
-
-### V1.13 (18-Aug-22)
-
-- API change in IntelliJ platforms now requires minimum version 2019.3.1. Sorry, giving up to maintain compatibility after four attempts.
-- Maintenance. Updated various dependencies (Kotlin 1.7.10) and AssertJ 3.23.1 and AssertJ-Guava 3.5.0.
-- Tried to fix unreproducible issue #9.
-- Added AssertThatIsZeroOne inspection demanded by issue #5.
-- Fix for wrongly joining statements that cannot be trivially joined (e.g. with filteredOn). Fixes issue #6.
-
-### V1.12 (06-May-21)
-
-- Maintenance. Updated various dependencies (Kotlin 1.50.0) and AssertJ 3.19.0
-- Fixed issue#3 reported by hankem where usingRecursiveComparison() was not considered a complex transformation.
-
-#### V1.11 (03-Oct-20) Day of German Unity Edition
-
-- Now is being built with JDK 11 (with Java 8 target).
-- Updated various dependencies (Kotlin 1.40.10) and AssertJ 3.17.2.
-- Fixed the ImplicitAssertion inspection that broke the plugin with IntelliJ 2020.3 EAP as reported by Frédéric Thomas.
-  Thanks!
-- Added new singleElement() from AssertJ >= 3.17.0 to ImplicitAssertionInspection.
-- Added several cases for ```hasSizeGreaterThan/LessThan/OrEqualTo()``` for EnumerablesEmpty inspection.
-- Added inversion of boolean conditions inside ```isEqualTo()``` and ```isNotEqualTo()``` for InvertedBooleanCondition
-  inspection.
-
-#### V1.10 (31-Jul-20) Friday the 31st Edition
-
-- Updated libraries to the latest versions (including AssertJ 3.16.1 and Kotlin 1.40-rc).
-- Fixed two possible index out-of-bounds exceptions in ExtractorReferenceContributor and BogusAssertionInspection.
-
-#### V1.9 (25-Feb-20) Mardi Gras Edition
-
-- TwistedAssertion inspection will no longer warn for ```.matches()``` and ```doesNotMatch()``` for regular expressions.
-  Apparently, ```assertThat("somestring").matches(regex)``` is a valid test if the regex is what needs to be tested.
-  If the actual expression is of ```Class``` type, this will no longer be reported.
-- If the expected expression in TwistedAssertion is also a constant, the warning will be weakened and
-  no quick fix will be available.
-- BogusAssertion inspection will no longer warn if the expression contains method calls.
-  Moreover, for assertions of ```isEqualTo()``` and ```hasSameHashCodeAs()```, AND if the containing method name contains 'equal' or 'hashcode',
-  the warning will be reduced to information level as the assertion may be testing ```equals()``` or ```hashCode()``` for validity.
-
-#### V1.8 (14-Feb-20) Valentine Edition
-
-- Maintenance. Removed experimental API use. Updated dependencies. Fixed testing problems introduced with IntelliJ IDEA 2019.3
-- Added new TwistedAssertion inspection that will warn about assertions with the actual expression being a constant indicating
-  swapped use of actual and expected expressions.
-- Added new BogusAssertion inspection that showing typical copy and paste errors where actual and expected expressions are the same.
-
-#### V1.7 (19-Nov-19)
-
-- Fixed a lapsuus in AssertThatFileExpression also transforming ```.listFiles()``` with a filter argument.
-- Added first version of AssertThatPathExpression for a limited number transformations (more stuff is possible,
-  but requires detection and transformation of static ```Files```-methods).
-- Added AssertThatComparableExpression for funny ```compareTo()``` uses.
-- Added ```hasSize(), isEmpty()``` and ```isNotEmpty()``` for AssertThatFileExpression when using AssertJ >= 3.14.0.
-
 #### V1.6 (30-Sep-19)
-
 - Really fixed AssertThatGuavaOptional inspections to avoid conversions from ```.get()``` to ```.contains()```
   for array types. Sigh. Shouldn't be working >12h a day and then do some more stuff at home.
 - Fixed a bug in AssertThatBinaryExpression inspection for ```assertThat(null != expression)``` and related
@@ -916,38 +653,33 @@ Feel free to use the code (in package ```de.platon42.intellij.jupiter```) for yo
   Specifically, uses of ```matches()```, ```compareToIgnoreCase()```, ```indexOf()```, and ```trim()```.
 
 #### V1.5 (24-Sep-19)
-
+- Fix for AssertThatCollectionOrMap inspection sometimes causing an index out of bounds exception.
-- Fix for AssertThatCollectionOrMap inspection sometimes causing an index out-of-bounds exception.
 - AssertThatGuavaOptional inspections will now avoid conversions from ```.get()``` to ```.contains()```
   for array types (currently not correctly supported by ```contains()``` in AssertJ-Guava).
-- Added a settings option for AssertThatCollectionOrMap inspection respecting the degenerated case of maps with ```null``` values.
+- Added an settings option for AssertThatCollectionOrMap inspection respecting the degenerated case of maps with ```null``` values.
   It is now possible to change the behavior for ```map.get(key) == null```, so it can offer either ```.doesNotContainKey()``` (default)
   or ```.containsEntry(key, null)```, or even both.
 - Fixes to AssertThatSize inspection after extending it for Maps in previous release as not all
   combinations for ```.hasSameSizeAs()``` are supported.
 
 #### V1.4 (25-Aug-19)
-
 - Minor fix for highlighting of JoinVarArgsContains inspection.
 - Extended AssertThatSize inspection to Maps, too.
 - Extended AssertThatCollectionOrMap inspection for several ```assertThat(map.get())``` cases as suggested by Georgij G.
 
 #### V1.3 (03-Aug-19)
-
 - New JoinVarArgsContains inspection that will detect multiple ```.contains()```, ```.doesNotContain()```,
   and ```.containsOnlyOnce()``` calls within the same statement that could be joined together using variadic arguments.
 - AssertJ 3.13.0 broke some inspections due to new ```AbstractStringAssert::isEqualTo()``` method.
 - AssertThatJava8Optional and AssertThatGuavaOptional inspections do not longer try to fix
   ```assertThat(optional).isEqualTo(Optional.fromNullable(expression))``` to ```contains()```
   when ```expression``` is not a non-null constant expression.
-
+  
 #### V1.2 (23-Jun-19)
-
 - Due to popular demand the JoinAssertThatStatements inspection will now add line breaks on joining statements.
   The amount of statements joined without causing line breaks can be configured but defaults to 1 (always).
-
+          
 #### V1.1 (09-Jun-19)
-
 - Improved JoinAssertThatStatements detection of expressions with side-effects and added pre/post-increment/decrement detection.
 - Added Guava Optional ```opt.orNull() == null``` case. You know, I'm not making this stuff up, people actually write this kind of code.
 - Added Java 8 Optional ```opt.orElse(null) == null``` case, too.
@@ -958,18 +690,14 @@ Feel free to use the code (in package ```de.platon42.intellij.jupiter```) for yo
 - Added new AssertThatObjectExpression inspection for ```toString()``` and ```hashCode()``` and moved ```equals()``` from AssertThatBinaryExpression there.
 
 #### V1.0 (06-May-19)
-
 - First release to be considered stable enough for production use.
 - Fixed a NPE in AssumeThatInsteadOfReturn inspection quickfix for empty else branches.
 - Fixed missing description for AssumeThatInsteadOfReturn inspection.
-- Added new AssertThatCollectionOrMapExpression inspection that tries to pull out methods such as ```isEmpty()``` or ```contains()``` out of an actual ```assertThat()```
+- Added new AssertThatCollectionOrMapExpression inspection that tries to pull out methods such as ```isEmpty()``` or ```contains()``` out of an actual ```assertThat()``` expression.
-  expression.
 
 #### V0.8 (05-May-19)
-
 - Fixed missing description for JoinAssertThatStatements and detection of equivalent expressions (sorry, released it too hastily).
-- Fixed ```isEmpty()``` for enumerables and strings and ```isNull()``` for object conversions to be applied only if it is the terminal method call as ```isEmpty()```
+- Fixed ```isEmpty()``` for enumerables and strings and ```isNull()``` for object conversions to be applied only if it is the terminal method call as ```isEmpty()``` and ```isNull()``` return void.
-  and ```isNull()``` return void.
 - Heavily reworked inspections for edge cases, such as multiple ```isEqualTo()``` calls inside a single statement.
 - Some inspections could generate bogus code for weird situations, this has been made more fool-proof.
 - Corrected highlighting for many inspections.
@@ -978,7 +706,6 @@ Feel free to use the code (in package ```de.platon42.intellij.jupiter```) for yo
 - Added a first version of a new inspection that tries to detect bogus uses of return statements in test methods and replaces them by ```assumeThat()``` calls.
 
 #### V0.7 (28-Apr-19)
-
 - Another fix for AssertThatGuavaOptional inspection regarding using the same family name for slightly different quick fix executions
   (really, Jetbrains, this sucks for no reason).
 - Extended AssertThatSize inspection to transform ```hasSize()``` into ```hasSameSizeAs()```, if possible.
@@ -986,7 +713,6 @@ Feel free to use the code (in package ```de.platon42.intellij.jupiter```) for yo
   actual object together, preserving comments.
 
 #### V0.6 (22-Apr-19)
-
 - New AssertThatStringExpression inspection that will move ```isEmpty()```, ```equals()```, ```equalsIgnoreCase()```, ```contains()```,
   ```startsWith()```, and ```endsWith()``` out of actual expression.
 - Extended AssertThatSize inspection to take ```String```s and ```CharSequences``` into account, too.
@@ -995,36 +721,28 @@ Feel free to use the code (in package ```de.platon42.intellij.jupiter```) for yo
 - New AssertThatInstanceOf inspection that moves instanceof expressions out of ```assertThat()```.
 
 #### V0.5 (18-Apr-19)
-
 - Fixed incompatibility with IDEA versions < 2018.2 (affected AssertThatSizeInspection). Minimal version is now 2017.3.
 - Fixed missing Guava imports (if not already present) for AssertThatGuavaInspection. This was a major PITA to get right.
 - Added support for referencing and refactoring inside ```.extracting()``` methods with fields, properties and methods (though
   getter renaming does not work that perfect, but I'm giving up for now as the IntelliJ SDK docs are seriously lacking).
-- Fixed an exception in batch mode if the description string was the same but for different fixes.
+- Fixed an exception in batch mode if the description string was the same but for different fixes. 
   Now descriptions are different for quick fixes triggered by AssertThatJava8OptionalInspection and AssertThatGuavaOptionalInspection.
 
 #### V0.4 (11-Apr-19)
-
 - Reduced minimal supported IDEA version from 2018.2 to 2017.2.
-- New inspection AssertThatJava8Optional that operates on Java 8 ```Optional``` objects and tries to use ```contains()```, ```containsSame()```, ```isPresent()```,
+- New inspection AssertThatJava8Optional that operates on Java 8 ```Optional``` objects and tries to use ```contains()```, ```containsSame()```, ```isPresent()```, and ```isNotPresent()``` instead.
-  and ```isNotPresent()``` instead.
 - New inspection AssertThatGuavaOptional that operates on Guava ```Optional``` objects and tries to use ```contains()```, ```isPresent()```, and ```isAbsent()``` instead.
 - Added support in AssertThatBinaryExpressionIsTrueOrFalse for ```is(Not)EqualTo(Boolean.TRUE/FALSE)```.
 
 #### V0.3 (07-Apr-19)
-
+- New inspection AssertThatBinaryExpressionIsTrueOrFalse that will find and fix common binary expressions and ```equals()``` statements (more than 150 combinations) inside ```assertThat()```.
-- New inspection AssertThatBinaryExpressionIsTrueOrFalse that will find and fix common binary expressions and ```equals()``` statements (more than 150 combinations)
-  inside ```assertThat()```.
 - Merged AssertThatObjectIsNull and AssertThatObjectIsNotNull to AssertThatObjectIsNullOrNotNull.
-- Support for ```hasSizeLessThan()```, ```hasSizeLessThanOrEqualTo()```, ```hasSizeGreaterThanOrEqualTo()```, and ```hasSizeGreaterThan()``` for AssertThatSizeInspection (with
+- Support for ```hasSizeLessThan()```, ```hasSizeLessThanOrEqualTo()```, ```hasSizeGreaterThanOrEqualTo()```, and ```hasSizeGreaterThan()``` for AssertThatSizeInspection (with AssertJ >=3.12.0).
-  AssertJ >=3.12.0).
 - Really fixed highlighting for JUnit conversion. Sorry.
 
 #### V0.2 (01-Apr-19)
-
 - Fixed descriptions and quick fix texts.
-- Fixed highlighting of found problems and 'Run inspection by Name' returning nothing, too.
+- Fixed highlighting of found problems and also 'Run inspection by Name' returning nothing.
 
 #### V0.1 (31-Mar-19)
-
+- Initial release.
-- Initial release.

build.gradle

@@ -0,0 +1,81 @@
+plugins {
+    id 'java'
+    id 'org.jetbrains.intellij' version '0.4.10'
+    id 'org.jetbrains.kotlin.jvm' version '1.3.50'
+    id 'jacoco'
+    id 'com.github.kt3k.coveralls' version '2.8.4'
+}
+
+group 'de.platon42'
+version '1.6'
+
+repositories {
+    mavenCentral()
+}
+
+/*
+  To run tests in IntelliJ use these VM Options for run configuration 
+  -ea -Didea.system.path=build/idea-sandbox/system-test -Didea.config.path=build/idea-sandbox/config-test -Didea.plugins.path=build/idea-sandbox/plugins-test
+ */
+
+dependencies {
+    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8"
+    testCompile "org.assertj:assertj-core:3.13.2"
+    testCompile "org.assertj:assertj-guava:3.2.1"
+    testImplementation 'org.junit.jupiter:junit-jupiter-api:5.5.2'
+    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.5.2'
+    testImplementation "org.jetbrains.kotlin:kotlin-test"
+//    testImplementation "org.jetbrains.kotlin:kotlin-test-junit"
+}
+
+compileKotlin {
+    kotlinOptions.jvmTarget = "1.8"
+}
+compileTestKotlin {
+    kotlinOptions.jvmTarget = "1.8"
+}
+intellij {
+    version '2019.2.3'
+//    pluginName 'Concise AssertJ Optimizing Nitpicker (Cajon)'
+    updateSinceUntilBuild false
+    plugins = ['java']
+}
+
+patchPluginXml {
+    changeNotes """
+  <h4>V1.6 (30-Sep-19)</h4>
+    <ul>
+      <li>Really fixed AssertThatGuavaOptional inspections to avoid conversions from .get() to .contains()
+          for array types. Sigh. Shouldn't be working &gt;12h a day and then do some more stuff at home.
+      <li>Fixed a bug in AssertThatBinaryExpression inspection for assertThat(null != expression) and related
+          that would not correctly invert the condition on transformation.
+      <li>Added new AssertThatFileExpression to move out many common methods from inside the
+          assertThat() expression (exists(), getName(), getParent() and many more).
+      <li>Added several transformations to AssertThatStringExpression inspection.
+          Specifically, uses of matches(), compareToIgnoreCase(), indexOf(), and trim().
+    </ul>
+  <p>Full changelog available at <a href="https://github.com/chrisly42/cajon-plugin#changelog">Github project site</a>.</p>
+"""
+}
+
+test {
+    useJUnitPlatform()
+    testLogging {
+        events "passed", "skipped", "failed"
+    }
+}
+
+jacoco {
+    toolVersion = '0.8.4'
+}
+
+jacocoTestReport {
+    reports {
+        xml.enabled true
+        csv.enabled false
+    }
+}
+
+publishPlugin {
+    token intellijPublishToken
+}

build.gradle.kts

@@ -1,131 +0,0 @@
-plugins {
-    id("java")
-    id("org.jetbrains.intellij") version "1.17.1"
-    id("org.jetbrains.kotlin.jvm") version "1.9.22"
-    id("jacoco")
-    id("com.github.kt3k.coveralls") version "2.12.2"
-}
-
-group = "de.platon42"
-version = "1.14"
-
-repositories {
-    mavenCentral()
-}
-
-/*
-  To run tests in IntelliJ use these VM Options for run configuration
-  -ea -Didea.system.path=build/idea-sandbox/system-test -Didea.config.path=build/idea-sandbox/config-test -Didea.plugins.path=build/idea-sandbox/plugins-test
- */
-
-dependencies {
-    //implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8"
-    testImplementation("org.assertj:assertj-core:3.25.3")
-    testImplementation("org.assertj:assertj-guava:3.25.3")
-    testImplementation("org.junit.jupiter:junit-jupiter-api:5.10.2")
-    testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:5.10.2")
-    testImplementation("org.jetbrains.kotlin:kotlin-test")
-    testImplementation("org.jetbrains.kotlin:kotlin-reflect")
-    testImplementation("org.junit.platform:junit-platform-launcher:1.10.2")
-//    testImplementation "org.jetbrains.kotlin:kotlin-test-junit"
-}
-
-intellij {
-    version.set("2022.2") // LATEST-EAP-SNAPSHOT
-    //pluginName.set(provider { 'Concise AssertJ Optimizing Nitpicker (Cajon)' })
-    updateSinceUntilBuild.set(false)
-    plugins.set(listOf("com.intellij.java"))
-}
-
-tasks {
-    withType<JavaCompile> {
-        sourceCompatibility = "11"
-        targetCompatibility = "11"
-    }
-    withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
-        kotlinOptions.jvmTarget = "11"
-    }
-
-    test {
-        useJUnitPlatform()
-        testLogging {
-            events("passed", "skipped", "failed")
-        }
-    }
-
-
-    prepareSandbox {
-        enabled = true
-    }
-
-    verifyPlugin {
-        enabled = true
-    }
-
-    verifyPluginConfiguration {
-        enabled = true
-    }
-
-    patchPluginXml {
-        enabled = true
-        sinceBuild.set("222")
-        changeNotes.set(
-            """
-  <h4>V1.14 (19-Feb-24)</h4>
-    <ul>
-      <li>Now requires minimum version 2022.2.
-      <li>Maintenance. Updated various dependencies (Kotlin 1.9.22) and AssertJ 3.25.3 and AssertJ-Guava 3.25.3.
-      <li>Reworked JUnit 5 test framework to work again. However, all the tests are broken.
-      I spent several days trying to figure out what is going on, but I'm giving up on this pile of crap called IntelliJ. 
-      Jetbrains keeps breaking the APIs and implementations every year and I just cannot be bothered anymore.
-      <li>This is very likely the last version.
-    </ul>
-  <h4>V1.13 (18-Aug-22)</h4>
-    <ul>
-      <li>API change in IntelliJ platforms now requires minimum version 2019.3.1. Sorry, giving up to maintain compatibility after four attempts.
-      <li>Maintenance. Updated various dependencies (Kotlin 1.7.10) and AssertJ 3.23.1 and AssertJ-Guava 3.5.0.
-      <li>Tried to fix unreproducible issue #9.
-      <li>Added AssertThatIsZeroOne inspection demanded by issue #5.
-      <li>Fix for wrongly joining statements that cannot be trivially joined (e.g. with filteredOn). Fixes issue #6.
-    </ul>
-  <p>Full changelog available at <a href="https://git.platon42.de/chrisly42/cajon-plugin#changelog">Gitea project site</a>.</p>
-"""
-        )
-    }
-
-    publishPlugin {
-        token.set(System.getProperty("org.gradle.project.intellijPublishToken"))
-    }
-
-    runIde {
-        enabled = true
-        if (project.hasProperty("ideDir")) {
-            ideDir.set(file(project.property("ideDir")!!))
-            jbrVersion.set(project.property("ideJBR")!! as String)
-        }
-        autoReloadPlugins.set(false)
-    }
-
-
-    runPluginVerifier {
-        ideVersions.set(listOf("IC-222.4167.29", "IC-233.14015.106")) // 2022.2.2 - 2023.3.3
-        downloadDir.set(System.getenv("user.home") + "/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/verifier")
-    }
-
-
-}
-
-//tasks.coveralls {
-//    dependsOn(jacocoTestReport)
-//}
-
-//jacoco {
-//    toolVersion = '0.8.8'
-//}
-//
-//jacocoTestReport {
-//    reports {
-//        xml.required.set(true)
-//        csv.required.set(false)
-//    }
-//}

gradle.properties

@@ -1,4 +1,3 @@
 kotlin.code.style=official
 kotlin.incremental=true
-intellijPublishToken=perm:dummy
+intellijPublishToken=perm:dummy
-systemProp.jdk.tls.client.protocols="TLSv1,TLSv1.1,TLSv1.2"

gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,6 @@
+#Thu Feb 21 17:35:51 CET 2019
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
+distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip

gradlew

@@ -1,21 +1,5 @@
 #!/usr/bin/env sh
 
-#
-# Copyright 2015 the original author or authors.
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#      https://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
 ##############################################################################
 ##
 ##  Gradle start up script for UN*X
@@ -44,7 +28,7 @@ APP_NAME="Gradle"
 APP_BASE_NAME=`basename "$0"`
 
 # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
-DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
+DEFAULT_JVM_OPTS=""
 
 # Use the maximum available, or set MAX_FD != -1 to use that value.
 MAX_FD="maximum"
@@ -72,7 +56,7 @@ case "`uname`" in
   Darwin* )
     darwin=true
     ;;
-  MSYS* | MINGW* )
+  MINGW* )
     msys=true
     ;;
   NONSTOP* )
@@ -82,7 +66,6 @@ esac
 
 CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar
 
-
 # Determine the Java command to use to start the JVM.
 if [ -n "$JAVA_HOME" ] ; then
     if [ -x "$JAVA_HOME/jre/sh/java" ] ; then
@@ -126,11 +109,10 @@ if $darwin; then
     GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\""
 fi
 
-# For Cygwin or MSYS, switch paths to Windows format before running java
+# For Cygwin, switch paths to Windows format before running java
-if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
+if $cygwin ; then
     APP_HOME=`cygpath --path --mixed "$APP_HOME"`
     CLASSPATH=`cygpath --path --mixed "$CLASSPATH"`
-
     JAVACMD=`cygpath --unix "$JAVACMD"`
 
     # We build the pattern for arguments to be converted via cygpath
@@ -156,19 +138,19 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
         else
             eval `echo args$i`="\"$arg\""
         fi
-        i=`expr $i + 1`
+        i=$((i+1))
     done
     case $i in
-        0) set -- ;;
+        (0) set -- ;;
-        1) set -- "$args0" ;;
+        (1) set -- "$args0" ;;
-        2) set -- "$args0" "$args1" ;;
+        (2) set -- "$args0" "$args1" ;;
-        3) set -- "$args0" "$args1" "$args2" ;;
+        (3) set -- "$args0" "$args1" "$args2" ;;
-        4) set -- "$args0" "$args1" "$args2" "$args3" ;;
+        (4) set -- "$args0" "$args1" "$args2" "$args3" ;;
-        5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;;
+        (5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;;
-        6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;;
+        (6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;;
-        7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;;
+        (7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;;
-        8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;;
+        (8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;;
-        9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;;
+        (9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;;
     esac
 fi
 
@@ -177,9 +159,14 @@ save () {
     for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done
     echo " "
 }
-APP_ARGS=`save "$@"`
+APP_ARGS=$(save "$@")
 
 # Collect all arguments for the java command, following the shell quoting and substitution rules
 eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS"
 
+# by default we should be in the correct project dir, but when run from Finder on Mac, the cwd is wrong
+if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then
+  cd "$(dirname "$0")"
+fi
+
 exec "$JAVACMD" "$@"

gradlew.bat

@@ -1,19 +1,3 @@
-@rem
-@rem Copyright 2015 the original author or authors.
-@rem
-@rem Licensed under the Apache License, Version 2.0 (the "License");
-@rem you may not use this file except in compliance with the License.
-@rem You may obtain a copy of the License at
-@rem
-@rem      https://www.apache.org/licenses/LICENSE-2.0
-@rem
-@rem Unless required by applicable law or agreed to in writing, software
-@rem distributed under the License is distributed on an "AS IS" BASIS,
-@rem WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-@rem See the License for the specific language governing permissions and
-@rem limitations under the License.
-@rem
-
 @if "%DEBUG%" == "" @echo off
 @rem ##########################################################################
 @rem
@@ -29,18 +13,15 @@ if "%DIRNAME%" == "" set DIRNAME=.
 set APP_BASE_NAME=%~n0
 set APP_HOME=%DIRNAME%
 
-@rem Resolve any "." and ".." in APP_HOME to make it shorter.
-for %%i in ("%APP_HOME%") do set APP_HOME=%%~fi
-
 @rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
-set DEFAULT_JVM_OPTS="-Xmx64m" "-Xms64m"
+set DEFAULT_JVM_OPTS=
 
 @rem Find java.exe
 if defined JAVA_HOME goto findJavaFromJavaHome
 
 set JAVA_EXE=java.exe
 %JAVA_EXE% -version >NUL 2>&1
-if "%ERRORLEVEL%" == "0" goto execute
+if "%ERRORLEVEL%" == "0" goto init
 
 echo.
 echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
@@ -54,7 +35,7 @@ goto fail
 set JAVA_HOME=%JAVA_HOME:"=%
 set JAVA_EXE=%JAVA_HOME%/bin/java.exe
 
-if exist "%JAVA_EXE%" goto execute
+if exist "%JAVA_EXE%" goto init
 
 echo.
 echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME%
@@ -64,14 +45,28 @@ echo location of your Java installation.
 
 goto fail
 
+:init
+@rem Get command-line arguments, handling Windows variants
+
+if not "%OS%" == "Windows_NT" goto win9xME_args
+
+:win9xME_args
+@rem Slurp the command line arguments.
+set CMD_LINE_ARGS=
+set _SKIP=2
+
+:win9xME_args_slurp
+if "x%~1" == "x" goto execute
+
+set CMD_LINE_ARGS=%*
+
 :execute
 @rem Setup the command line
 
 set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar
 
-
 @rem Execute Gradle
-"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %*
+"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %CMD_LINE_ARGS%
 
 :end
 @rem End local scope for the variables with windows NT shell

src/main/java/de/platon42/intellij/plugins/cajon/AssertJClassNames.kt

@@ -12,101 +12,51 @@ class AssertJClassNames {
 
         @NonNls
         const val DESCRIPTABLE_INTERFACE = "org.assertj.core.api.Descriptable"
-
         @NonNls
         const val EXTENSION_POINTS_INTERFACE = "org.assertj.core.api.ExtensionPoints"
-
         @NonNls
         const val ENUMERABLE_ASSERT_INTERFACE = "org.assertj.core.api.EnumerableAssert"
-
         @NonNls
         const val OBJECT_ENUMERABLE_ASSERT_INTERFACE = "org.assertj.core.api.ObjectEnumerableAssert"
 
         @NonNls
         const val ASSERT_INTERFACE = "org.assertj.core.api.Assert"
-
         @NonNls
         const val ABSTRACT_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractAssert"
-
         @NonNls
         const val ABSTRACT_OBJECT_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractObjectAssert"
-
         @NonNls
         const val ABSTRACT_BOOLEAN_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractBooleanAssert"
-
-        @NonNls
-        const val ABSTRACT_SHORT_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractShortAssert"
-
         @NonNls
         const val ABSTRACT_INTEGER_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractIntegerAssert"
-
         @NonNls
         const val ABSTRACT_LONG_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractLongAssert"
-
         @NonNls
         const val ABSTRACT_FLOAT_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractFloatAssert"
-
         @NonNls
         const val ABSTRACT_DOUBLE_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractDoubleAssert"
-
         @NonNls
         const val ABSTRACT_COMPARABLE_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractComparableAssert"
-
         @NonNls
         const val ABSTRACT_STRING_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractStringAssert"
-
         @NonNls
         const val ABSTRACT_CHAR_SEQUENCE_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractCharSequenceAssert"
-
         @NonNls
         const val ABSTRACT_MAP_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractMapAssert"
-
-        @NonNls
-        const val ABSTRACT_BOOLEAN_ARRAY_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractBooleanArrayAssert"
-
-        @NonNls
-        const val ABSTRACT_BYTE_ARRAY_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractByteArrayAssert"
-
-        @NonNls
-        const val ABSTRACT_SHORT_ARRAY_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractShortArrayAssert"
-
-        @NonNls
-        const val ABSTRACT_INT_ARRAY_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractIntArrayAssert"
-
-        @NonNls
-        const val ABSTRACT_LONG_ARRAY_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractLongArrayAssert"
-
-        @NonNls
-        const val ABSTRACT_FLOAT_ARRAY_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractFloatArrayAssert"
-
-        @NonNls
-        const val ABSTRACT_DOUBLE_ARRAY_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractDoubleArrayAssert"
-
-        @NonNls
-        const val ABSTRACT_CHAR_ARRAY_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractCharArrayAssert"
-
         @NonNls
         const val ABSTRACT_OBJECT_ARRAY_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractObjectArrayAssert"
-
         @NonNls
         const val ABSTRACT_ITERABLE_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractIterableAssert"
-
-        @NonNls
-        const val ABSTRACT_FILE_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractFileAssert"
-
         @NonNls
         const val ABSTRACT_OPTIONAL_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractOptionalAssert"
-
         @NonNls
         const val EXTRACTORS_CLASSNAME = "org.assertj.core.extractor.Extractors"
 
         @NonNls
         const val GUAVA_OPTIONAL_CLASSNAME = "com.google.common.base.Optional"
-
         @NonNls
         const val GUAVA_ASSERTIONS_CLASSNAME = "org.assertj.guava.api.Assertions"
-
         @NonNls
         const val GUAVA_OPTIONAL_ASSERTIONS_CLASSNAME = "org.assertj.guava.api.OptionalAssert"
     }
-}
+}

src/main/java/de/platon42/intellij/plugins/cajon/CommonMatchers.kt

@@ -21,50 +21,24 @@ val EXTRACTING_CALL_MATCHERS = CallMatcher.anyOf(
 
 val DESCRIBED_AS = CallMatcher.instanceCall(AssertJClassNames.DESCRIPTABLE_INTERFACE, MethodNames.DESCRIBED_AS, MethodNames.AS)!!
 val WITH_REPRESENTATION_AND_SUCH = CallMatcher.instanceCall(AssertJClassNames.ASSERT_INTERFACE, "withRepresentation", "withThreadDumpOnError")!!
-val USING_COMPARATOR = CallMatcher.anyOf(
+val USING_COMPARATOR = CallMatcher.instanceCall(AssertJClassNames.ASSERT_INTERFACE, "usingComparator", "usingDefaultComparator")!!
-    CallMatcher.instanceCall(
-        AssertJClassNames.ASSERT_INTERFACE,
-        "usingComparator",
-        "usingDefaultComparator"
-    ),
-    CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_ASSERT_CLASSNAME, "usingRecursiveComparison"),
-    CallMatcher.instanceCall(
-        AssertJClassNames.ABSTRACT_OBJECT_ASSERT_CLASSNAME,
-        "usingComparatorForFields",
-        "usingComparatorForType"
-    )
-)!!
-
 val IN_HEXADECIMAL_OR_BINARY = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_ASSERT_CLASSNAME, MethodNames.IN_HEXADECIMAL, MethodNames.IN_BINARY)!!
 val EXTENSION_POINTS = CallMatcher.instanceCall(
     AssertJClassNames.EXTENSION_POINTS_INTERFACE,
     "is", "isNot", "has", "doesNotHave",
     "satisfies"
 )!!
-
 val MORE_EXTENSION_POINTS = CallMatcher.instanceCall(
     AssertJClassNames.OBJECT_ENUMERABLE_ASSERT_INTERFACE,
     "are", "areNot", "have", "doNotHave",
     "areAtLeast", "areAtLeastOne", "areAtMost", "areExactly",
     "haveAtLeastOne", "haveAtLeast", "haveAtMost", "haveExactly",
-    "singleElement", "hasOnlyOneElementSatisfying", "anyMatch", "noneMatch", "anySatisfy", "noneSatisfy"
+    "hasOnlyOneElementSatisfying", "anyMatch", "noneMatch", "anySatisfy", "noneSatisfy"
 )!!
 
-val FILTERED_ON = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_ITERABLE_ASSERT_CLASSNAME, "filteredOn", "filteredOnNull", "filteredOnAssertions")!!
-
 val COMPLEX_CALLS_THAT_MAKES_STUFF_TRICKY = CallMatcher.anyOf(
-    EXTRACTING_CALL_MATCHERS,
     DESCRIBED_AS,
     WITH_REPRESENTATION_AND_SUCH,
-    FILTERED_ON,
-    USING_COMPARATOR,
-    IN_HEXADECIMAL_OR_BINARY
-)!!
-
-val COMPLEX_STUFF_THAT_MAKES_JOINING_IMPOSSIBLE = CallMatcher.anyOf(
-    EXTRACTING_CALL_MATCHERS,
-    WITH_REPRESENTATION_AND_SUCH,
-    FILTERED_ON,
     USING_COMPARATOR,
     IN_HEXADECIMAL_OR_BINARY
 )!!

src/main/java/de/platon42/intellij/plugins/cajon/Extensions.kt

@@ -1,5 +1,6 @@
 package de.platon42.intellij.plugins.cajon
 
+import com.intellij.lang.jvm.JvmModifier
 import com.intellij.psi.*
 import com.intellij.psi.codeStyle.CodeStyleManager
 import com.intellij.psi.codeStyle.JavaCodeStyleManager
@@ -32,7 +33,7 @@ fun PsiElement.findOutmostMethodCall(): PsiMethodCallExpression? {
 fun PsiElement.findStaticMethodCall(): PsiMethodCallExpression? {
     var elem: PsiElement? = this
     while (elem != null) {
-        if ((elem is PsiMethodCallExpression) && (elem.resolveMethod()?.hasModifierProperty(PsiModifier.STATIC) == true)) {
+        if ((elem is PsiMethodCallExpression) && (elem.resolveMethod()?.hasModifier(JvmModifier.STATIC) == true)) {
             return elem
         }
         elem = elem.firstChild
@@ -43,7 +44,7 @@ fun PsiElement.findStaticMethodCall(): PsiMethodCallExpression? {
 fun PsiElement.gatherAssertionCalls(): List<PsiMethodCallExpression> {
     val assertThatMethodCall = findStaticMethodCall() ?: return emptyList()
     return assertThatMethodCall.collectMethodCallsUpToStatement()
-        .filterNot(NOT_ACTUAL_ASSERTIONS::test)
+        .filterNot { NOT_ACTUAL_ASSERTIONS.test(it) }
         .toList()
 }
 
@@ -115,7 +116,8 @@ fun PsiMethodCallExpression.getExpectedNullNonNullResult(): Boolean? {
 }
 
 fun PsiMethodCallExpression.calculateConstantParameterValue(argIndex: Int): Any? {
-    return getArgOrNull(argIndex)?.calculateConstantValue()
+    if (argIndex >= argumentList.expressions.size) return null
+    return getArg(argIndex).calculateConstantValue()
 }
 
 fun PsiExpression.calculateConstantValue(): Any? {
@@ -180,4 +182,4 @@ fun PsiExpression.getAllTheSameNullNotNullConstants(): Boolean? {
         }
     }
     return lockedResult
-}
+}

src/main/java/de/platon42/intellij/plugins/cajon/MethodNames.kt

@@ -17,25 +17,19 @@ class MethodNames {
 
         @NonNls
         const val AS = "as"
-
         @NonNls
         const val DESCRIBED_AS = "describedAs"
-
         @NonNls
         const val IN_HEXADECIMAL = "inHexadecimal"
-
         @NonNls
         const val IN_BINARY = "inBinary"
 
         @NonNls
         const val IS_EQUAL_TO = "isEqualTo"
-
         @NonNls
         const val IS_NOT_EQUAL_TO = "isNotEqualTo"
-
         @NonNls
         const val IS_SAME_AS = "isSameAs"
-
         @NonNls
         const val IS_NOT_SAME_AS = "isNotSameAs"
 
@@ -44,133 +38,89 @@ class MethodNames {
 
         @NonNls
         const val IS_GREATER_THAN = "isGreaterThan"
-
         @NonNls
         const val IS_GREATER_THAN_OR_EQUAL_TO = "isGreaterThanOrEqualTo"
-
         @NonNls
         const val IS_LESS_THAN = "isLessThan"
-
         @NonNls
         const val IS_LESS_THAN_OR_EQUAL_TO = "isLessThanOrEqualTo"
-
         @NonNls
         const val IS_ZERO = "isZero"
-
         @NonNls
         const val IS_NOT_ZERO = "isNotZero"
-
-        @NonNls
-        const val IS_ONE = "isOne"
-
         @NonNls
         const val IS_TRUE = "isTrue"
-
         @NonNls
         const val IS_FALSE = "isFalse"
-
         @NonNls
         const val IS_NULL = "isNull" // terminal, returns void
-
         @NonNls
         const val IS_NOT_NULL = "isNotNull"
-
         @NonNls
         const val IS_CLOSE_TO = "isCloseTo"
-
         @NonNls
         const val IS_NOT_CLOSE_TO = "isNotCloseTo"
-
         @NonNls
         const val IS_INSTANCE_OF = "isInstanceOf"
-
         @NonNls
         const val IS_NOT_INSTANCE_OF = "isNotInstanceOf"
 
         @NonNls
         const val IS_NULL_OR_EMPTY = "isNullOrEmpty" // terminal, returns void
-
         @NonNls
         const val IS_EMPTY = "isEmpty" // terminal, returns void
-
         @NonNls
         const val IS_NOT_EMPTY = "isNotEmpty"
-
         @NonNls
         const val HAS_SIZE = "hasSize"
-
         @NonNls
         const val HAS_SIZE_LESS_THAN = "hasSizeLessThan"
-
         @NonNls
         const val HAS_SIZE_LESS_THAN_OR_EQUAL_TO = "hasSizeLessThanOrEqualTo"
-
         @NonNls
         const val HAS_SIZE_GREATER_THAN = "hasSizeGreaterThan"
-
         @NonNls
         const val HAS_SIZE_GREATER_THAN_OR_EQUAL_TO = "hasSizeGreaterThanOrEqualTo"
-
         @NonNls
         const val HAS_SAME_SIZE_AS = "hasSameSizeAs"
-
         @NonNls
         const val CONTAINS = "contains"
-
         @NonNls
         const val CONTAINS_ONLY_ONCE = "containsOnlyOnce"
-
         @NonNls
         const val DOES_NOT_CONTAIN = "doesNotContain"
-
         @NonNls
         const val CONTAINS_EXACTLY = "containsExactly"
-
         @NonNls
         const val CONTAINS_ALL = "containsAll"
-
         @NonNls
         const val CONTAINS_KEY = "containsKey"
-
         @NonNls
         const val DOES_NOT_CONTAIN_KEY = "doesNotContainKey"
-
         @NonNls
         const val CONTAINS_VALUE = "containsValue"
-
         @NonNls
         const val DOES_NOT_CONTAIN_VALUE = "doesNotContainValue"
-
         @NonNls
         const val CONTAINS_ENTRY = "containsEntry"
-
         @NonNls
         const val DOES_NOT_CONTAIN_ENTRY = "doesNotContainEntry"
-
         @NonNls
         const val IS_EQUAL_TO_IC = "isEqualToIgnoringCase"
-
         @NonNls
         const val IS_NOT_EQUAL_TO_IC = "isNotEqualToIgnoringCase"
-
         @NonNls
         const val STARTS_WITH = "startsWith"
-
         @NonNls
         const val ENDS_WITH = "endsWith"
-
         @NonNls
         const val DOES_NOT_START_WITH = "doesNotStartWith"
-
         @NonNls
         const val DOES_NOT_END_WITH = "doesNotEndWith"
-
         @NonNls
         const val CONTAINS_SAME = "containsSame"
-
         @NonNls
         const val IS_PRESENT = "isPresent"
-
         @NonNls
         const val IS_NOT_PRESENT = "isNotPresent"
 

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AbstractAssertJInspection.kt

@@ -15,7 +15,6 @@ import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_D
 import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_FLOAT_ASSERT_CLASSNAME
 import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_INTEGER_ASSERT_CLASSNAME
 import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_LONG_ASSERT_CLASSNAME
-import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_SHORT_ASSERT_CLASSNAME
 import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_STRING_ASSERT_CLASSNAME
 import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ASSERTIONS_CLASSNAME
 import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ASSERT_INTERFACE
@@ -73,8 +72,6 @@ abstract class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool()
 
         val ASSERT_THAT_BOOLEAN = CallMatcher.staticCall(ASSERTIONS_CLASSNAME, MethodNames.ASSERT_THAT)
             .parameterTypes("boolean")!!
-        val ASSERT_THAT_BOOLEAN_OBJ = CallMatcher.staticCall(ASSERTIONS_CLASSNAME, MethodNames.ASSERT_THAT)
-            .parameterTypes(CommonClassNames.JAVA_LANG_BOOLEAN)!!
 
         val ASSERT_THAT_ANY = CallMatcher.staticCall(ASSERTIONS_CLASSNAME, MethodNames.ASSERT_THAT)
             .parameterCount(1)!!
@@ -89,8 +86,6 @@ abstract class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool()
             .parameterTypes(CommonClassNames.JAVA_LANG_OBJECT)!!
         val IS_EQUAL_TO_STRING = CallMatcher.instanceCall(ABSTRACT_STRING_ASSERT_CLASSNAME, MethodNames.IS_EQUAL_TO)
             .parameterTypes(CommonClassNames.JAVA_LANG_STRING)!!
-        val IS_EQUAL_TO_SHORT = CallMatcher.instanceCall(ABSTRACT_SHORT_ASSERT_CLASSNAME, MethodNames.IS_EQUAL_TO)
-            .parameterTypes("short")!!
         val IS_EQUAL_TO_INT = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, MethodNames.IS_EQUAL_TO)
             .parameterTypes("int")!!
         val IS_EQUAL_TO_LONG = CallMatcher.instanceCall(ABSTRACT_LONG_ASSERT_CLASSNAME, MethodNames.IS_EQUAL_TO)
@@ -106,8 +101,6 @@ abstract class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool()
             .parameterTypes(CommonClassNames.JAVA_LANG_OBJECT)!!
         val IS_NOT_EQUAL_TO_BOOLEAN = CallMatcher.instanceCall(ABSTRACT_BOOLEAN_ASSERT_CLASSNAME, MethodNames.IS_NOT_EQUAL_TO)
             .parameterTypes("boolean")!!
-        val IS_NOT_EQUAL_TO_SHORT = CallMatcher.instanceCall(ABSTRACT_SHORT_ASSERT_CLASSNAME, MethodNames.IS_NOT_EQUAL_TO)
-            .parameterTypes("short")!!
         val IS_NOT_EQUAL_TO_INT = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, MethodNames.IS_NOT_EQUAL_TO)
             .parameterTypes("int")!!
         val IS_NOT_EQUAL_TO_LONG = CallMatcher.instanceCall(ABSTRACT_LONG_ASSERT_CLASSNAME, MethodNames.IS_NOT_EQUAL_TO)
@@ -133,14 +126,6 @@ abstract class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool()
             .parameterCount(0)!!
         val HAS_SIZE = CallMatcher.instanceCall(ENUMERABLE_ASSERT_INTERFACE, MethodNames.HAS_SIZE)
             .parameterTypes("int")!!
-        val HAS_SIZE_GREATER_THAN_INT = CallMatcher.instanceCall(ENUMERABLE_ASSERT_INTERFACE, MethodNames.HAS_SIZE_GREATER_THAN)
-            .parameterTypes("int")!!
-        val HAS_SIZE_GREATER_THAN_OR_EQUAL_TO_INT = CallMatcher.instanceCall(ENUMERABLE_ASSERT_INTERFACE, MethodNames.HAS_SIZE_GREATER_THAN_OR_EQUAL_TO)
-            .parameterTypes("int")!!
-        val HAS_SIZE_LESS_THAN_INT = CallMatcher.instanceCall(ENUMERABLE_ASSERT_INTERFACE, MethodNames.HAS_SIZE_LESS_THAN)
-            .parameterTypes("int")!!
-        val HAS_SIZE_LESS_THAN_OR_EQUAL_TO_INT = CallMatcher.instanceCall(ENUMERABLE_ASSERT_INTERFACE, MethodNames.HAS_SIZE_LESS_THAN_OR_EQUAL_TO)
-            .parameterTypes("int")!!
 
         val IS_GREATER_THAN_INT = CallMatcher.instanceCall(ABSTRACT_COMPARABLE_ASSERT_CLASSNAME, MethodNames.IS_GREATER_THAN)
             .parameterTypes("int")!!
@@ -152,23 +137,17 @@ abstract class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool()
         val IS_LESS_THAN_OR_EQUAL_TO_INT = CallMatcher.instanceCall(ABSTRACT_COMPARABLE_ASSERT_CLASSNAME, MethodNames.IS_LESS_THAN_OR_EQUAL_TO)
             .parameterTypes("int")!!
 
-        val IS_ZERO_INT = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, MethodNames.IS_ZERO)
+        val IS_ZERO = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, MethodNames.IS_ZERO)
             .parameterCount(0)!!
-        val IS_NOT_ZERO_INT = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, MethodNames.IS_NOT_ZERO)
+        val IS_NOT_ZERO = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, MethodNames.IS_NOT_ZERO)
             .parameterCount(0)!!
-        val IS_ZERO_LONG = CallMatcher.instanceCall(ABSTRACT_LONG_ASSERT_CLASSNAME, MethodNames.IS_ZERO)
+        val IS_NEGATIVE = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, "isNegative")
             .parameterCount(0)!!
-        val IS_NOT_ZERO_LONG = CallMatcher.instanceCall(ABSTRACT_LONG_ASSERT_CLASSNAME, MethodNames.IS_NOT_ZERO)
+        val IS_NOT_NEGATIVE = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, "isNotNegative")
             .parameterCount(0)!!
-        val IS_ONE_INT = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, "isOne")
+        val IS_POSITIVE = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, "isPositive")
             .parameterCount(0)!!
-        val IS_NEGATIVE_INT = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, "isNegative")
+        val IS_NOT_POSITIVE = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, "isNotPositive")
-            .parameterCount(0)!!
-        val IS_NOT_NEGATIVE_INT = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, "isNotNegative")
-            .parameterCount(0)!!
-        val IS_POSITIVE_INT = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, "isPositive")
-            .parameterCount(0)!!
-        val IS_NOT_POSITIVE_INT = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, "isNotPositive")
             .parameterCount(0)!!
 
         val IS_TRUE = CallMatcher.instanceCall(ABSTRACT_BOOLEAN_ASSERT_CLASSNAME, MethodNames.IS_TRUE)
@@ -182,12 +161,12 @@ abstract class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool()
             .parameterCount(0)!!
         val CHAR_SEQUENCE_LENGTH = CallMatcher.instanceCall("java.lang.CharSequence", "length")
             .parameterCount(0)!!
-        val OBJECT_EQUALS = CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_OBJECT, MethodNames.EQUALS)
+        val OBJECT_EQUALS = CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_OBJECT, "equals")
             .parameterTypes(CommonClassNames.JAVA_LANG_OBJECT)!!
 
         val OPTIONAL_GET = CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_OPTIONAL, "get")
             .parameterCount(0)!!
-        val OPTIONAL_IS_PRESENT = CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_OPTIONAL, MethodNames.IS_PRESENT)
+        val OPTIONAL_IS_PRESENT = CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_OPTIONAL, "isPresent")
             .parameterCount(0)!!
         val OPTIONAL_OR_ELSE = CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_OPTIONAL, "orElse")
             .parameterCount(1)!!
@@ -201,7 +180,7 @@ abstract class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool()
 
         val GUAVA_OPTIONAL_GET = CallMatcher.instanceCall(GUAVA_OPTIONAL_CLASSNAME, "get")
             .parameterCount(0)!!
-        val GUAVA_OPTIONAL_IS_PRESENT = CallMatcher.instanceCall(GUAVA_OPTIONAL_CLASSNAME, MethodNames.IS_PRESENT)
+        val GUAVA_OPTIONAL_IS_PRESENT = CallMatcher.instanceCall(GUAVA_OPTIONAL_CLASSNAME, "isPresent")
             .parameterCount(0)!!
         val GUAVA_OPTIONAL_OR_NULL = CallMatcher.instanceCall(GUAVA_OPTIONAL_CLASSNAME, "orNull")
             .parameterCount(0)!!
@@ -307,4 +286,4 @@ abstract class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool()
     ) {
         registerConciseMethod(REMOVE_EXPECTED_OUTMOST_DESCRIPTION_TEMPLATE, holder, expression, oldExpectedCallExpression, replacementMethod, quickFixSupplier)
     }
-}
+}

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AbstractJUnitAssertInspection.kt

@@ -4,51 +4,39 @@ import com.intellij.codeInspection.AbstractBaseJavaLocalInspectionTool
 import com.intellij.psi.PsiMethodCallExpression
 import org.jetbrains.annotations.NonNls
 
-abstract class AbstractJUnitAssertInspection : AbstractBaseJavaLocalInspectionTool() {
+open class AbstractJUnitAssertInspection : AbstractBaseJavaLocalInspectionTool() {
 
     companion object {
         @NonNls
         const val JUNIT_ASSERT_CLASSNAME = "org.junit.Assert"
-
         @NonNls
         const val JUNIT_ASSUME_CLASSNAME = "org.junit.Assume"
 
         @NonNls
         const val ASSERT_TRUE_METHOD = "assertTrue"
-
         @NonNls
         const val ASSERT_FALSE_METHOD = "assertFalse"
-
         @NonNls
         const val ASSERT_NULL_METHOD = "assertNull"
-
         @NonNls
         const val ASSERT_NOT_NULL_METHOD = "assertNotNull"
-
         @NonNls
         const val ASSERT_EQUALS_METHOD = "assertEquals"
-
         @NonNls
         const val ASSERT_NOT_EQUALS_METHOD = "assertNotEquals"
-
         @NonNls
         const val ASSERT_SAME_METHOD = "assertSame"
-
         @NonNls
         const val ASSERT_NOT_SAME_METHOD = "assertNotSame"
-
         @NonNls
         const val ASSERT_ARRAY_EQUALS_METHOD = "assertArrayEquals"
 
         @NonNls
         const val ASSUME_TRUE_METHOD = "assumeTrue"
-
         @NonNls
         const val ASSUME_FALSE_METHOD = "assumeFalse"
-
         @NonNls
         const val ASSUME_NOT_NULL_METHOD = "assumeNotNull"
-
         @NonNls
         const val ASSUME_NO_EXCEPTION = "assumeNoException"
 

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AbstractMoveOutInspection.kt

@@ -42,8 +42,7 @@ abstract class AbstractMoveOutInspection : AbstractAssertJInspection() {
                     MoveOutMethodCallExpressionQuickFix(
                         desc, method,
                         replaceOnlyThisMethod = mapping.expectedMatcher,
-                        replaceFromOriginalMethod = mapping.replaceFromOriginalMethod,
+                        replaceFromOriginalMethod = mapping.replaceFromOriginalMethod
-                        noExpectedExpression = mapping.noExpectedExpression
                     )
                 }
             }
@@ -58,7 +57,6 @@ abstract class AbstractMoveOutInspection : AbstractAssertJInspection() {
         val expectNullNonNull: Boolean? = null,
         val expectedMatcher: CallMatcher? = null,
         val replaceFromOriginalMethod: Boolean = false,
-        val noExpectedExpression: Boolean = false,
         val additionalCondition: ((PsiExpressionStatement, PsiMethodCallExpression) -> Boolean)? = null
     )
 }

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatBooleanConditionInspection.kt

@@ -21,19 +21,18 @@ class AssertThatBooleanConditionInspection : AbstractAssertJInspection() {
             override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
                 super.visitMethodCallExpression(expression)
                 if (!expression.hasAssertThat()) return
-                val isEqualToObject = IS_EQUAL_TO_OBJECT.test(expression)
+                val matchingCalls = listOf(
-                val isEqualToPrimitive = IS_EQUAL_TO_BOOLEAN.test(expression)
+                    IS_EQUAL_TO_OBJECT, IS_EQUAL_TO_BOOLEAN,
-                val isNotEqualToObject = IS_NOT_EQUAL_TO_OBJECT.test(expression)
+                    IS_NOT_EQUAL_TO_OBJECT, IS_NOT_EQUAL_TO_BOOLEAN
-                val isNotEqualToPrimitive = IS_NOT_EQUAL_TO_BOOLEAN.test(expression)
+                ).map { it.test(expression) }
-
+                if (matchingCalls.none { it }) return
-                if (!(isEqualToObject || isEqualToPrimitive || isNotEqualToObject || isNotEqualToPrimitive)) return
                 if (!checkAssertedType(expression, ABSTRACT_BOOLEAN_ASSERT_CLASSNAME)) return
 
                 val expectedExpression = expression.firstArg
                 if (!TypeConversionUtil.isBooleanType(expectedExpression.type)) return
 
                 val expectedResult = expression.calculateConstantParameterValue(0) as? Boolean ?: return
-                val flippedBooleanTest = isNotEqualToObject || isNotEqualToPrimitive
+                val flippedBooleanTest = matchingCalls.drop(2).any { it }
 
                 val replacementMethod = (expectedResult xor flippedBooleanTest).map(MethodNames.IS_TRUE, MethodNames.IS_FALSE)
                 registerSimplifyMethod(holder, expression, replacementMethod)

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatComparableInspection.kt

@@ -1,115 +0,0 @@
-package de.platon42.intellij.plugins.cajon.inspections
-
-import com.intellij.codeInspection.ProblemsHolder
-import com.intellij.psi.*
-import com.siyeh.ig.callMatcher.CallMatcher
-import de.platon42.intellij.plugins.cajon.MethodNames
-import de.platon42.intellij.plugins.cajon.calculateConstantValue
-import de.platon42.intellij.plugins.cajon.firstArg
-
-class AssertThatComparableInspection : AbstractMoveOutInspection() {
-
-    companion object {
-        private const val DISPLAY_NAME = "Asserting a compareTo() expression"
-
-        private val ARG_IS_ZERO_CONST: (PsiExpressionStatement, PsiMethodCallExpression) -> Boolean = { _, call -> call.firstArg.calculateConstantValue() == 0 }
-        private val ARG_IS_PLUS_ONE_CONST: (PsiExpressionStatement, PsiMethodCallExpression) -> Boolean = { _, call -> call.firstArg.calculateConstantValue() == 1 }
-        private val ARG_IS_MINUS_ONE_CONST: (PsiExpressionStatement, PsiMethodCallExpression) -> Boolean = { _, call -> call.firstArg.calculateConstantValue() == -1 }
-
-        private val COMPARABLE_COMPARE_TO =
-            CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_COMPARABLE, "compareTo").parameterCount(1)
-
-        private val MAPPINGS = listOf(
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                "isEqualByComparingTo", expectedMatcher = IS_EQUAL_TO_INT, replaceFromOriginalMethod = true,
-                additionalCondition = ARG_IS_ZERO_CONST
-            ),
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                "isEqualByComparingTo", expectedMatcher = IS_ZERO_INT, replaceFromOriginalMethod = true
-            ),
-
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                "isNotEqualByComparingTo", expectedMatcher = IS_NOT_EQUAL_TO_INT, replaceFromOriginalMethod = true,
-                additionalCondition = ARG_IS_ZERO_CONST
-            ),
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                "isNotEqualByComparingTo", expectedMatcher = IS_NOT_ZERO_INT, replaceFromOriginalMethod = true
-            ),
-
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                MethodNames.IS_GREATER_THAN_OR_EQUAL_TO, expectedMatcher = IS_GREATER_THAN_OR_EQUAL_TO_INT, replaceFromOriginalMethod = true,
-                additionalCondition = ARG_IS_ZERO_CONST
-            ),
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                MethodNames.IS_GREATER_THAN_OR_EQUAL_TO, expectedMatcher = CallMatcher.anyOf(IS_NOT_EQUAL_TO_INT, IS_GREATER_THAN_INT), replaceFromOriginalMethod = true,
-                additionalCondition = ARG_IS_MINUS_ONE_CONST
-            ),
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                MethodNames.IS_GREATER_THAN_OR_EQUAL_TO, expectedMatcher = IS_NOT_NEGATIVE_INT, replaceFromOriginalMethod = true
-            ),
-
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                MethodNames.IS_GREATER_THAN, expectedMatcher = CallMatcher.anyOf(IS_EQUAL_TO_INT, IS_GREATER_THAN_OR_EQUAL_TO_INT), replaceFromOriginalMethod = true,
-                additionalCondition = ARG_IS_PLUS_ONE_CONST
-            ),
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                MethodNames.IS_GREATER_THAN, expectedMatcher = IS_GREATER_THAN_INT, replaceFromOriginalMethod = true,
-                additionalCondition = ARG_IS_ZERO_CONST
-            ),
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                MethodNames.IS_GREATER_THAN, expectedMatcher = CallMatcher.anyOf(IS_POSITIVE_INT, IS_ONE_INT), replaceFromOriginalMethod = true
-            ),
-
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                MethodNames.IS_LESS_THAN_OR_EQUAL_TO, expectedMatcher = IS_LESS_THAN_OR_EQUAL_TO_INT, replaceFromOriginalMethod = true,
-                additionalCondition = ARG_IS_ZERO_CONST
-            ),
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                MethodNames.IS_LESS_THAN_OR_EQUAL_TO, expectedMatcher = CallMatcher.anyOf(IS_NOT_EQUAL_TO_INT, IS_LESS_THAN_INT), replaceFromOriginalMethod = true,
-                additionalCondition = ARG_IS_PLUS_ONE_CONST
-            ),
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                MethodNames.IS_LESS_THAN_OR_EQUAL_TO, expectedMatcher = IS_NOT_POSITIVE_INT, replaceFromOriginalMethod = true
-            ),
-
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                MethodNames.IS_LESS_THAN, expectedMatcher = CallMatcher.anyOf(IS_EQUAL_TO_INT, IS_LESS_THAN_OR_EQUAL_TO_INT), replaceFromOriginalMethod = true,
-                additionalCondition = ARG_IS_MINUS_ONE_CONST
-            ),
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                MethodNames.IS_LESS_THAN, expectedMatcher = IS_LESS_THAN_INT, replaceFromOriginalMethod = true,
-                additionalCondition = ARG_IS_ZERO_CONST
-            ),
-            MoveOutMapping(
-                COMPARABLE_COMPARE_TO,
-                MethodNames.IS_LESS_THAN, expectedMatcher = IS_NEGATIVE_INT, replaceFromOriginalMethod = true
-            )
-        )
-    }
-
-    override fun getDisplayName() = DISPLAY_NAME
-
-    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
-        return object : JavaElementVisitor() {
-            override fun visitExpressionStatement(statement: PsiExpressionStatement) {
-                super.visitExpressionStatement(statement)
-                createInspectionsForMappings(statement, holder, MAPPINGS)
-            }
-        }
-    }
-}

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatEnumerableIsEmptyInspection.kt

@@ -5,7 +5,6 @@ import com.intellij.psi.JavaElementVisitor
 import com.intellij.psi.PsiElementVisitor
 import com.intellij.psi.PsiMethodCallExpression
 import com.intellij.psi.PsiStatement
-import com.siyeh.ig.callMatcher.CallMatcher
 import de.platon42.intellij.plugins.cajon.MethodNames
 import de.platon42.intellij.plugins.cajon.calculateConstantParameterValue
 import de.platon42.intellij.plugins.cajon.hasAssertThat
@@ -13,7 +12,7 @@ import de.platon42.intellij.plugins.cajon.hasAssertThat
 class AssertThatEnumerableIsEmptyInspection : AbstractAssertJInspection() {
 
     companion object {
-        private const val DISPLAY_NAME = "Asserting an empty or not empty enumerable"
+        private const val DISPLAY_NAME = "Asserting an empty enumerable"
     }
 
     override fun getDisplayName() = DISPLAY_NAME
@@ -24,17 +23,11 @@ class AssertThatEnumerableIsEmptyInspection : AbstractAssertJInspection() {
                 super.visitMethodCallExpression(expression)
                 if (!expression.hasAssertThat()) return
                 val isLastExpression = expression.parent is PsiStatement
+                if (!(HAS_SIZE.test(expression) && isLastExpression)) return
+
                 val value = expression.calculateConstantParameterValue(0) ?: return
-
+                if (value == 0) {
-                val isEmpty = (CallMatcher.anyOf(HAS_SIZE, HAS_SIZE_LESS_THAN_OR_EQUAL_TO_INT).test(expression) && (value == 0)) ||
-                        (HAS_SIZE_LESS_THAN_INT.test(expression) && (value == 1))
-                val isNotEmpty = (HAS_SIZE_GREATER_THAN_INT.test(expression) && (value == 0)) ||
-                        (HAS_SIZE_GREATER_THAN_OR_EQUAL_TO_INT.test(expression) && (value == 1))
-
-                if (isEmpty && isLastExpression) {
                     registerSimplifyMethod(holder, expression, MethodNames.IS_EMPTY)
-                } else if (isNotEmpty) {
-                    registerSimplifyMethod(holder, expression, MethodNames.IS_NOT_EMPTY)
                 }
             }
         }

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatFileExpressionInspection.kt

@@ -1,9 +1,13 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
 import com.intellij.codeInspection.ProblemsHolder
-import com.intellij.psi.*
+import com.intellij.psi.CommonClassNames
+import com.intellij.psi.JavaElementVisitor
+import com.intellij.psi.PsiElementVisitor
+import com.intellij.psi.PsiExpressionStatement
 import com.siyeh.ig.callMatcher.CallMatcher
-import de.platon42.intellij.plugins.cajon.*
+import de.platon42.intellij.plugins.cajon.AssertJClassNames
+import de.platon42.intellij.plugins.cajon.MethodNames
 
 
 class AssertThatFileExpressionInspection : AbstractMoveOutInspection() {
@@ -11,94 +15,61 @@ class AssertThatFileExpressionInspection : AbstractMoveOutInspection() {
     companion object {
         private const val DISPLAY_NAME = "Asserting a file specific expression"
 
-        private val ARG_IS_ZERO_CONST: (PsiExpressionStatement, PsiMethodCallExpression) -> Boolean = { _, call -> call.firstArg.calculateConstantValue() == 0 }
-        private val ARG_IS_NOT_ZERO_CONST: (PsiExpressionStatement, PsiMethodCallExpression) -> Boolean = { _, call ->
-            val constant =
-                call.firstArg.calculateConstantValue()
-            (constant != null) && (constant != 0)
-        }
-
         private val MAPPINGS = listOf(
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "canRead").parameterCount(0),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "canRead"),
                 "canRead", expectBoolean = true
             ),
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "canWrite").parameterCount(0),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "canWrite"),
                 "canWrite", expectBoolean = true
             ),
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "exists").parameterCount(0),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "exists"),
                 "exists", "doesNotExist", expectBoolean = true
             ),
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "isAbsolute").parameterCount(0),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "isAbsolute"),
                 "isAbsolute", "isRelative", expectBoolean = true
             ),
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "isDirectory").parameterCount(0),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "isDirectory"),
                 "isDirectory", expectBoolean = true
             ),
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "isFile").parameterCount(0),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "isFile"),
                 "isFile", expectBoolean = true
             ),
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "getName").parameterCount(0),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "getName"),
                 "hasName",
                 expectedMatcher = CallMatcher.anyOf(IS_EQUAL_TO_OBJECT, IS_EQUAL_TO_STRING)
             ),
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "getParent", "getParentFile").parameterCount(0),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "getParent", "getParentFile"),
                 "hasNoParent", expectNullNonNull = true
             ),
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "getParent").parameterCount(0),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "getParent"),
                 "hasParent",
                 expectedMatcher = CallMatcher.anyOf(IS_EQUAL_TO_OBJECT, IS_EQUAL_TO_STRING)
             ),
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "getParentFile").parameterCount(0),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "getParentFile"),
                 "hasParent",
                 expectedMatcher = IS_EQUAL_TO_OBJECT
             ),
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "list", "listFiles").parameterCount(0),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "list", "listFiles"),
                 "isEmptyDirectory",
                 expectedMatcher = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_OBJECT_ARRAY_ASSERT_CLASSNAME, MethodNames.IS_EMPTY)
-                    .parameterCount(0)
+                    .parameterCount(0)!!
             ),
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "list", "listFiles").parameterCount(0),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "list", "listFiles"),
                 "isNotEmptyDirectory",
                 expectedMatcher = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_OBJECT_ARRAY_ASSERT_CLASSNAME, MethodNames.IS_NOT_EMPTY)
-                    .parameterCount(0)
+                    .parameterCount(0)!!
-            )
-        )
-
-        private val MAPPINGS_SINCE_ASSERTJ_3_14_0 = listOf(
-            MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "length").parameterCount(0),
-                MethodNames.IS_EMPTY, expectedMatcher = IS_ZERO_LONG, noExpectedExpression = true
-            ),
-            MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "length").parameterCount(0),
-                MethodNames.IS_EMPTY, expectedMatcher = IS_EQUAL_TO_LONG, noExpectedExpression = true,
-                additionalCondition = ARG_IS_ZERO_CONST
-            ),
-            MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "length").parameterCount(0),
-                MethodNames.IS_NOT_EMPTY, expectedMatcher = IS_NOT_ZERO_LONG, noExpectedExpression = true
-            ),
-            MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "length").parameterCount(0),
-                MethodNames.IS_NOT_EMPTY, expectedMatcher = IS_NOT_EQUAL_TO_LONG, noExpectedExpression = true,
-                additionalCondition = ARG_IS_ZERO_CONST
-            ),
-            MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "length").parameterCount(0),
-                MethodNames.HAS_SIZE, expectedMatcher = IS_EQUAL_TO_LONG,
-                additionalCondition = ARG_IS_NOT_ZERO_CONST
             )
         )
     }
@@ -110,9 +81,6 @@ class AssertThatFileExpressionInspection : AbstractMoveOutInspection() {
             override fun visitExpressionStatement(statement: PsiExpressionStatement) {
                 super.visitExpressionStatement(statement)
                 createInspectionsForMappings(statement, holder, MAPPINGS)
-                if (hasAssertJMethod(statement, AssertJClassNames.ABSTRACT_FILE_ASSERT_CLASSNAME, MethodNames.HAS_SIZE)) {
-                    createInspectionsForMappings(statement, holder, MAPPINGS_SINCE_ASSERTJ_3_14_0)
-                }
             }
         }
     }

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatGuavaOptionalInspection.kt

@@ -92,7 +92,9 @@ class AssertThatGuavaOptionalInspection : AbstractAssertJInspection() {
             }
 
             private fun checkPreconditions(staticMethodCall: PsiMethodCallExpression): Boolean {
-                if (CallMatcher.anyOf(ASSERT_THAT_ANY, GUAVA_ASSERT_THAT_ANY).test(staticMethodCall)) {
+                val assertThatGuava = GUAVA_ASSERT_THAT_ANY.test(staticMethodCall)
+
+                if (ASSERT_THAT_ANY.test(staticMethodCall) || assertThatGuava) {
                     JavaPsiFacade.getInstance(staticMethodCall.project)
                         .findClass(AssertJClassNames.GUAVA_ASSERTIONS_CLASSNAME, GlobalSearchScope.allScope(staticMethodCall.project)) ?: return false
                     return true

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatInvertedBooleanConditionInspection.kt

@@ -1,13 +1,8 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
 import com.intellij.codeInspection.ProblemsHolder
-import com.intellij.openapi.util.TextRange
 import com.intellij.psi.*
-import com.intellij.psi.util.PsiUtil
-import com.intellij.psi.util.TypeConversionUtil
-import com.siyeh.ig.callMatcher.CallMatcher
 import de.platon42.intellij.plugins.cajon.*
-import de.platon42.intellij.plugins.cajon.quickfixes.InvertUnaryExpressionQuickFix
 import de.platon42.intellij.plugins.cajon.quickfixes.InvertUnaryStatementQuickFix
 
 class AssertThatInvertedBooleanConditionInspection : AbstractAssertJInspection() {
@@ -15,8 +10,6 @@ class AssertThatInvertedBooleanConditionInspection : AbstractAssertJInspection()
     companion object {
         private const val DISPLAY_NAME = "Asserting an inverted boolean condition"
         private const val INVERT_CONDITION_MESSAGE = "Condition inside assertThat() could be inverted"
-        private const val REMOVE_INSTANCEOF_DESCRIPTION_TEMPLATE = "Invert condition in %s() and use %s() instead"
-        private const val INVERT_OUTSIDE_CONDITION_MESSAGE = "Condition outside assertThat() could be inverted"
     }
 
     override fun getDisplayName() = DISPLAY_NAME
@@ -27,27 +20,13 @@ class AssertThatInvertedBooleanConditionInspection : AbstractAssertJInspection()
                 super.visitMethodCallExpression(expression)
                 if (!expression.hasAssertThat()) return
                 val staticMethodCall = expression.findStaticMethodCall() ?: return
-                if (expression.getExpectedBooleanResult() != null) {
+                if (!ASSERT_THAT_BOOLEAN.test(staticMethodCall)) return
-                    if (!ASSERT_THAT_BOOLEAN.test(staticMethodCall)) return
+                expression.getExpectedBooleanResult() ?: return
-                    val prefixExpression = staticMethodCall.firstArg as? PsiPrefixExpression ?: return
-                    if (prefixExpression.operationTokenType == JavaTokenType.EXCL) {
-                        val outmostMethodCall = expression.findOutmostMethodCall() ?: return
-                        holder.registerProblem(outmostMethodCall, INVERT_CONDITION_MESSAGE, InvertUnaryStatementQuickFix())
-                    }
-                } else {
-                    if (!CallMatcher.anyOf(ASSERT_THAT_BOOLEAN, ASSERT_THAT_BOOLEAN_OBJ).test(staticMethodCall)) return
-                    val isEqualTo = CallMatcher.anyOf(IS_EQUAL_TO_BOOLEAN, IS_EQUAL_TO_OBJECT).test(expression)
-                    val isNotEqualTo = CallMatcher.anyOf(IS_NOT_EQUAL_TO_BOOLEAN, IS_NOT_EQUAL_TO_OBJECT).test(expression)
-                    if (!(isEqualTo || isNotEqualTo)) return
-                    val prefixExpression = expression.firstArg as? PsiPrefixExpression ?: return
-                    val operand = PsiUtil.skipParenthesizedExprDown(prefixExpression.operand) ?: return
-                    if (!TypeConversionUtil.isPrimitiveAndNotNull(operand.type)) return
-                    val originalMethod = getOriginalMethodName(expression) ?: return
 
-                    val replacementMethod = isEqualTo.map(MethodNames.IS_NOT_EQUAL_TO, MethodNames.IS_EQUAL_TO)
+                val prefixExpression = staticMethodCall.firstArg as? PsiPrefixExpression ?: return
-                    val description = REMOVE_INSTANCEOF_DESCRIPTION_TEMPLATE.format(originalMethod, replacementMethod)
+                if (prefixExpression.operationTokenType == JavaTokenType.EXCL) {
-                    val textRange = TextRange(staticMethodCall.textLength, expression.textLength)
+                    val outmostMethodCall = expression.findOutmostMethodCall() ?: return
-                    holder.registerProblem(expression, textRange, INVERT_OUTSIDE_CONDITION_MESSAGE, InvertUnaryExpressionQuickFix(description, replacementMethod))
+                    holder.registerProblem(outmostMethodCall, INVERT_CONDITION_MESSAGE, InvertUnaryStatementQuickFix())
                 }
             }
         }

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatIsZeroOneInspection.kt

@@ -1,81 +0,0 @@
-package de.platon42.intellij.plugins.cajon.inspections
-
-import com.intellij.codeInspection.ProblemsHolder
-import com.intellij.psi.JavaElementVisitor
-import com.intellij.psi.PsiElementVisitor
-import com.intellij.psi.PsiMethodCallExpression
-import com.intellij.psi.util.TypeConversionUtil
-import com.siyeh.ig.callMatcher.CallMatcher
-import de.platon42.intellij.plugins.cajon.*
-
-class AssertThatIsZeroOneInspection : AbstractAssertJInspection() {
-
-    companion object {
-        private const val DISPLAY_NAME = "Asserting a zero or one value"
-    }
-
-    override fun getDisplayName() = DISPLAY_NAME
-
-    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
-        return object : JavaElementVisitor() {
-            override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
-                super.visitMethodCallExpression(expression)
-                if (!expression.hasAssertThat()) return
-                val isEqualTo = CallMatcher.anyOf(IS_EQUAL_TO_OBJECT, IS_EQUAL_TO_SHORT, IS_EQUAL_TO_INT, IS_EQUAL_TO_LONG, IS_EQUAL_TO_FLOAT, IS_EQUAL_TO_DOUBLE).test(expression)
-                val isNotEqualTo =
-                    CallMatcher.anyOf(IS_NOT_EQUAL_TO_OBJECT, IS_NOT_EQUAL_TO_SHORT, IS_NOT_EQUAL_TO_INT, IS_NOT_EQUAL_TO_LONG, IS_NOT_EQUAL_TO_FLOAT, IS_NOT_EQUAL_TO_DOUBLE)
-                        .test(expression)
-
-                if (!(isEqualTo || isNotEqualTo)) return
-
-                val expectedExpression = expression.firstArg
-                if (!TypeConversionUtil.isNumericType(expectedExpression.type)) return
-
-                val expectedResult = expression.calculateConstantParameterValue(0) ?: return
-                var isZero = false
-                var isOne = false
-                when (expectedResult) {
-                    is Short -> {
-                        isZero = (expectedResult == 0.toShort())
-                        isOne = (expectedResult == 1.toShort())
-                    }
-
-                    is Int -> {
-                        isZero = (expectedResult == 0)
-                        isOne = (expectedResult == 1)
-                    }
-
-                    is Long -> {
-                        isZero = (expectedResult == 0L)
-                        isOne = (expectedResult == 1L)
-                    }
-
-                    is Float -> {
-                        isZero = (expectedResult == 0.0f)
-                        isOne = (expectedResult == 1.0f)
-                    }
-
-                    is Double -> {
-                        isZero = (expectedResult == 0.0)
-                        isOne = (expectedResult == 1.0)
-                    }
-                }
-                if (isZero || isOne) {
-                    val numericBaseClass = listOf(
-                        AssertJClassNames.ABSTRACT_SHORT_ASSERT_CLASSNAME,
-                        AssertJClassNames.ABSTRACT_INTEGER_ASSERT_CLASSNAME,
-                        AssertJClassNames.ABSTRACT_LONG_ASSERT_CLASSNAME,
-                        AssertJClassNames.ABSTRACT_FLOAT_ASSERT_CLASSNAME,
-                        AssertJClassNames.ABSTRACT_DOUBLE_ASSERT_CLASSNAME
-                    ).any { checkAssertedType(expression, it) }
-                    if (!numericBaseClass) return
-                }
-                if (isZero) {
-                    registerSimplifyMethod(holder, expression, isEqualTo.map(MethodNames.IS_ZERO, MethodNames.IS_NOT_ZERO))
-                } else if (isOne && isEqualTo) {
-                    registerSimplifyMethod(holder, expression, MethodNames.IS_ONE)
-                }
-            }
-        }
-    }
-}

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatJava8OptionalInspection.kt

@@ -76,4 +76,4 @@ class AssertThatJava8OptionalInspection : AbstractAssertJInspection() {
             }
         }
     }
-}
+}

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatObjectExpressionInspection.kt

@@ -34,9 +34,9 @@ class AssertThatObjectExpressionInspection : AbstractMoveOutInspection() {
             override fun visitExpressionStatement(statement: PsiExpressionStatement) {
                 super.visitExpressionStatement(statement)
                 if (!statement.hasAssertThat()) return
-
+                
                 val staticMethodCall = statement.findStaticMethodCall() ?: return
-                val assertThatArgument = staticMethodCall.getArgOrNull(0) as? PsiMethodCallExpression ?: return
+                val assertThatArgument = staticMethodCall.firstArg as? PsiMethodCallExpression ?: return
                 if (OBJECT_HASHCODE.test(assertThatArgument)) {
                     val expectedCallExpression = statement.findOutmostMethodCall() ?: return
                     val isEqualTo = staticMethodCall.findFluentCallTo(IS_EQUAL_TO_INT) ?: return

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatObjectIsNullOrNotNullInspection.kt

@@ -32,4 +32,4 @@ class AssertThatObjectIsNullOrNotNullInspection : AbstractAssertJInspection() {
             }
         }
     }
-}
+}

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatPathExpressionInspection.kt

@@ -1,52 +0,0 @@
-package de.platon42.intellij.plugins.cajon.inspections
-
-import com.intellij.codeInspection.ProblemsHolder
-import com.intellij.psi.JavaElementVisitor
-import com.intellij.psi.PsiElementVisitor
-import com.intellij.psi.PsiExpressionStatement
-import com.siyeh.ig.callMatcher.CallMatcher
-import de.platon42.intellij.plugins.cajon.MethodNames
-
-
-class AssertThatPathExpressionInspection : AbstractMoveOutInspection() {
-
-    companion object {
-        private const val DISPLAY_NAME = "Asserting a path specific expression"
-        private const val JAVA_NIO_PATH = "java.nio.file.Path"
-
-        private val MAPPINGS = listOf(
-            MoveOutMapping(
-                CallMatcher.instanceCall(JAVA_NIO_PATH, "isAbsolute").parameterCount(0),
-                "isAbsolute", "isRelative", expectBoolean = true
-            ),
-            MoveOutMapping(
-                CallMatcher.instanceCall(JAVA_NIO_PATH, MethodNames.STARTS_WITH).parameterTypes(JAVA_NIO_PATH),
-                "startsWithRaw", expectBoolean = true
-            ),
-            MoveOutMapping(
-                CallMatcher.instanceCall(JAVA_NIO_PATH, MethodNames.ENDS_WITH).parameterTypes(JAVA_NIO_PATH),
-                "endsWithRaw", expectBoolean = true
-            ),
-            MoveOutMapping(
-                CallMatcher.instanceCall(JAVA_NIO_PATH, "getParent").parameterCount(0),
-                "hasParentRaw",
-                expectedMatcher = IS_EQUAL_TO_OBJECT
-            ),
-            MoveOutMapping(
-                CallMatcher.instanceCall(JAVA_NIO_PATH, "getParent").parameterCount(0),
-                "hasNoParentRaw", expectNullNonNull = true
-            )
-        )
-    }
-
-    override fun getDisplayName() = DISPLAY_NAME
-
-    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
-        return object : JavaElementVisitor() {
-            override fun visitExpressionStatement(statement: PsiExpressionStatement) {
-                super.visitExpressionStatement(statement)
-                createInspectionsForMappings(statement, holder, MAPPINGS)
-            }
-        }
-    }
-}

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatSizeInspection.kt

@@ -57,10 +57,10 @@ class AssertThatSizeInspection : AbstractAssertJInspection() {
             } else {
                 val isTestForEmpty = ((IS_LESS_THAN_OR_EQUAL_TO_INT.test(expression) && (constValue == 0))
                         || (IS_LESS_THAN_INT.test(expression) && (constValue == 1))
-                        || IS_ZERO_INT.test(expression))
+                        || IS_ZERO.test(expression))
                 val isTestForNotEmpty = ((IS_GREATER_THAN_INT.test(expression) && (constValue == 0))
                         || (IS_GREATER_THAN_OR_EQUAL_TO_INT.test(expression) && (constValue == 1))
-                        || IS_NOT_ZERO_INT.test(expression))
+                        || IS_NOT_ZERO.test(expression))
                 if ((isTestForEmpty && isLastExpression) || isTestForNotEmpty) {
                     val replacementMethod = isTestForEmpty.map(MethodNames.IS_EMPTY, MethodNames.IS_NOT_EMPTY)
                     return Match(expression, replacementMethod, noExpectedExpression = true)

src/main/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatStringExpressionInspection.kt

@@ -22,12 +22,12 @@ class AssertThatStringExpressionInspection : AbstractMoveOutInspection() {
 
         private val MAPPINGS = listOf(
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, MethodNames.IS_EMPTY).parameterCount(0),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "isEmpty").parameterCount(0),
                 MethodNames.IS_EMPTY, MethodNames.IS_NOT_EMPTY, expectBoolean = true
             ),
             MoveOutMapping(
                 CallMatcher.anyOf(
-                    CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, MethodNames.EQUALS).parameterCount(1),
+                    CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "equals").parameterCount(1),
                     CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "contentEquals").parameterCount(1)
                 ),
                 MethodNames.IS_EQUAL_TO, MethodNames.IS_NOT_EQUAL_TO, expectBoolean = true
@@ -37,15 +37,15 @@ class AssertThatStringExpressionInspection : AbstractMoveOutInspection() {
                 MethodNames.IS_EQUAL_TO_IC, MethodNames.IS_NOT_EQUAL_TO_IC, expectBoolean = true
             ),
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, MethodNames.CONTAINS).parameterCount(1),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "contains").parameterCount(1),
                 MethodNames.CONTAINS, MethodNames.DOES_NOT_CONTAIN, expectBoolean = true
             ),
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, MethodNames.STARTS_WITH).parameterTypes(CommonClassNames.JAVA_LANG_STRING),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "startsWith").parameterTypes(CommonClassNames.JAVA_LANG_STRING),
                 MethodNames.STARTS_WITH, MethodNames.DOES_NOT_START_WITH, expectBoolean = true
             ),
             MoveOutMapping(
-                CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, MethodNames.ENDS_WITH).parameterTypes(CommonClassNames.JAVA_LANG_STRING),
+                CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "endsWith").parameterTypes(CommonClassNames.JAVA_LANG_STRING),
                 MethodNames.ENDS_WITH, MethodNames.DOES_NOT_END_WITH, expectBoolean = true
             ),
             MoveOutMapping(
@@ -60,7 +60,7 @@ class AssertThatStringExpressionInspection : AbstractMoveOutInspection() {
             ),
             MoveOutMapping(
                 STRING_COMPARE_TO_IGNORE_CASE,
-                MethodNames.IS_EQUAL_TO_IC, expectedMatcher = IS_ZERO_INT, replaceFromOriginalMethod = true
+                MethodNames.IS_EQUAL_TO_IC, expectedMatcher = IS_ZERO, replaceFromOriginalMethod = true
             ),
             MoveOutMapping(
                 STRING_COMPARE_TO_IGNORE_CASE,
@@ -69,7 +69,7 @@ class AssertThatStringExpressionInspection : AbstractMoveOutInspection() {
             ),
             MoveOutMapping(
                 STRING_COMPARE_TO_IGNORE_CASE,
-                MethodNames.IS_NOT_EQUAL_TO_IC, expectedMatcher = IS_NOT_ZERO_INT, replaceFromOriginalMethod = true
+                MethodNames.IS_NOT_EQUAL_TO_IC, expectedMatcher = IS_NOT_ZERO, replaceFromOriginalMethod = true
             ),
 
             MoveOutMapping(
@@ -79,7 +79,7 @@ class AssertThatStringExpressionInspection : AbstractMoveOutInspection() {
             ),
             MoveOutMapping(
                 STRING_INDEX_OF,
-                MethodNames.STARTS_WITH, expectedMatcher = IS_ZERO_INT, replaceFromOriginalMethod = true
+                MethodNames.STARTS_WITH, expectedMatcher = IS_ZERO, replaceFromOriginalMethod = true
             ),
 
             MoveOutMapping(
@@ -89,12 +89,12 @@ class AssertThatStringExpressionInspection : AbstractMoveOutInspection() {
             ),
             MoveOutMapping(
                 STRING_INDEX_OF,
-                MethodNames.DOES_NOT_START_WITH, expectedMatcher = IS_NOT_ZERO_INT, replaceFromOriginalMethod = true
+                MethodNames.DOES_NOT_START_WITH, expectedMatcher = IS_NOT_ZERO, replaceFromOriginalMethod = true
             ),
 
             MoveOutMapping(
                 STRING_INDEX_OF,
-                MethodNames.CONTAINS, expectedMatcher = IS_NOT_NEGATIVE_INT, replaceFromOriginalMethod = true
+                MethodNames.CONTAINS, expectedMatcher = IS_NOT_NEGATIVE, replaceFromOriginalMethod = true
             ),
             MoveOutMapping(
                 STRING_INDEX_OF,
@@ -119,7 +119,7 @@ class AssertThatStringExpressionInspection : AbstractMoveOutInspection() {
             ),
             MoveOutMapping(
                 STRING_INDEX_OF,
-                MethodNames.DOES_NOT_CONTAIN, expectedMatcher = IS_NEGATIVE_INT, replaceFromOriginalMethod = true
+                MethodNames.DOES_NOT_CONTAIN, expectedMatcher = IS_NEGATIVE, replaceFromOriginalMethod = true
             ),
             MoveOutMapping(
                 STRING_INDEX_OF,

src/main/java/de/platon42/intellij/plugins/cajon/inspections/BogusAssertionInspection.kt

@@ -1,177 +0,0 @@
-package de.platon42.intellij.plugins.cajon.inspections
-
-import com.intellij.codeInspection.ProblemHighlightType
-import com.intellij.codeInspection.ProblemsHolder
-import com.intellij.psi.*
-import com.intellij.psi.util.PsiTreeUtil
-import com.siyeh.ig.callMatcher.CallMatcher
-import com.siyeh.ig.psiutils.EquivalenceChecker
-import de.platon42.intellij.plugins.cajon.*
-
-class BogusAssertionInspection : AbstractAssertJInspection() {
-
-    companion object {
-        private const val DISPLAY_NAME = "Bogus assertion due to same actual and expected expressions"
-        private const val ACTUAL_IS_EQUAL_TO_EXPECTED_MESSAGE = "Actual expression in assertThat() is the same as expected"
-        private const val WEAK_ACTUAL_IS_EQUAL_TO_EXPECTED_MESSAGE = "Same actual and expected expression, but may be testing equals() or hashCode()"
-
-        private val SAME_OBJECT =
-            CallMatcher.instanceCall(
-                AssertJClassNames.ASSERT_INTERFACE,
-                MethodNames.IS_EQUAL_TO,
-                MethodNames.IS_SAME_AS,
-                "hasSameClassAs",
-                "hasSameHashCodeAs"
-            ).parameterCount(1)
-
-        private val ARRAY_METHODS = arrayOf(
-            MethodNames.HAS_SAME_SIZE_AS,
-            MethodNames.CONTAINS,
-            "containsAnyOf",
-            MethodNames.CONTAINS_EXACTLY,
-            "containsExactlyInAnyOrder",
-            "containsOnly",
-            "containsSequence",
-            "containsSubsequence",
-            MethodNames.STARTS_WITH,
-            MethodNames.ENDS_WITH
-        )
-
-        private val SAME_BOOLEAN_ARRAY_CONTENTS =
-            CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_BOOLEAN_ARRAY_ASSERT_CLASSNAME, *ARRAY_METHODS).parameterCount(1)
-        private val SAME_BYTE_ARRAY_CONTENTS =
-            CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_BYTE_ARRAY_ASSERT_CLASSNAME, *ARRAY_METHODS).parameterCount(1)
-        private val SAME_SHORT_ARRAY_CONTENTS =
-            CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_SHORT_ARRAY_ASSERT_CLASSNAME, *ARRAY_METHODS).parameterCount(1)
-        private val SAME_INT_ARRAY_CONTENTS =
-            CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_INT_ARRAY_ASSERT_CLASSNAME, *ARRAY_METHODS).parameterCount(1)
-        private val SAME_LONG_ARRAY_CONTENTS =
-            CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_LONG_ARRAY_ASSERT_CLASSNAME, *ARRAY_METHODS).parameterCount(1)
-        private val SAME_FLOAT_ARRAY_CONTENTS =
-            CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_FLOAT_ARRAY_ASSERT_CLASSNAME, *ARRAY_METHODS).parameterCount(1)
-        private val SAME_DOUBLE_ARRAY_CONTENTS =
-            CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_DOUBLE_ARRAY_ASSERT_CLASSNAME, *ARRAY_METHODS).parameterCount(1)
-        private val SAME_CHAR_ARRAY_CONTENTS =
-            CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_CHAR_ARRAY_ASSERT_CLASSNAME, *ARRAY_METHODS).parameterCount(1)
-        private val SAME_OBJECT_ARRAY_CONTENTS =
-            CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_OBJECT_ARRAY_ASSERT_CLASSNAME, *ARRAY_METHODS).parameterCount(1)
-
-        private val HASHCODE_OR_IS_EQUAL_TO =
-            CallMatcher.instanceCall(
-                AssertJClassNames.ASSERT_INTERFACE,
-                MethodNames.IS_EQUAL_TO, "hasSameHashCodeAs"
-            ).parameterCount(1)
-
-        private val SAME_ENUMERABLE_CONTENTS =
-            CallMatcher.instanceCall(
-                AssertJClassNames.ENUMERABLE_ASSERT_INTERFACE,
-                MethodNames.HAS_SAME_SIZE_AS
-            ).parameterCount(1)
-
-        private val SAME_ITERABLE_CONTENTS =
-            CallMatcher.instanceCall(
-                AssertJClassNames.ABSTRACT_ITERABLE_ASSERT_CLASSNAME,
-                "hasSameElementsAs",
-                MethodNames.CONTAINS_ALL,
-                "containsAnyElementsOf",
-                "containsOnlyElementsOf",
-                "containsExactlyElementsOf",
-                "containsSequence",
-                "containsSubsequence"
-            ).parameterCount(1)
-
-        private val SAME_MAP_CONTENTS =
-            CallMatcher.instanceCall(
-                AssertJClassNames.ABSTRACT_MAP_ASSERT_CLASSNAME,
-                "containsAllEntriesOf",
-                "containsExactlyEntriesOf",
-                "containsExactlyInAnyOrderEntriesOf",
-                MethodNames.HAS_SAME_SIZE_AS
-            ).parameterCount(1)
-
-        private val SAME_CHAR_SEQUENCE_CONTENTS =
-            CallMatcher.instanceCall(
-                AssertJClassNames.ABSTRACT_CHAR_SEQUENCE_ASSERT_CLASSNAME,
-                MethodNames.IS_EQUAL_TO,
-                MethodNames.IS_EQUAL_TO_IC,
-                MethodNames.STARTS_WITH,
-                MethodNames.ENDS_WITH,
-                "containsSequence",
-                "containsSubsequence"
-            ).parameterCount(1)
-
-        private val SAME_ACTUAL_AND_EXPECTED_MATCHERS = CallMatcher.anyOf(
-            SAME_OBJECT,
-            SAME_ENUMERABLE_CONTENTS,
-            SAME_ITERABLE_CONTENTS,
-            SAME_MAP_CONTENTS,
-            SAME_CHAR_SEQUENCE_CONTENTS,
-
-            SAME_BOOLEAN_ARRAY_CONTENTS,
-            SAME_BYTE_ARRAY_CONTENTS,
-            SAME_SHORT_ARRAY_CONTENTS,
-            SAME_INT_ARRAY_CONTENTS,
-            SAME_LONG_ARRAY_CONTENTS,
-            SAME_FLOAT_ARRAY_CONTENTS,
-            SAME_DOUBLE_ARRAY_CONTENTS,
-            SAME_CHAR_ARRAY_CONTENTS,
-            SAME_OBJECT_ARRAY_CONTENTS
-        )
-    }
-
-    override fun getDisplayName() = DISPLAY_NAME
-
-    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
-        return object : JavaElementVisitor() {
-            override fun visitExpressionStatement(statement: PsiExpressionStatement) {
-                super.visitExpressionStatement(statement)
-                if (!statement.hasAssertThat()) return
-                val assertThatCall = PsiTreeUtil.findChildrenOfType(statement, PsiMethodCallExpression::class.java).find { ALL_ASSERT_THAT_MATCHERS.test(it) } ?: return
-                val actualExpression = assertThatCall.firstArg
-                val allCalls = assertThatCall.collectMethodCallsUpToStatement().toList()
-                // Note: replace with TrackingEquivalenceChecker() for IDEA >= 2019.1
-                val equivalenceChecker = EquivalenceChecker.getCanonicalPsiEquivalence()!!
-                val isSameExpression = allCalls
-                    .filter { it.argumentList.expressions.size == 1 }
-                    .filter(SAME_ACTUAL_AND_EXPECTED_MATCHERS::test)
-                    .any { equivalenceChecker.expressionsAreEquivalent(actualExpression, it.firstArg) }
-                if (isSameExpression) {
-                    if (!hasExpressionWithSideEffects(actualExpression)) {
-                        if (allCalls.any(HASHCODE_OR_IS_EQUAL_TO::test)) {
-                            val method = PsiTreeUtil.getParentOfType(statement, PsiMethod::class.java, true)
-                            val methodName = method?.name
-                            if ((methodName != null)
-                                && ((methodName.contains("equal", ignoreCase = true) || methodName.contains("hashcode", ignoreCase = true)))
-                            ) {
-                                if (isOnTheFly) {
-                                    holder.registerProblem(statement, WEAK_ACTUAL_IS_EQUAL_TO_EXPECTED_MESSAGE, ProblemHighlightType.INFORMATION)
-                                }
-                                return
-                            }
-                        }
-                        holder.registerProblem(statement, ACTUAL_IS_EQUAL_TO_EXPECTED_MESSAGE)
-                    }
-                }
-            }
-
-            private fun hasExpressionWithSideEffects(actualExpression: PsiExpression): Boolean {
-                var result = false
-                PsiTreeUtil.processElements(actualExpression) { element ->
-                    val matched = when (element) {
-                        is PsiUnaryExpression -> (element.operationTokenType == JavaTokenType.PLUSPLUS)
-                                || (element.operationTokenType == JavaTokenType.MINUSMINUS)
-                        is PsiMethodCallExpression -> true
-                        else -> false
-                    }
-                    if (matched) {
-                        result = true
-                        false
-                    } else {
-                        true
-                    }
-                }
-                return result
-            }
-        }
-    }
-}

src/main/java/de/platon42/intellij/plugins/cajon/inspections/ImplicitAssertionInspection.kt

@@ -30,26 +30,27 @@ class ImplicitAssertionInspection : AbstractAssertJInspection() {
         private val OBJECT_ENUMERABLE_ANY_CONTENT_ASSERTIONS = CallMatcher.instanceCall(
             AssertJClassNames.OBJECT_ENUMERABLE_ASSERT_INTERFACE,
             MethodNames.CONTAINS, "containsOnly", "containsOnlyNulls", MethodNames.CONTAINS_ONLY_ONCE,
-            MethodNames.CONTAINS_EXACTLY, "containsExactlyInAnyOrder", "containsExactlyInAnyOrderElementsOf",
+            "containsExactly", "containsExactlyInAnyOrder", "containsExactlyInAnyOrderElementsOf",
-            MethodNames.CONTAINS_ALL, "containsAnyOf",
+            "containsAll", "containsAnyOf",
             "containsAnyElementsOf", "containsExactlyElementsOf", "containsOnlyElementsOf",
             "isSubsetOf", "containsSequence", "containsSubsequence",
-            "doesNotContainSequence", "doesNotContainSubsequence", MethodNames.DOES_NOT_CONTAIN,
+            "doesNotContainSequence", "doesNotContainSubsequence", "doesNotContain",
             "doesNotContainAnyElementsOf", "doesNotHaveDuplicates",
-            MethodNames.STARTS_WITH, MethodNames.ENDS_WITH, "containsNull", "doesNotContainNull",
+            "startsWith", "endsWith", "containsNull", "doesNotContainNull",
             "are", "areNot", "have", "doNotHave", "areAtLeastOne", "areAtLeast", "areAtMost", "areExactly",
             "haveAtLeastOne", "haveAtLeast", "haveAtMost", "haveExactly",
+            "doesNotHave", "doesNotHaveSameClassAs",
             "hasAtLeastOneElementOfType", "hasOnlyElementsOfType", "hasOnlyElementsOfTypes",
             "doesNotHaveAnyElementsOfTypes",
             "has", "doesNotHave",
-            "singleElement", "hasOnlyOneElementSatisfying", "hasSameElementsAs",
+            "hasOnlyOneElementSatisfying", "hasSameElementsAs",
             "allMatch", "allSatisfy", "anyMatch", "anySatisfy", "noneMatch", "noneSatisfy"
         )!!
 
         private val OBJECT_ENUMERABLE_AT_LEAST_ONE_CONTENT_ASSERTIONS = CallMatcher.instanceCall(
             AssertJClassNames.OBJECT_ENUMERABLE_ASSERT_INTERFACE,
             "containsOnlyNulls",
-            MethodNames.STARTS_WITH, MethodNames.ENDS_WITH, "containsNull",
+            "startsWith", "endsWith", "containsNull",
             "areAtLeastOne",
             "haveAtLeastOne",
             "hasAtLeastOneElementOfType",
@@ -72,10 +73,10 @@ class ImplicitAssertionInspection : AbstractAssertJInspection() {
 
         private val NON_NULL_CORE_ASSERTIONS = CallMatcher.instanceCall(
             AssertJClassNames.ASSERT_INTERFACE,
-            MethodNames.IS_INSTANCE_OF, "isInstanceOfSatisfying", "isInstanceOfAny", "isExactlyInstanceOf", "isOfAnyClassIn",
+            "isInstanceOf", "isInstanceOfSatisfying", "isInstanceOfAny", "isExactlyInstanceOf", "isOfAnyClassIn",
-            MethodNames.IS_NOT_INSTANCE_OF, "isNotInstanceOfAny", "isNotExactlyInstanceOf", "isNotOfAnyClassIn",
+            "isNotInstanceOf", "isNotInstanceOfAny", "isNotExactlyInstanceOf", "isNotOfAnyClassIn",
             "hasSameClassAs", "doesNotHaveSameClassAs",
-            MethodNames.HAS_TO_STRING, "hasSameHashCodeAs"
+            "hasToString", "hasSameHashCodeAs"
         )!!
 
         private val GUAVA_IS_PRESENT = CallMatcher.instanceCall(AssertJClassNames.GUAVA_OPTIONAL_ASSERTIONS_CLASSNAME, MethodNames.IS_PRESENT)

src/main/java/de/platon42/intellij/plugins/cajon/inspections/JoinAssertThatStatementsInspection.kt

@@ -72,7 +72,7 @@ class JoinAssertThatStatementsInspection : AbstractAssertJInspection() {
                     if (!statement.hasAssertThat()) return null
 
                     val assertThatCall = PsiTreeUtil.findChildrenOfType(statement, PsiMethodCallExpression::class.java).find { ALL_ASSERT_THAT_MATCHERS.test(it) }
-                    return assertThatCall?.takeIf { it.findFluentCallTo(COMPLEX_STUFF_THAT_MAKES_JOINING_IMPOSSIBLE) == null }
+                    return assertThatCall?.takeIf { it.findFluentCallTo(EXTRACTING_CALL_MATCHERS) == null }
                 }
                 return null
             }
@@ -83,7 +83,6 @@ class JoinAssertThatStatementsInspection : AbstractAssertJInspection() {
                     val matched = when (element) {
                         is PsiUnaryExpression -> (element.operationTokenType == JavaTokenType.PLUSPLUS)
                                 || (element.operationTokenType == JavaTokenType.MINUSMINUS)
-
                         is PsiMethodCallExpression -> KNOWN_METHODS_WITH_SIDE_EFFECTS.test(element)
                         else -> false
                     }

src/main/java/de/platon42/intellij/plugins/cajon/inspections/JoinVarArgsContainsInspection.kt

@@ -26,7 +26,7 @@ class JoinVarArgsContainsInspection : AbstractAssertJInspection() {
     override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
         return object : JavaElementVisitor() {
             override fun visitExpressionStatement(statement: PsiExpressionStatement) {
-                super.visitExpressionStatement(statement)
+                super.visitStatement(statement)
                 if (!statement.hasAssertThat()) return
                 val assertThatCall = PsiTreeUtil.findChildrenOfType(statement, PsiMethodCallExpression::class.java).find { ALL_ASSERT_THAT_MATCHERS.test(it) } ?: return
 
@@ -35,7 +35,7 @@ class JoinVarArgsContainsInspection : AbstractAssertJInspection() {
                 if (allCalls.find(COMPLEX_CALLS_THAT_MAKES_STUFF_TRICKY::test) != null) return
 
                 val onlyAssertionCalls = allCalls
-                    .filterNot(NOT_ACTUAL_ASSERTIONS::test)
+                    .filterNot { NOT_ACTUAL_ASSERTIONS.test(it) }
                     .toList()
 
                 for (methodMatcher in MATCHERS) {

src/main/java/de/platon42/intellij/plugins/cajon/inspections/TwistedAssertionInspection.kt

@@ -1,108 +0,0 @@
-package de.platon42.intellij.plugins.cajon.inspections
-
-import com.intellij.codeInspection.ProblemHighlightType
-import com.intellij.codeInspection.ProblemsHolder
-import com.intellij.psi.*
-import com.intellij.psi.search.GlobalSearchScope
-import com.intellij.psi.util.PsiTreeUtil
-import com.siyeh.ig.callMatcher.CallMatcher
-import de.platon42.intellij.plugins.cajon.*
-import de.platon42.intellij.plugins.cajon.quickfixes.SwapActualAndExpectedExpressionMethodCallQuickFix
-
-class TwistedAssertionInspection : AbstractAssertJInspection() {
-
-    companion object {
-        private const val DISPLAY_NAME = "Twisted or suspicious actual and expected expressions"
-        private const val TWISTED_ACTUAL_AND_EXPECTED_MESSAGE = "Twisted actual and expected expressions in assertion"
-        private const val SWAP_ACTUAL_AND_EXPECTED_DESCRIPTION = "Swap actual and expected expressions in assertion"
-        private const val SWAP_ACTUAL_AND_EXPECTED_AND_REPLACE_DESCRIPTION_TEMPLATE = "Replace %s() by %s() and swap actual and expected expressions"
-        private const val ACTUAL_IS_A_CONSTANT_MESSAGE = "Actual expression in assertThat() is a constant"
-
-        private val GENERIC_IS_EQUAL_TO = CallMatcher.instanceCall(AssertJClassNames.ASSERT_INTERFACE, MethodNames.IS_EQUAL_TO).parameterCount(1)
-        private val GENERIC_IS_NOT_EQUAL_TO = CallMatcher.instanceCall(AssertJClassNames.ASSERT_INTERFACE, MethodNames.IS_NOT_EQUAL_TO).parameterCount(1)
-        private val GENERIC_IS_SAME_AS = CallMatcher.instanceCall(AssertJClassNames.ASSERT_INTERFACE, MethodNames.IS_SAME_AS).parameterCount(1)
-        private val GENERIC_IS_NOT_SAME_AS = CallMatcher.instanceCall(AssertJClassNames.ASSERT_INTERFACE, MethodNames.IS_NOT_SAME_AS).parameterCount(1)
-        private val GENERIC_IS_GREATER_THAN = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_COMPARABLE_ASSERT_CLASSNAME, MethodNames.IS_GREATER_THAN).parameterCount(1)
-        private val GENERIC_IS_GREATER_THAN_OR_EQUAL_TO =
-            CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_COMPARABLE_ASSERT_CLASSNAME, MethodNames.IS_GREATER_THAN_OR_EQUAL_TO).parameterCount(1)
-        private val GENERIC_IS_LESS_THAN = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_COMPARABLE_ASSERT_CLASSNAME, MethodNames.IS_LESS_THAN).parameterCount(1)
-        private val GENERIC_IS_LESS_THAN_OR_EQUAL_TO =
-            CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_COMPARABLE_ASSERT_CLASSNAME, MethodNames.IS_LESS_THAN_OR_EQUAL_TO).parameterCount(1)
-
-        private val STRING_IS_EQUAL_TO_IC = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_CHAR_SEQUENCE_ASSERT_CLASSNAME, MethodNames.IS_EQUAL_TO_IC).parameterCount(1)
-
-        private val STRING_REGEX_MATCHING = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_CHAR_SEQUENCE_ASSERT_CLASSNAME, "matches", "doesNotMatch").parameterCount(1)
-
-        private val CALL_MATCHER_TO_REPLACEMENT_MAP = mapOf(
-            GENERIC_IS_EQUAL_TO to MethodNames.IS_EQUAL_TO,
-            GENERIC_IS_NOT_EQUAL_TO to MethodNames.IS_NOT_EQUAL_TO,
-            GENERIC_IS_SAME_AS to MethodNames.IS_SAME_AS,
-            GENERIC_IS_NOT_SAME_AS to MethodNames.IS_NOT_SAME_AS,
-            GENERIC_IS_GREATER_THAN to MethodNames.IS_LESS_THAN_OR_EQUAL_TO,
-            GENERIC_IS_GREATER_THAN_OR_EQUAL_TO to MethodNames.IS_LESS_THAN,
-            GENERIC_IS_LESS_THAN to MethodNames.IS_GREATER_THAN_OR_EQUAL_TO,
-            GENERIC_IS_LESS_THAN_OR_EQUAL_TO to MethodNames.IS_GREATER_THAN,
-
-            STRING_IS_EQUAL_TO_IC to MethodNames.IS_EQUAL_TO_IC,
-            CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_CHAR_SEQUENCE_ASSERT_CLASSNAME, MethodNames.IS_NOT_EQUAL_TO_IC).parameterCount(1)
-                    to MethodNames.IS_NOT_EQUAL_TO_IC
-        )
-    }
-
-    override fun getDisplayName() = DISPLAY_NAME
-
-    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
-        return object : JavaElementVisitor() {
-            override fun visitExpressionStatement(statement: PsiExpressionStatement) {
-                super.visitExpressionStatement(statement)
-                if (!statement.hasAssertThat()) return
-                val assertThatCall = PsiTreeUtil.findChildrenOfType(statement, PsiMethodCallExpression::class.java).find { ALL_ASSERT_THAT_MATCHERS.test(it) } ?: return
-                val actualExpression = assertThatCall.firstArg
-                actualExpression.calculateConstantValue() ?: return
-                val allCalls = assertThatCall.collectMethodCallsUpToStatement().toList()
-                val tooComplex = allCalls.find(USING_COMPARATOR::test) != null
-                var severity = ProblemHighlightType.GENERIC_ERROR_OR_WARNING
-                if (actualExpression.type is PsiClassType) {
-                    val psiManager = PsiManager.getInstance(statement.project)
-                    val javaLangClass = PsiType.getJavaLangClass(psiManager, GlobalSearchScope.allScope(statement.project))
-                    if (actualExpression.type!!.isAssignableFrom(javaLangClass)) {
-                        return
-                    }
-                }
-
-                if (!tooComplex) {
-                    val onlyAssertionCalls = allCalls
-                        .filterNot(NOT_ACTUAL_ASSERTIONS::test)
-                        .toList()
-                    if (onlyAssertionCalls.size == 1) {
-                        val expectedMethodCall = onlyAssertionCalls.first()
-                        if (STRING_REGEX_MATCHING.test(expectedMethodCall)) {
-                            return
-                        }
-                        if (expectedMethodCall.getArgOrNull(0)?.calculateConstantValue() == null) {
-                            val matchedMethod = CALL_MATCHER_TO_REPLACEMENT_MAP.asSequence().firstOrNull { it.key.test(expectedMethodCall) }
-                            if (matchedMethod != null) {
-                                val originalMethodName = getOriginalMethodName(expectedMethodCall)
-                                val replacementMethod = matchedMethod.value
-                                val description = if (originalMethodName == replacementMethod) {
-                                    SWAP_ACTUAL_AND_EXPECTED_DESCRIPTION
-                                } else {
-                                    SWAP_ACTUAL_AND_EXPECTED_AND_REPLACE_DESCRIPTION_TEMPLATE.format(originalMethodName, replacementMethod)
-                                }
-                                holder.registerProblem(
-                                    statement,
-                                    TWISTED_ACTUAL_AND_EXPECTED_MESSAGE,
-                                    SwapActualAndExpectedExpressionMethodCallQuickFix(description, replacementMethod)
-                                )
-                                return
-                            }
-                        } else {
-                            severity = ProblemHighlightType.WEAK_WARNING
-                        }
-                    }
-                }
-                holder.registerProblem(statement, ACTUAL_IS_A_CONSTANT_MESSAGE, severity)
-            }
-        }
-    }
-}

src/main/java/de/platon42/intellij/plugins/cajon/quickfixes/InvertUnaryExpressionQuickFix.kt

@@ -1,31 +0,0 @@
-package de.platon42.intellij.plugins.cajon.quickfixes
-
-import com.intellij.codeInspection.ProblemDescriptor
-import com.intellij.openapi.project.Project
-import com.intellij.psi.PsiMethodCallExpression
-import com.intellij.psi.PsiUnaryExpression
-import com.intellij.psi.util.PsiUtil
-import de.platon42.intellij.plugins.cajon.createExpectedMethodCall
-import de.platon42.intellij.plugins.cajon.firstArg
-import de.platon42.intellij.plugins.cajon.replaceQualifierFromMethodCall
-
-class InvertUnaryExpressionQuickFix(description: String, private val replacementMethod: String) : AbstractCommonQuickFix(description) {
-
-    companion object {
-        private const val INVERT_CONDITION_DESCRIPTION = "Invert condition in isEqualTo()/isNotEqualTo() expressions"
-    }
-
-    override fun getFamilyName(): String {
-        return INVERT_CONDITION_DESCRIPTION
-    }
-
-    override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
-        val methodCall = descriptor.startElement as? PsiMethodCallExpression ?: return
-        val assertExpression = methodCall.firstArg as? PsiUnaryExpression ?: return
-        val operand = PsiUtil.skipParenthesizedExprDown(assertExpression.operand) ?: return
-
-        val expectedExpression = createExpectedMethodCall(assertExpression, replacementMethod, operand)
-        expectedExpression.replaceQualifierFromMethodCall(methodCall)
-        methodCall.replace(expectedExpression)
-    }
-}

src/main/java/de/platon42/intellij/plugins/cajon/quickfixes/JoinStatementsQuickFix.kt

@@ -56,8 +56,9 @@ class JoinStatementsQuickFix(private val separateLineLimit: Int) : AbstractCommo
     }
 
     private fun addLineBreak(project: Project, lastElementBeforeConcat: PsiElement) {
-        // was PsiParserFacade.getInstance(project).createWhiteSpaceFromText("\n\t"), changed due to breaking API changes
+        val newLineNode =
-        val newLineNode = project.getService(PsiParserFacade::class.java).createWhiteSpaceFromText("\n\t")
+            PsiParserFacade.SERVICE.getInstance(project).createWhiteSpaceFromText("\n\t")
+
         lastElementBeforeConcat.addAfter(newLineNode, lastElementBeforeConcat.firstChild)
     }
 

src/main/java/de/platon42/intellij/plugins/cajon/quickfixes/MoveOutMethodCallExpressionQuickFix.kt

@@ -46,7 +46,7 @@ class MoveOutMethodCallExpressionQuickFix(
                         val expectedExpression = createExpectedMethodCall(
                             it,
                             replacementMethod,
-                            *if (replaceFromOriginalMethod || noExpectedExpression) listOfNotNull(assertExpressionArg).toTypedArray() else it.argumentList.expressions
+                            *if (replaceFromOriginalMethod) arrayOf(assertExpressionArg!!) else it.argumentList.expressions
                         )
                         expectedExpression.replaceQualifierFromMethodCall(it)
                         it.replace(expectedExpression)

src/main/java/de/platon42/intellij/plugins/cajon/quickfixes/SwapActualAndExpectedExpressionMethodCallQuickFix.kt

@@ -1,34 +0,0 @@
-package de.platon42.intellij.plugins.cajon.quickfixes
-
-import com.intellij.codeInspection.ProblemDescriptor
-import com.intellij.openapi.project.Project
-import de.platon42.intellij.plugins.cajon.*
-
-class SwapActualAndExpectedExpressionMethodCallQuickFix(
-    description: String,
-    private val replacementMethod: String
-) : AbstractCommonQuickFix(description) {
-
-    companion object {
-        private const val SPLIT_EXPRESSION_DESCRIPTION = "Swap actual and expected expressions of assertions"
-    }
-
-    override fun getFamilyName(): String {
-        return SPLIT_EXPRESSION_DESCRIPTION
-    }
-
-    override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
-        val assertThatMethodCall = descriptor.startElement.findStaticMethodCall() ?: return
-
-        val methodToFix = assertThatMethodCall.collectMethodCallsUpToStatement()
-            .filterNot(NOT_ACTUAL_ASSERTIONS::test)
-            .first()
-
-        val oldActualExpression = assertThatMethodCall.firstArg.copy()!!
-        assertThatMethodCall.firstArg.replace(methodToFix.firstArg)
-
-        val expectedExpression = createExpectedMethodCall(methodToFix, replacementMethod, oldActualExpression)
-        expectedExpression.replaceQualifierFromMethodCall(methodToFix)
-        methodToFix.replace(expectedExpression)
-    }
-}

src/main/java/de/platon42/intellij/plugins/cajon/references/ExtractorReferenceContributor.kt

@@ -1,5 +1,6 @@
 package de.platon42.intellij.plugins.cajon.references
 
+import com.intellij.lang.jvm.JvmModifier
 import com.intellij.openapi.util.TextRange
 import com.intellij.patterns.PlatformPatterns
 import com.intellij.psi.*
@@ -29,7 +30,7 @@ class ExtractorReferenceContributor : PsiReferenceContributor() {
             val matchedGetter = PropertyUtilBase.findPropertyGetter(containingClass, partName, false, true)
             val fieldResult = PropertyUtilBase.findPropertyField(containingClass, partName, false)
             val textRange = TextRange(startOffset + 1, nextOffset)
-            val matchedBareMethod = containingClass.allMethods.find { (it.name == partName) && !it.hasModifierProperty(PsiModifier.STATIC) }
+            val matchedBareMethod = containingClass.allMethods.find { (it.name == partName) && !it.hasModifier(JvmModifier.STATIC) }
             val targets = listOfNotNull<PsiElement>(fieldResult, matchedGetter, matchedBareMethod)
             if (targets.isNotEmpty()) {
                 val results = listOf(textRange to targets)
@@ -43,7 +44,7 @@ class ExtractorReferenceContributor : PsiReferenceContributor() {
         }
 
         private fun lookupMethod(containingClass: PsiClass, methodName: String): List<Pair<TextRange, List<PsiElement>>>? {
-            val matchedMethod = containingClass.allMethods.find { (it.name == methodName) && !it.hasModifierProperty(PsiModifier.STATIC) } ?: return null
+            val matchedMethod = containingClass.allMethods.find { (it.name == methodName) && !it.hasModifier(JvmModifier.STATIC) } ?: return null
             val textRange = TextRange(1, methodName.length + 1)
             return listOf(textRange to listOf(matchedMethod))
         }
@@ -70,7 +71,7 @@ class ExtractorReferenceContributor : PsiReferenceContributor() {
     class ExtractorReference(literal: PsiLiteralExpression, range: TextRange, private val targets: List<PsiElement>) :
         PsiPolyVariantReferenceBase<PsiLiteralExpression>(literal, range, true) {
 
-        // Do not remove due to compatibility issue with IDEA <= 2018.2
+        // Do not remove due to compatiblity issue with IDEA <= 2018.2
         override fun getVariants(): Array<Any> {
             return ArrayUtil.EMPTY_OBJECT_ARRAY
         }
@@ -124,7 +125,6 @@ class ExtractorReferenceContributor : PsiReferenceContributor() {
             if (!CallMatcher.anyOf(EXTRACTING_FROM_ITERABLE, FLAT_EXTRACTING_FROM_ITERABLE).test(methodCallExpression)) return null
 
             val iterableType = findActualType(methodCallExpression) ?: return null
-            if (iterableType.parameters.isEmpty()) return null
             val innerType = iterableType.resolveGenerics().substitutor.substitute(iterableType.parameters[0])
             val containingClass = PsiTypesUtil.getPsiClass(innerType) ?: return null
             return if (isResultOf) lookupMethod(containingClass, literal) else lookupFieldOrProperty(containingClass, literal, 0)

src/main/resources/META-INF/plugin.xml

@@ -1,19 +1,20 @@
 <idea-plugin>
     <id>de.platon42.cajon</id>
     <name>Concise AssertJ Optimizing Nitpicker (Cajon)</name>
-    <vendor email="chrisly@platon42.de" url="https://git.platon42.de/chrisly42/cajon-plugin">Chris 'platon42' Hodges</vendor>
+    <vendor email="chrisly@platon42.de" url="https://github.com/chrisly42/cajon-plugin">Chris 'platon42' Hodges</vendor>
 
     <description><![CDATA[
     Cajon is an IntelliJ IDEA Plugin for shortening and optimizing AssertJ assertions.
-    It adds several <b>inspections and quick fixes</b> to fully use the fluent assertion methods
+    It adds several inspections and quick fixes to fully use the fluent assertion methods
     and thus makes the intention clear and concise, also generating better messages on test failures.
-    It can also be used to <b>convert JUnit 4 assertions and assumptions to AssertJ</b>.
+    It can also be used to convert JUnit 4 assertions and assumptions to AssertJ.
-    It supports <b>referencing inside extracting</b>()-methods with strings, adding refactoring safety.
+    It supports referencing inside extracting()-methods with strings, adding refactoring safety.
-    <b>Bogus or twisted assertions</b> are also reported.
     <p>
     <a href="https://github.com/chrisly42/cajon-plugin/blob/master/README.md">Full documentation here...</a>
     ]]></description>
 
+    <idea-version since-build="173.2696.26"/>
+
     <depends>com.intellij.modules.lang</depends>
     <depends>com.intellij.modules.platform</depends>
     <depends>com.intellij.modules.java</depends>
@@ -26,8 +27,6 @@
                          implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatBooleanConditionInspection"/>
         <localInspection groupPath="Java" shortName="AssertThatInvertedBooleanCondition" enabledByDefault="true" level="WARNING"
                          implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatInvertedBooleanConditionInspection"/>
-        <localInspection groupPath="Java" shortName="AssertThatIsZeroOne" enabledByDefault="true" level="WARNING"
-                         implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatIsZeroOneInspection"/>
         <localInspection groupPath="Java" shortName="AssertThatInstanceOf" enabledByDefault="true" level="WARNING"
                          implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatInstanceOfInspection"/>
         <localInspection groupPath="Java" shortName="AssertThatStringIsEmpty" enabledByDefault="true" level="WARNING"
@@ -42,16 +41,12 @@
                          implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatBinaryExpressionInspection"/>
         <localInspection groupPath="Java" shortName="AssertThatObjectExpression" enabledByDefault="true" level="WARNING"
                          implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatObjectExpressionInspection"/>
-        <localInspection groupPath="Java" shortName="AssertThatComparable" enabledByDefault="true" level="WARNING"
-                         implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatComparableInspection"/>
         <localInspection groupPath="Java" shortName="AssertThatStringExpression" enabledByDefault="true" level="WARNING"
                          implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatStringExpressionInspection"/>
         <localInspection groupPath="Java" shortName="AssertThatCollectionOrMapExpression" enabledByDefault="true" level="WARNING"
                          implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatCollectionOrMapExpressionInspection"/>
         <localInspection groupPath="Java" shortName="AssertThatFileExpression" enabledByDefault="true" level="WARNING"
                          implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatFileExpressionInspection"/>
-        <localInspection groupPath="Java" shortName="AssertThatPathExpression" enabledByDefault="true" level="WARNING"
-                         implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatPathExpressionInspection"/>
 
         <localInspection groupPath="Java" shortName="JoinAssertThatStatements" enabledByDefault="true" level="WARNING"
                          implementationClass="de.platon42.intellij.plugins.cajon.inspections.JoinAssertThatStatementsInspection"/>
@@ -68,15 +63,10 @@
         <localInspection groupPath="Java" shortName="ImplicitAssertion" enabledByDefault="true" level="WARNING"
                          implementationClass="de.platon42.intellij.plugins.cajon.inspections.ImplicitAssertionInspection"/>
 
-        <localInspection groupPath="Java" shortName="TwistedAssertion" enabledByDefault="true" level="WARNING"
-                         implementationClass="de.platon42.intellij.plugins.cajon.inspections.TwistedAssertionInspection"/>
-        <localInspection groupPath="Java" shortName="BogusAssertion" enabledByDefault="true" level="WARNING"
-                         implementationClass="de.platon42.intellij.plugins.cajon.inspections.BogusAssertionInspection"/>
-
         <localInspection groupPath="Java" shortName="JUnitAssertToAssertJ" enabledByDefault="true" level="WARNING"
                          implementationClass="de.platon42.intellij.plugins.cajon.inspections.JUnitAssertToAssertJInspection"/>
     </extensions>
 
     <actions>
     </actions>
-</idea-plugin>
+</idea-plugin>

src/main/resources/inspectionDescriptions/AssertThatComparable.html

@@ -1,5 +0,0 @@
-<html>
-<body>
-Turns assertThat(obj1.compareTo(obj2)) into assertThat(obj1).someMethod(obj2).
-</body>
-</html>

src/main/resources/inspectionDescriptions/AssertThatEnumerableIsEmpty.html

@@ -1,6 +1,6 @@
 <html>
 <body>
-Turns assertThat(enumerable).hasSize(0) and similar into assertThat(enumerable).isEmpty() or .isNotEmpty().
+Turns assertThat(enumerable).hasSize(0) into assertThat(enumerable).isEmpty().
 <!-- tooltip end -->
 <br>Works with anything that is enumerable such as arrays, iterables, collections, etc.
 </body>

src/main/resources/inspectionDescriptions/AssertThatInvertedBooleanCondition.html

@@ -1,6 +1,6 @@
 <html>
 <body>
-Turns assertThat(!condition).isEqualTo(true/false) into assertThat(condition).isFalse()/isTrue() and negates .is(Not)EqualTo(!var).
+Turns assertThat(!condition).isEqualTo(true/false) into assertThat(condition).isFalse()/isTrue().
 <!-- tooltip end -->
 <br>Also works with constant expressions and Boolean.TRUE/FALSE.
 </body>

src/main/resources/inspectionDescriptions/AssertThatIsZeroOne.html

@@ -1,8 +0,0 @@
-<html>
-<body>
-Turns assertThat(numeric).isEqualTo(0/1) into assertThat(numeric).isZero()/isOne()
-or assertThat(numeric).isNotEqualTo(0) into assertThat(numeric).isNotZero().
-<!-- tooltip end -->
-<br>Also works with constant expressions.
-</body>
-</html>

src/main/resources/inspectionDescriptions/AssertThatPathExpression.html

@@ -1,7 +0,0 @@
-<html>
-<body>
-Operates on assertions on objects of type Path. Turns assertThat(file.someMethod(arg)).someAssertion() into assertThat(path).someMethod(arg).
-<!-- tooltip end -->
-<br>someMethod() can be isAbsolute(), getParent(), startsWith() and endsWith().
-</body>
-</html>

src/main/resources/inspectionDescriptions/BogusAssertion.html

@@ -1,6 +0,0 @@
-<html>
-<body>
-Finds typical copy and paste errors where the assertion will never fail, such as assertThat(foo).isEqualTo(foo), because actual
-and expected expressions are the same.
-</body>
-</html>

src/main/resources/inspectionDescriptions/TwistedAssertion.html

@@ -1,7 +0,0 @@
-<html>
-<body>
-Finds assertion method calls that have the expected and actual expressions twisted, such as assertThat(5).isEqualTo(foo).
-<!-- tooltip end -->
-For some obvious cases, a quickfix to swap the actual and expected expressions is provided.
-</body>
-</html>

src/test/java/de/platon42/intellij/jupiter/AbstractJUnit5TestCase.kt

@@ -1,151 +0,0 @@
-package de.platon42.intellij.jupiter
-
-import com.intellij.jarRepository.JarRepositoryManager
-import com.intellij.jarRepository.RemoteRepositoryDescription
-import com.intellij.openapi.module.Module
-import com.intellij.openapi.roots.ContentEntry
-import com.intellij.openapi.roots.DependencyScope
-import com.intellij.openapi.roots.ModifiableRootModel
-import com.intellij.openapi.vfs.LocalFileSystem
-import com.intellij.testFramework.IdeaTestUtil
-import com.intellij.testFramework.LightProjectDescriptor
-import com.intellij.testFramework.PlatformTestUtil
-import com.intellij.testFramework.PsiTestUtil
-import com.intellij.testFramework.fixtures.DefaultLightProjectDescriptor
-import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
-import com.intellij.testFramework.fixtures.LightJavaCodeInsightFixtureTestCase
-import com.intellij.testFramework.rules.TestNameExtension
-import org.jetbrains.idea.maven.utils.library.RepositoryLibraryProperties
-import org.junit.jupiter.api.extension.AfterEachCallback
-import org.junit.jupiter.api.extension.BeforeEachCallback
-import org.junit.jupiter.api.extension.ExtensionContext
-import org.junit.jupiter.api.extension.RegisterExtension
-import java.nio.file.Paths
-import java.util.*
-import java.util.function.Consumer
-import java.util.stream.Collectors
-import java.util.stream.Stream
-
-
-abstract class AbstractJUnit5TestCase {
-
-    @RegisterExtension
-    protected val testNameRule = TestNameExtension()
-
-    @RegisterExtension
-    protected val edtInterceptorExtension = EdtInterceptorExtension()
-
-    protected fun getTestName(lowercaseFirstLetter: Boolean): String {
-        return PlatformTestUtil.getTestName(testNameRule.methodName, lowercaseFirstLetter)
-    }
-
-    @RegisterExtension
-    private val testCase = object : LightJavaCodeInsightFixtureTestCase(), BeforeEachCallback, AfterEachCallback {
-
-        lateinit var extensionContext: ExtensionContext
-
-        override fun getProjectDescriptor(): LightProjectDescriptor {
-            val testJdk = getMethodOrClassAnnotation(TestJdk::class.java) ?: return super.getProjectDescriptor()
-            val projectDescriptor: DefaultLightProjectDescriptor = object : DefaultLightProjectDescriptor({ IdeaTestUtil.getMockJdk(testJdk.value.toJavaVersion()) }) {
-                override fun configureModule(module: Module, model: ModifiableRootModel, contentEntry: ContentEntry) {
-                    super.configureModule(module, model, contentEntry)
-                    val localJars = getMethodOrClassAnnotation(AddLocalJarToModule::class.java)
-                    if (localJars != null) {
-                        localJars.value.forEach {
-                            addJarContaining(
-                                model,
-                                it.java
-                            )
-                        }
-                    }
-                    val mavenDependencies = getMethodOrClassAnnotations(AddMavenDependencyToModule::class.java)
-                    mavenDependencies.forEach(Consumer { it: AddMavenDependencyToModule ->
-                        addFromMaven(
-                            model,
-                            it.value,
-                            it.includeTransitiveDependencies,
-                            it.scope
-                        )
-                    })
-                }
-            }
-
-            return projectDescriptor
-        }
-
-        fun addJarContaining(model: ModifiableRootModel?, clazz: Class<*>) {
-            val filename = clazz.getResource(clazz.simpleName + ".class").file
-            val jarName = filename.substring(0, filename.indexOf(".jar") + 4).removePrefix("file:")
-            val jarPath = Paths.get(jarName)
-
-            val jarFile = LocalFileSystem.getInstance().refreshAndFindFileByPath(jarName)
-            myFixture.allowTreeAccessForFile(jarFile!!)
-            PsiTestUtil.addLibrary(
-                model!!,
-                jarPath.fileName.toString().replace(".jar", ""),
-                jarPath.parent.toString(),
-                jarPath.fileName.toString()
-            )
-        }
-
-        fun addFromMaven(
-            model: ModifiableRootModel, mavenCoordinates: String,
-            includeTransitiveDependencies: Boolean, dependencyScope: DependencyScope?
-        ) {
-            val remoteRepositoryDescriptions = RemoteRepositoryDescription.DEFAULT_REPOSITORIES
-            val libraryProperties = RepositoryLibraryProperties(mavenCoordinates, includeTransitiveDependencies)
-            val roots =
-                JarRepositoryManager.loadDependenciesModal(model.project, libraryProperties, false, false, null, remoteRepositoryDescriptions)
-            val tableModel = model.moduleLibraryTable.modifiableModel
-            val library = tableModel.createLibrary(mavenCoordinates)
-            val libraryModel = library.modifiableModel
-            check(!roots.isEmpty()) { String.format("No roots for '%s'", mavenCoordinates) }
-
-            for (root in roots) {
-                libraryModel.addRoot(root.file, root.type)
-            }
-
-            val libraryOrderEntry = model.findLibraryOrderEntry(library) ?: throw java.lang.IllegalStateException("Unable to find registered library $mavenCoordinates")
-            libraryOrderEntry.scope = dependencyScope!!
-
-            libraryModel.commit()
-            tableModel.commit()
-        }
-
-        override fun getTestDataPath(): String {
-            val testDataPath = getMethodOrClassAnnotation(TestDataPath::class.java) ?: return super.getTestDataPath()
-            val testDataSubPath = getMethodOrClassAnnotation(TestDataSubPath::class.java) ?: return testDataPath.value
-            return Paths.get(testDataPath.value, testDataSubPath.value).toString()
-        }
-
-        fun getMyFixture(): JavaCodeInsightTestFixture = myFixture
-
-        private fun <T : Annotation?> getMethodOrClassAnnotation(clazz: Class<T>): T? {
-            var annotation = extensionContext.requiredTestMethod.getAnnotation(clazz)
-            if (annotation == null) {
-                annotation = extensionContext.requiredTestClass.getAnnotation(clazz)
-            }
-            return annotation
-        }
-
-        private fun <T : Annotation?> getMethodOrClassAnnotations(clazz: Class<T>): List<T> {
-            return Stream.of(
-                extensionContext.requiredTestMethod.getAnnotationsByType(clazz),
-                extensionContext.requiredTestClass.getAnnotationsByType(clazz)
-            )
-                .flatMap { array: Array<T>? -> Arrays.stream(array) }
-                .collect(Collectors.toList())
-        }
-
-        override fun beforeEach(context: ExtensionContext) {
-            extensionContext = context
-            setUp()
-        }
-
-        override fun afterEach(context: ExtensionContext) {
-            tearDown()
-        }
-    }
-
-    protected val fixture: JavaCodeInsightTestFixture get() = testCase.getMyFixture()
-}

src/test/java/de/platon42/intellij/jupiter/AddLocalJarToModule.java

@@ -0,0 +1,10 @@
+package de.platon42.intellij.jupiter;
+
+import java.lang.annotation.*;
+
+@Target({ElementType.TYPE, ElementType.METHOD})
+@Retention(RetentionPolicy.RUNTIME)
+@Inherited
+public @interface AddLocalJarToModule {
+    Class[] value();
+}

src/test/java/de/platon42/intellij/jupiter/AddLocalJarToModule.kt

@@ -1,9 +0,0 @@
-package de.platon42.intellij.jupiter
-
-import java.lang.annotation.Inherited
-import kotlin.reflect.KClass
-
-@Target(AnnotationTarget.CLASS, AnnotationTarget.FUNCTION, AnnotationTarget.PROPERTY_GETTER, AnnotationTarget.PROPERTY_SETTER)
-@Retention(AnnotationRetention.RUNTIME)
-@Inherited
-annotation class AddLocalJarToModule(vararg val value: KClass<*>)

src/test/java/de/platon42/intellij/jupiter/AddMavenDependencyToModule.kt

@@ -1,17 +0,0 @@
-package de.platon42.intellij.jupiter
-
-import com.intellij.openapi.roots.DependencyScope
-import java.lang.annotation.Inherited
-
-@Target(AnnotationTarget.CLASS, AnnotationTarget.FUNCTION, AnnotationTarget.PROPERTY_GETTER, AnnotationTarget.PROPERTY_SETTER)
-@Retention(AnnotationRetention.RUNTIME)
-@Inherited
-@JvmRepeatable(
-    AddMavenDependencyToModule.List::class
-)
-annotation class AddMavenDependencyToModule(val value: String, val includeTransitiveDependencies: Boolean = false, val scope: DependencyScope = DependencyScope.COMPILE) {
-    @Target(AnnotationTarget.CLASS, AnnotationTarget.FUNCTION, AnnotationTarget.PROPERTY_GETTER, AnnotationTarget.PROPERTY_SETTER)
-    @Retention(AnnotationRetention.RUNTIME)
-    @Inherited
-    annotation class List(vararg val value: AddMavenDependencyToModule)
-}

src/test/java/de/platon42/intellij/jupiter/EdtInterceptorExtension.kt

@@ -1,50 +0,0 @@
-package de.platon42.intellij.jupiter
-
-import com.intellij.testFramework.TestLoggerFactory
-import com.intellij.testFramework.fixtures.IdeaTestExecutionPolicy
-import com.intellij.testFramework.runInEdtAndWait
-import org.junit.jupiter.api.extension.ExtensionContext
-import org.junit.jupiter.api.extension.InvocationInterceptor
-import org.junit.jupiter.api.extension.ReflectiveInvocationContext
-import java.lang.reflect.Method
-
-class EdtInterceptorExtension : InvocationInterceptor {
-
-    override fun interceptTestMethod(
-        invocation: InvocationInterceptor.Invocation<Void>,
-        invocationContext: ReflectiveInvocationContext<Method>,
-        extensionContext: ExtensionContext
-    ) {
-        val throwables = arrayOfNulls<Throwable>(1)
-
-        val runnable = Runnable {
-            try {
-                TestLoggerFactory.onTestStarted()
-                invocation.proceed()
-                TestLoggerFactory.onTestFinished(true, extensionContext.displayName)
-            } catch (e: Throwable) {
-                TestLoggerFactory.onTestFinished(false, extensionContext.displayName)
-                throwables[0] = e
-            }
-        }
-
-        invokeTestRunnable(runnable)
-
-        if (throwables[0] != null) {
-            throw throwables[0]!!
-        }
-    }
-
-    companion object {
-        private fun invokeTestRunnable(runnable: Runnable) {
-            val policy = IdeaTestExecutionPolicy.current()
-            if (policy != null && !policy.runInDispatchThread()) {
-                runnable.run()
-            } else {
-                runInEdtAndWait {
-                    runnable.run()
-                }
-            }
-        }
-    }
-}

src/test/java/de/platon42/intellij/jupiter/LightCodeInsightExtension.java

@@ -0,0 +1,203 @@
+package de.platon42.intellij.jupiter;
+
+import com.intellij.openapi.module.Module;
+import com.intellij.openapi.projectRoots.Sdk;
+import com.intellij.openapi.projectRoots.impl.JavaAwareProjectJdkTableImpl;
+import com.intellij.openapi.roots.ContentEntry;
+import com.intellij.openapi.roots.ModifiableRootModel;
+import com.intellij.openapi.util.Disposer;
+import com.intellij.openapi.vfs.LocalFileSystem;
+import com.intellij.openapi.vfs.VirtualFile;
+import com.intellij.testFramework.*;
+import com.intellij.testFramework.fixtures.IdeaTestExecutionPolicy;
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture;
+import com.intellij.testFramework.fixtures.LightJavaCodeInsightFixtureTestCase;
+import org.jetbrains.annotations.NotNull;
+import org.junit.jupiter.api.extension.*;
+import org.junit.jupiter.api.extension.ExtensionContext.Namespace;
+import org.junit.jupiter.api.extension.ExtensionContext.Store;
+
+import java.lang.annotation.Annotation;
+import java.lang.reflect.Method;
+import java.lang.reflect.Parameter;
+import java.net.URISyntaxException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.logging.Logger;
+import java.util.stream.Stream;
+
+public class LightCodeInsightExtension implements ParameterResolver, AfterTestExecutionCallback, InvocationInterceptor {
+
+    private static final Logger LOG = Logger.getLogger(LightCodeInsightExtension.class.getName());
+
+    @Override
+    public boolean supportsParameter(ParameterContext parameterContext, ExtensionContext extensionContext) throws ParameterResolutionException {
+        Parameter parameter = parameterContext.getParameter();
+        return parameter.isAnnotationPresent(MyFixture.class)
+                || parameter.isAnnotationPresent(MyTestCase.class);
+    }
+
+    @Override
+    public Object resolveParameter(ParameterContext parameterContext, ExtensionContext extensionContext) throws ParameterResolutionException {
+        LightCodeInsightFixtureTestCaseWrapper testCase = getWrapper(extensionContext);
+        Parameter parameter = parameterContext.getParameter();
+        if (parameter.isAnnotationPresent(MyFixture.class)) {
+            return testCase.getMyFixture();
+        } else if (parameter.isAnnotationPresent(MyTestCase.class)) {
+            return testCase;
+        }
+        return null;
+    }
+
+    private LightCodeInsightFixtureTestCaseWrapper getWrapper(ExtensionContext extensionContext) {
+        Store store = getStore(extensionContext);
+        return (LightCodeInsightFixtureTestCaseWrapper) store.getOrComputeIfAbsent("testCase",
+                key -> {
+                    LightCodeInsightFixtureTestCaseWrapper wrapper = new LightCodeInsightFixtureTestCaseWrapper(extensionContext);
+                    try {
+                        wrapper.setUp();
+                    } catch (Exception e) {
+                        LOG.severe("Exception during setUp(): " + e);
+                        throw new IllegalStateException("Exception during setUp()", e);
+                    }
+                    return wrapper;
+                });
+    }
+
+    @Override
+    public void afterTestExecution(ExtensionContext context) throws Exception {
+        Store store = getStore(context);
+        LightCodeInsightFixtureTestCaseWrapper testCase = (LightCodeInsightFixtureTestCaseWrapper) store.get("testCase");
+        if (testCase != null) {
+            testCase.tearDown();
+        }
+    }
+
+    private static Store getStore(ExtensionContext context) {
+        return context.getStore(Namespace.create(LightCodeInsightExtension.class, context.getRequiredTestMethod()));
+    }
+
+    @Override
+    public void interceptTestMethod(Invocation<Void> invocation, ReflectiveInvocationContext<Method> invocationContext, ExtensionContext extensionContext) throws Throwable {
+        Throwable[] throwables = new Throwable[1];
+
+        Runnable runnable = () -> {
+            try {
+                TestLoggerFactory.onTestStarted();
+                invocation.proceed();
+                TestLoggerFactory.onTestFinished(true);
+            } catch (Throwable e) {
+                TestLoggerFactory.onTestFinished(false);
+                throwables[0] = e;
+            }
+        };
+
+        invokeTestRunnable(runnable);
+
+        if (throwables[0] != null) {
+            throw throwables[0];
+        }
+    }
+
+    private static void invokeTestRunnable(@NotNull Runnable runnable) {
+        IdeaTestExecutionPolicy policy = IdeaTestExecutionPolicy.current();
+        if (policy != null && !policy.runInDispatchThread()) {
+            runnable.run();
+        } else {
+            EdtTestUtilKt.runInEdtAndWait(() -> {
+                runnable.run();
+                return null;
+            });
+        }
+    }
+
+    private static class LightCodeInsightFixtureTestCaseWrapper extends LightJavaCodeInsightFixtureTestCase {
+        private final ExtensionContext extensionContext;
+
+        private LightCodeInsightFixtureTestCaseWrapper(ExtensionContext extensionContext) {
+            this.extensionContext = extensionContext;
+        }
+
+        @Override
+        public void setUp() throws Exception {
+            super.setUp();
+        }
+
+        @Override
+        public void tearDown() throws Exception {
+            super.tearDown();
+            UsefulTestCase.clearFields(this);
+            if (myFixture != null && getProject() != null && !getProject().isDisposed()) {
+                Disposer.dispose(getProject());
+            }
+        }
+
+        @NotNull
+        @Override
+        protected LightProjectDescriptor getProjectDescriptor() {
+            TestJdk testJdk = getMethodOrClassAnnotation(TestJdk.class);
+            if (testJdk == null) {
+                return super.getProjectDescriptor();
+            }
+            return new ProjectDescriptor(testJdk.value(), testJdk.annotations()) {
+                @Override
+                public Sdk getSdk() {
+                    return testJdk.useInternal()
+                            ? JavaAwareProjectJdkTableImpl.getInstanceEx().getInternalJdk()
+                            : super.getSdk();
+                }
+
+                @Override
+                public void configureModule(@NotNull Module module, @NotNull ModifiableRootModel model, @NotNull ContentEntry contentEntry) {
+                    super.configureModule(module, model, contentEntry);
+                    AddLocalJarToModule methodOrClassAnnotation = getMethodOrClassAnnotation(AddLocalJarToModule.class);
+                    if (methodOrClassAnnotation != null) {
+                        Stream.of(methodOrClassAnnotation.value()).forEach(it -> addJarContaining(model, it));
+                    }
+                }
+            };
+        }
+
+        void addJarContaining(ModifiableRootModel model, Class clazz) {
+            try {
+                Path jarPath = Paths.get(clazz.getProtectionDomain().getCodeSource().getLocation().toURI());
+
+                VirtualFile jarFile = LocalFileSystem.getInstance().findFileByIoFile(jarPath.toFile());
+                myFixture.allowTreeAccessForFile(jarFile);
+                PsiTestUtil.addLibrary(
+                        model,
+                        jarPath.getFileName().toString().replace(".jar", ""),
+                        jarPath.getParent().toString(),
+                        jarPath.getFileName().toString()
+                );
+            } catch (URISyntaxException e) {
+                throw new IllegalArgumentException("Class URL malformed", e);
+            }
+        }
+
+        @Override
+        protected String getTestDataPath() {
+            TestDataPath testDataPath = getMethodOrClassAnnotation(TestDataPath.class);
+            if (testDataPath == null) {
+                return super.getTestDataPath();
+            }
+            TestDataSubPath testDataSubPath = getMethodOrClassAnnotation(TestDataSubPath.class);
+            if (testDataSubPath == null) {
+                return testDataPath.value();
+            }
+            return Paths.get(testDataPath.value(), testDataSubPath.value()).toString();
+        }
+
+        public JavaCodeInsightTestFixture getMyFixture() {
+            return myFixture;
+        }
+
+        private <T extends Annotation> T getMethodOrClassAnnotation(Class<T> clazz) {
+            T annotation = extensionContext.getRequiredTestMethod().getAnnotation(clazz);
+            if (annotation == null) {
+                annotation = extensionContext.getRequiredTestClass().getAnnotation(clazz);
+            }
+            return annotation;
+        }
+    }
+}

src/test/java/de/platon42/intellij/jupiter/MyFixture.java

@@ -0,0 +1,11 @@
+package de.platon42.intellij.jupiter;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+@Target(ElementType.PARAMETER)
+@Retention(RetentionPolicy.RUNTIME)
+public @interface MyFixture {
+}

src/test/java/de/platon42/intellij/jupiter/MyTestCase.java

@@ -0,0 +1,11 @@
+package de.platon42.intellij.jupiter;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+@Target(ElementType.PARAMETER)
+@Retention(RetentionPolicy.RUNTIME)
+public @interface MyTestCase {
+}

src/test/java/de/platon42/intellij/jupiter/TestDataPath.java

@@ -0,0 +1,10 @@
+package de.platon42.intellij.jupiter;
+
+import java.lang.annotation.*;
+
+@Target({ElementType.TYPE, ElementType.METHOD})
+@Retention(RetentionPolicy.RUNTIME)
+@Inherited
+public @interface TestDataPath {
+    String value();
+}

src/test/java/de/platon42/intellij/jupiter/TestDataPath.kt

@@ -1,8 +0,0 @@
-package de.platon42.intellij.jupiter
-
-import java.lang.annotation.Inherited
-
-@Target(AnnotationTarget.CLASS, AnnotationTarget.FUNCTION, AnnotationTarget.PROPERTY_GETTER, AnnotationTarget.PROPERTY_SETTER)
-@Retention(AnnotationRetention.RUNTIME)
-@Inherited
-annotation class TestDataPath(val value: String)

src/test/java/de/platon42/intellij/jupiter/TestDataSubPath.java

@@ -0,0 +1,10 @@
+package de.platon42.intellij.jupiter;
+
+import java.lang.annotation.*;
+
+@Target({ElementType.TYPE, ElementType.METHOD})
+@Retention(RetentionPolicy.RUNTIME)
+@Inherited
+public @interface TestDataSubPath {
+    String value();
+}

src/test/java/de/platon42/intellij/jupiter/TestDataSubPath.kt

@@ -1,8 +0,0 @@
-package de.platon42.intellij.jupiter
-
-import java.lang.annotation.Inherited
-
-@Target(AnnotationTarget.CLASS, AnnotationTarget.FUNCTION, AnnotationTarget.PROPERTY_GETTER, AnnotationTarget.PROPERTY_SETTER)
-@Retention(AnnotationRetention.RUNTIME)
-@Inherited
-annotation class TestDataSubPath(val value: String)

src/test/java/de/platon42/intellij/jupiter/TestJdk.java

@@ -0,0 +1,16 @@
+package de.platon42.intellij.jupiter;
+
+import com.intellij.pom.java.LanguageLevel;
+
+import java.lang.annotation.*;
+
+@Target({ElementType.TYPE, ElementType.METHOD})
+@Retention(RetentionPolicy.RUNTIME)
+@Inherited
+public @interface TestJdk {
+    LanguageLevel value();
+
+    boolean annotations() default false;
+
+    boolean useInternal() default false;
+}

src/test/java/de/platon42/intellij/jupiter/TestJdk.kt

@@ -1,9 +0,0 @@
-package de.platon42.intellij.jupiter
-
-import com.intellij.pom.java.LanguageLevel
-import java.lang.annotation.Inherited
-
-@Target(AnnotationTarget.CLASS, AnnotationTarget.FUNCTION, AnnotationTarget.PROPERTY_GETTER, AnnotationTarget.PROPERTY_SETTER)
-@Retention(AnnotationRetention.RUNTIME)
-@Inherited
-annotation class TestJdk(val value: LanguageLevel)

src/test/java/de/platon42/intellij/plugins/cajon/AbstractCajonTest.kt

@@ -2,51 +2,46 @@ package de.platon42.intellij.plugins.cajon
 
 import com.intellij.codeInsight.intention.IntentionAction
 import com.intellij.pom.java.LanguageLevel
-import de.platon42.intellij.jupiter.AbstractJUnit5TestCase
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
 import de.platon42.intellij.jupiter.AddLocalJarToModule
+import de.platon42.intellij.jupiter.LightCodeInsightExtension
 import de.platon42.intellij.jupiter.TestDataPath
 import de.platon42.intellij.jupiter.TestJdk
 import org.assertj.core.api.Assertions
 import org.assertj.core.api.Assertions.assertThat
-import org.assertj.core.api.Condition
 import org.junit.jupiter.api.DisplayNameGeneration
 import org.junit.jupiter.api.DisplayNameGenerator
+import org.junit.jupiter.api.extension.ExtendWith
 import java.lang.reflect.Method
 
+@ExtendWith(LightCodeInsightExtension::class)
 @TestDataPath("src/test/resources")
-@TestJdk(LanguageLevel.JDK_1_8)
+@TestJdk(LanguageLevel.JDK_1_8, annotations = true, useInternal = true)
 @AddLocalJarToModule(Assertions::class)
-//@AddMavenDependencyToModule("org.assertj:assertj-core:3.25.3", includeTransitiveDependencies = false, DependencyScope.COMPILE)
 @DisplayNameGeneration(AbstractCajonTest.CutOffFixtureDisplayNameGenerator::class)
-abstract class AbstractCajonTest : AbstractJUnit5TestCase() {
+abstract class AbstractCajonTest {
 
-    protected fun executeQuickFixes(regex: Regex, expectedFixes: Int) {
+    protected fun executeQuickFixes(myFixture: JavaCodeInsightTestFixture, regex: Regex, expectedFixes: Int) {
-        val quickfixes = getQuickFixes(regex, expectedFixes)
+        val quickfixes = getQuickFixes(myFixture, regex, expectedFixes)
         assertThat(quickfixes.groupBy { it.familyName }).hasSize(1)
-        quickfixes.forEach(fixture::launchAction)
+        quickfixes.forEach(myFixture::launchAction)
     }
 
-    protected fun executeQuickFixesNoFamilyNameCheck(regex: Regex, expectedFixes: Int) {
+    protected fun executeQuickFixesNoFamilyNameCheck(myFixture: JavaCodeInsightTestFixture, regex: Regex, expectedFixes: Int) {
-        val quickfixes = getQuickFixes(regex, expectedFixes)
+        val quickfixes = getQuickFixes(myFixture, regex, expectedFixes)
-        quickfixes.forEach(fixture::launchAction)
+        quickfixes.forEach(myFixture::launchAction)
     }
 
-    protected fun getQuickFixes(regex: Regex, expectedFixes: Int): List<IntentionAction> {
+    protected fun getQuickFixes(myFixture: JavaCodeInsightTestFixture, regex: Regex, expectedFixes: Int): List<IntentionAction> {
-        val allFixes = fixture.getAllQuickFixes()
+        val quickfixes = myFixture.getAllQuickFixes().filter { it.text.matches(regex) }
-        val quickfixes = allFixes.filter { it.text.matches(regex) }
+        assertThat(quickfixes).`as`("Fixes matched by $regex: ${myFixture.getAllQuickFixes().map { it.text }}").hasSize(expectedFixes)
-        assertThat(quickfixes).`as`("Fixes matched by $regex: ${allFixes.map { it.text }}").hasSize(expectedFixes)
         return quickfixes
     }
 
-    protected fun assertHighlightings(count: Int, snippet: String) {
-        assertThat(fixture.doHighlighting())
-            .areExactly(count, Condition({ it.description?.contains(snippet) ?: false }, "containing"))
-    }
-
     class CutOffFixtureDisplayNameGenerator : DisplayNameGenerator.ReplaceUnderscores() {
         override fun generateDisplayNameForMethod(testClass: Class<*>?, testMethod: Method?): String {
             val nameForMethod = super.generateDisplayNameForMethod(testClass, testMethod)
             return nameForMethod.substringBefore("$")
         }
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatBinaryExpressionInspectionTest.kt

@@ -1,19 +1,19 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
-import com.intellij.testFramework.RunsInEdt
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.junit.jupiter.api.Test
 
-@TestDataSubPath("inspections/BinaryExpression")
 internal class AssertThatBinaryExpressionInspectionTest : AbstractCajonTest() {
 
     @Test
-    @RunsInEdt
+    @TestDataSubPath("inspections/BinaryExpression")
-    internal fun assertThat_of_binary_expression_can_be_moved_out() {
+    internal fun assertThat_of_binary_expression_can_be_moved_out(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.enableInspections(AssertThatBinaryExpressionInspection::class.java)
+        myFixture.enableInspections(AssertThatBinaryExpressionInspection::class.java)
-        fixture.configureByFile("BinaryExpressionBefore.java")
+        myFixture.configureByFile("BinaryExpressionBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Split binary expression out of assertThat()"), 161)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Split binary expression out of assertThat()"), 161)
-        fixture.checkResultByFile("BinaryExpressionAfter.java")
+        myFixture.checkResultByFile("BinaryExpressionAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatBooleanConditionInspectionTest.kt

@@ -1,20 +1,22 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.junit.jupiter.api.Test
 
-@TestDataSubPath("inspections/BooleanCondition")
 internal class AssertThatBooleanConditionInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun assertThat_with_isEqualTo_true_or_false_can_use_isTrue_or_isFalse() {
+    @TestDataSubPath("inspections/BooleanCondition")
-        fixture.enableInspections(AssertThatBooleanConditionInspection::class.java)
+    internal fun assertThat_with_isEqualTo_true_or_false_can_use_isTrue_or_isFalse(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("BooleanConditionBefore.java")
+        myFixture.enableInspections(AssertThatBooleanConditionInspection::class.java)
-        executeQuickFixes(Regex.fromLiteral("Replace isEqualTo() with isTrue()"), 6)
+        myFixture.configureByFile("BooleanConditionBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Replace isEqualTo() with isFalse()"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isTrue()"), 6)
-        executeQuickFixes(Regex.fromLiteral("Replace isNotEqualTo() with isTrue()"), 4)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isFalse()"), 5)
-        executeQuickFixes(Regex.fromLiteral("Replace isNotEqualTo() with isFalse()"), 4)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotEqualTo() with isTrue()"), 4)
-        fixture.checkResultByFile("BooleanConditionAfter.java")
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotEqualTo() with isFalse()"), 4)
+        myFixture.checkResultByFile("BooleanConditionAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatCollectionOrMapExpressionInspectionTest.kt

@@ -1,5 +1,7 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.assertj.core.api.Assertions.assertThat
@@ -9,68 +11,68 @@ import org.junit.jupiter.api.Test
 internal class AssertThatCollectionOrMapExpressionInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun assertThat_with_certain_Collection_and_Map_methods() {
+    internal fun assertThat_with_certain_Collection_and_Map_methods(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.enableInspections(AssertThatCollectionOrMapExpressionInspection::class.java)
+        myFixture.enableInspections(AssertThatCollectionOrMapExpressionInspection::class.java)
-        fixture.configureByFile("CollectionMapExpressionBefore.java")
+        myFixture.configureByFile("CollectionMapExpressionBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isEmpty() instead"), 4)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isEmpty() instead"), 4)
-        executeQuickFixes(Regex.fromLiteral("Remove contains() of actual expression and use assertThat().contains() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove contains() of actual expression and use assertThat().contains() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove containsAll() of actual expression and use assertThat().containsAll() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsAll() of actual expression and use assertThat().containsAll() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove containsKey() of actual expression and use assertThat().containsKey() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsKey() of actual expression and use assertThat().containsKey() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove containsValue() of actual expression and use assertThat().containsValue() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsValue() of actual expression and use assertThat().containsValue() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isNotEmpty() instead"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isNotEmpty() instead"), 5)
-        executeQuickFixes(Regex.fromLiteral("Remove contains() of actual expression and use assertThat().doesNotContain() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove contains() of actual expression and use assertThat().doesNotContain() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove containsKey() of actual expression and use assertThat().doesNotContainKey() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsKey() of actual expression and use assertThat().doesNotContainKey() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove containsValue() of actual expression and use assertThat().doesNotContainValue() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsValue() of actual expression and use assertThat().doesNotContainValue() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
-        executeQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 4)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 4)
-        fixture.checkResultByFile("CollectionMapExpressionAfter.java")
+        myFixture.checkResultByFile("CollectionMapExpressionAfter.java")
     }
 
     @Test
-    internal fun assertThat_with_certain_Collection_and_Map_methods_with_Null_values() {
+    internal fun assertThat_with_certain_Collection_and_Map_methods_with_Null_values(@MyFixture myFixture: JavaCodeInsightTestFixture) {
         val inspection = AssertThatCollectionOrMapExpressionInspection()
         inspection.behaviorForMapValueEqualsNull = 3
-        fixture.enableInspections(inspection)
+        myFixture.enableInspections(inspection)
-        fixture.configureByFile("CollectionMapExpressionBefore.java")
+        myFixture.configureByFile("CollectionMapExpressionBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isEmpty() instead"), 4)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isEmpty() instead"), 4)
-        executeQuickFixes(Regex.fromLiteral("Remove contains() of actual expression and use assertThat().contains() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove contains() of actual expression and use assertThat().contains() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove containsAll() of actual expression and use assertThat().containsAll() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsAll() of actual expression and use assertThat().containsAll() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove containsKey() of actual expression and use assertThat().containsKey() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsKey() of actual expression and use assertThat().containsKey() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove containsValue() of actual expression and use assertThat().containsValue() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsValue() of actual expression and use assertThat().containsValue() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isNotEmpty() instead"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isNotEmpty() instead"), 5)
-        executeQuickFixes(Regex.fromLiteral("Remove contains() of actual expression and use assertThat().doesNotContain() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove contains() of actual expression and use assertThat().doesNotContain() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove containsKey() of actual expression and use assertThat().doesNotContainKey() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsKey() of actual expression and use assertThat().doesNotContainKey() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove containsValue() of actual expression and use assertThat().doesNotContainValue() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsValue() of actual expression and use assertThat().doesNotContainValue() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 6)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 6)
-        executeQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 0)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 0)
-        fixture.checkResultByFile("CollectionMapExpressionWithNullValuesAfter.java")
+        myFixture.checkResultByFile("CollectionMapExpressionWithNullValuesAfter.java")
     }
 
     @Test
-    internal fun assertThat_with_certain_Collection_and_Map_methods_with_no_quickfixes_for_get_equals_null() {
+    internal fun assertThat_with_certain_Collection_and_Map_methods_with_no_quickfixes_for_get_equals_null(@MyFixture myFixture: JavaCodeInsightTestFixture) {
         val inspection = AssertThatCollectionOrMapExpressionInspection()
         inspection.behaviorForMapValueEqualsNull = 0
 
-        fixture.enableInspections(inspection)
+        myFixture.enableInspections(inspection)
-        fixture.configureByFile("CollectionMapExpressionBefore.java")
+        myFixture.configureByFile("CollectionMapExpressionBefore.java")
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 2)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 2)
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 0)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 0)
     }
 
     @Test
-    internal fun assertThat_with_certain_Collection_and_Map_methods_with_only_warnings_for_get_equals_null() {
+    internal fun assertThat_with_certain_Collection_and_Map_methods_with_only_warnings_for_get_equals_null(@MyFixture myFixture: JavaCodeInsightTestFixture) {
         val inspection = AssertThatCollectionOrMapExpressionInspection()
         inspection.behaviorForMapValueEqualsNull = 1
 
-        fixture.enableInspections(inspection)
+        myFixture.enableInspections(inspection)
-        fixture.configureByFile("CollectionMapExpressionBefore.java")
+        myFixture.configureByFile("CollectionMapExpressionBefore.java")
-        val highlights = fixture.doHighlighting()
+        val highlights = myFixture.doHighlighting()
             .asSequence()
             .filter { it.description == "Moving get() expression out of assertThat() would be more concise" }
             .filter {
@@ -79,24 +81,24 @@ internal class AssertThatCollectionOrMapExpressionInspectionTest : AbstractCajon
             .toList()
         assertThat(highlights).hasSize(4)
 
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 2)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 2)
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 0)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 0)
     }
 
     @Test
-    internal fun assertThat_with_certain_Collection_and_Map_methods_with_both_quickfixes_for_get_equals_null() {
+    internal fun assertThat_with_certain_Collection_and_Map_methods_with_both_quickfixes_for_get_equals_null(@MyFixture myFixture: JavaCodeInsightTestFixture) {
         val inspection = AssertThatCollectionOrMapExpressionInspection()
         inspection.behaviorForMapValueEqualsNull = 4
 
-        fixture.enableInspections(inspection)
+        myFixture.enableInspections(inspection)
-        fixture.configureByFile("CollectionMapExpressionBefore.java")
+        myFixture.configureByFile("CollectionMapExpressionBefore.java")
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 2)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 2)
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead (regular map)"), 4)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead (regular map)"), 4)
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry(key, null) instead (degenerated map)"), 4)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry(key, null) instead (degenerated map)"), 4)
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
-        getQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 0)
+        getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 0)
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatComparableInspectionTest.kt

@@ -1,22 +0,0 @@
-package de.platon42.intellij.plugins.cajon.inspections
-
-import de.platon42.intellij.jupiter.TestDataSubPath
-import de.platon42.intellij.plugins.cajon.AbstractCajonTest
-import org.junit.jupiter.api.Test
-
-@TestDataSubPath("inspections/Comparable")
-internal class AssertThatComparableInspectionTest : AbstractCajonTest() {
-
-    @Test
-    internal fun assertThat_with_compareTo_method() {
-        fixture.enableInspections(AssertThatComparableInspection::class.java)
-        fixture.configureByFile("ComparableBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Remove compareTo() of actual expression and use assertThat().isEqualByComparingTo() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove compareTo() of actual expression and use assertThat().isNotEqualByComparingTo() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove compareTo() of actual expression and use assertThat().isGreaterThanOrEqualTo() instead"), 4)
-        executeQuickFixes(Regex.fromLiteral("Remove compareTo() of actual expression and use assertThat().isGreaterThan() instead"), 5)
-        executeQuickFixes(Regex.fromLiteral("Remove compareTo() of actual expression and use assertThat().isLessThanOrEqualTo() instead"), 4)
-        executeQuickFixes(Regex.fromLiteral("Remove compareTo() of actual expression and use assertThat().isLessThan() instead"), 4)
-        fixture.checkResultByFile("ComparableAfter.java")
-    }
-}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatEnumerableIsEmptyInspectionTest.kt

@@ -1,21 +1,19 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.junit.jupiter.api.Test
 
-@TestDataSubPath("inspections/EnumerableIsEmpty")
 internal class AssertThatEnumerableIsEmptyInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun assertThat_with_hasSize_zero_and_similar_can_use_isEmpty() {
+    @TestDataSubPath("inspections/EnumerableIsEmpty")
-        fixture.enableInspections(AssertThatEnumerableIsEmptyInspection::class.java)
+    internal fun assertThat_with_hasSize_zero_can_use_isEmpty(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("EnumerableIsEmptyBefore.java")
+        myFixture.enableInspections(AssertThatEnumerableIsEmptyInspection::class.java)
-        executeQuickFixes(Regex.fromLiteral("Replace hasSize() with isEmpty()"), 5)
+        myFixture.configureByFile("EnumerableIsEmptyBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Replace hasSizeLessThan() with isEmpty()"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace hasSize() with isEmpty()"), 5)
-        executeQuickFixes(Regex.fromLiteral("Replace hasSizeLessThanOrEqualTo() with isEmpty()"), 5)
+        myFixture.checkResultByFile("EnumerableIsEmptyAfter.java")
-        executeQuickFixes(Regex.fromLiteral("Replace hasSizeGreaterThan() with isNotEmpty()"), 6)
-        executeQuickFixes(Regex.fromLiteral("Replace hasSizeGreaterThanOrEqualTo() with isNotEmpty()"), 6)
-        fixture.checkResultByFile("EnumerableIsEmptyAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatFileExpressionInspectionTest.kt

@@ -1,36 +1,35 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.junit.jupiter.api.Test
 
-@TestDataSubPath("inspections/FileExpression")
 internal class AssertThatFileExpressionInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun assertThat_with_certain_File_methods() {
+    @TestDataSubPath("inspections/FileExpression")
-        fixture.enableInspections(AssertThatFileExpressionInspection::class.java)
+    internal fun assertThat_with_certain_File_methods(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("FileExpressionBefore.java")
+        myFixture.enableInspections(AssertThatFileExpressionInspection::class.java)
-        executeQuickFixes(Regex.fromLiteral("Remove canRead() of actual expression and use assertThat().canRead() instead"), 3)
+        myFixture.configureByFile("FileExpressionBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Remove canWrite() of actual expression and use assertThat().canWrite() instead"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove canRead() of actual expression and use assertThat().canRead() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove exists() of actual expression and use assertThat().exists() instead"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove canWrite() of actual expression and use assertThat().canWrite() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove exists() of actual expression and use assertThat().doesNotExist() instead"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove exists() of actual expression and use assertThat().exists() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove isAbsolute() of actual expression and use assertThat().isAbsolute() instead"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove exists() of actual expression and use assertThat().doesNotExist() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove isAbsolute() of actual expression and use assertThat().isRelative() instead"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove isAbsolute() of actual expression and use assertThat().isAbsolute() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove isDirectory() of actual expression and use assertThat().isDirectory() instead"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove isAbsolute() of actual expression and use assertThat().isRelative() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove isFile() of actual expression and use assertThat().isFile() instead"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove isDirectory() of actual expression and use assertThat().isDirectory() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove getName() of actual expression and use assertThat().hasName() instead"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove isFile() of actual expression and use assertThat().isFile() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove getParent() of actual expression and use assertThat().hasNoParent() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove getName() of actual expression and use assertThat().hasName() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove getParentFile() of actual expression and use assertThat().hasNoParent() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove getParent() of actual expression and use assertThat().hasNoParent() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove getParent() of actual expression and use assertThat().hasParent() instead"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove getParentFile() of actual expression and use assertThat().hasNoParent() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove getParentFile() of actual expression and use assertThat().hasParent() instead"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove getParent() of actual expression and use assertThat().hasParent() instead"), 1)
-        executeQuickFixes(Regex.fromLiteral("Remove listFiles() of actual expression and use assertThat().isEmptyDirectory() instead"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove getParentFile() of actual expression and use assertThat().hasParent() instead"), 1)
-        executeQuickFixes(Regex.fromLiteral("Remove listFiles() of actual expression and use assertThat().isNotEmptyDirectory() instead"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove listFiles() of actual expression and use assertThat().isEmptyDirectory() instead"), 1)
-        executeQuickFixes(Regex.fromLiteral("Remove list() of actual expression and use assertThat().isEmptyDirectory() instead"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove listFiles() of actual expression and use assertThat().isNotEmptyDirectory() instead"), 1)
-        executeQuickFixes(Regex.fromLiteral("Remove list() of actual expression and use assertThat().isNotEmptyDirectory() instead"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove list() of actual expression and use assertThat().isEmptyDirectory() instead"), 1)
-        executeQuickFixes(Regex.fromLiteral("Remove length() of actual expression and use assertThat().isEmpty() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove list() of actual expression and use assertThat().isNotEmptyDirectory() instead"), 1)
-        executeQuickFixes(Regex.fromLiteral("Remove length() of actual expression and use assertThat().isNotEmpty() instead"), 2)
+        myFixture.checkResultByFile("FileExpressionAfter.java")
-        executeQuickFixes(Regex.fromLiteral("Remove length() of actual expression and use assertThat().hasSize() instead"), 1)
-        fixture.checkResultByFile("FileExpressionAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatGuavaOptionalInspectionTest.kt

@@ -1,45 +1,48 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
-import de.platon42.intellij.jupiter.AddMavenDependencyToModule
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.AddLocalJarToModule
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
+import org.assertj.core.api.Assertions
 import org.junit.jupiter.api.Test
 
-@AddMavenDependencyToModule("org.assertj:assertj-guava:3.25.3")
+@AddLocalJarToModule(com.google.common.base.Optional::class, org.assertj.guava.api.Assertions::class, Assertions::class)
 @TestDataSubPath("inspections/GuavaOptional")
 internal class AssertThatGuavaOptionalInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun assertThat_get_or_isPresent_for_Guava_Optional_can_be_simplified() {
+    internal fun assertThat_get_or_isPresent_for_Guava_Optional_can_be_simplified(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.enableInspections(AssertThatGuavaOptionalInspection::class.java)
+        myFixture.enableInspections(AssertThatGuavaOptionalInspection::class.java)
-        fixture.configureByFile("GuavaOptionalBefore.java")
+        myFixture.configureByFile("GuavaOptionalBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Remove isPresent() of actual expression and use assertThat().isPresent() instead"), 6)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove isPresent() of actual expression and use assertThat().isPresent() instead"), 6)
-        executeQuickFixes(Regex.fromLiteral("Remove isPresent() of actual expression and use assertThat().isAbsent() instead"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove isPresent() of actual expression and use assertThat().isAbsent() instead"), 5)
-        executeQuickFixes(Regex.fromLiteral("Remove orNull() of actual expression and use assertThat().isPresent() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove orNull() of actual expression and use assertThat().isPresent() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove orNull() of actual expression and use assertThat().isAbsent() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove orNull() of actual expression and use assertThat().isAbsent() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().contains() instead"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().contains() instead"), 1)
-        executeQuickFixes(Regex.fromLiteral("Unwrap expected expression and replace isEqualTo() with contains()"), 6)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap expected expression and replace isEqualTo() with contains()"), 6)
-        executeQuickFixes(Regex.fromLiteral("Replace isEqualTo() with Guava assertThat().isAbsent()"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with Guava assertThat().isAbsent()"), 3)
-        executeQuickFixes(Regex.fromLiteral("Replace isNotEqualTo() with Guava assertThat().isPresent()"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotEqualTo() with Guava assertThat().isPresent()"), 3)
-        fixture.checkResultByFile("GuavaOptionalAfter.java")
+        myFixture.checkResultByFile("GuavaOptionalAfter.java")
     }
 
     @Test
-    internal fun adds_missing_Guava_import_any_order() {
+    internal fun adds_missing_Guava_import_any_order(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.enableInspections(AssertThatGuavaOptionalInspection::class.java)
+        myFixture.enableInspections(AssertThatGuavaOptionalInspection::class.java)
-        fixture.configureByFile("WithoutPriorGuavaImportBefore.java")
+        myFixture.configureByFile("WithoutPriorGuavaImportBefore.java")
-        executeQuickFixesNoFamilyNameCheck(Regex(".*eplace .* with .*"), 4)
+        executeQuickFixesNoFamilyNameCheck(myFixture, Regex(".*eplace .* with .*"), 4)
-        executeQuickFixesNoFamilyNameCheck(Regex("Remove .*"), 3)
+        executeQuickFixesNoFamilyNameCheck(myFixture, Regex("Remove .*"), 3)
-        fixture.checkResultByFile("WithoutPriorGuavaImportAfter.java")
+        myFixture.checkResultByFile("WithoutPriorGuavaImportAfter.java")
     }
 
     @Test
-    internal fun adds_missing_Guava_import_isAbsent_first() {
+    internal fun adds_missing_Guava_import_isAbsent_first(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.enableInspections(AssertThatGuavaOptionalInspection::class.java)
+        myFixture.enableInspections(AssertThatGuavaOptionalInspection::class.java)
-        fixture.configureByFile("WithoutPriorGuavaImportBefore.java")
+        myFixture.configureByFile("WithoutPriorGuavaImportBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Replace isEqualTo() with Guava assertThat().isAbsent()"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with Guava assertThat().isAbsent()"), 1)
-        executeQuickFixesNoFamilyNameCheck(Regex(".*eplace .* with .*"), 3)
+        executeQuickFixesNoFamilyNameCheck(myFixture, Regex(".*eplace .* with .*"), 3)
-        executeQuickFixesNoFamilyNameCheck(Regex("Remove .*"), 3)
+        executeQuickFixesNoFamilyNameCheck(myFixture, Regex("Remove .*"), 3)
-        fixture.checkResultByFile("WithoutPriorGuavaImportAfter.java")
+        myFixture.checkResultByFile("WithoutPriorGuavaImportAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatInstanceOfInspectionTest.kt

@@ -1,18 +1,20 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.junit.jupiter.api.Test
 
-@TestDataSubPath("inspections/InstanceOf")
 internal class AssertThatInstanceOfInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun assertThat_with_instanceof_can_be_moved_out() {
+    @TestDataSubPath("inspections/InstanceOf")
-        fixture.enableInspections(AssertThatInstanceOfInspection::class.java)
+    internal fun assertThat_with_instanceof_can_be_moved_out(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("InstanceOfBefore.java")
+        myFixture.enableInspections(AssertThatInstanceOfInspection::class.java)
-        executeQuickFixes(Regex.fromLiteral("Remove instanceof in actual expression and use assertThat().isInstanceOf() instead"), 6)
+        myFixture.configureByFile("InstanceOfBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Remove instanceof in actual expression and use assertThat().isNotInstanceOf() instead"), 6)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove instanceof in actual expression and use assertThat().isInstanceOf() instead"), 6)
-        fixture.checkResultByFile("InstanceOfAfter.java")
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove instanceof in actual expression and use assertThat().isNotInstanceOf() instead"), 6)
+        myFixture.checkResultByFile("InstanceOfAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatInvertedBooleanConditionInspectionTest.kt

@@ -1,19 +1,19 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.junit.jupiter.api.Test
 
-@TestDataSubPath("inspections/InvertedBooleanCondition")
 internal class AssertThatInvertedBooleanConditionInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun assertThat_with_inverted_boolean_condition_can_be_inverted() {
+    @TestDataSubPath("inspections/InvertedBooleanCondition")
-        fixture.enableInspections(AssertThatInvertedBooleanConditionInspection::class.java)
+    internal fun assertThat_with_inverted_boolean_condition_can_be_inverted(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("InvertedBooleanConditionBefore.java")
+        myFixture.enableInspections(AssertThatInvertedBooleanConditionInspection::class.java)
-        executeQuickFixes(Regex.fromLiteral("Invert condition in assertThat()"), 25)
+        myFixture.configureByFile("InvertedBooleanConditionBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Invert condition in isEqualTo() and use isNotEqualTo() instead"), 4)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Invert condition in assertThat()"), 25)
-        executeQuickFixes(Regex.fromLiteral("Invert condition in isNotEqualTo() and use isEqualTo() instead"), 2)
+        myFixture.checkResultByFile("InvertedBooleanConditionAfter.java")
-        fixture.checkResultByFile("InvertedBooleanConditionAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatIsZeroOneInspectionTest.kt

@@ -1,19 +0,0 @@
-package de.platon42.intellij.plugins.cajon.inspections
-
-import de.platon42.intellij.jupiter.TestDataSubPath
-import de.platon42.intellij.plugins.cajon.AbstractCajonTest
-import org.junit.jupiter.api.Test
-
-@TestDataSubPath("inspections/IsZeroOne")
-internal class AssertThatIsZeroOneInspectionTest : AbstractCajonTest() {
-
-    @Test
-    internal fun assertThat_with_isEqualTo_zero_or_one_can_use_isZero_or_isOne_plus_isNotZero() {
-        fixture.enableInspections(AssertThatIsZeroOneInspection::class.java)
-        fixture.configureByFile("IsZeroOneBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Replace isEqualTo() with isZero()"), 10)
-        executeQuickFixes(Regex.fromLiteral("Replace isEqualTo() with isOne()"), 10)
-        executeQuickFixes(Regex.fromLiteral("Replace isNotEqualTo() with isNotZero()"), 10)
-        fixture.checkResultByFile("IsZeroOneAfter.java")
-    }
-}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatJava8OptionalInspectionTest.kt

@@ -1,25 +1,27 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.junit.jupiter.api.Test
 
-@TestDataSubPath("inspections/Java8Optional")
 internal class AssertThatJava8OptionalInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun assertThat_get_or_isPresent_for_Java8_Optional_can_be_simplified() {
+    @TestDataSubPath("inspections/Java8Optional")
-        fixture.enableInspections(AssertThatJava8OptionalInspection::class.java)
+    internal fun assertThat_get_or_isPresent_for_Java8_Optional_can_be_simplified(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("Java8OptionalBefore.java")
+        myFixture.enableInspections(AssertThatJava8OptionalInspection::class.java)
-        executeQuickFixes(Regex.fromLiteral("Remove isPresent() of actual expression and use assertThat().isPresent() instead"), 6)
+        myFixture.configureByFile("Java8OptionalBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Remove isPresent() of actual expression and use assertThat().isNotPresent() instead"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove isPresent() of actual expression and use assertThat().isPresent() instead"), 6)
-        executeQuickFixes(Regex.fromLiteral("Remove orElse() of actual expression and use assertThat().isPresent() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove isPresent() of actual expression and use assertThat().isNotPresent() instead"), 5)
-        executeQuickFixes(Regex.fromLiteral("Remove orElse() of actual expression and use assertThat().isNotPresent() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove orElse() of actual expression and use assertThat().isPresent() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().contains() instead"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove orElse() of actual expression and use assertThat().isNotPresent() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsSame() instead"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().contains() instead"), 1)
-        executeQuickFixes(Regex.fromLiteral("Replace isEqualTo() with isNotPresent()"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsSame() instead"), 1)
-        executeQuickFixes(Regex.fromLiteral("Replace isNotEqualTo() with isPresent()"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isNotPresent()"), 1)
-        executeQuickFixes(Regex.fromLiteral("Unwrap expected expression and replace isEqualTo() with contains()"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotEqualTo() with isPresent()"), 1)
-        fixture.checkResultByFile("Java8OptionalAfter.java")
+        executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap expected expression and replace isEqualTo() with contains()"), 2)
+        myFixture.checkResultByFile("Java8OptionalAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatObjectExpressionInspectionTest.kt

@@ -1,20 +1,22 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.junit.jupiter.api.Test
 
-@TestDataSubPath("inspections/ObjectExpression")
 internal class AssertThatObjectExpressionInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun assertThat_with_certain_Object_methods() {
+    @TestDataSubPath("inspections/ObjectExpression")
-        fixture.enableInspections(AssertThatObjectExpressionInspection::class.java)
+    internal fun assertThat_with_certain_Object_methods(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("ObjectExpressionBefore.java")
+        myFixture.enableInspections(AssertThatObjectExpressionInspection::class.java)
-        executeQuickFixes(Regex.fromLiteral("Remove equals() of actual expression and use assertThat().isEqualTo() instead"), 4)
+        myFixture.configureByFile("ObjectExpressionBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Remove equals() of actual expression and use assertThat().isNotEqualTo() instead"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove equals() of actual expression and use assertThat().isEqualTo() instead"), 4)
-        executeQuickFixes(Regex.fromLiteral("Replace calls to hashCode() with hasSameHashCodeAs()"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove equals() of actual expression and use assertThat().isNotEqualTo() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove toString() of actual expression and use assertThat().hasToString() instead"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace calls to hashCode() with hasSameHashCodeAs()"), 1)
-        fixture.checkResultByFile("ObjectExpressionAfter.java")
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove toString() of actual expression and use assertThat().hasToString() instead"), 1)
+        myFixture.checkResultByFile("ObjectExpressionAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatObjectIsNullOrNotNullInspectionTest.kt

@@ -1,18 +1,20 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.junit.jupiter.api.Test
 
-@TestDataSubPath("inspections/ObjectIsNullOrNotNull")
 internal class AssertThatObjectIsNullOrNotNullInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun assertThat_with_isEqualTo_null_can_use_isNull() {
+    @TestDataSubPath("inspections/ObjectIsNullOrNotNull")
-        fixture.enableInspections(AssertThatObjectIsNullOrNotNullInspection::class.java)
+    internal fun assertThat_with_isEqualTo_null_can_use_isNull(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("ObjectIsNullOrNotNullBefore.java")
+        myFixture.enableInspections(AssertThatObjectIsNullOrNotNullInspection::class.java)
-        executeQuickFixes(Regex.fromLiteral("Replace isEqualTo() with isNull()"), 4)
+        myFixture.configureByFile("ObjectIsNullOrNotNullBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Replace isNotEqualTo() with isNotNull()"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isNull()"), 4)
-        fixture.checkResultByFile("ObjectIsNullOrNotNullAfter.java")
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotEqualTo() with isNotNull()"), 5)
+        myFixture.checkResultByFile("ObjectIsNullOrNotNullAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatPathExpressionInspectionTest.kt

@@ -1,22 +0,0 @@
-package de.platon42.intellij.plugins.cajon.inspections
-
-import de.platon42.intellij.jupiter.TestDataSubPath
-import de.platon42.intellij.plugins.cajon.AbstractCajonTest
-import org.junit.jupiter.api.Test
-
-@TestDataSubPath("inspections/PathExpression")
-internal class AssertThatPathExpressionInspectionTest : AbstractCajonTest() {
-
-    @Test
-    internal fun assertThat_with_certain_Path_methods() {
-        fixture.enableInspections(AssertThatPathExpressionInspection::class.java)
-        fixture.configureByFile("PathExpressionBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Remove isAbsolute() of actual expression and use assertThat().isAbsolute() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove isAbsolute() of actual expression and use assertThat().isRelative() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove startsWith() of actual expression and use assertThat().startsWithRaw() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove endsWith() of actual expression and use assertThat().endsWithRaw() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove getParent() of actual expression and use assertThat().hasNoParentRaw() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove getParent() of actual expression and use assertThat().hasParentRaw() instead"), 1)
-        fixture.checkResultByFile("PathExpressionAfter.java")
-    }
-}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatSizeInspectionTest.kt

@@ -1,32 +1,36 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
+import org.assertj.core.api.Assertions.assertThat
+import org.assertj.core.api.extrakting
 import org.junit.jupiter.api.Test
 
-@TestDataSubPath("inspections/Size")
 internal class AssertThatSizeInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun assertThat_size_of_array_collection_or_map_can_be_simplified() {
+    @TestDataSubPath("inspections/Size")
-        fixture.enableInspections(AssertThatSizeInspection::class.java)
+    internal fun assertThat_size_of_array_collection_or_map_can_be_simplified(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("SizeBefore.java")
+        myFixture.enableInspections(AssertThatSizeInspection::class.java)
-        assertHighlightings(1, "Try to operate on the iterable itself rather than its size")
+        myFixture.configureByFile("SizeBefore.java")
+        assertThat(myFixture.doHighlighting()).extrakting { it.description }.containsOnlyOnce("Try to operate on the iterable itself rather than its size")
 
-        executeQuickFixes(Regex.fromLiteral("Replace isEqualTo() with isEmpty()"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isEmpty()"), 5)
-        executeQuickFixes(Regex.fromLiteral("Replace isZero() with isEmpty()"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isZero() with isEmpty()"), 5)
-        executeQuickFixes(Regex.fromLiteral("Replace isNotZero() with isNotEmpty()"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotZero() with isNotEmpty()"), 5)
-        executeQuickFixes(Regex.fromLiteral("Replace isGreaterThan() with isNotEmpty()"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThan() with isNotEmpty()"), 5)
-        executeQuickFixes(Regex.fromLiteral("Replace isGreaterThanOrEqualTo() with isNotEmpty()"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThanOrEqualTo() with isNotEmpty()"), 5)
-        executeQuickFixes(Regex.fromLiteral("Replace isLessThan() with isEmpty()"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThan() with isEmpty()"), 5)
-        executeQuickFixes(Regex.fromLiteral("Replace isLessThanOrEqualTo() with isEmpty()"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThanOrEqualTo() with isEmpty()"), 5)
-        executeQuickFixes(Regex.fromLiteral("Replace isEqualTo() with hasSameSizeAs()"), 15)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with hasSameSizeAs()"), 15)
-        executeQuickFixes(Regex.fromLiteral("Replace isEqualTo() with hasSize()"), 15)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with hasSize()"), 15)
-        executeQuickFixes(Regex.fromLiteral("Replace isGreaterThan() with hasSizeGreaterThan()"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThan() with hasSizeGreaterThan()"), 5)
-        executeQuickFixes(Regex.fromLiteral("Replace isGreaterThanOrEqualTo() with hasSizeGreaterThanOrEqualTo()"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThanOrEqualTo() with hasSizeGreaterThanOrEqualTo()"), 5)
-        executeQuickFixes(Regex.fromLiteral("Replace isLessThan() with hasSizeLessThan()"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThan() with hasSizeLessThan()"), 5)
-        executeQuickFixes(Regex.fromLiteral("Replace isLessThanOrEqualTo() with hasSizeLessThanOrEqualTo()"), 5)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThanOrEqualTo() with hasSizeLessThanOrEqualTo()"), 5)
-        executeQuickFixes(Regex.fromLiteral("Remove size determination of expected expression and replace hasSize() with hasSameSizeAs()"), 17)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove size determination of expected expression and replace hasSize() with hasSameSizeAs()"), 17)
-        fixture.checkResultByFile("SizeAfter.java")
+        myFixture.checkResultByFile("SizeAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatStringExpressionInspectionTest.kt

@@ -1,39 +1,41 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.junit.jupiter.api.Test
 
-@TestDataSubPath("inspections/StringExpression")
 internal class AssertThatStringExpressionInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun assertThat_with_certain_String_methods() {
+    @TestDataSubPath("inspections/StringExpression")
-        fixture.enableInspections(AssertThatStringExpressionInspection::class.java)
+    internal fun assertThat_with_certain_String_methods(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("StringExpressionBefore.java")
+        myFixture.enableInspections(AssertThatStringExpressionInspection::class.java)
-        executeQuickFixes(Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isEmpty() instead"), 3)
+        myFixture.configureByFile("StringExpressionBefore.java")
-        executeQuickFixes(Regex.fromLiteral("Remove equals() of actual expression and use assertThat().isEqualTo() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isEmpty() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove equalsIgnoreCase() of actual expression and use assertThat().isEqualToIgnoringCase() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove equals() of actual expression and use assertThat().isEqualTo() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove contentEquals() of actual expression and use assertThat().isEqualTo() instead"), 4)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove equalsIgnoreCase() of actual expression and use assertThat().isEqualToIgnoringCase() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove contains() of actual expression and use assertThat().contains() instead"), 4)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove contentEquals() of actual expression and use assertThat().isEqualTo() instead"), 4)
-        executeQuickFixes(Regex.fromLiteral("Remove startsWith() of actual expression and use assertThat().startsWith() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove contains() of actual expression and use assertThat().contains() instead"), 4)
-        executeQuickFixes(Regex.fromLiteral("Remove endsWith() of actual expression and use assertThat().endsWith() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove startsWith() of actual expression and use assertThat().startsWith() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove matches() of actual expression and use assertThat().matches() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove endsWith() of actual expression and use assertThat().endsWith() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove matches() of actual expression and use assertThat().doesNotMatch() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove matches() of actual expression and use assertThat().matches() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isNotEmpty() instead"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove matches() of actual expression and use assertThat().doesNotMatch() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove equals() of actual expression and use assertThat().isNotEqualTo() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isNotEmpty() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove equalsIgnoreCase() of actual expression and use assertThat().isNotEqualToIgnoringCase() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove equals() of actual expression and use assertThat().isNotEqualTo() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove contentEquals() of actual expression and use assertThat().isNotEqualTo() instead"), 4)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove equalsIgnoreCase() of actual expression and use assertThat().isNotEqualToIgnoringCase() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove contains() of actual expression and use assertThat().doesNotContain() instead"), 4)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove contentEquals() of actual expression and use assertThat().isNotEqualTo() instead"), 4)
-        executeQuickFixes(Regex.fromLiteral("Remove startsWith() of actual expression and use assertThat().doesNotStartWith() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove contains() of actual expression and use assertThat().doesNotContain() instead"), 4)
-        executeQuickFixes(Regex.fromLiteral("Remove endsWith() of actual expression and use assertThat().doesNotEndWith() instead"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove startsWith() of actual expression and use assertThat().doesNotStartWith() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove compareToIgnoreCase() of actual expression and use assertThat().isEqualToIgnoringCase() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove endsWith() of actual expression and use assertThat().doesNotEndWith() instead"), 3)
-        executeQuickFixes(Regex.fromLiteral("Remove compareToIgnoreCase() of actual expression and use assertThat().isNotEqualToIgnoringCase() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove compareToIgnoreCase() of actual expression and use assertThat().isEqualToIgnoringCase() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove indexOf() of actual expression and use assertThat().startsWith() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove compareToIgnoreCase() of actual expression and use assertThat().isNotEqualToIgnoringCase() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove indexOf() of actual expression and use assertThat().doesNotStartWith() instead"), 2)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove indexOf() of actual expression and use assertThat().startsWith() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove indexOf() of actual expression and use assertThat().contains() instead"), 4)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove indexOf() of actual expression and use assertThat().doesNotStartWith() instead"), 2)
-        executeQuickFixes(Regex.fromLiteral("Remove indexOf() of actual expression and use assertThat().doesNotContain() instead"), 4)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove indexOf() of actual expression and use assertThat().contains() instead"), 4)
-        executeQuickFixes(Regex.fromLiteral("Remove trim() of actual expression and use assertThat().isNotBlank() instead"), 1)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove indexOf() of actual expression and use assertThat().doesNotContain() instead"), 4)
-        fixture.checkResultByFile("StringExpressionAfter.java")
+        executeQuickFixes(myFixture, Regex.fromLiteral("Remove trim() of actual expression and use assertThat().isNotBlank() instead"), 1)
+        myFixture.checkResultByFile("StringExpressionAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssertThatStringIsEmptyInspectionTest.kt

@@ -1,25 +1,27 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.assertj.core.api.Assertions.assertThat
 import org.assertj.core.api.extrakting
 import org.junit.jupiter.api.Test
 
-@TestDataSubPath("inspections/StringIsEmpty")
 internal class AssertThatStringIsEmptyInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun assertThat_with_isEqualTo_emptyString_can_use_isEmpty() {
+    @TestDataSubPath("inspections/StringIsEmpty")
-        fixture.enableInspections(AssertThatStringIsEmptyInspection::class.java)
+    internal fun assertThat_with_isEqualTo_emptyString_can_use_isEmpty(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("StringIsEmptyBefore.java")
+        myFixture.enableInspections(AssertThatStringIsEmptyInspection::class.java)
-        val highlights = fixture.doHighlighting()
+        myFixture.configureByFile("StringIsEmptyBefore.java")
+        val highlights = myFixture.doHighlighting()
             .asSequence()
             .filter { it.description?.contains(" can be simplified to") ?: false }
             .toList()
         assertThat(highlights).hasSize(6).extrakting { it.text }.doesNotContain("assertThat")
-        executeQuickFixes(Regex.fromLiteral("Replace isEqualTo() with isEmpty()"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isEmpty()"), 3)
-        executeQuickFixes(Regex.fromLiteral("Replace hasSize() with isEmpty()"), 3)
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace hasSize() with isEmpty()"), 3)
-        fixture.checkResultByFile("StringIsEmptyAfter.java")
+        myFixture.checkResultByFile("StringIsEmptyAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/AssumeThatInsteadOfReturnInspectionTest.kt

@@ -1,20 +1,22 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
-import de.platon42.intellij.jupiter.AddMavenDependencyToModule
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.AddLocalJarToModule
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
+import org.assertj.core.api.Assertions
 import org.junit.jupiter.api.Test
 
-@AddMavenDependencyToModule("junit:junit:4.13.2")
+@AddLocalJarToModule(Assertions::class, Test::class, org.junit.Test::class)
-@AddMavenDependencyToModule("org.junit.jupiter:junit-jupiter-api:5.10.2")
-@TestDataSubPath("inspections/AssumeThat")
 internal class AssumeThatInsteadOfReturnInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun conditional_returns_can_be_replaced_by_assumeThat() {
+    @TestDataSubPath("inspections/AssumeThat")
-        fixture.enableInspections(AssumeThatInsteadOfReturnInspection::class.java)
+    internal fun conditional_returns_can_be_replaced_by_assumeThat(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("AssumeThatBefore.java")
+        myFixture.enableInspections(AssumeThatInsteadOfReturnInspection::class.java)
-        executeQuickFixes(Regex.fromLiteral("Replace if statement by assumeTrue()"), 5)
+        myFixture.configureByFile("AssumeThatBefore.java")
-        fixture.checkResultByFile("AssumeThatAfter.java")
+        executeQuickFixes(myFixture, Regex.fromLiteral("Replace if statement by assumeTrue()"), 5)
+        myFixture.checkResultByFile("AssumeThatAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/BogusAssertionInspectionTest.kt

@@ -1,17 +0,0 @@
-package de.platon42.intellij.plugins.cajon.inspections
-
-import de.platon42.intellij.jupiter.TestDataSubPath
-import de.platon42.intellij.plugins.cajon.AbstractCajonTest
-import org.junit.jupiter.api.Test
-
-@TestDataSubPath("inspections/BogusAssertion")
-internal class BogusAssertionInspectionTest : AbstractCajonTest() {
-
-    @Test
-    internal fun reports_bogus_assertions() {
-        fixture.enableInspections(BogusAssertionInspection::class.java)
-        fixture.configureByFile("BogusAssertionBefore.java")
-        assertHighlightings(14 * 9 + 10 + 12 + 8, "Actual expression in assertThat() is the same as expected")
-        assertHighlightings(3, "Same actual and expected expression, but may be testing equals() or hashCode()")
-    }
-}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/ImplicitAssertionInspectionTest.kt

@@ -1,21 +1,24 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
-import de.platon42.intellij.jupiter.AddMavenDependencyToModule
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.AddLocalJarToModule
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
+import org.assertj.core.api.Assertions
 import org.junit.jupiter.api.Test
 
-@AddMavenDependencyToModule("org.assertj:assertj-guava:3.25.3")
+@AddLocalJarToModule(com.google.common.base.Optional::class, org.assertj.guava.api.Assertions::class, Assertions::class)
-@TestDataSubPath("inspections/ImplicitAssertion")
 internal class ImplicitAssertionInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun implicit_assertions_can_be_removed() {
+    @TestDataSubPath("inspections/ImplicitAssertion")
-        fixture.enableInspections(ImplicitAssertionInspection::class.java)
+    internal fun implicit_assertions_can_be_removed(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("ImplicitAssertionBefore.java")
+        myFixture.enableInspections(ImplicitAssertionInspection::class.java)
-        executeQuickFixesNoFamilyNameCheck(Regex("Delete implicit isNotNull\\(\\) covered by .*"), 102)
+        myFixture.configureByFile("ImplicitAssertionBefore.java")
-        executeQuickFixesNoFamilyNameCheck(Regex("Delete implicit isNotEmpty\\(\\) covered by .*"), 17)
+        executeQuickFixesNoFamilyNameCheck(myFixture, Regex("Delete implicit isNotNull\\(\\) covered by .*"), 101)
-        executeQuickFixesNoFamilyNameCheck(Regex("Delete implicit isPresent\\(\\) covered by .*"), 8)
+        executeQuickFixesNoFamilyNameCheck(myFixture, Regex("Delete implicit isNotEmpty\\(\\) covered by .*"), 17)
-        fixture.checkResultByFile("ImplicitAssertionAfter.java")
+        executeQuickFixesNoFamilyNameCheck(myFixture, Regex("Delete implicit isPresent\\(\\) covered by .*"), 8)
+        myFixture.checkResultByFile("ImplicitAssertionAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/JUnitAssertToAssertJInspectionTest.kt

@@ -1,20 +1,24 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
-import de.platon42.intellij.jupiter.AddMavenDependencyToModule
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.AddLocalJarToModule
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
+import org.assertj.core.api.Assertions
+import org.junit.Assert
 import org.junit.jupiter.api.Test
 
-@AddMavenDependencyToModule("junit:junit:4.13.2")
+@AddLocalJarToModule(Assert::class, Assertions::class)
-@TestDataSubPath("inspections/JUnitAssertToAssertJ")
 internal class JUnitAssertToAssertJInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun junit_Assertions_can_be_converted_into_AssertJ() {
+    @TestDataSubPath("inspections/JUnitAssertToAssertJ")
-        fixture.enableInspections(JUnitAssertToAssertJInspection::class.java)
+    internal fun junit_Assertions_can_be_converted_into_AssertJ(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("JUnitAssertToAssertJInspectionBefore.java")
+        myFixture.enableInspections(JUnitAssertToAssertJInspection::class.java)
-        executeQuickFixesNoFamilyNameCheck(Regex("Convert assert.*\\(\\) to assertThat\\(\\).*"), 48)
+        myFixture.configureByFile("JUnitAssertToAssertJInspectionBefore.java")
-        executeQuickFixesNoFamilyNameCheck(Regex("Convert assume.*\\(\\) to assumeThat\\(\\).*"), 7)
+        executeQuickFixesNoFamilyNameCheck(myFixture, Regex("Convert assert.*\\(\\) to assertThat\\(\\).*"), 48)
-        fixture.checkResultByFile("JUnitAssertToAssertJInspectionAfter.java")
+        executeQuickFixesNoFamilyNameCheck(myFixture, Regex("Convert assume.*\\(\\) to assumeThat\\(\\).*"), 7)
+        myFixture.checkResultByFile("JUnitAssertToAssertJInspectionAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/JoinAssertThatStatementsInspectionTest.kt

@@ -1,17 +1,19 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.junit.jupiter.api.Test
 
-@TestDataSubPath("inspections/JoinStatements")
 internal class JoinAssertThatStatementsInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun assertThat_statements_can_be_joined_together() {
+    @TestDataSubPath("inspections/JoinStatements")
-        fixture.enableInspections(JoinAssertThatStatementsInspection::class.java)
+    internal fun assertThat_statements_can_be_joined_together(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("JoinStatementsBefore.java")
+        myFixture.enableInspections(JoinAssertThatStatementsInspection::class.java)
-        executeQuickFixes(Regex.fromLiteral("Join assertThat() statements"), 5)
+        myFixture.configureByFile("JoinStatementsBefore.java")
-        fixture.checkResultByFile("JoinStatementsAfter.java")
+        executeQuickFixes(myFixture, Regex.fromLiteral("Join assertThat() statements"), 5)
+        myFixture.checkResultByFile("JoinStatementsAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/JoinVarArgsContainsInspectionTest.kt

@@ -1,17 +1,19 @@
 package de.platon42.intellij.plugins.cajon.inspections
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.junit.jupiter.api.Test
 
-@TestDataSubPath("inspections/JoinVarArgsContains")
 internal class JoinVarArgsContainsInspectionTest : AbstractCajonTest() {
 
     @Test
-    internal fun join_contains_and_doesNotContain_together_where_possible() {
+    @TestDataSubPath("inspections/JoinVarArgsContains")
-        fixture.enableInspections(JoinVarArgsContainsInspection::class.java)
+    internal fun join_contains_and_doesNotContain_together_where_possible(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFile("JoinVarArgsContainsBefore.java")
+        myFixture.enableInspections(JoinVarArgsContainsInspection::class.java)
-        executeQuickFixes(Regex.fromLiteral("Join multiple arguments to variadic argument method calls"), 3)
+        myFixture.configureByFile("JoinVarArgsContainsBefore.java")
-        fixture.checkResultByFile("JoinVarArgsContainsAfter.java")
+        executeQuickFixes(myFixture, Regex.fromLiteral("Join multiple arguments to variadic argument method calls"), 3)
+        myFixture.checkResultByFile("JoinVarArgsContainsAfter.java")
     }
-}
+}

src/test/java/de/platon42/intellij/plugins/cajon/inspections/TwistedAssertionInspectionTest.kt

@@ -1,21 +0,0 @@
-package de.platon42.intellij.plugins.cajon.inspections
-
-import de.platon42.intellij.jupiter.TestDataSubPath
-import de.platon42.intellij.plugins.cajon.AbstractCajonTest
-import org.junit.jupiter.api.Test
-
-@TestDataSubPath("inspections/TwistedAssertion")
-internal class TwistedAssertionInspectionTest : AbstractCajonTest() {
-
-    @Test
-    internal fun hint_twisted_actual_and_expected_and_provide_quickfix_where_possible() {
-        fixture.enableInspections(TwistedAssertionInspection::class.java)
-        fixture.configureByFile("TwistedAssertionBefore.java")
-        assertHighlightings(9, "Actual expression in assertThat() is a constant")
-        assertHighlightings(10, "Twisted actual and expected expressions")
-
-        executeQuickFixes(Regex.fromLiteral("Swap actual and expected expressions in assertion"), 6)
-        executeQuickFixesNoFamilyNameCheck(Regex("Replace .* by .* and swap actual and expected expressions"), 4)
-        fixture.checkResultByFile("TwistedAssertionAfter.java")
-    }
-}

src/test/java/de/platon42/intellij/plugins/cajon/references/ExtractorReferenceContributorTest.kt

@@ -1,5 +1,7 @@
 package de.platon42.intellij.plugins.cajon.references
 
+import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
+import de.platon42.intellij.jupiter.MyFixture
 import de.platon42.intellij.jupiter.TestDataSubPath
 import de.platon42.intellij.plugins.cajon.AbstractCajonTest
 import org.assertj.core.api.Assertions.assertThat
@@ -11,68 +13,68 @@ import org.junit.jupiter.api.Test
 internal class ExtractorReferenceContributorTest : AbstractCajonTest() {
 
     @Test
-    internal fun extractor_is_able_to_find_reference_for_field_extracting() {
+    internal fun extractor_is_able_to_find_reference_for_field_extracting(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFiles("FindReference1.java", "Address.java", "Contact.java")
+        myFixture.configureByFiles("FindReference1.java", "Address.java", "Contact.java")
-        assertThat(fixture.elementAtCaret.text).isEqualTo("private String name;")
+        assertThat(myFixture.elementAtCaret.text).isEqualTo("private String name;")
     }
 
     @Test
-    internal fun extractor_is_able_to_find_reference_for_first_part_of_a_path() {
+    internal fun extractor_is_able_to_find_reference_for_first_part_of_a_path(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFiles("FindReference2.java", "Address.java", "Contact.java")
+        myFixture.configureByFiles("FindReference2.java", "Address.java", "Contact.java")
-        assertThat(fixture.elementAtCaret.text).isEqualTo("protected Address address;")
+        assertThat(myFixture.elementAtCaret.text).isEqualTo("protected Address address;")
     }
 
     @Test
-    internal fun extractor_is_able_to_find_reference_for_second_part_of_a_path_and_both_getter_and_field() {
+    internal fun extractor_is_able_to_find_reference_for_second_part_of_a_path_and_both_getter_and_field(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFiles("FindReference3.java", "Address.java", "Contact.java")
+        myFixture.configureByFiles("FindReference3.java", "Address.java", "Contact.java")
-        assertThat(fixture.elementAtCaret.text).startsWith("private String street;")
+        assertThat(myFixture.elementAtCaret.text).startsWith("private String street;")
     }
 
     @Test
-    internal fun extractor_is_able_to_find_reference_on_a_bare_method_call() {
+    internal fun extractor_is_able_to_find_reference_on_a_bare_method_call(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFiles("FindReference4.java", "Address.java", "Contact.java")
+        myFixture.configureByFiles("FindReference4.java", "Address.java", "Contact.java")
-        assertThat(fixture.elementAtCaret.text).startsWith("public Boolean getREALLYnoMAILINGS()")
+        assertThat(myFixture.elementAtCaret.text).startsWith("public Boolean getREALLYnoMAILINGS()")
     }
 
     @Test
-    internal fun extractor_is_able_to_find_reference_with_only_Getter_on_second_part() {
+    internal fun extractor_is_able_to_find_reference_with_only_Getter_on_second_part(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFiles("FindReference5.java", "Address.java", "Contact.java")
+        myFixture.configureByFiles("FindReference5.java", "Address.java", "Contact.java")
-        assertThat(fixture.elementAtCaret.text).startsWith("public boolean isNoMailings()")
+        assertThat(myFixture.elementAtCaret.text).startsWith("public boolean isNoMailings()")
     }
 
     @Test
-    internal fun extractor_is_able_to_find_reference_using_byName_extractor() {
+    internal fun extractor_is_able_to_find_reference_using_byName_extractor(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFiles("FindReference6.java", "Address.java", "Contact.java")
+        myFixture.configureByFiles("FindReference6.java", "Address.java", "Contact.java")
-        assertThat(fixture.elementAtCaret.text).isEqualTo("private String name;")
+        assertThat(myFixture.elementAtCaret.text).isEqualTo("private String name;")
     }
 
     @Test
-    internal fun extractor_is_able_to_find_reference_using_resultOf_extractor() {
+    internal fun extractor_is_able_to_find_reference_using_resultOf_extractor(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFiles("FindReference7.java", "Address.java", "Contact.java")
+        myFixture.configureByFiles("FindReference7.java", "Address.java", "Contact.java")
-        assertThat(fixture.elementAtCaret.text).startsWith("public String getStreetName()")
+        assertThat(myFixture.elementAtCaret.text).startsWith("public String getStreetName()")
     }
 
     @Test
-    internal fun extractor_is_able_to_find_reference_for_field_extraction_on_list() {
+    internal fun extractor_is_able_to_find_reference_for_field_extraction_on_list(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFiles("FindReference8.java", "Address.java", "Contact.java")
+        myFixture.configureByFiles("FindReference8.java", "Address.java", "Contact.java")
-        assertThat(fixture.elementAtCaret.text).isEqualTo("private String name;")
+        assertThat(myFixture.elementAtCaret.text).isEqualTo("private String name;")
     }
 
     @Test
-    internal fun extractor_is_able_to_find_reference_for_field_flat_extraction_of_path_on_list() {
+    internal fun extractor_is_able_to_find_reference_for_field_flat_extraction_of_path_on_list(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFiles("FindReference9.java", "Address.java", "Contact.java")
+        myFixture.configureByFiles("FindReference9.java", "Address.java", "Contact.java")
-        assertThat(fixture.elementAtCaret.text).startsWith("private String street;")
+        assertThat(myFixture.elementAtCaret.text).startsWith("private String street;")
     }
 
     @Test
-    internal fun extractor_is_able_to_find_reference_for_extraction_on_result_of_method() {
+    internal fun extractor_is_able_to_find_reference_for_extraction_on_result_of_method(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFiles("FindReference10.java", "Address.java", "Contact.java")
+        myFixture.configureByFiles("FindReference10.java", "Address.java", "Contact.java")
-        assertThat(fixture.elementAtCaret.text).startsWith("public String getStreetName()")
+        assertThat(myFixture.elementAtCaret.text).startsWith("public String getStreetName()")
     }
 
     @Test
-    internal fun extractor_is_unable_to_find_reference() {
+    internal fun extractor_is_unable_to_find_reference(@MyFixture myFixture: JavaCodeInsightTestFixture) {
-        fixture.configureByFiles("FindReference11.java", "Address.java", "Contact.java")
+        myFixture.configureByFiles("FindReference11.java", "Address.java", "Contact.java")
-        assertThatThrownBy { fixture.elementAtCaret.text }.isInstanceOf(AssertionError::class.java)
+        assertThatThrownBy { myFixture.elementAtCaret.text }.isInstanceOf(AssertionError::class.java)
     }
-}
+}

src/test/resources/inspections/BogusAssertion/BogusAssertionBefore.java

@@ -1,218 +0,0 @@
-import java.io.File;
-import java.util.*;
-
-import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.fail;
-
-public class BogusAssertions {
-
-    private void bogusAssertions() {
-        boolean[] boolarray = new boolean[10];
-        byte[] bytearray = new byte[10];
-        short[] shortarray = new short[10];
-        int[] intarray = new int[10];
-        long[] longarray = new long[10];
-        float[] floatarray = new float[10];
-        double[] doublearray = new double[10];
-        char[] chararray = new char[10];
-        Object[] objarray = new Object[10];
-        String string = "foo";
-        List<String> list = new ArrayList<>();
-        Map<String, Integer> map = new HashMap<>();
-        String bar = "bar";
-
-        assertThat(boolarray).isEqualTo(boolarray);
-        assertThat(boolarray).isSameAs(boolarray);
-        assertThat(boolarray).hasSameClassAs(boolarray);
-        assertThat(boolarray).hasSameHashCodeAs(boolarray);
-        assertThat(boolarray).hasSameSizeAs(boolarray);
-        assertThat(boolarray).contains(boolarray);
-        assertThat(boolarray).containsAnyOf(boolarray);
-        assertThat(boolarray).containsExactly(boolarray);
-        assertThat(boolarray).containsExactlyInAnyOrder(boolarray);
-        assertThat(boolarray).containsOnly(boolarray);
-        assertThat(boolarray).containsSequence(boolarray);
-        assertThat(boolarray).containsSubsequence(boolarray);
-        assertThat(boolarray).startsWith(boolarray);
-        assertThat(boolarray).endsWith(boolarray);
-
-        assertThat(bytearray).isEqualTo(bytearray);
-        assertThat(bytearray).isSameAs(bytearray);
-        assertThat(bytearray).hasSameClassAs(bytearray);
-        assertThat(bytearray).hasSameHashCodeAs(bytearray);
-        assertThat(bytearray).hasSameSizeAs(bytearray);
-        assertThat(bytearray).contains(bytearray);
-        assertThat(bytearray).containsAnyOf(bytearray);
-        assertThat(bytearray).containsExactly(bytearray);
-        assertThat(bytearray).containsExactlyInAnyOrder(bytearray);
-        assertThat(bytearray).containsOnly(bytearray);
-        assertThat(bytearray).containsSequence(bytearray);
-        assertThat(bytearray).containsSubsequence(bytearray);
-        assertThat(bytearray).startsWith(bytearray);
-        assertThat(bytearray).endsWith(bytearray);
-
-        assertThat(shortarray).isEqualTo(shortarray);
-        assertThat(shortarray).isSameAs(shortarray);
-        assertThat(shortarray).hasSameClassAs(shortarray);
-        assertThat(shortarray).hasSameHashCodeAs(shortarray);
-        assertThat(shortarray).hasSameSizeAs(shortarray);
-        assertThat(shortarray).contains(shortarray);
-        assertThat(shortarray).containsAnyOf(shortarray);
-        assertThat(shortarray).containsExactly(shortarray);
-        assertThat(shortarray).containsExactlyInAnyOrder(shortarray);
-        assertThat(shortarray).containsOnly(shortarray);
-        assertThat(shortarray).containsSequence(shortarray);
-        assertThat(shortarray).containsSubsequence(shortarray);
-        assertThat(shortarray).startsWith(shortarray);
-        assertThat(shortarray).endsWith(shortarray);
-
-        assertThat(intarray).isEqualTo(intarray);
-        assertThat(intarray).isSameAs(intarray);
-        assertThat(intarray).hasSameClassAs(intarray);
-        assertThat(intarray).hasSameHashCodeAs(intarray);
-        assertThat(intarray).hasSameSizeAs(intarray);
-        assertThat(intarray).contains(intarray);
-        assertThat(intarray).containsAnyOf(intarray);
-        assertThat(intarray).containsExactly(intarray);
-        assertThat(intarray).containsExactlyInAnyOrder(intarray);
-        assertThat(intarray).containsOnly(intarray);
-        assertThat(intarray).containsSequence(intarray);
-        assertThat(intarray).containsSubsequence(intarray);
-        assertThat(intarray).startsWith(intarray);
-        assertThat(intarray).endsWith(intarray);
-
-        assertThat(longarray).isEqualTo(longarray);
-        assertThat(longarray).isSameAs(longarray);
-        assertThat(longarray).hasSameClassAs(longarray);
-        assertThat(longarray).hasSameHashCodeAs(longarray);
-        assertThat(longarray).hasSameSizeAs(longarray);
-        assertThat(longarray).contains(longarray);
-        assertThat(longarray).containsAnyOf(longarray);
-        assertThat(longarray).containsExactly(longarray);
-        assertThat(longarray).containsExactlyInAnyOrder(longarray);
-        assertThat(longarray).containsOnly(longarray);
-        assertThat(longarray).containsSequence(longarray);
-        assertThat(longarray).containsSubsequence(longarray);
-        assertThat(longarray).startsWith(longarray);
-        assertThat(longarray).endsWith(longarray);
-
-        assertThat(floatarray).isEqualTo(floatarray);
-        assertThat(floatarray).isSameAs(floatarray);
-        assertThat(floatarray).hasSameClassAs(floatarray);
-        assertThat(floatarray).hasSameHashCodeAs(floatarray);
-        assertThat(floatarray).hasSameSizeAs(floatarray);
-        assertThat(floatarray).contains(floatarray);
-        assertThat(floatarray).containsAnyOf(floatarray);
-        assertThat(floatarray).containsExactly(floatarray);
-        assertThat(floatarray).containsExactlyInAnyOrder(floatarray);
-        assertThat(floatarray).containsOnly(floatarray);
-        assertThat(floatarray).containsSequence(floatarray);
-        assertThat(floatarray).containsSubsequence(floatarray);
-        assertThat(floatarray).startsWith(floatarray);
-        assertThat(floatarray).endsWith(floatarray);
-
-        assertThat(doublearray).isEqualTo(doublearray);
-        assertThat(doublearray).isSameAs(doublearray);
-        assertThat(doublearray).hasSameClassAs(doublearray);
-        assertThat(doublearray).hasSameHashCodeAs(doublearray);
-        assertThat(doublearray).hasSameSizeAs(doublearray);
-        assertThat(doublearray).contains(doublearray);
-        assertThat(doublearray).containsAnyOf(doublearray);
-        assertThat(doublearray).containsExactly(doublearray);
-        assertThat(doublearray).containsExactlyInAnyOrder(doublearray);
-        assertThat(doublearray).containsOnly(doublearray);
-        assertThat(doublearray).containsSequence(doublearray);
-        assertThat(doublearray).containsSubsequence(doublearray);
-        assertThat(doublearray).startsWith(doublearray);
-        assertThat(doublearray).endsWith(doublearray);
-
-        assertThat(chararray).isEqualTo(chararray);
-        assertThat(chararray).isSameAs(chararray);
-        assertThat(chararray).hasSameClassAs(chararray);
-        assertThat(chararray).hasSameHashCodeAs(chararray);
-        assertThat(chararray).hasSameSizeAs(chararray);
-        assertThat(chararray).contains(chararray);
-        assertThat(chararray).containsAnyOf(chararray);
-        assertThat(chararray).containsExactly(chararray);
-        assertThat(chararray).containsExactlyInAnyOrder(chararray);
-        assertThat(chararray).containsOnly(chararray);
-        assertThat(chararray).containsSequence(chararray);
-        assertThat(chararray).containsSubsequence(chararray);
-        assertThat(chararray).startsWith(chararray);
-        assertThat(chararray).endsWith(chararray);
-
-        assertThat(objarray).isEqualTo(objarray);
-        assertThat(objarray).isSameAs(objarray);
-        assertThat(objarray).hasSameClassAs(objarray);
-        assertThat(objarray).hasSameHashCodeAs(objarray);
-        assertThat(objarray).hasSameSizeAs(objarray);
-        assertThat(objarray).contains(objarray);
-        assertThat(objarray).containsAnyOf(objarray);
-        assertThat(objarray).containsExactly(objarray);
-        assertThat(objarray).containsExactlyInAnyOrder(objarray);
-        assertThat(objarray).containsOnly(objarray);
-        assertThat(objarray).containsSequence(objarray);
-        assertThat(objarray).containsSubsequence(objarray);
-        assertThat(objarray).startsWith(objarray);
-        assertThat(objarray).endsWith(objarray);
-
-        assertThat(string).as("foo").isEqualTo(string);
-        assertThat(string).as("foo").isSameAs(string);
-        assertThat(string).as("foo").hasSameClassAs(string);
-        assertThat(string).as("foo").hasSameHashCodeAs(string);
-        assertThat(string).as("foo").hasSameSizeAs(string);
-        assertThat(string).as("foo").isEqualToIgnoringCase(string);
-        assertThat(string).as("foo").containsSequence(string);
-        assertThat(string).as("foo").containsSubsequence(string);
-        assertThat(string).as("foo").startsWith(string);
-        assertThat(string).as("foo").endsWith(string);
-
-        assertThat(list).as("foo").isEqualTo(list);
-        assertThat(list).as("foo").isSameAs(list);
-        assertThat(list).as("foo").hasSameClassAs(list);
-        assertThat(list).as("foo").hasSameHashCodeAs(list);
-        assertThat(list).as("foo").hasSameSizeAs(list);
-        assertThat(list).as("foo").containsAll(list);
-        assertThat(list).as("foo").containsAnyElementsOf(list);
-        assertThat(list).as("foo").containsOnlyElementsOf(list);
-        assertThat(list).as("foo").containsExactlyElementsOf(list);
-        assertThat(list).as("foo").hasSameElementsAs(list);
-        assertThat(list).as("foo").containsSequence(list);
-        assertThat(list).as("foo").containsSubsequence(list);
-
-        assertThat(map).as("foo").isEqualTo(map);
-        assertThat(map).as("foo").isSameAs(map);
-        assertThat(map).as("foo").hasSameClassAs(map);
-        assertThat(map).as("foo").hasSameHashCodeAs(map);
-        assertThat(map).as("foo").hasSameSizeAs(map);
-        assertThat(map).as("foo").containsAllEntriesOf(map);
-        assertThat(map).as("foo").containsExactlyEntriesOf(map);
-        assertThat(map).as("foo").containsExactlyInAnyOrderEntriesOf(map);
-
-        assertThat(bar).isEqualTo(string);
-
-        assertThat(new Random().nextBoolean()).isEqualTo(new Random().nextBoolean());
-        assertThat(generateString()).isEqualTo(generateString());
-
-        int number = 4;
-        assertThat(number++).isEqualTo(number++);
-        assertThat(number++).isEqualTo(number++);
-
-        org.junit.Assert.assertThat(list, null);
-        fail("oh no!");
-    }
-
-    private void test_equals() {
-        assertThat("foo").isEqualTo("foo");
-        assertThat(new File("foo")).isEqualTo(new File("foo"));
-    }
-
-    private void test_HasHCode() {
-        assertThat("foo").hasSameHashCodeAs("foo");
-    }
-
-    private String generateString()
-    {
-        return "foo";
-    }
-}

src/test/resources/inspections/Comparable/ComparableAfter.java

@@ -1,41 +0,0 @@
-import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.fail;
-
-public class CompareTo {
-
-    private void comparable() {
-        String string = "string";
-        assertThat(string).isEqualByComparingTo("foo");
-        assertThat(string).isEqualByComparingTo("foo");
-
-        assertThat(string).isNotEqualByComparingTo("foo");
-        assertThat(string).isNotEqualByComparingTo("foo");
-
-        assertThat(string).isGreaterThanOrEqualTo("foo");
-        assertThat(string).isGreaterThanOrEqualTo("foo");
-        assertThat(string).isGreaterThanOrEqualTo("foo");
-        assertThat(string).isGreaterThanOrEqualTo("foo");
-
-        assertThat(string).isGreaterThan("foo");
-        assertThat(string).isGreaterThan("foo");
-        assertThat(string).isGreaterThan("foo");
-        assertThat(string).isGreaterThan("foo");
-        assertThat(string).isGreaterThan("foo");
-
-        assertThat(string).isLessThanOrEqualTo("foo");
-        assertThat(string).isLessThanOrEqualTo("foo");
-        assertThat(string).isLessThanOrEqualTo("foo");
-        assertThat(string).isLessThanOrEqualTo("foo");
-
-        assertThat(string).isLessThan("foo");
-        assertThat(string).isLessThan("foo");
-        assertThat(string).isLessThan("foo");
-        assertThat(string).isLessThan("foo");
-
-        assertThat(string.compareTo("foo")).isNotEqualTo(2);
-        assertThat(string.compareTo("foo")).isEqualTo(2);
-
-        org.junit.Assert.assertThat(string, null);
-        fail("oh no!");
-    }
-}

src/test/resources/inspections/Comparable/ComparableBefore.java

@@ -1,41 +0,0 @@
-import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.fail;
-
-public class CompareTo {
-
-    private void comparable() {
-        String string = "string";
-        assertThat(string.compareTo("foo")).isEqualTo(0);
-        assertThat(string.compareTo("foo")).isZero();
-
-        assertThat(string.compareTo("foo")).isNotEqualTo(0);
-        assertThat(string.compareTo("foo")).isNotZero();
-
-        assertThat(string.compareTo("foo")).isNotEqualTo(-1);
-        assertThat(string.compareTo("foo")).isGreaterThanOrEqualTo(0);
-        assertThat(string.compareTo("foo")).isGreaterThan(-1);
-        assertThat(string.compareTo("foo")).isNotNegative();
-
-        assertThat(string.compareTo("foo")).isEqualTo(1);
-        assertThat(string.compareTo("foo")).isOne();
-        assertThat(string.compareTo("foo")).isGreaterThan(0);
-        assertThat(string.compareTo("foo")).isPositive();
-        assertThat(string.compareTo("foo")).isGreaterThanOrEqualTo(1);
-
-        assertThat(string.compareTo("foo")).isNotEqualTo(1);
-        assertThat(string.compareTo("foo")).isLessThanOrEqualTo(0);
-        assertThat(string.compareTo("foo")).isLessThan(1);
-        assertThat(string.compareTo("foo")).isNotPositive();
-
-        assertThat(string.compareTo("foo")).isEqualTo(-1);
-        assertThat(string.compareTo("foo")).isLessThan(0);
-        assertThat(string.compareTo("foo")).isNegative();
-        assertThat(string.compareTo("foo")).isLessThanOrEqualTo(-1);
-
-        assertThat(string.compareTo("foo")).isNotEqualTo(2);
-        assertThat(string.compareTo("foo")).isEqualTo(2);
-
-        org.junit.Assert.assertThat(string, null);
-        fail("oh no!");
-    }
-}

src/test/resources/inspections/EnumerableIsEmpty/EnumerableIsEmptyAfter.java

@@ -16,32 +16,7 @@ public class EnumerableIsEmpty {
         assertThat(new ArrayList<Long>()).as("etc").hasSize(1);
         assertThat(new Long[1]).as("etc").hasSize(1);
 
-        assertThat("string").as("foo").isEmpty();
-        assertThat(new StringBuilder()).as("bar").isEmpty();
-        assertThat(new ArrayList<Long>()).as("etc").isEmpty();
-        assertThat(new Long[1]).as("etc").isEmpty();
-
-        assertThat("string").as("foo").isEmpty();
-        assertThat(new StringBuilder()).as("bar").isEmpty();
-        assertThat(new ArrayList<Long>()).as("etc").isEmpty();
-        assertThat(new Long[1]).as("etc").isEmpty();
-
-        assertThat("string").as("foo").isNotEmpty();
-        assertThat(new StringBuilder()).as("bar").isNotEmpty();
-        assertThat(new ArrayList<Long>()).as("etc").isNotEmpty();
-        assertThat(new Long[1]).as("etc").isNotEmpty();
-
-        assertThat("string").as("foo").isNotEmpty();
-        assertThat(new StringBuilder()).as("bar").isNotEmpty();
-        assertThat(new ArrayList<Long>()).as("etc").isNotEmpty();
-        assertThat(new Long[1]).as("etc").isNotEmpty();
-
         assertThat("string").as("foo").hasSize(0).hasSameSizeAs("foo").isEmpty();
-        assertThat("string").as("foo").hasSizeLessThanOrEqualTo(0).hasSameSizeAs("foo").isEmpty();
-        assertThat("string").as("foo").hasSizeLessThan(1).hasSameSizeAs("foo").isEmpty();
-
-        assertThat("string").as("foo").isNotEmpty().hasSameSizeAs("foo").isNotEmpty();
-        assertThat("string").as("foo").isNotEmpty().hasSameSizeAs("foo").isNotEmpty();
 
         org.junit.Assert.assertThat("foo", null);
         fail("oh no!");

src/test/resources/inspections/EnumerableIsEmpty/EnumerableIsEmptyBefore.java

@@ -16,32 +16,7 @@ public class EnumerableIsEmpty {
         assertThat(new ArrayList<Long>()).as("etc").hasSize(1);
         assertThat(new Long[1]).as("etc").hasSize(1);
 
-        assertThat("string").as("foo").hasSizeLessThanOrEqualTo(0);
-        assertThat(new StringBuilder()).as("bar").hasSizeLessThanOrEqualTo(0 + 0);
-        assertThat(new ArrayList<Long>()).as("etc").hasSizeLessThanOrEqualTo(10 / 100);
-        assertThat(new Long[1]).as("etc").hasSizeLessThanOrEqualTo(1 - 1);
-
-        assertThat("string").as("foo").hasSizeLessThan(1);
-        assertThat(new StringBuilder()).as("bar").hasSizeLessThan(0 + 1);
-        assertThat(new ArrayList<Long>()).as("etc").hasSizeLessThan(10 / 10);
-        assertThat(new Long[1]).as("etc").hasSizeLessThan(1 - 0);
-
-        assertThat("string").as("foo").hasSizeGreaterThan(0);
-        assertThat(new StringBuilder()).as("bar").hasSizeGreaterThan(0 + 0);
-        assertThat(new ArrayList<Long>()).as("etc").hasSizeGreaterThan(10 / 100);
-        assertThat(new Long[1]).as("etc").hasSizeGreaterThan(1 - 1);
-
-        assertThat("string").as("foo").hasSizeGreaterThanOrEqualTo(1);
-        assertThat(new StringBuilder()).as("bar").hasSizeGreaterThanOrEqualTo(0 + 1);
-        assertThat(new ArrayList<Long>()).as("etc").hasSizeGreaterThanOrEqualTo(10 / 10);
-        assertThat(new Long[1]).as("etc").hasSizeGreaterThanOrEqualTo(1 - 0);
-
         assertThat("string").as("foo").hasSize(0).hasSameSizeAs("foo").hasSize(0);
-        assertThat("string").as("foo").hasSizeLessThanOrEqualTo(0).hasSameSizeAs("foo").hasSizeLessThanOrEqualTo(0);
-        assertThat("string").as("foo").hasSizeLessThan(1).hasSameSizeAs("foo").hasSizeLessThan(1);
-
-        assertThat("string").as("foo").hasSizeGreaterThan(0).hasSameSizeAs("foo").hasSizeGreaterThan(0);
-        assertThat("string").as("foo").hasSizeGreaterThanOrEqualTo(1).hasSameSizeAs("foo").hasSizeGreaterThanOrEqualTo(1);
 
         org.junit.Assert.assertThat("foo", null);
         fail("oh no!");

src/test/resources/inspections/FileExpression/FileExpressionAfter.java

@@ -75,22 +75,11 @@ public class FileExpression {
         assertThat(file.getParentFile()).isNotEqualTo(null);
         assertThat(file.getParentFile()).isNotNull();
 
-        assertThat(file).isEmpty();
-        assertThat(file).isEmpty();
-        assertThat(file).isNotEmpty();
-        assertThat(file).isNotEmpty();
-        assertThat(file).hasSize(2);
-
         assertThat(file.listFiles()).isNull();
         assertThat(file.listFiles()).isNullOrEmpty();
         assertThat(file).isEmptyDirectory();
         assertThat(file).isNotEmptyDirectory();
 
-        assertThat(file.listFiles(f -> f.canExecute())).isNull();
-        assertThat(file.listFiles(f -> f.canExecute())).isNullOrEmpty();
-        assertThat(file.listFiles(f -> f.canExecute())).isEmpty();
-        assertThat(file.listFiles(f -> f.canExecute())).isNotEmpty();
-
         assertThat(file.list()).isNull();
         assertThat(file.list()).isNullOrEmpty();
         assertThat(file).isEmptyDirectory();

src/test/resources/inspections/FileExpression/FileExpressionBefore.java

@@ -75,22 +75,11 @@ public class FileExpression {
         assertThat(file.getParentFile()).isNotEqualTo(null);
         assertThat(file.getParentFile()).isNotNull();
 
-        assertThat(file.length()).isEqualTo(0);
-        assertThat(file.length()).isZero();
-        assertThat(file.length()).isNotEqualTo(0);
-        assertThat(file.length()).isNotZero();
-        assertThat(file.length()).isEqualTo(2);
-
         assertThat(file.listFiles()).isNull();
         assertThat(file.listFiles()).isNullOrEmpty();
         assertThat(file.listFiles()).isEmpty();
         assertThat(file.listFiles()).isNotEmpty();
 
-        assertThat(file.listFiles(f -> f.canExecute())).isNull();
-        assertThat(file.listFiles(f -> f.canExecute())).isNullOrEmpty();
-        assertThat(file.listFiles(f -> f.canExecute())).isEmpty();
-        assertThat(file.listFiles(f -> f.canExecute())).isNotEmpty();
-
         assertThat(file.list()).isNull();
         assertThat(file.list()).isNullOrEmpty();
         assertThat(file.list()).isEmpty();

src/test/resources/inspections/ImplicitAssertion/ImplicitAssertionAfter.java

@@ -153,7 +153,6 @@ public class ImplicitAssertion {
         assertThat(list).areAtMost(1, stringCondition);
         assertThat(list).areExactly(1, stringCondition);
         assertThat(list).hasOnlyOneElementSatisfying(stringConsumer);
-        assertThat(list).singleElement(as(STRING)).isEqualTo(stringConsumer);
         assertThat(list).haveAtLeastOne(stringCondition);
         assertThat(list).haveAtLeast(1, stringCondition);
         assertThat(list).haveAtMost(1, stringCondition);
@@ -230,7 +229,6 @@ public class ImplicitAssertion {
         assertThat(list).isNotEmpty().areAtMost(1, stringCondition);
         assertThat(list).isNotEmpty().areExactly(1, stringCondition);
         assertThat(list).isNotEmpty().hasOnlyOneElementSatisfying(stringConsumer);
-        assertThat(list).isNotEmpty().singleElement(as(STRING)).isEqualTo(stringConsumer);
         assertThat(list).haveAtLeastOne(stringCondition);
         assertThat(list).isNotEmpty().haveAtLeast(1, stringCondition);
         assertThat(list).isNotEmpty().haveAtMost(1, stringCondition);

src/test/resources/inspections/ImplicitAssertion/ImplicitAssertionBefore.java

@@ -153,7 +153,6 @@ public class ImplicitAssertion {
         assertThat(list).isNotNull().areAtMost(1, stringCondition);
         assertThat(list).isNotNull().areExactly(1, stringCondition);
         assertThat(list).isNotNull().hasOnlyOneElementSatisfying(stringConsumer);
-        assertThat(list).isNotNull().singleElement(as(STRING)).isEqualTo(stringConsumer);
         assertThat(list).isNotNull().haveAtLeastOne(stringCondition);
         assertThat(list).isNotNull().haveAtLeast(1, stringCondition);
         assertThat(list).isNotNull().haveAtMost(1, stringCondition);
@@ -230,7 +229,6 @@ public class ImplicitAssertion {
         assertThat(list).isNotEmpty().areAtMost(1, stringCondition);
         assertThat(list).isNotEmpty().areExactly(1, stringCondition);
         assertThat(list).isNotEmpty().hasOnlyOneElementSatisfying(stringConsumer);
-        assertThat(list).isNotEmpty().singleElement(as(STRING)).isEqualTo(stringConsumer);
         assertThat(list).isNotEmpty().haveAtLeastOne(stringCondition);
         assertThat(list).isNotEmpty().haveAtLeast(1, stringCondition);
         assertThat(list).isNotEmpty().haveAtMost(1, stringCondition);

src/test/resources/inspections/InvertedBooleanCondition/InvertedBooleanConditionAfter.java

@@ -3,7 +3,7 @@ import static org.assertj.core.api.Assertions.fail;
 
 public class InvertedBooleanCondition {
 
-    private void invertedBooleanCondition(boolean primitiveVariable, Boolean objectVariable) {
+    private void invertedBooleanCondition() {
         boolean primitive = false;
         Boolean object = Boolean.TRUE;
 
@@ -37,23 +37,6 @@ public class InvertedBooleanCondition {
         assertThat(primitive).as("foo").isFalse().as("bar").isFalse();
         assertThat(primitive).as("foo").isFalse().as("bar").isTrue();
 
-        assertThat(primitive).isNotEqualTo(primitiveVariable);
-        assertThat(primitive).isEqualTo(primitiveVariable);
-
-        assertThat(object).isNotEqualTo(primitiveVariable);
-        assertThat(object).isEqualTo(primitiveVariable);
-
-        assertThat(primitive).isEqualTo(!objectVariable); // not safe for null value
-        assertThat(primitive).isNotEqualTo(!objectVariable); // not safe for null value
-
-        assertThat(object).isEqualTo(!objectVariable); // not safe for null value
-        assertThat(object).isNotEqualTo(!objectVariable); // not safe for null value
-
-        assertThat(primitive).isNotEqualTo(primitiveVariable);
-        assertThat(primitive).isNotEqualTo(primitiveVariable);
-
-        assertThat(primitive).isEqualTo(!primitiveVariable && objectVariable);
-
         org.junit.Assert.assertThat(object, null);
         fail("oh no!");
     }

src/test/resources/inspections/InvertedBooleanCondition/InvertedBooleanConditionBefore.java

@@ -3,7 +3,7 @@ import static org.assertj.core.api.Assertions.fail;
 
 public class InvertedBooleanCondition {
 
-    private void invertedBooleanCondition(boolean primitiveVariable, Boolean objectVariable) {
+    private void invertedBooleanCondition() {
         boolean primitive = false;
         Boolean object = Boolean.TRUE;
 
@@ -37,23 +37,6 @@ public class InvertedBooleanCondition {
         assertThat(!primitive).as("foo").isEqualTo(Boolean.TRUE).as("bar").isNotEqualTo(false);
         assertThat(!primitive).as("foo").isEqualTo(Boolean.TRUE).as("bar").isNotEqualTo(true);
 
-        assertThat(primitive).isEqualTo(!primitiveVariable);
-        assertThat(primitive).isNotEqualTo(!primitiveVariable);
-
-        assertThat(object).isEqualTo(!primitiveVariable);
-        assertThat(object).isNotEqualTo(!primitiveVariable);
-
-        assertThat(primitive).isEqualTo(!objectVariable); // not safe for null value
-        assertThat(primitive).isNotEqualTo(!objectVariable); // not safe for null value
-
-        assertThat(object).isEqualTo(!objectVariable); // not safe for null value
-        assertThat(object).isNotEqualTo(!objectVariable); // not safe for null value
-
-        assertThat(primitive).isEqualTo((!primitiveVariable));
-        assertThat(primitive).isEqualTo(!(primitiveVariable));
-
-        assertThat(primitive).isEqualTo(!primitiveVariable && objectVariable);
-
         org.junit.Assert.assertThat(object, null);
         fail("oh no!");
     }