Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
eab50f590b | ||
|
|
66f1467b23 | ||
|
|
6a36294a2b | ||
|
|
0b79a6d7dc | ||
|
|
6fb23ea89c | ||
|
|
362c4210a5 | ||
|
|
e55acf9c74 | ||
|
|
3ece81b024 | ||
|
|
0b2ce470db | ||
|
|
941ddfdb5e | ||
|
|
666e373405 | ||
|
|
8b0da63f86 | ||
|
|
66508ceb2c | ||
|
|
db02f7fb93 | ||
|
|
a707eee9ad | ||
|
|
533c20906a | ||
|
|
da83f7f101 | ||
|
|
faeb509797 |
+10
@@ -0,0 +1,10 @@
|
||||
language: java
|
||||
jdk:
|
||||
- openjdk8
|
||||
|
||||
before_script:
|
||||
- chmod +x gradlew
|
||||
- chmod +x gradle/wrapper/gradle-wrapper.jar
|
||||
|
||||
script:
|
||||
- ./gradlew clean test jacocoTestReport coveralls
|
||||
@@ -1,15 +1,17 @@
|
||||
# Cajon - Concise AssertJ Optimizing Nitpicker
|
||||
# Cajon - Concise AssertJ Optimizing Nitpicker [](https://travis-ci.org/chrisly42/cajon-plugin) [](https://coveralls.io/github/chrisly42/cajon-plugin?branch=master)
|
||||
|
||||
Cajon is an IntelliJ IDEA Plugin for shortening and optimizing AssertJ assertions.
|
||||
Cajon is an IntelliJ IDEA Plugin for shortening and optimizing [AssertJ](https://assertj.github.io/doc/) assertions.
|
||||
|
||||
## Why?
|
||||
## Purpose
|
||||
|
||||
First, code is easier to read, when it is concise and reflects the intention clearly.
|
||||
AssertJ has plenty of different convenience methods that describing various intentions precisely.
|
||||
Why write longer, more complex code that can be expressed in brevity?
|
||||
|
||||
Second, AssertJ is able to output more meaningful descriptions when an assertion fails.
|
||||
Second, when using the available special assertion methods of AssertJ, a failure of a condition
|
||||
can be expressed in better detail and with more meaningful descriptions.
|
||||
This makes finding bugs and fixing failed tests more efficient.
|
||||
Nobody likes to read failures of the kind "failed because true is not false".
|
||||
|
||||
For example:
|
||||
|
||||
@@ -50,12 +52,44 @@ The plugin will report inspections in your opened editor file as warnings.
|
||||
You can then quick-fix these with your quick-fix hotkey (usually Alt-Return or Opt-Return).
|
||||
|
||||
Or, you can use the "Run Inspection by Name..." action to run one inspection on a bigger scope (e.g. the whole project).
|
||||
Applying a quick fix might result in further optimization possibilities, so
|
||||
you might need to perform a couple of fixes before you get to the final result.
|
||||
|
||||
Check out this example where every line represents the result after a Cajon quickfix:
|
||||
```
|
||||
assertFalse(!(array.length == collection.size()));
|
||||
|
||||
assertThat(!(array.length == collection.size())).isFalse();
|
||||
|
||||
assertThat(array.length == collection.size()).isTrue();
|
||||
|
||||
assertThat(array.length).isEqualTo(collection.size());
|
||||
|
||||
assertThat(array).hasSameSizeAs(collection);
|
||||
```
|
||||
|
||||
You can toggle the various inspections in the Settings/Editor/Inspections in the AssertJ group.
|
||||
|
||||
## Implemented inspections
|
||||
## Implemented inspections and quickfixes
|
||||
|
||||
- JoinAssertThatStatements
|
||||
|
||||
Joins multiple ```assertThat()``` statements with same actual expression together.
|
||||
|
||||
```
|
||||
from: assertThat(expected).someCondition();
|
||||
assertThat(expected).anotherCondition();
|
||||
to: assertThat(expected).someCondition().anotherCondition();
|
||||
```
|
||||
Joining will work on actual expressions inside assertThat() that are equivalent expressions,
|
||||
except for method calls with known side-effect methods such as ```Iterator.next()``` -- please notify me about others.
|
||||
|
||||
The comments of the statements will be preserved. When using ```.extracting()``` or similar, the statements will not be merged.
|
||||
|
||||
- AssertThatObjectIsNullOrNotNull
|
||||
|
||||
Uses ```isNull()``` and ```isNotNull()``` instead.
|
||||
|
||||
```
|
||||
from: assertThat(object).isEqualTo(null);
|
||||
to: assertThat(object).isNull();
|
||||
@@ -64,26 +98,91 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
to: assertThat(object).isNotNull();
|
||||
```
|
||||
|
||||
- AssertThatBooleanIsTrueOrFalse
|
||||
- AssertThatBooleanCondition
|
||||
|
||||
Uses ```isTrue()``` and ```isFalse()``` instead.
|
||||
|
||||
```
|
||||
from: assertThat(booleanValue).isEqualTo(true/false/Boolean.TRUE/Boolean.FALSE);
|
||||
to: assertThat(booleanValue).isTrue()/isFalse();
|
||||
```
|
||||
|
||||
- AssertThatInvertedBooleanCondition
|
||||
|
||||
Inverts the boolean condition to make it more readable.
|
||||
|
||||
```
|
||||
from: assertThat(!booleanValue).isEqualTo(true/false/Boolean.TRUE/Boolean.FALSE);
|
||||
from: assertThat(!booleanValue).isTrue()/isFalse();
|
||||
to: assertThat(booleanValue).isFalse()/isTrue();
|
||||
```
|
||||
|
||||
- AssertThatInstanceOf
|
||||
|
||||
Moves ```instanceof``` expressions out of ```assertThat()```.
|
||||
|
||||
```
|
||||
from: assertThat(object instanceof classname).isEqualTo(true);
|
||||
from: assertThat(object instanceof classname).isTrue();
|
||||
to: assertThat(object).isInstanceOf(classname.class);
|
||||
|
||||
from: assertThat(object instanceof classname).isEqualTo(false);
|
||||
from: assertThat(object instanceof classname).isFalse();
|
||||
to: assertThat(object).isNotInstanceOf(classname.class);
|
||||
```
|
||||
|
||||
- AssertThatStringIsEmpty
|
||||
|
||||
Uses ```isEmpty()``` for empty string assertions.
|
||||
|
||||
```
|
||||
from: assertThat(charSequence/string).isEqualTo("");
|
||||
from: assertThat(charSequence/string).hasSize(0);
|
||||
to: assertThat(charSequence/string).isEmpty();
|
||||
```
|
||||
|
||||
The ```assertThat(string.length()).isEqualTo(0);``` case is handled in the AssertThatSize inspection.
|
||||
|
||||
- AssertThatStringExpression
|
||||
|
||||
Moves string operations inside assertThat() out.
|
||||
|
||||
```
|
||||
from: assertThat(stringActual.isEmpty()).isTrue();
|
||||
to: assertThat(stringActual).isEmpty();
|
||||
|
||||
from: assertThat(stringActual.equals(stringExpected)).isTrue();
|
||||
from: assertThat(stringActual.contentEquals(charSeqExpected)).isTrue();
|
||||
to: assertThat(stringActual).isEqualTo(stringExpected);
|
||||
|
||||
from: assertThat(stringActual.equalsIgnoreCase(stringExpected)).isTrue();
|
||||
to: assertThat(stringActual).isEqualToIgnoringCase(stringExpected);
|
||||
|
||||
from: assertThat(stringActual.contains(stringExpected)).isTrue();
|
||||
to: assertThat(stringActual).contains(stringExpected);
|
||||
|
||||
from: assertThat(stringActual.startsWith(stringExpected)).isTrue();
|
||||
to: assertThat(stringActual).startsWith(stringExpected);
|
||||
|
||||
from: assertThat(stringActual.endsWith(stringExpected)).isTrue();
|
||||
to: assertThat(stringActual).endsWith(stringExpected);
|
||||
```
|
||||
Analogously with ```isFalse()```.
|
||||
|
||||
- AssertThatEnumerableIsEmpty
|
||||
|
||||
Uses ```isEmpty()``` for ```hasSize(0)``` iterable assertions instead.
|
||||
|
||||
```
|
||||
from: assertThat(enumerable).hasSize(0);
|
||||
to: assertThat(enumerable).isEmpty();
|
||||
```
|
||||
|
||||
- AssertThatSize
|
||||
|
||||
Makes assertions on sizes of arrays, collections, strings,
|
||||
or ```CharSequence```s more concise.
|
||||
|
||||
```
|
||||
from: assertThat(array.length).isEqualTo(0);
|
||||
from: assertThat(array.length).isLessThanOrEqualTo(0);
|
||||
@@ -98,9 +197,12 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
|
||||
from: assertThat(array.length).isEqualTo(anotherArray.length);
|
||||
to: assertThat(array).hasSameSizeAs(anotherArray);
|
||||
|
||||
from: assertThat(array).hasSize(anotherArray.length);
|
||||
to: assertThat(array).hasSameSizeAs(anotherArray);
|
||||
```
|
||||
|
||||
with AssertJ 13.2.0 or higher
|
||||
and additionally with AssertJ 13.2.0 or later
|
||||
|
||||
```
|
||||
from: assertThat(array.length).isLessThanOrEqualTo(expression);
|
||||
@@ -115,9 +217,23 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
from: assertThat(array.length).isGreaterThanOrEqualTo(expression);
|
||||
to: assertThat(array).hasSizeGreaterThanOrEqualTo(expression);
|
||||
```
|
||||
and analogously for collections...
|
||||
and analogously for collections, strings and CharSequences, e.g:
|
||||
|
||||
```
|
||||
from: assertThat("string".length()).isLessThan(1);
|
||||
to: assertThat("string").isEmpty();
|
||||
|
||||
from: assertThat("string".length()).isEqualTo(collection.size())
|
||||
to: assertThat("string").hasSameSizeAs(collection);
|
||||
|
||||
from: assertThat("string".length()).hasSize("strong".length())
|
||||
to: assertThat("string").hasSameSizeAs("strong");
|
||||
```
|
||||
|
||||
- AssertThatBinaryExpression
|
||||
|
||||
Splits a boolean condition represented by binary expression out of ```assertThat()```.
|
||||
|
||||
- AssertThatBinaryExpressionIsTrueOrFalse
|
||||
```
|
||||
from: assertThat(primActual == primExpected).isTrue();
|
||||
to: assertThat(primActual).isEqualTo(primExpected);
|
||||
@@ -130,10 +246,18 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
|
||||
from: assertThat(null == objActual).isFalse();
|
||||
to: assertThat(objActual).isNotNull();
|
||||
|
||||
from: assertThat(objActual.equals(objExpected).isTrue();
|
||||
to: assertThat(objActual).isEqualTo(objExpected);
|
||||
```
|
||||
...and many, many more combinations (more than 150).
|
||||
|
||||
- AssertThatJava8Optional
|
||||
|
||||
Examines the statement for Java 8 Optional type and whether the statement
|
||||
effectively tries to assert the presence, absence or content and then
|
||||
replaces the statement by better assertions.
|
||||
|
||||
```
|
||||
from: assertThat(opt.isPresent()).isEqualTo(true);
|
||||
from: assertThat(opt.isPresent()).isNotEqualTo(false);
|
||||
@@ -162,35 +286,12 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
to: assertThat(opt).isPresent();
|
||||
```
|
||||
|
||||
- JUnitAssertToAssertJ
|
||||
```
|
||||
assertTrue(condition);
|
||||
assertTrue(message, condition);
|
||||
assertFalse(condition);
|
||||
assertFalse(message, condition);
|
||||
assertNull(object);
|
||||
assertNull(message, object);
|
||||
assertNonNull(object);
|
||||
assertNonNull(message, object);
|
||||
assertEquals(expected, actual);
|
||||
assertEquals(message, expected, actual);
|
||||
assertEquals(expectedDoubleOrFloat, actualDoubleOrFloat, delta);
|
||||
assertEquals(message, expectedDoubleOrFloat, actualDoubleOrFloat, delta);
|
||||
assertNotEquals(unexpected, actual);
|
||||
assertNotEquals(message, unexpected, actual);
|
||||
assertNotEquals(unexpectedDoubleOrFloat, actualDoubleOrFloat, delta);
|
||||
assertNotEquals(message, unexpectedDoubleOrFloat, actualDoubleOrFloat, delta);
|
||||
assertSame(expected, actual);
|
||||
assertSame(message, expected, actual);
|
||||
assertNotSame(unexpected, actual);
|
||||
assertNotSame(message, unexpected, actual);
|
||||
assertArrayEquals(expected, actual);
|
||||
assertArrayEquals(message, expectedArray, actualArray);
|
||||
assertArrayEquals(expectedDoubleOrFloatArray, actualDoubleOrFloatArray, delta);
|
||||
assertArrayEquals(message, expectedDoubleOrFloatArray, actualDoubleOrFloatArray, delta);
|
||||
```
|
||||
|
||||
- AssertThatGuavaOptional
|
||||
|
||||
Examines the statement for Google Guava Optional type and whether the statement
|
||||
effectively tries to assert the presence, absence or content and then
|
||||
replaces the statement by better assertions.
|
||||
|
||||
```
|
||||
from: assertThat(opt.isPresent()).isEqualTo(true);
|
||||
from: assertThat(opt.isPresent()).isNotEqualTo(false);
|
||||
@@ -218,11 +319,86 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
|
||||
AssertJ for Guava needs to be available in the classpath.
|
||||
|
||||
- AssumeThatInsteadOfReturn
|
||||
|
||||
Tries to detect bogus uses of return statements in test methods and replaces them by ```assumeThat()``` calls.
|
||||
|
||||
Novices will use these to skip test execution by bailing out early on some preconditions not met.
|
||||
However, this suggests that the test has actually been run and passed instead of showing the test
|
||||
as being skipped.
|
||||
|
||||
Return statements in ```if``` statements in main test methods (must be annotated with JUnit 4 or
|
||||
Jupiter @Test annotations) will be verified to have at least one ```assertThat()``` statement in the code flow.
|
||||
Method calls within the same class will be examined for ```assertThat()``` statements, too.
|
||||
However, at most 50 statements and down to five recursions will be tolerated before giving up.
|
||||
|
||||
Currently, the quickfix may lose some comments during operation. The other branch of the ```if``` statement
|
||||
will be inlined (blocks with declarations will remain a code block due to variable scope).
|
||||
|
||||
The generated ```assumeThat()``` statement could be optimized further (similar to ```assertThat()```).
|
||||
|
||||
Example:
|
||||
|
||||
```
|
||||
@Test
|
||||
public void check_fuel_emission() {
|
||||
if (System.getProperty("manufacturer").equals("Volkswagen")) {
|
||||
return;
|
||||
}
|
||||
double nitroxppm = doWltpDrivingCycle();
|
||||
assertThat(nitroxppm).isLessThan(500.0);
|
||||
}
|
||||
```
|
||||
will be transformed to
|
||||
```
|
||||
@Test
|
||||
public void check_fuel_emission() {
|
||||
assumeThat(System.getProperty("manufacturer").equals("Volkswagen")).isFalse();
|
||||
double nitroxppm = doWltpDrivingCycle();
|
||||
assertThat(nitroxppm).isLessThan(500.0);
|
||||
}
|
||||
```
|
||||
|
||||
- JUnitAssertToAssertJ
|
||||
|
||||
Tries to convert most of the JUnit 4 assertions to AssertJ format.
|
||||
|
||||
Does not support Hamcrest-Matchers.
|
||||
If you need that kind of conversion, you might want to check out the
|
||||
[Assertions2AssertJ plugin](https://plugins.jetbrains.com/plugin/10345-assertions2assertj) by Ric Emery.
|
||||
|
||||
```
|
||||
assertTrue(condition);
|
||||
assertTrue(message, condition);
|
||||
assertFalse(condition);
|
||||
assertFalse(message, condition);
|
||||
assertNull(object);
|
||||
assertNull(message, object);
|
||||
assertNonNull(object);
|
||||
assertNonNull(message, object);
|
||||
assertEquals(expected, actual);
|
||||
assertEquals(message, expected, actual);
|
||||
assertEquals(expectedDoubleOrFloat, actualDoubleOrFloat, delta);
|
||||
assertEquals(message, expectedDoubleOrFloat, actualDoubleOrFloat, delta);
|
||||
assertNotEquals(unexpected, actual);
|
||||
assertNotEquals(message, unexpected, actual);
|
||||
assertNotEquals(unexpectedDoubleOrFloat, actualDoubleOrFloat, delta);
|
||||
assertNotEquals(message, unexpectedDoubleOrFloat, actualDoubleOrFloat, delta);
|
||||
assertSame(expected, actual);
|
||||
assertSame(message, expected, actual);
|
||||
assertNotSame(unexpected, actual);
|
||||
assertNotSame(message, unexpected, actual);
|
||||
assertArrayEquals(expected, actual);
|
||||
assertArrayEquals(message, expectedArray, actualArray);
|
||||
assertArrayEquals(expectedDoubleOrFloatArray, actualDoubleOrFloatArray, delta);
|
||||
assertArrayEquals(message, expectedDoubleOrFloatArray, actualDoubleOrFloatArray, delta);
|
||||
```
|
||||
|
||||
### Implemented referencing
|
||||
|
||||
```
|
||||
.extracting("field")
|
||||
.extracting("outerfield.fieldInsideObjectTypeOfOuterfield.andSoOn")
|
||||
.extracting("outerField.fieldInsideObjectTypeOfOuterField.andSoOn")
|
||||
.extracting("property") // where the class has a getProperty() (or isProperty() for boolean) method
|
||||
.extracting("bareMethod") // supported with AssertJ 13.12.0
|
||||
.extracting(Extractors.byName("fieldOrPropertyOrBareMethod")
|
||||
@@ -234,42 +410,54 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
.flatExtracting(Extractors.resultOf("bareMethod")
|
||||
```
|
||||
Works on both POJOs and ```Iterable```s/```Array```s.
|
||||
Implementation is very basic though and does not work with fancy cascaded .extracting() sequences.
|
||||
If there's demand, I will add it.
|
||||
|
||||
## Development notice
|
||||
|
||||
Cajon is written in Kotlin 1.3.
|
||||
|
||||
Cajon is probably the only plugin that uses JUnit 5 Jupiter for unit testing so far (or at least the only one that I'm aware of ;) ).
|
||||
The IntelliJ framework actually uses the JUnit 3 TestCase for plugin testing and I took me quite a while to make it work with JUnit 5.
|
||||
The IntelliJ framework actually uses the JUnit 3 TestCase for plugin testing and it took me quite a while to make it work with JUnit 5.
|
||||
Feel free to use the code (in package de.platon42.intellij.jupiter) for your projects (with attribution).
|
||||
|
||||
## TODO
|
||||
- AssertThatNegatedBooleanExpression
|
||||
- AssertThatInstanceOf
|
||||
- AssertThatStringOps
|
||||
```
|
||||
from: assertThat(string.contains(foobar)).isTrue();
|
||||
to: assertThat(string).contains(foobar);
|
||||
from: assertThat(string.startsWith(foobar)).isTrue();
|
||||
to: assertThat(string).startsWith(foobar);
|
||||
from: assertThat(string.endsWith(foobar)).isTrue();
|
||||
to: assertThat(string).endsWith(foobar);
|
||||
from: assertThat(string.equalsIgnoreCase(foobar)).isTrue();
|
||||
to: assertThat(string).isEqualToIgnoringCase(foobar);
|
||||
```
|
||||
Analogously with ```isFalse()```.
|
||||
|
||||
- AssumeInsteadOfReturn
|
||||
## Planned features
|
||||
- Extraction with property names to lambda with Java 8
|
||||
```
|
||||
from: assertThat(object).extracting("propOne", "propNoGetter", "propTwo.innerProp")...
|
||||
to: assertThat(object).extracting(type::getPropOne, it -> it.propNoGetter, it -> it.getPropTwo().getInnerProp())...
|
||||
```
|
||||
- Kotlin support
|
||||
|
||||
- Kotlin support (right now, however, with less than 100 downloads after a month, this is unlikely to happen)
|
||||
|
||||
## Changelog
|
||||
|
||||
#### V0.5 (13-Apr-19)
|
||||
#### V0.8 (05-May-19)
|
||||
- Fixed missing description for JoinAssertThatStatements and detection of equivalent expressions (sorry, released it too hastily).
|
||||
- Fixed ```isEmpty()``` for enumerables and strings and ```isNull()``` for object conversions to be applied only if it is the terminal method call as ```isEmpty()``` and ```isNull()``` return void.
|
||||
- Heavily reworked inspections for edge cases, such as multiple ```isEqualTo()``` calls inside a single statement.
|
||||
- Some inspections could generate bogus code for weird situations, this has been made more fool-proof.
|
||||
- Corrected highlighting for many inspections.
|
||||
- Fixed family names for inspections in batch mode.
|
||||
- Reworded many inspection messages for better understanding.
|
||||
- Added a first version of a new inspection that tries to detect bogus uses of return statements in test methods and replaces them by ```assumeThat()``` calls.
|
||||
|
||||
#### V0.7 (28-Apr-19)
|
||||
- Another fix for AssertThatGuavaOptional inspection regarding using the same family name for slightly different quick fix executions
|
||||
(really, Jetbrains, this sucks for no reason).
|
||||
- Extended AssertThatSize inspection to transform ```hasSize()``` into ```hasSameSizeAs()```, if possible.
|
||||
- Implemented first version of JoinAssertThatStatements inspection that will try to merge ```assertThat()``` statements with the same
|
||||
actual object together, preserving comments.
|
||||
|
||||
#### V0.6 (22-Apr-19)
|
||||
- New AssertThatStringExpression inspection that will move ```isEmpty()```, ```equals()```, ```equalsIgnoreCase()```, ```contains()```,
|
||||
```startsWith()```, and ```endsWith()``` out of actual expression.
|
||||
- Extended AssertThatSize inspection to take ```String```s and ```CharSequences``` into account, too.
|
||||
- New AssertThatInvertedBooleanCondition inspection that will remove inverted boolean expressions inside ```assertThat()```.
|
||||
- Renamed a few inspections to better/shorter names.
|
||||
- New AssertThatInstanceOf inspection that moves instanceof expressions out of ```assertThat()```.
|
||||
|
||||
#### V0.5 (18-Apr-19)
|
||||
- Fixed incompatibility with IDEA versions < 2018.2 (affected AssertThatSizeInspection). Minimal version is now 2017.3.
|
||||
- Fixed missing Guava imports (if not already present) for AssertThatGuavaInspection. This was a major PITA to get right.
|
||||
- Added support for referencing and refactoring inside ```.extracting()``` methods with fields, properties and methods (though
|
||||
|
||||
+36
-26
@@ -1,11 +1,13 @@
|
||||
plugins {
|
||||
id 'java'
|
||||
id 'org.jetbrains.intellij' version '0.4.3'
|
||||
id 'org.jetbrains.kotlin.jvm' version '1.3.30'
|
||||
id 'org.jetbrains.intellij' version '0.4.8'
|
||||
id 'org.jetbrains.kotlin.jvm' version '1.3.31'
|
||||
id 'jacoco'
|
||||
id 'com.github.kt3k.coveralls' version '2.8.2'
|
||||
}
|
||||
|
||||
group 'de.platon42'
|
||||
version '0.5'
|
||||
version '0.8'
|
||||
|
||||
repositories {
|
||||
mavenCentral()
|
||||
@@ -33,44 +35,52 @@ compileTestKotlin {
|
||||
kotlinOptions.jvmTarget = "1.8"
|
||||
}
|
||||
intellij {
|
||||
version '2019.1'
|
||||
version '2019.1.1'
|
||||
// pluginName 'Concise AssertJ Optimizing Nitpicker (Cajon)'
|
||||
updateSinceUntilBuild false
|
||||
}
|
||||
|
||||
patchPluginXml {
|
||||
changeNotes """
|
||||
<h4>V0.5 (18-Apr-19)</h4>
|
||||
<h4>V0.8 (05-May-19)</h4>
|
||||
<ul>
|
||||
<li>Fixed incompatibility with IDEA versions < 2018.2 (affected AssertThatSizeInspection). Minimal version is now 2017.3.
|
||||
<li>Fixed missing Guava imports (if not already present) for AssertThatGuavaInspection. This was a major PITA to get right.
|
||||
<li>Added support for referencing and refactoring inside .extracting() methods with fields, properties and methods (though
|
||||
getter renaming does not work that perfect, but I'm giving up for now as the IntelliJ SDK docs are seriously lacking).
|
||||
<li>Fixed an exception in batch mode if the description string was the same but for different fixes.
|
||||
Now descriptions are different for quick fixes triggered by AssertThatJava8OptionalInspection and AssertThatGuavaOptionalInspection.
|
||||
<li>Fixed missing description for JoinAssertThatStatements and detection of equivalent expressions (sorry, released it too hastily).
|
||||
<li>Fixed isEmpty() for enumerables and strings and isNull() for object conversions to be applied only if it is the terminal method call as isEmpty() and isNull() return void.
|
||||
<li>Heavily reworked inspections for edge cases, such as multiple isEqualTo() calls inside a single statement.
|
||||
<li>Some inspections could generate bogus code for weird situations, this has been made more fool-proof.
|
||||
<li>Corrected highlighting for many inspections.
|
||||
<li>Fixed family names for inspections in batch mode.
|
||||
<li>Reworded many inspection messages for better understanding.
|
||||
<li>Added a first version of a new inspection that tries to detect bogus uses of return statements in test methods and replaces them by assumeThat() calls.
|
||||
</ul>
|
||||
<h4>V0.4 (11-Apr-19)</h4>
|
||||
<h4>V0.7 (28-Apr-19)</h4>
|
||||
<ul>
|
||||
<li>Reduced minimal supported IDEA version from 2018.2 to 2017.2.
|
||||
<li>New inspection AssertThatJava8Optional that operates on Java 8 Optional objects and tries to use contains(), containsSame(), isPresent(), and isNotPresent() instead.
|
||||
<li>New inspection AssertThatGuavaOptional that operates on Guava Optional objects and tries to use contains(), isPresent(), and isAbsent() instead.
|
||||
<li>Added support in AssertThatBinaryExpressionIsTrueOrFalse for is(Not)EqualTo(Boolean.TRUE/FALSE).
|
||||
</ul>
|
||||
<h4>V0.3 (07-Apr-19)</h4>
|
||||
<ul>
|
||||
<li>New inspection AssertThatBinaryExpressionIsTrueOrFalse that will find and fix common binary expressions and equals() statements (more than 150 combinations) inside assertThat().
|
||||
<li>Merged AssertThatObjectIsNull and AssertThatObjectIsNotNull to AssertThatObjectIsNullOrNotNull.
|
||||
<li>Support for hasSizeLessThan(), hasSizeLessThanOrEqualTo(), hasSizeGreaterThanOrEqualTo(), and hasSizeGreaterThan() for AssertThatSizeInspection (with AssertJ >=13.2.0).
|
||||
<li>Really fixed highlighting for JUnit conversion. Sorry.
|
||||
<li>Another fix for AssertThatGuavaOptional inspection regarding using the same family name for slightly different quick fix executions
|
||||
(really, Jetbrains, this sucks for no reason).
|
||||
<li>Extended AssertThatSize inspection to transform hasSize() into hasSameSizeAs(), if possible.
|
||||
<li>Implemented first version of JoinAssertThatStatements inspection that will try to merge assertThat() statements with the same
|
||||
actual object together, preserving comments.
|
||||
</ul>
|
||||
<p>Full changelog available at <a href="https://github.com/chrisly42/cajon-plugin#changelog">Github project site</a>.</p>
|
||||
"""
|
||||
}
|
||||
|
||||
test {
|
||||
useJUnitPlatform()
|
||||
// testLogging {
|
||||
// events "passed", "skipped", "failed"
|
||||
// }
|
||||
testLogging {
|
||||
events "passed", "skipped", "failed"
|
||||
}
|
||||
}
|
||||
|
||||
jacoco {
|
||||
toolVersion = '0.8.3'
|
||||
}
|
||||
|
||||
jacocoTestReport {
|
||||
reports {
|
||||
xml.enabled true
|
||||
csv.enabled false
|
||||
}
|
||||
}
|
||||
|
||||
publishPlugin {
|
||||
|
||||
@@ -7,6 +7,16 @@ class AssertJClassNames {
|
||||
@NonNls
|
||||
const val ASSERTIONS_CLASSNAME = "org.assertj.core.api.Assertions"
|
||||
|
||||
@NonNls
|
||||
const val ASSUMPTIONS_CLASSNAME = "org.assertj.core.api.Assumptions"
|
||||
|
||||
@NonNls
|
||||
const val DESCRIPTABLE_INTERFACE = "org.assertj.core.api.Descriptable"
|
||||
@NonNls
|
||||
const val EXTENSION_POINTS_INTERFACE = "org.assertj.core.api.ExtensionPoints"
|
||||
|
||||
@NonNls
|
||||
const val ASSERT_INTERFACE = "org.assertj.core.api.Assert"
|
||||
@NonNls
|
||||
const val ABSTRACT_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractAssert"
|
||||
@NonNls
|
||||
@@ -32,7 +42,5 @@ class AssertJClassNames {
|
||||
const val GUAVA_OPTIONAL_CLASSNAME = "com.google.common.base.Optional"
|
||||
@NonNls
|
||||
const val GUAVA_ASSERTIONS_CLASSNAME = "org.assertj.guava.api.Assertions"
|
||||
@NonNls
|
||||
const val GUAVA_OPTIONAL_ASSERT_CLASSNAME = "org.assertj.guava.api.OptionalAssert"
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,38 @@
|
||||
package de.platon42.intellij.plugins.cajon
|
||||
|
||||
import com.intellij.psi.CommonClassNames
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
|
||||
val CORE_ASSERT_THAT_MATCHER = CallMatcher.staticCall(AssertJClassNames.ASSERTIONS_CLASSNAME, MethodNames.ASSERT_THAT)!!
|
||||
val GUAVA_ASSERT_THAT_MATCHER = CallMatcher.staticCall(AssertJClassNames.GUAVA_ASSERTIONS_CLASSNAME, MethodNames.ASSERT_THAT)!!
|
||||
val ALL_ASSERT_THAT_MATCHERS = CallMatcher.anyOf(CORE_ASSERT_THAT_MATCHER, GUAVA_ASSERT_THAT_MATCHER)!!
|
||||
|
||||
val EXTRACTING_FROM_OBJECT = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_OBJECT_ASSERT_CLASSNAME, "extracting")!!
|
||||
val EXTRACTING_FROM_ITERABLE = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_ITERABLE_ASSERT_CLASSNAME, "extracting")!!
|
||||
val FLAT_EXTRACTING_FROM_ITERABLE = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_ITERABLE_ASSERT_CLASSNAME, "flatExtracting")!!
|
||||
val EXTRACTING_RESULT_OF_FROM_ITERABLE = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_ITERABLE_ASSERT_CLASSNAME, "extractingResultOf")!!
|
||||
|
||||
val EXTRACTING_CALL_MATCHERS = CallMatcher.anyOf(
|
||||
EXTRACTING_FROM_OBJECT,
|
||||
EXTRACTING_FROM_ITERABLE,
|
||||
FLAT_EXTRACTING_FROM_ITERABLE,
|
||||
EXTRACTING_RESULT_OF_FROM_ITERABLE
|
||||
)!!
|
||||
|
||||
val DESCRIBED_AS = CallMatcher.instanceCall(AssertJClassNames.DESCRIPTABLE_INTERFACE, MethodNames.DESCRIBED_AS, MethodNames.AS)!!
|
||||
val WITH_REPRESENTATION_AND_SUCH = CallMatcher.instanceCall(AssertJClassNames.ASSERT_INTERFACE, "withRepresentation", "withThreadDumpOnError")!!
|
||||
val USING_COMPARATOR = CallMatcher.instanceCall(AssertJClassNames.ASSERT_INTERFACE, "usingComparator", "usingDefaultComparator")!!
|
||||
val IN_HEXADECIMAL_OR_BINARY = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_ASSERT_CLASSNAME, MethodNames.IN_HEXADECIMAL, MethodNames.IN_BINARY)!!
|
||||
val EXTENSION_POINTS = CallMatcher.instanceCall(AssertJClassNames.EXTENSION_POINTS_INTERFACE, "is", "isNot", "has", "doesNotHave", "satisfies")!!
|
||||
|
||||
val NOT_ACTUAL_ASSERTIONS = CallMatcher.anyOf(
|
||||
ALL_ASSERT_THAT_MATCHERS,
|
||||
DESCRIBED_AS,
|
||||
WITH_REPRESENTATION_AND_SUCH,
|
||||
USING_COMPARATOR,
|
||||
IN_HEXADECIMAL_OR_BINARY
|
||||
)!!
|
||||
|
||||
val KNOWN_METHODS_WITH_SIDE_EFFECTS = CallMatcher.anyOf(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_ITERATOR, "next")
|
||||
)!!
|
||||
@@ -1,39 +1,76 @@
|
||||
package de.platon42.intellij.plugins.cajon
|
||||
|
||||
import com.intellij.lang.jvm.JvmModifier
|
||||
import com.intellij.psi.*
|
||||
import com.intellij.psi.codeStyle.CodeStyleManager
|
||||
import com.intellij.psi.codeStyle.JavaCodeStyleManager
|
||||
import com.intellij.psi.util.PsiTreeUtil
|
||||
import com.intellij.psi.util.PsiUtil
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.inspections.AbstractAssertJInspection
|
||||
|
||||
val PsiMethodCallExpression.qualifierExpression: PsiExpression get() = this.methodExpression.qualifierExpression!!
|
||||
val PsiMethodCallExpression.firstArg: PsiExpression get() = this.argumentList.expressions[0]!!
|
||||
val PsiMethodCallExpression.qualifierExpression: PsiExpression get() = methodExpression.qualifierExpression!!
|
||||
val PsiMethodCallExpression.firstArg: PsiExpression get() = getArg(0)
|
||||
|
||||
fun PsiElement.hasAssertThat(): Boolean {
|
||||
val elementText = text
|
||||
return elementText.startsWith("${MethodNames.ASSERT_THAT}(") || elementText.contains(".${MethodNames.ASSERT_THAT}(")
|
||||
}
|
||||
|
||||
fun PsiMethodCallExpression.replaceQualifier(qualifier: PsiElement) {
|
||||
this.qualifierExpression.replace(qualifier)
|
||||
qualifierExpression.replace(qualifier)
|
||||
}
|
||||
|
||||
fun PsiMethodCallExpression.replaceQualifierFromMethodCall(oldMethodCall: PsiMethodCallExpression) {
|
||||
this.qualifierExpression.replace(oldMethodCall.qualifierExpression)
|
||||
qualifierExpression.replace(oldMethodCall.qualifierExpression)
|
||||
}
|
||||
|
||||
fun PsiElement.findOutmostMethodCall(): PsiMethodCallExpression? {
|
||||
val statement = PsiTreeUtil.getParentOfType(this, PsiStatement::class.java) ?: return null
|
||||
val statement = PsiTreeUtil.getParentOfType(this, PsiStatement::class.java, false) ?: return null
|
||||
return PsiTreeUtil.findChildOfType(statement, PsiMethodCallExpression::class.java)
|
||||
}
|
||||
|
||||
fun PsiMethodCallExpression.getArg(n: Int): PsiExpression = this.argumentList.expressions[n]
|
||||
fun PsiElement.findStaticMethodCall(): PsiMethodCallExpression? {
|
||||
var elem: PsiElement? = this
|
||||
while (elem != null) {
|
||||
if ((elem is PsiMethodCallExpression) && (elem.resolveMethod()?.hasModifier(JvmModifier.STATIC) == true)) {
|
||||
return elem
|
||||
}
|
||||
elem = elem.firstChild
|
||||
}
|
||||
return null
|
||||
}
|
||||
|
||||
fun PsiElement.gatherAssertionCalls(): List<PsiMethodCallExpression> {
|
||||
val assertThatMethodCall = findStaticMethodCall() ?: return emptyList()
|
||||
return assertThatMethodCall.collectMethodCallsUpToStatement()
|
||||
.filterNot { NOT_ACTUAL_ASSERTIONS.test(it) }
|
||||
.toList()
|
||||
}
|
||||
|
||||
fun PsiMethodCallExpression.collectMethodCallsUpToStatement(): Sequence<PsiMethodCallExpression> {
|
||||
return generateSequence(this) { PsiTreeUtil.getParentOfType(it, PsiMethodCallExpression::class.java, true, PsiStatement::class.java) }
|
||||
}
|
||||
|
||||
fun PsiMethodCallExpression.findFluentCallTo(matcher: CallMatcher): PsiMethodCallExpression? {
|
||||
return collectMethodCallsUpToStatement().find { matcher.test(it) }
|
||||
}
|
||||
|
||||
fun PsiMethodCallExpression.getArg(n: Int): PsiExpression = PsiUtil.skipParenthesizedExprDown(argumentList.expressions[n])!!
|
||||
|
||||
fun PsiMethodCallExpression.getArgOrNull(n: Int): PsiExpression? = argumentList.expressions.getOrNull(n)
|
||||
|
||||
fun <T> Boolean.map(forTrue: T, forFalse: T) = if (this) forTrue else forFalse
|
||||
|
||||
fun PsiMethod.addAsStaticImport(context: PsiElement, vararg allowedClashes: String) {
|
||||
val factory = JavaPsiFacade.getElementFactory(context.project)
|
||||
val methodName = this.name
|
||||
val containingClass = this.containingClass ?: return
|
||||
val methodName = name
|
||||
val containingClass = containingClass ?: return
|
||||
val importList = (context.containingFile as PsiJavaFile).importList ?: return
|
||||
val notImportedStatically = importList.importStaticStatements.none {
|
||||
val targetClass = it.resolveTargetClass() ?: return@none false
|
||||
((it.referenceName == methodName) && !allowedClashes.contains(targetClass.qualifiedName))
|
||||
|| (it.isOnDemand && (targetClass == this.containingClass))
|
||||
|| (it.isOnDemand && (targetClass == containingClass))
|
||||
}
|
||||
if (notImportedStatically) {
|
||||
importList.add(factory.createImportStaticStatement(containingClass, methodName))
|
||||
@@ -45,3 +82,66 @@ fun PsiElement.shortenAndReformat() {
|
||||
codeStyleManager.shortenClassReferences(this)
|
||||
CodeStyleManager.getInstance(project).reformat(this)
|
||||
}
|
||||
|
||||
fun PsiMethodCallExpression.getExpectedBooleanResult(): Boolean? {
|
||||
val isTrue = AbstractAssertJInspection.IS_TRUE.test(this)
|
||||
val isFalse = AbstractAssertJInspection.IS_FALSE.test(this)
|
||||
if (isTrue || isFalse) {
|
||||
return isTrue
|
||||
} else {
|
||||
val isEqualTo = AbstractAssertJInspection.IS_EQUAL_TO_BOOLEAN.test(this) || AbstractAssertJInspection.IS_EQUAL_TO_OBJECT.test(this)
|
||||
val isNotEqualTo =
|
||||
AbstractAssertJInspection.IS_NOT_EQUAL_TO_BOOLEAN.test(this) || AbstractAssertJInspection.IS_NOT_EQUAL_TO_OBJECT.test(this)
|
||||
if (isEqualTo || isNotEqualTo) {
|
||||
val constValue = calculateConstantParameterValue(0) as? Boolean ?: return null
|
||||
return isNotEqualTo xor constValue
|
||||
}
|
||||
}
|
||||
return null
|
||||
}
|
||||
|
||||
fun PsiMethodCallExpression.calculateConstantParameterValue(argIndex: Int): Any? {
|
||||
if (argIndex >= argumentList.expressions.size) return null
|
||||
val valueExpression = getArg(argIndex)
|
||||
val constantEvaluationHelper = JavaPsiFacade.getInstance(project).constantEvaluationHelper
|
||||
val value = constantEvaluationHelper.computeConstantExpression(valueExpression)
|
||||
if (value == null) {
|
||||
val field = (valueExpression as? PsiReferenceExpression)?.resolve() as? PsiField
|
||||
if (field?.containingClass?.qualifiedName == CommonClassNames.JAVA_LANG_BOOLEAN) {
|
||||
return when (field.name) {
|
||||
"TRUE" -> true
|
||||
"FALSE" -> false
|
||||
else -> null
|
||||
}
|
||||
}
|
||||
}
|
||||
return value
|
||||
}
|
||||
|
||||
fun PsiExpression.getAllTheSameExpectedBooleanConstants(): Boolean? {
|
||||
val assertThatMethodCall = findStaticMethodCall() ?: return null
|
||||
var lockedResult: Boolean? = null
|
||||
val methodsToView = generateSequence(assertThatMethodCall) { PsiTreeUtil.getParentOfType(it, PsiMethodCallExpression::class.java) }
|
||||
|
||||
for (methodCall in methodsToView) {
|
||||
val expectedResult = methodCall.getExpectedBooleanResult()
|
||||
if (expectedResult != null) {
|
||||
if ((lockedResult != null) && (lockedResult != expectedResult)) {
|
||||
return null
|
||||
}
|
||||
lockedResult = expectedResult
|
||||
} else {
|
||||
val isNotConstant = CallMatcher.anyOf(
|
||||
EXTENSION_POINTS,
|
||||
AbstractAssertJInspection.IS_EQUAL_TO_BOOLEAN,
|
||||
AbstractAssertJInspection.IS_EQUAL_TO_OBJECT,
|
||||
AbstractAssertJInspection.IS_NOT_EQUAL_TO_BOOLEAN,
|
||||
AbstractAssertJInspection.IS_NOT_EQUAL_TO_OBJECT
|
||||
).test(methodCall)
|
||||
if (isNotConstant) {
|
||||
return null
|
||||
}
|
||||
}
|
||||
}
|
||||
return lockedResult
|
||||
}
|
||||
@@ -4,9 +4,7 @@ import com.intellij.psi.JavaPsiFacade
|
||||
import com.intellij.psi.PsiElement
|
||||
import com.intellij.psi.PsiExpression
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
|
||||
val CORE_ASSERT_THAT_MATCHER = CallMatcher.staticCall(AssertJClassNames.ASSERTIONS_CLASSNAME, MethodNames.ASSERT_THAT)!!
|
||||
import com.intellij.psi.search.GlobalSearchScope
|
||||
|
||||
fun createAssertThat(context: PsiElement, actualExpression: PsiExpression): PsiMethodCallExpression {
|
||||
return createAssertThat(context, AssertJClassNames.ASSERTIONS_CLASSNAME, actualExpression)
|
||||
@@ -33,3 +31,10 @@ fun createMethodCall(context: PsiElement, fullQualifiedMethodName: String, varar
|
||||
arguments.forEachIndexed { index, newArg -> expectedExpression.getArg(index).replace(newArg) }
|
||||
return expectedExpression
|
||||
}
|
||||
|
||||
fun hasAssertJMethod(element: PsiElement, classname: String, methodname: String): Boolean {
|
||||
val findClass =
|
||||
JavaPsiFacade.getInstance(element.project).findClass(classname, GlobalSearchScope.allScope(element.project))
|
||||
?: return false
|
||||
return findClass.allMethods.any { it.name == methodname }
|
||||
}
|
||||
@@ -11,8 +11,19 @@ class MethodNames {
|
||||
|
||||
@NonNls
|
||||
const val ASSERT_THAT = "assertThat"
|
||||
|
||||
@NonNls
|
||||
const val ASSUME_THAT = "assumeThat"
|
||||
|
||||
@NonNls
|
||||
const val AS = "as"
|
||||
@NonNls
|
||||
const val DESCRIBED_AS = "describedAs"
|
||||
@NonNls
|
||||
const val IN_HEXADECIMAL = "inHexadecimal"
|
||||
@NonNls
|
||||
const val IN_BINARY = "inBinary"
|
||||
|
||||
@NonNls
|
||||
const val IS_EQUAL_TO = "isEqualTo"
|
||||
@NonNls
|
||||
@@ -38,16 +49,20 @@ class MethodNames {
|
||||
@NonNls
|
||||
const val IS_FALSE = "isFalse"
|
||||
@NonNls
|
||||
const val IS_NULL = "isNull"
|
||||
const val IS_NULL = "isNull" // terminal, returns void
|
||||
@NonNls
|
||||
const val IS_NOT_NULL = "isNotNull"
|
||||
@NonNls
|
||||
const val IS_CLOSE_TO = "isCloseTo"
|
||||
@NonNls
|
||||
const val IS_NOT_CLOSE_TO = "isNotCloseTo"
|
||||
@NonNls
|
||||
const val IS_INSTANCE_OF = "isInstanceOf"
|
||||
@NonNls
|
||||
const val IS_NOT_INSTANCE_OF = "isNotInstanceOf"
|
||||
|
||||
@NonNls
|
||||
const val IS_EMPTY = "isEmpty"
|
||||
const val IS_EMPTY = "isEmpty" // terminal, returns void
|
||||
@NonNls
|
||||
const val IS_NOT_EMPTY = "isNotEmpty"
|
||||
@NonNls
|
||||
@@ -65,8 +80,22 @@ class MethodNames {
|
||||
@NonNls
|
||||
const val CONTAINS = "contains"
|
||||
@NonNls
|
||||
const val DOES_NOT_CONTAIN = "doesNotContain"
|
||||
@NonNls
|
||||
const val CONTAINS_EXACTLY = "containsExactly"
|
||||
@NonNls
|
||||
const val IS_EQUAL_TO_IC = "isEqualToIgnoringCase"
|
||||
@NonNls
|
||||
const val IS_NOT_EQUAL_TO_IC = "isNotEqualToIgnoringCase"
|
||||
@NonNls
|
||||
const val STARTS_WITH = "startsWith"
|
||||
@NonNls
|
||||
const val ENDS_WITH = "endsWith"
|
||||
@NonNls
|
||||
const val DOES_NOT_START_WITH = "doesNotStartWith"
|
||||
@NonNls
|
||||
const val DOES_NOT_END_WITH = "doesNotEndWith"
|
||||
@NonNls
|
||||
const val CONTAINS_SAME = "containsSame"
|
||||
@NonNls
|
||||
const val IS_PRESENT = "isPresent"
|
||||
|
||||
+36
-67
@@ -3,6 +3,7 @@ package de.platon42.intellij.plugins.cajon.inspections
|
||||
import com.intellij.codeInspection.AbstractBaseJavaLocalInspectionTool
|
||||
import com.intellij.codeInspection.LocalQuickFix
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.openapi.util.TextRange
|
||||
import com.intellij.psi.*
|
||||
import com.intellij.psi.search.GlobalSearchScope
|
||||
import com.intellij.psi.tree.IElementType
|
||||
@@ -14,10 +15,10 @@ import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_C
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_ENUMERABLE_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_INTEGER_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ASSERTIONS_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ASSERT_INTERFACE
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.GUAVA_ASSERTIONS_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.GUAVA_OPTIONAL_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.MethodNames
|
||||
import de.platon42.intellij.plugins.cajon.getArg
|
||||
import de.platon42.intellij.plugins.cajon.qualifierExpression
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.ReplaceSimpleMethodCallQuickFix
|
||||
|
||||
@@ -29,7 +30,8 @@ open class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
|
||||
const val REPLACE_DESCRIPTION_TEMPLATE = "Replace %s() with %s()"
|
||||
const val REMOVE_EXPECTED_OUTMOST_DESCRIPTION_TEMPLATE = "Unwrap expected expression and replace %s() with %s()"
|
||||
const val REMOVE_ACTUAL_OUTMOST_DESCRIPTION_TEMPLATE = "Unwrap actual expression and replace %s() with %s()"
|
||||
const val MOVE_ACTUAL_EXPRESSION_DESCRIPTION_TEMPLATE = "Remove %s() of actual expression and use assertThat().%s() instead"
|
||||
const val MOVING_OUT_MESSAGE_TEMPLATE = "Moving %s() expression out of assertThat() would be more concise"
|
||||
|
||||
val TOKEN_TO_ASSERTJ_FOR_PRIMITIVE_MAP = mapOf<IElementType, String>(
|
||||
JavaTokenType.EQEQ to MethodNames.IS_EQUAL_TO,
|
||||
@@ -74,21 +76,21 @@ open class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
val ASSERT_THAT_JAVA8_OPTIONAL = CallMatcher.staticCall(ASSERTIONS_CLASSNAME, MethodNames.ASSERT_THAT)
|
||||
.parameterTypes(CommonClassNames.JAVA_UTIL_OPTIONAL)!!
|
||||
|
||||
val ASSERT_THAT_GUAVA_OPTIONAL = CallMatcher.staticCall(GUAVA_ASSERTIONS_CLASSNAME, MethodNames.ASSERT_THAT)
|
||||
.parameterTypes(GUAVA_OPTIONAL_CLASSNAME)!!
|
||||
val GUAVA_ASSERT_THAT_ANY = CallMatcher.staticCall(GUAVA_ASSERTIONS_CLASSNAME, MethodNames.ASSERT_THAT)
|
||||
.parameterCount(1)!!
|
||||
|
||||
val IS_EQUAL_TO_OBJECT = CallMatcher.instanceCall(ABSTRACT_ASSERT_CLASSNAME, MethodNames.IS_EQUAL_TO)
|
||||
val IS_EQUAL_TO_OBJECT = CallMatcher.instanceCall(ASSERT_INTERFACE, MethodNames.IS_EQUAL_TO)
|
||||
.parameterTypes(CommonClassNames.JAVA_LANG_OBJECT)!!
|
||||
val IS_NOT_EQUAL_TO_OBJECT = CallMatcher.instanceCall(ABSTRACT_ASSERT_CLASSNAME, MethodNames.IS_NOT_EQUAL_TO)
|
||||
val IS_NOT_EQUAL_TO_OBJECT = CallMatcher.instanceCall(ASSERT_INTERFACE, MethodNames.IS_NOT_EQUAL_TO)
|
||||
.parameterTypes(CommonClassNames.JAVA_LANG_OBJECT)!!
|
||||
val IS_EQUAL_TO_BOOLEAN = CallMatcher.instanceCall(ABSTRACT_BOOLEAN_ASSERT_CLASSNAME, MethodNames.IS_EQUAL_TO)
|
||||
.parameterTypes("boolean")!!
|
||||
val IS_NOT_EQUAL_TO_BOOLEAN =
|
||||
CallMatcher.instanceCall(ABSTRACT_BOOLEAN_ASSERT_CLASSNAME, MethodNames.IS_NOT_EQUAL_TO)
|
||||
.parameterTypes("boolean")!!
|
||||
val IS_SAME_AS_OBJECT = CallMatcher.instanceCall(ABSTRACT_ASSERT_CLASSNAME, MethodNames.IS_SAME_AS)
|
||||
val IS_SAME_AS_OBJECT = CallMatcher.instanceCall(ASSERT_INTERFACE, MethodNames.IS_SAME_AS)
|
||||
.parameterTypes(CommonClassNames.JAVA_LANG_OBJECT)!!
|
||||
val IS_NOT_SAME_AS_OBJECT = CallMatcher.instanceCall(ABSTRACT_ASSERT_CLASSNAME, MethodNames.IS_NOT_SAME_AS)
|
||||
val IS_NOT_SAME_AS_OBJECT = CallMatcher.instanceCall(ASSERT_INTERFACE, MethodNames.IS_NOT_SAME_AS)
|
||||
.parameterTypes(CommonClassNames.JAVA_LANG_OBJECT)!!
|
||||
|
||||
val HAS_SIZE = CallMatcher.instanceCall(ABSTRACT_ENUMERABLE_ASSERT_CLASSNAME, MethodNames.HAS_SIZE)
|
||||
@@ -118,6 +120,8 @@ open class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
|
||||
val COLLECTION_SIZE = CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_COLLECTION, "size")
|
||||
.parameterCount(0)!!
|
||||
val CHAR_SEQUENCE_LENGTH = CallMatcher.instanceCall("java.lang.CharSequence", "length")
|
||||
.parameterCount(0)!!
|
||||
val OBJECT_EQUALS = CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_OBJECT, "equals")
|
||||
.parameterTypes(CommonClassNames.JAVA_LANG_OBJECT)!!
|
||||
|
||||
@@ -172,7 +176,22 @@ open class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
val description = REPLACE_DESCRIPTION_TEMPLATE.format(originalMethod, replacementMethod)
|
||||
val message = SIMPLIFY_MESSAGE_TEMPLATE.format(originalMethod, replacementMethod)
|
||||
val quickFix = ReplaceSimpleMethodCallQuickFix(description, replacementMethod)
|
||||
holder.registerProblem(expression, message, quickFix)
|
||||
val textRange = TextRange(expression.qualifierExpression.textLength, expression.textLength)
|
||||
holder.registerProblem(expression, textRange, message, quickFix)
|
||||
}
|
||||
|
||||
protected fun registerMoveOutMethod(
|
||||
holder: ProblemsHolder,
|
||||
expression: PsiMethodCallExpression,
|
||||
oldActualExpression: PsiMethodCallExpression,
|
||||
replacementMethod: String,
|
||||
quickFixSupplier: (String, String) -> LocalQuickFix
|
||||
) {
|
||||
val originalMethod = getOriginalMethodName(oldActualExpression) ?: return
|
||||
val description = MOVE_ACTUAL_EXPRESSION_DESCRIPTION_TEMPLATE.format(originalMethod, replacementMethod)
|
||||
val message = MOVING_OUT_MESSAGE_TEMPLATE.format(originalMethod)
|
||||
val quickfix = quickFixSupplier(description, replacementMethod)
|
||||
holder.registerProblem(expression, message, quickfix)
|
||||
}
|
||||
|
||||
protected fun registerReplaceMethod(
|
||||
@@ -182,22 +201,23 @@ open class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
replacementMethod: String,
|
||||
quickFixSupplier: (String, String) -> LocalQuickFix
|
||||
) {
|
||||
registerConciseMethod(REPLACE_DESCRIPTION_TEMPLATE, oldExpectedCallExpression, replacementMethod, quickFixSupplier, holder, expression)
|
||||
registerConciseMethod(REPLACE_DESCRIPTION_TEMPLATE, holder, expression, oldExpectedCallExpression, replacementMethod, quickFixSupplier)
|
||||
}
|
||||
|
||||
private fun registerConciseMethod(
|
||||
protected fun registerConciseMethod(
|
||||
descriptionTemplate: String,
|
||||
holder: ProblemsHolder,
|
||||
expression: PsiMethodCallExpression,
|
||||
oldExpectedCallExpression: PsiMethodCallExpression,
|
||||
replacementMethod: String,
|
||||
quickFixSupplier: (String, String) -> LocalQuickFix,
|
||||
holder: ProblemsHolder,
|
||||
expression: PsiMethodCallExpression
|
||||
quickFixSupplier: (String, String) -> LocalQuickFix
|
||||
) {
|
||||
val originalMethod = getOriginalMethodName(oldExpectedCallExpression) ?: return
|
||||
val description = descriptionTemplate.format(originalMethod, replacementMethod)
|
||||
val message = MORE_CONCISE_MESSAGE_TEMPLATE.format(replacementMethod, originalMethod)
|
||||
val quickfix = quickFixSupplier(description, replacementMethod)
|
||||
holder.registerProblem(expression, message, quickfix)
|
||||
val textRange = TextRange(expression.qualifierExpression.textLength, expression.textLength)
|
||||
holder.registerProblem(expression, textRange, message, quickfix)
|
||||
}
|
||||
|
||||
protected fun registerRemoveExpectedOutmostMethod(
|
||||
@@ -207,57 +227,6 @@ open class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
replacementMethod: String,
|
||||
quickFixSupplier: (String, String) -> LocalQuickFix
|
||||
) {
|
||||
registerConciseMethod(REMOVE_EXPECTED_OUTMOST_DESCRIPTION_TEMPLATE, oldExpectedCallExpression, replacementMethod, quickFixSupplier, holder, expression)
|
||||
}
|
||||
|
||||
protected fun registerRemoveActualOutmostMethod(
|
||||
holder: ProblemsHolder,
|
||||
expression: PsiMethodCallExpression,
|
||||
oldExpectedCallExpression: PsiMethodCallExpression,
|
||||
replacementMethod: String,
|
||||
quickFixSupplier: (String, String) -> LocalQuickFix
|
||||
) {
|
||||
registerConciseMethod(REMOVE_ACTUAL_OUTMOST_DESCRIPTION_TEMPLATE, oldExpectedCallExpression, replacementMethod, quickFixSupplier, holder, expression)
|
||||
}
|
||||
|
||||
protected fun calculateConstantParameterValue(expression: PsiMethodCallExpression, argIndex: Int): Any? {
|
||||
if (argIndex >= expression.argumentList.expressions.size) return null
|
||||
val valueExpression = expression.getArg(argIndex)
|
||||
val constantEvaluationHelper = JavaPsiFacade.getInstance(expression.project).constantEvaluationHelper
|
||||
val value = constantEvaluationHelper.computeConstantExpression(valueExpression)
|
||||
if (value == null) {
|
||||
val field = (valueExpression as? PsiReferenceExpression)?.resolve() as? PsiField
|
||||
if (field?.containingClass?.qualifiedName == CommonClassNames.JAVA_LANG_BOOLEAN) {
|
||||
return when (field.name) {
|
||||
"TRUE" -> true
|
||||
"FALSE" -> false
|
||||
else -> null
|
||||
}
|
||||
}
|
||||
}
|
||||
return value
|
||||
}
|
||||
|
||||
protected fun getExpectedBooleanResult(expectedCallExpression: PsiMethodCallExpression): Boolean? {
|
||||
val isTrue = IS_TRUE.test(expectedCallExpression)
|
||||
val isFalse = IS_FALSE.test(expectedCallExpression)
|
||||
if (isTrue || isFalse) {
|
||||
return isTrue
|
||||
} else {
|
||||
val isEqualTo = IS_EQUAL_TO_BOOLEAN.test(expectedCallExpression) || IS_EQUAL_TO_OBJECT.test(expectedCallExpression)
|
||||
val isNotEqualTo = IS_NOT_EQUAL_TO_BOOLEAN.test(expectedCallExpression) || IS_NOT_EQUAL_TO_OBJECT.test(expectedCallExpression)
|
||||
if (isEqualTo || isNotEqualTo) {
|
||||
val constValue = calculateConstantParameterValue(expectedCallExpression, 0) as? Boolean ?: return null
|
||||
return isNotEqualTo xor constValue
|
||||
}
|
||||
}
|
||||
return null
|
||||
}
|
||||
|
||||
protected fun hasAssertJMethod(element: PsiElement, classname: String, methodname: String): Boolean {
|
||||
val findClass =
|
||||
JavaPsiFacade.getInstance(element.project).findClass(classname, GlobalSearchScope.allScope(element.project))
|
||||
?: return false
|
||||
return findClass.allMethods.any { it.name == methodname }
|
||||
registerConciseMethod(REMOVE_EXPECTED_OUTMOST_DESCRIPTION_TEMPLATE, holder, expression, oldExpectedCallExpression, replacementMethod, quickFixSupplier)
|
||||
}
|
||||
}
|
||||
-4
@@ -7,10 +7,6 @@ import org.jetbrains.annotations.NonNls
|
||||
open class AbstractJUnitAssertInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
|
||||
companion object {
|
||||
const val CONVERT_MESSAGE_TEMPLATE = "%s can be converted to AssertJ style"
|
||||
|
||||
const val REPLACE_DESCRIPTION_TEMPLATE = "Replace %s() with assertThat().%s()"
|
||||
|
||||
@NonNls
|
||||
const val JUNIT_ASSERT_CLASSNAME = "org.junit.Assert"
|
||||
|
||||
|
||||
+23
-24
@@ -4,16 +4,11 @@ import com.intellij.codeInspection.LocalQuickFix
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.*
|
||||
import com.intellij.psi.util.TypeConversionUtil
|
||||
import de.platon42.intellij.plugins.cajon.MethodNames
|
||||
import de.platon42.intellij.plugins.cajon.MethodNames.Companion.IS_NOT_NULL
|
||||
import de.platon42.intellij.plugins.cajon.MethodNames.Companion.IS_NULL
|
||||
import de.platon42.intellij.plugins.cajon.findOutmostMethodCall
|
||||
import de.platon42.intellij.plugins.cajon.firstArg
|
||||
import de.platon42.intellij.plugins.cajon.map
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.MoveOutMethodCallExpressionQuickFix
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.SplitBinaryExpressionMethodCallQuickFix
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.SplitEqualsExpressionMethodCallQuickFix
|
||||
|
||||
class AssertThatBinaryExpressionIsTrueOrFalseInspection : AbstractAssertJInspection() {
|
||||
class AssertThatBinaryExpressionInspection : AbstractAssertJInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Asserting a binary expression"
|
||||
@@ -25,19 +20,23 @@ class AssertThatBinaryExpressionIsTrueOrFalseInspection : AbstractAssertJInspect
|
||||
|
||||
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
|
||||
super.visitMethodCallExpression(expression)
|
||||
if (!ASSERT_THAT_BOOLEAN.test(expression)) {
|
||||
override fun visitExpressionStatement(statement: PsiExpressionStatement) {
|
||||
super.visitExpressionStatement(statement)
|
||||
if (!statement.hasAssertThat()) {
|
||||
return
|
||||
}
|
||||
val staticMethodCall = statement.findStaticMethodCall() ?: return
|
||||
if (!ASSERT_THAT_BOOLEAN.test(staticMethodCall)) {
|
||||
return
|
||||
}
|
||||
|
||||
val expectedCallExpression = expression.findOutmostMethodCall() ?: return
|
||||
val expectedResult = getExpectedBooleanResult(expectedCallExpression) ?: return
|
||||
val expectedCallExpression = statement.findOutmostMethodCall() ?: return
|
||||
val expectedResult = expectedCallExpression.getAllTheSameExpectedBooleanConstants() ?: return
|
||||
|
||||
val assertThatArgument = expression.firstArg
|
||||
val assertThatArgument = staticMethodCall.firstArg
|
||||
if (assertThatArgument is PsiMethodCallExpression && OBJECT_EQUALS.test(assertThatArgument)) {
|
||||
val replacementMethod = if (expectedResult) MethodNames.IS_EQUAL_TO else MethodNames.IS_NOT_EQUAL_TO
|
||||
registerSplitMethod(holder, expression, "${MethodNames.EQUALS}()", replacementMethod, ::SplitEqualsExpressionMethodCallQuickFix)
|
||||
val replacementMethod = expectedResult.map(MethodNames.IS_EQUAL_TO, MethodNames.IS_NOT_EQUAL_TO)
|
||||
registerSplitMethod(holder, expectedCallExpression, "${MethodNames.EQUALS}()", replacementMethod, ::MoveOutMethodCallExpressionQuickFix)
|
||||
return
|
||||
}
|
||||
|
||||
@@ -51,8 +50,8 @@ class AssertThatBinaryExpressionIsTrueOrFalseInspection : AbstractAssertJInspect
|
||||
if (isLeftNull && isRightNull) {
|
||||
return
|
||||
} else if (isLeftNull || isRightNull) {
|
||||
val replacementMethod = if (expectedResult) IS_NULL else IS_NOT_NULL
|
||||
registerSplitMethod(holder, expression, "binary", replacementMethod) { desc, method ->
|
||||
val replacementMethod = expectedResult.map(MethodNames.IS_NULL, MethodNames.IS_NOT_NULL)
|
||||
registerSplitMethod(holder, expectedCallExpression, "binary", replacementMethod) { desc, method ->
|
||||
SplitBinaryExpressionMethodCallQuickFix(desc, method, pickRightOperand = isLeftNull, noExpectedExpression = true)
|
||||
}
|
||||
return
|
||||
@@ -60,24 +59,26 @@ class AssertThatBinaryExpressionIsTrueOrFalseInspection : AbstractAssertJInspect
|
||||
|
||||
val isPrimitive = bothTypes.all(TypeConversionUtil::isPrimitiveAndNotNull)
|
||||
val isNumericType = bothTypes.all(TypeConversionUtil::isNumericType)
|
||||
val constantEvaluationHelper = JavaPsiFacade.getInstance(expression.project).constantEvaluationHelper
|
||||
val constantEvaluationHelper = JavaPsiFacade.getInstance(statement.project).constantEvaluationHelper
|
||||
val swapExpectedAndActual = constantEvaluationHelper.computeConstantExpression(binaryExpression.lOperand) != null
|
||||
|
||||
val tokenType = binaryExpression.operationSign.tokenType
|
||||
val tokenType = binaryExpression.operationTokenType
|
||||
.let {
|
||||
if (swapExpectedAndActual) SWAP_SIDE_OF_BINARY_OPERATOR.getOrDefault(it, it) else it
|
||||
}
|
||||
.let {
|
||||
if (expectedResult) it else INVERT_BINARY_OPERATOR.getOrDefault(it, it)
|
||||
} ?: return
|
||||
}
|
||||
val mappingToUse =
|
||||
(isPrimitive || isNumericType).map(TOKEN_TO_ASSERTJ_FOR_PRIMITIVE_MAP, TOKEN_TO_ASSERTJ_FOR_OBJECT_MAPPINGS)
|
||||
val replacementMethod = mappingToUse[tokenType] ?: return
|
||||
|
||||
registerSplitMethod(holder, expression, "binary", replacementMethod) { desc, method ->
|
||||
registerSplitMethod(holder, expectedCallExpression, "binary", replacementMethod) { desc, method ->
|
||||
SplitBinaryExpressionMethodCallQuickFix(desc, method, pickRightOperand = swapExpectedAndActual)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private fun registerSplitMethod(
|
||||
holder: ProblemsHolder,
|
||||
@@ -92,5 +93,3 @@ class AssertThatBinaryExpressionIsTrueOrFalseInspection : AbstractAssertJInspect
|
||||
holder.registerProblem(expression, message, quickfix)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
+7
-6
@@ -5,15 +5,13 @@ import com.intellij.psi.JavaElementVisitor
|
||||
import com.intellij.psi.PsiElementVisitor
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.intellij.psi.util.TypeConversionUtil
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_BOOLEAN_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.MethodNames
|
||||
import de.platon42.intellij.plugins.cajon.firstArg
|
||||
import de.platon42.intellij.plugins.cajon.map
|
||||
|
||||
class AssertThatBooleanIsTrueOrFalseInspection : AbstractAssertJInspection() {
|
||||
class AssertThatBooleanConditionInspection : AbstractAssertJInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Asserting true or false"
|
||||
private const val DISPLAY_NAME = "Asserting a boolean condition"
|
||||
}
|
||||
|
||||
override fun getDisplayName() = DISPLAY_NAME
|
||||
@@ -22,6 +20,9 @@ class AssertThatBooleanIsTrueOrFalseInspection : AbstractAssertJInspection() {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
|
||||
super.visitMethodCallExpression(expression)
|
||||
if (!expression.hasAssertThat()) {
|
||||
return
|
||||
}
|
||||
val matchingCalls = listOf(
|
||||
IS_EQUAL_TO_OBJECT, IS_EQUAL_TO_BOOLEAN,
|
||||
IS_NOT_EQUAL_TO_OBJECT, IS_NOT_EQUAL_TO_BOOLEAN
|
||||
@@ -37,7 +38,7 @@ class AssertThatBooleanIsTrueOrFalseInspection : AbstractAssertJInspection() {
|
||||
if (!TypeConversionUtil.isBooleanType(expectedExpression.type)) {
|
||||
return
|
||||
}
|
||||
val expectedResult = calculateConstantParameterValue(expression, 0) as? Boolean ?: return
|
||||
val expectedResult = expression.calculateConstantParameterValue(0) as? Boolean ?: return
|
||||
val flippedBooleanTest = matchingCalls.drop(2).any { it }
|
||||
|
||||
val replacementMethod = (expectedResult xor flippedBooleanTest).map(MethodNames.IS_TRUE, MethodNames.IS_FALSE)
|
||||
+9
-2
@@ -4,7 +4,10 @@ import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.JavaElementVisitor
|
||||
import com.intellij.psi.PsiElementVisitor
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.intellij.psi.PsiStatement
|
||||
import de.platon42.intellij.plugins.cajon.MethodNames
|
||||
import de.platon42.intellij.plugins.cajon.calculateConstantParameterValue
|
||||
import de.platon42.intellij.plugins.cajon.hasAssertThat
|
||||
|
||||
class AssertThatEnumerableIsEmptyInspection : AbstractAssertJInspection() {
|
||||
|
||||
@@ -18,11 +21,15 @@ class AssertThatEnumerableIsEmptyInspection : AbstractAssertJInspection() {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
|
||||
super.visitMethodCallExpression(expression)
|
||||
if (!HAS_SIZE.test(expression)) {
|
||||
if (!expression.hasAssertThat()) {
|
||||
return
|
||||
}
|
||||
val isLastExpression = expression.parent is PsiStatement
|
||||
if (!(HAS_SIZE.test(expression) && isLastExpression)) {
|
||||
return
|
||||
}
|
||||
|
||||
val value = calculateConstantParameterValue(expression, 0) ?: return
|
||||
val value = expression.calculateConstantParameterValue(0) ?: return
|
||||
if (value == 0) {
|
||||
registerSimplifyMethod(holder, expression, MethodNames.IS_EMPTY)
|
||||
}
|
||||
|
||||
+64
-62
@@ -1,10 +1,8 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.JavaElementVisitor
|
||||
import com.intellij.psi.JavaPsiFacade
|
||||
import com.intellij.psi.PsiElementVisitor
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.intellij.openapi.util.TextRange
|
||||
import com.intellij.psi.*
|
||||
import com.intellij.psi.search.GlobalSearchScope
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
@@ -14,97 +12,101 @@ class AssertThatGuavaOptionalInspection : AbstractAssertJInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Asserting an Optional (Guava)"
|
||||
private const val REPLACE_GUAVA_DESCRIPTION_TEMPLATE = "Replace %s() with Guava assertThat().%s()"
|
||||
}
|
||||
|
||||
override fun getDisplayName() = DISPLAY_NAME
|
||||
|
||||
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
|
||||
super.visitMethodCallExpression(expression)
|
||||
JavaPsiFacade.getInstance(expression.project)
|
||||
.findClass(AssertJClassNames.GUAVA_ASSERTIONS_CLASSNAME, GlobalSearchScope.allScope(expression.project)) ?: return
|
||||
val assertThatGuava = ASSERT_THAT_GUAVA_OPTIONAL.test(expression)
|
||||
if (!(ASSERT_THAT_ANY.test(expression) || assertThatGuava)) {
|
||||
override fun visitExpressionStatement(statement: PsiExpressionStatement) {
|
||||
super.visitExpressionStatement(statement)
|
||||
if (!statement.hasAssertThat()) {
|
||||
return
|
||||
}
|
||||
val expectedCallExpression = expression.findOutmostMethodCall() ?: return
|
||||
val staticMethodCall = statement.findStaticMethodCall() ?: return
|
||||
|
||||
val isEqualTo = IS_EQUAL_TO_OBJECT.test(expectedCallExpression)
|
||||
val isNotEqualTo = IS_NOT_EQUAL_TO_OBJECT.test(expectedCallExpression)
|
||||
if (assertThatGuava) {
|
||||
if (isEqualTo) {
|
||||
val innerExpectedCall = expectedCallExpression.firstArg as? PsiMethodCallExpression ?: return
|
||||
if (CallMatcher.anyOf(GUAVA_OPTIONAL_OF, GUAVA_OPTIONAL_FROM_NULLABLE).test(innerExpectedCall)) {
|
||||
registerRemoveExpectedOutmostMethod(holder, expression, expectedCallExpression, MethodNames.CONTAINS, ::RemoveExpectedOutmostMethodCallQuickFix)
|
||||
} else if (GUAVA_OPTIONAL_ABSENT.test(innerExpectedCall)) {
|
||||
registerSimplifyMethod(holder, expectedCallExpression, MethodNames.IS_ABSENT)
|
||||
if (!checkPreconditions(staticMethodCall)) {
|
||||
return
|
||||
}
|
||||
} else if (isNotEqualTo) {
|
||||
val innerExpectedCall = expectedCallExpression.firstArg as? PsiMethodCallExpression ?: return
|
||||
if (GUAVA_OPTIONAL_ABSENT.test(innerExpectedCall)) {
|
||||
registerSimplifyMethod(holder, expectedCallExpression, MethodNames.IS_PRESENT)
|
||||
val actualExpression = staticMethodCall.firstArg as? PsiMethodCallExpression ?: return
|
||||
|
||||
val outmostMethodCall = statement.findOutmostMethodCall() ?: return
|
||||
if (GUAVA_OPTIONAL_GET.test(actualExpression)) {
|
||||
val expectedCallExpression = staticMethodCall.gatherAssertionCalls().singleOrNull() ?: return
|
||||
if (IS_EQUAL_TO_OBJECT.test(expectedCallExpression)) {
|
||||
registerMoveOutMethod(holder, outmostMethodCall, actualExpression, MethodNames.CONTAINS) { desc, method ->
|
||||
QuickFixWithPostfixDelegate(
|
||||
RemoveActualOutmostMethodCallQuickFix(desc, method),
|
||||
ForGuavaPostFix.REPLACE_BY_GUAVA_ASSERT_THAT_AND_STATIC_IMPORT
|
||||
)
|
||||
}
|
||||
}
|
||||
} else {
|
||||
// we're not calling an assertThat() from Guava, but a core-AssertJ one!
|
||||
// We need to replace that by the Guava one, if we want to apply a formally correct fix.
|
||||
val actualExpression = expression.firstArg as? PsiMethodCallExpression
|
||||
if (actualExpression != null) {
|
||||
if (GUAVA_OPTIONAL_GET.test(actualExpression) && isEqualTo) {
|
||||
registerRemoveActualOutmostForGuavaMethod(holder, expression, expectedCallExpression, MethodNames.CONTAINS)
|
||||
} else if (GUAVA_OPTIONAL_IS_PRESENT.test(actualExpression)) {
|
||||
val expectedPresence = getExpectedBooleanResult(expectedCallExpression) ?: return
|
||||
val expectedPresence = outmostMethodCall.getAllTheSameExpectedBooleanConstants() ?: return
|
||||
val replacementMethod = expectedPresence.map(MethodNames.IS_PRESENT, MethodNames.IS_ABSENT)
|
||||
registerRemoveActualOutmostForGuavaMethod(holder, expression, expectedCallExpression, replacementMethod, noExpectedExpression = true)
|
||||
}
|
||||
}
|
||||
if (isEqualTo) {
|
||||
val innerExpectedCall = expectedCallExpression.firstArg as? PsiMethodCallExpression ?: return
|
||||
if (CallMatcher.anyOf(GUAVA_OPTIONAL_OF, GUAVA_OPTIONAL_FROM_NULLABLE).test(innerExpectedCall)) {
|
||||
registerRemoveExpectedOutmostMethod(holder, expression, expectedCallExpression, MethodNames.CONTAINS) { desc, method ->
|
||||
registerMoveOutMethod(holder, outmostMethodCall, actualExpression, replacementMethod) { desc, method ->
|
||||
QuickFixWithPostfixDelegate(
|
||||
RemoveExpectedOutmostMethodCallQuickFix(desc, method),
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method),
|
||||
ForGuavaPostFix.REPLACE_BY_GUAVA_ASSERT_THAT_AND_STATIC_IMPORT
|
||||
)
|
||||
}
|
||||
} else if (GUAVA_OPTIONAL_ABSENT.test(innerExpectedCall)) {
|
||||
registerSimplifyForGuavaMethod(holder, expectedCallExpression, MethodNames.IS_ABSENT)
|
||||
}
|
||||
} else if (isNotEqualTo) {
|
||||
val innerExpectedCall = expectedCallExpression.firstArg as? PsiMethodCallExpression ?: return
|
||||
if (GUAVA_OPTIONAL_ABSENT.test(innerExpectedCall)) {
|
||||
registerSimplifyForGuavaMethod(holder, expectedCallExpression, MethodNames.IS_PRESENT)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private fun registerRemoveActualOutmostForGuavaMethod(
|
||||
holder: ProblemsHolder,
|
||||
expression: PsiMethodCallExpression,
|
||||
oldExpectedCallExpression: PsiMethodCallExpression,
|
||||
replacementMethod: String,
|
||||
noExpectedExpression: Boolean = false
|
||||
) {
|
||||
registerRemoveActualOutmostMethod(holder, expression, oldExpectedCallExpression, replacementMethod) { desc, method ->
|
||||
override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
|
||||
super.visitMethodCallExpression(expression)
|
||||
if (!expression.hasAssertThat()) {
|
||||
return
|
||||
}
|
||||
val staticMethodCall = expression.findStaticMethodCall() ?: return
|
||||
if (!checkPreconditions(staticMethodCall)) {
|
||||
return
|
||||
}
|
||||
// We're not calling an assertThat() from Guava, but a core-AssertJ one!
|
||||
// We need to replace that by the Guava one, if we want to apply a formally correct fix.
|
||||
if (IS_EQUAL_TO_OBJECT.test(expression)) {
|
||||
val innerExpectedCall = expression.firstArg as? PsiMethodCallExpression ?: return
|
||||
if (CallMatcher.anyOf(GUAVA_OPTIONAL_OF, GUAVA_OPTIONAL_FROM_NULLABLE).test(innerExpectedCall)) {
|
||||
registerRemoveExpectedOutmostMethod(holder, expression, expression, MethodNames.CONTAINS) { desc, method ->
|
||||
QuickFixWithPostfixDelegate(
|
||||
RemoveActualOutmostMethodCallQuickFix(desc, method, noExpectedExpression),
|
||||
UnwrapExpectedStaticMethodCallQuickFix(desc, method),
|
||||
ForGuavaPostFix.REPLACE_BY_GUAVA_ASSERT_THAT_AND_STATIC_IMPORT
|
||||
)
|
||||
}
|
||||
} else if (GUAVA_OPTIONAL_ABSENT.test(innerExpectedCall)) {
|
||||
registerSimplifyForGuavaMethod(holder, expression, MethodNames.IS_ABSENT)
|
||||
}
|
||||
} else if (IS_NOT_EQUAL_TO_OBJECT.test(expression)) {
|
||||
val innerExpectedCall = expression.firstArg as? PsiMethodCallExpression ?: return
|
||||
if (GUAVA_OPTIONAL_ABSENT.test(innerExpectedCall)) {
|
||||
registerSimplifyForGuavaMethod(holder, expression, MethodNames.IS_PRESENT)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private fun checkPreconditions(staticMethodCall: PsiMethodCallExpression): Boolean {
|
||||
val assertThatGuava = GUAVA_ASSERT_THAT_ANY.test(staticMethodCall)
|
||||
|
||||
if (ASSERT_THAT_ANY.test(staticMethodCall) || assertThatGuava) {
|
||||
JavaPsiFacade.getInstance(staticMethodCall.project)
|
||||
.findClass(AssertJClassNames.GUAVA_ASSERTIONS_CLASSNAME, GlobalSearchScope.allScope(staticMethodCall.project)) ?: return false
|
||||
return true
|
||||
}
|
||||
return false
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private fun registerSimplifyForGuavaMethod(holder: ProblemsHolder, expression: PsiMethodCallExpression, replacementMethod: String) {
|
||||
val originalMethod = getOriginalMethodName(expression) ?: return
|
||||
val description = REPLACE_DESCRIPTION_TEMPLATE.format(originalMethod, replacementMethod)
|
||||
val description = REPLACE_GUAVA_DESCRIPTION_TEMPLATE.format(originalMethod, replacementMethod)
|
||||
val message = SIMPLIFY_MESSAGE_TEMPLATE.format(originalMethod, replacementMethod)
|
||||
val quickFix = QuickFixWithPostfixDelegate(
|
||||
ReplaceSimpleMethodCallQuickFix(description, replacementMethod),
|
||||
ForGuavaPostFix.REPLACE_BY_GUAVA_ASSERT_THAT_AND_STATIC_IMPORT
|
||||
)
|
||||
holder.registerProblem(expression, message, quickFix)
|
||||
val textRange = TextRange(expression.qualifierExpression.textLength, expression.textLength)
|
||||
holder.registerProblem(expression, textRange, message, quickFix)
|
||||
}
|
||||
}
|
||||
+52
@@ -0,0 +1,52 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.codeInspection.LocalQuickFix
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.*
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.MoveOutInstanceOfExpressionQuickFix
|
||||
|
||||
class AssertThatInstanceOfInspection : AbstractAssertJInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Asserting a class instance"
|
||||
private const val REMOVE_INSTANCEOF_DESCRIPTION_TEMPLATE = "Remove instanceof in actual expression and use assertThat().%s() instead"
|
||||
private const val MOVE_OUT_INSTANCEOF_MESSAGE = "instanceof expression could be moved out of assertThat()"
|
||||
}
|
||||
|
||||
override fun getDisplayName() = DISPLAY_NAME
|
||||
|
||||
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitExpressionStatement(statement: PsiExpressionStatement) {
|
||||
super.visitExpressionStatement(statement)
|
||||
if (!statement.hasAssertThat()) {
|
||||
return
|
||||
}
|
||||
val staticMethodCall = statement.findStaticMethodCall() ?: return
|
||||
if (!ASSERT_THAT_BOOLEAN.test(staticMethodCall)) {
|
||||
return
|
||||
}
|
||||
|
||||
val expectedCallExpression = statement.findOutmostMethodCall() ?: return
|
||||
val expectedResult = expectedCallExpression.getAllTheSameExpectedBooleanConstants() ?: return
|
||||
|
||||
if (staticMethodCall.firstArg is PsiInstanceOfExpression) {
|
||||
val replacementMethod = expectedResult.map(MethodNames.IS_INSTANCE_OF, MethodNames.IS_NOT_INSTANCE_OF)
|
||||
registerMoveOutInstanceOfMethod(holder, expectedCallExpression, replacementMethod, ::MoveOutInstanceOfExpressionQuickFix)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private fun registerMoveOutInstanceOfMethod(
|
||||
holder: ProblemsHolder,
|
||||
expression: PsiMethodCallExpression,
|
||||
replacementMethod: String,
|
||||
quickFixSupplier: (String, String) -> LocalQuickFix
|
||||
) {
|
||||
val description = REMOVE_INSTANCEOF_DESCRIPTION_TEMPLATE.format(replacementMethod)
|
||||
val quickfix = quickFixSupplier(description, replacementMethod)
|
||||
holder.registerProblem(expression, MOVE_OUT_INSTANCEOF_MESSAGE, quickfix)
|
||||
}
|
||||
}
|
||||
+38
@@ -0,0 +1,38 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.*
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.InvertUnaryStatementQuickFix
|
||||
|
||||
class AssertThatInvertedBooleanConditionInspection : AbstractAssertJInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Asserting an inverted boolean condition"
|
||||
private const val INVERT_CONDITION_MESSAGE = "Condition inside assertThat() could be inverted"
|
||||
}
|
||||
|
||||
override fun getDisplayName() = DISPLAY_NAME
|
||||
|
||||
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
|
||||
super.visitMethodCallExpression(expression)
|
||||
if (!expression.hasAssertThat()) {
|
||||
return
|
||||
}
|
||||
val staticMethodCall = expression.findStaticMethodCall() ?: return
|
||||
if (!ASSERT_THAT_BOOLEAN.test(staticMethodCall)) {
|
||||
return
|
||||
}
|
||||
expression.getExpectedBooleanResult() ?: return
|
||||
|
||||
val prefixExpression = staticMethodCall.firstArg as? PsiPrefixExpression ?: return
|
||||
if (prefixExpression.operationTokenType == JavaTokenType.EXCL) {
|
||||
val outmostMethodCall = expression.findOutmostMethodCall() ?: return
|
||||
holder.registerProblem(outmostMethodCall, INVERT_CONDITION_MESSAGE, InvertUnaryStatementQuickFix())
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
+43
-32
@@ -3,14 +3,13 @@ package de.platon42.intellij.plugins.cajon.inspections
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.JavaElementVisitor
|
||||
import com.intellij.psi.PsiElementVisitor
|
||||
import com.intellij.psi.PsiExpressionStatement
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.MethodNames
|
||||
import de.platon42.intellij.plugins.cajon.findOutmostMethodCall
|
||||
import de.platon42.intellij.plugins.cajon.firstArg
|
||||
import de.platon42.intellij.plugins.cajon.map
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.MoveOutMethodCallExpressionQuickFix
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.RemoveActualOutmostMethodCallQuickFix
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.RemoveExpectedOutmostMethodCallQuickFix
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.UnwrapExpectedStaticMethodCallQuickFix
|
||||
|
||||
class AssertThatJava8OptionalInspection : AbstractAssertJInspection() {
|
||||
|
||||
@@ -22,46 +21,58 @@ class AssertThatJava8OptionalInspection : AbstractAssertJInspection() {
|
||||
|
||||
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
|
||||
super.visitMethodCallExpression(expression)
|
||||
if (!ASSERT_THAT_ANY.test(expression)) {
|
||||
override fun visitExpressionStatement(statement: PsiExpressionStatement) {
|
||||
super.visitExpressionStatement(statement)
|
||||
if (!statement.hasAssertThat()) {
|
||||
return
|
||||
}
|
||||
val expectedCallExpression = expression.findOutmostMethodCall() ?: return
|
||||
|
||||
if (ASSERT_THAT_JAVA8_OPTIONAL.test(expression)) {
|
||||
if (IS_EQUAL_TO_OBJECT.test(expectedCallExpression)) {
|
||||
val innerExpectedCall = expectedCallExpression.firstArg as? PsiMethodCallExpression ?: return
|
||||
if (CallMatcher.anyOf(OPTIONAL_OF, OPTIONAL_OF_NULLABLE).test(innerExpectedCall)) {
|
||||
registerRemoveExpectedOutmostMethod(holder, expression, expectedCallExpression, MethodNames.CONTAINS, ::RemoveExpectedOutmostMethodCallQuickFix)
|
||||
} else if (OPTIONAL_EMPTY.test(innerExpectedCall)) {
|
||||
registerSimplifyMethod(holder, expectedCallExpression, MethodNames.IS_NOT_PRESENT)
|
||||
}
|
||||
} else if (IS_NOT_EQUAL_TO_OBJECT.test(expectedCallExpression)) {
|
||||
val innerExpectedCall = expectedCallExpression.firstArg as? PsiMethodCallExpression ?: return
|
||||
if (OPTIONAL_EMPTY.test(innerExpectedCall)) {
|
||||
registerSimplifyMethod(holder, expectedCallExpression, MethodNames.IS_PRESENT)
|
||||
}
|
||||
}
|
||||
} else {
|
||||
val actualExpression = expression.firstArg as? PsiMethodCallExpression ?: return
|
||||
val staticMethodCall = statement.findStaticMethodCall() ?: return
|
||||
if (!ASSERT_THAT_ANY.test(staticMethodCall)) {
|
||||
return
|
||||
}
|
||||
val actualExpression = staticMethodCall.firstArg as? PsiMethodCallExpression ?: return
|
||||
|
||||
val outmostMethodCall = statement.findOutmostMethodCall() ?: return
|
||||
if (OPTIONAL_GET.test(actualExpression)) {
|
||||
val expectedCallExpression = staticMethodCall.gatherAssertionCalls().singleOrNull() ?: return
|
||||
if (IS_EQUAL_TO_OBJECT.test(expectedCallExpression)) {
|
||||
registerRemoveActualOutmostMethod(holder, expression, expectedCallExpression, MethodNames.CONTAINS) { desc, method ->
|
||||
registerMoveOutMethod(holder, outmostMethodCall, actualExpression, MethodNames.CONTAINS) { desc, method ->
|
||||
RemoveActualOutmostMethodCallQuickFix(desc, method)
|
||||
}
|
||||
} else if (IS_SAME_AS_OBJECT.test(expectedCallExpression)) {
|
||||
registerRemoveActualOutmostMethod(holder, expression, expectedCallExpression, MethodNames.CONTAINS_SAME) { desc, method ->
|
||||
registerMoveOutMethod(holder, outmostMethodCall, actualExpression, MethodNames.CONTAINS_SAME) { desc, method ->
|
||||
RemoveActualOutmostMethodCallQuickFix(desc, method)
|
||||
}
|
||||
}
|
||||
} else if (OPTIONAL_IS_PRESENT.test(actualExpression)) {
|
||||
val expectedPresence = getExpectedBooleanResult(expectedCallExpression) ?: return
|
||||
val expectedPresence = outmostMethodCall.getAllTheSameExpectedBooleanConstants() ?: return
|
||||
val replacementMethod = expectedPresence.map(MethodNames.IS_PRESENT, MethodNames.IS_NOT_PRESENT)
|
||||
registerRemoveActualOutmostMethod(holder, expression, expectedCallExpression, replacementMethod) { desc, method ->
|
||||
RemoveActualOutmostMethodCallQuickFix(desc, method, noExpectedExpression = true)
|
||||
}
|
||||
registerMoveOutMethod(holder, outmostMethodCall, actualExpression, replacementMethod) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
|
||||
super.visitMethodCallExpression(expression)
|
||||
if (!expression.hasAssertThat()) {
|
||||
return
|
||||
}
|
||||
val staticMethodCall = expression.findStaticMethodCall() ?: return
|
||||
if (!ASSERT_THAT_JAVA8_OPTIONAL.test(staticMethodCall)) {
|
||||
return
|
||||
}
|
||||
if (IS_EQUAL_TO_OBJECT.test(expression)) {
|
||||
val innerExpectedCall = expression.firstArg as? PsiMethodCallExpression ?: return
|
||||
if (CallMatcher.anyOf(OPTIONAL_OF, OPTIONAL_OF_NULLABLE).test(innerExpectedCall)) {
|
||||
registerRemoveExpectedOutmostMethod(holder, expression, expression, MethodNames.CONTAINS, ::UnwrapExpectedStaticMethodCallQuickFix)
|
||||
} else if (OPTIONAL_EMPTY.test(innerExpectedCall)) {
|
||||
registerSimplifyMethod(holder, expression, MethodNames.IS_NOT_PRESENT)
|
||||
}
|
||||
} else if (IS_NOT_EQUAL_TO_OBJECT.test(expression)) {
|
||||
val innerExpectedCall = expression.firstArg as? PsiMethodCallExpression ?: return
|
||||
if (OPTIONAL_EMPTY.test(innerExpectedCall)) {
|
||||
registerSimplifyMethod(holder, expression, MethodNames.IS_PRESENT)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
+7
-5
@@ -1,12 +1,10 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.JavaElementVisitor
|
||||
import com.intellij.psi.PsiElementVisitor
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.intellij.psi.PsiType
|
||||
import com.intellij.psi.*
|
||||
import de.platon42.intellij.plugins.cajon.MethodNames
|
||||
import de.platon42.intellij.plugins.cajon.firstArg
|
||||
import de.platon42.intellij.plugins.cajon.hasAssertThat
|
||||
import de.platon42.intellij.plugins.cajon.map
|
||||
|
||||
class AssertThatObjectIsNullOrNotNullInspection : AbstractAssertJInspection() {
|
||||
@@ -21,9 +19,13 @@ class AssertThatObjectIsNullOrNotNullInspection : AbstractAssertJInspection() {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
|
||||
super.visitMethodCallExpression(expression)
|
||||
if (!expression.hasAssertThat()) {
|
||||
return
|
||||
}
|
||||
val isNotEqualTo = IS_NOT_EQUAL_TO_OBJECT.test(expression)
|
||||
val isEqualTo = IS_EQUAL_TO_OBJECT.test(expression)
|
||||
if (!(isEqualTo || isNotEqualTo)) {
|
||||
val isLastExpression = expression.parent is PsiStatement
|
||||
if (!((isEqualTo && isLastExpression) || isNotEqualTo)) {
|
||||
return
|
||||
}
|
||||
|
||||
|
||||
+120
-59
@@ -2,17 +2,18 @@ package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.*
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_CHAR_SEQUENCE_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_ITERABLE_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.MethodNames
|
||||
import de.platon42.intellij.plugins.cajon.findOutmostMethodCall
|
||||
import de.platon42.intellij.plugins.cajon.firstArg
|
||||
import de.platon42.intellij.plugins.cajon.map
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.ReplaceHasSizeMethodCallQuickFix
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.ReplaceSizeMethodCallQuickFix
|
||||
|
||||
class AssertThatSizeInspection : AbstractAssertJInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Asserting the size of an collection or array"
|
||||
private const val DISPLAY_NAME = "Asserting the size of an collection, array or string"
|
||||
private const val REMOVE_SIZE_DESCRIPTION_TEMPLATE = "Remove size determination of expected expression and replace %s() with %s()"
|
||||
private const val REMOVE_ALL_MESSAGE = "Try to operate on the iterable itself rather than its size"
|
||||
|
||||
private val BONUS_EXPRESSIONS_CALL_MATCHER_MAP = listOf(
|
||||
IS_LESS_THAN_INT to MethodNames.HAS_SIZE_LESS_THAN,
|
||||
@@ -20,61 +21,8 @@ class AssertThatSizeInspection : AbstractAssertJInspection() {
|
||||
IS_GREATER_THAN_INT to MethodNames.HAS_SIZE_GREATER_THAN,
|
||||
IS_GREATER_THAN_OR_EQUAL_TO_INT to MethodNames.HAS_SIZE_GREATER_THAN_OR_EQUAL_TO
|
||||
)
|
||||
}
|
||||
|
||||
override fun getDisplayName() = DISPLAY_NAME
|
||||
|
||||
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
|
||||
super.visitMethodCallExpression(expression)
|
||||
if (!ASSERT_THAT_INT.test(expression)) {
|
||||
return
|
||||
}
|
||||
val actualExpression = expression.firstArg
|
||||
|
||||
if (isArrayLength(actualExpression) || isCollectionSize(actualExpression)) {
|
||||
val expectedCallExpression = expression.findOutmostMethodCall() ?: return
|
||||
val constValue = calculateConstantParameterValue(expectedCallExpression, 0)
|
||||
if (IS_EQUAL_TO_INT.test(expectedCallExpression)) {
|
||||
if (constValue == 0) {
|
||||
registerReplaceMethod(holder, expression, expectedCallExpression, MethodNames.IS_EMPTY) { desc, method ->
|
||||
ReplaceSizeMethodCallQuickFix(desc, method, noExpectedExpression = true)
|
||||
}
|
||||
} else {
|
||||
val equalToExpression = expectedCallExpression.firstArg
|
||||
if (isCollectionSize(equalToExpression) || isArrayLength(equalToExpression)) {
|
||||
registerReplaceMethod(holder, expression, expectedCallExpression, MethodNames.HAS_SAME_SIZE_AS) { desc, method ->
|
||||
ReplaceSizeMethodCallQuickFix(desc, method, expectedIsCollection = true)
|
||||
}
|
||||
} else {
|
||||
registerReplaceMethod(holder, expression, expectedCallExpression, MethodNames.HAS_SIZE) { desc, method ->
|
||||
ReplaceSizeMethodCallQuickFix(desc, method)
|
||||
}
|
||||
}
|
||||
}
|
||||
} else {
|
||||
val isTestForEmpty = ((IS_LESS_THAN_OR_EQUAL_TO_INT.test(expectedCallExpression) && (constValue == 0))
|
||||
|| (IS_LESS_THAN_INT.test(expectedCallExpression) && (constValue == 1))
|
||||
|| IS_ZERO.test(expectedCallExpression))
|
||||
val isTestForNotEmpty = ((IS_GREATER_THAN_INT.test(expectedCallExpression) && (constValue == 0))
|
||||
|| (IS_GREATER_THAN_OR_EQUAL_TO_INT.test(expectedCallExpression) && (constValue == 1))
|
||||
|| IS_NOT_ZERO.test(expectedCallExpression))
|
||||
if (isTestForEmpty || isTestForNotEmpty) {
|
||||
val replacementMethod = isTestForEmpty.map(MethodNames.IS_EMPTY, MethodNames.IS_NOT_EMPTY)
|
||||
registerReplaceMethod(holder, expression, expectedCallExpression, replacementMethod) { desc, method ->
|
||||
ReplaceSizeMethodCallQuickFix(desc, method, noExpectedExpression = true)
|
||||
}
|
||||
} else if (hasAssertJMethod(expression, ABSTRACT_ITERABLE_ASSERT_CLASSNAME, MethodNames.HAS_SIZE_LESS_THAN)) {
|
||||
// new stuff in AssertJ 13.2.0
|
||||
val matchedMethod = BONUS_EXPRESSIONS_CALL_MATCHER_MAP.find { it.first.test(expectedCallExpression) }?.second ?: return
|
||||
registerReplaceMethod(holder, expression, expectedCallExpression, matchedMethod) { desc, method ->
|
||||
ReplaceSizeMethodCallQuickFix(desc, method)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
private fun isCharSequenceLength(expression: PsiExpression) = (expression is PsiMethodCallExpression) && CHAR_SEQUENCE_LENGTH.test(expression)
|
||||
|
||||
private fun isCollectionSize(expression: PsiExpression) = (expression is PsiMethodCallExpression) && COLLECTION_SIZE.test(expression)
|
||||
|
||||
@@ -83,6 +31,119 @@ class AssertThatSizeInspection : AbstractAssertJInspection() {
|
||||
return ((psiReferenceExpression.qualifierExpression?.type is PsiArrayType)
|
||||
&& ((psiReferenceExpression.resolve() as? PsiField)?.name == "length"))
|
||||
}
|
||||
|
||||
fun getMatch(expression: PsiMethodCallExpression, isForArrayOrCollection: Boolean, isForString: Boolean): Match? {
|
||||
val isLastExpression = expression.parent is PsiStatement
|
||||
val constValue = expression.calculateConstantParameterValue(0)
|
||||
if (IS_EQUAL_TO_INT.test(expression)) {
|
||||
return if ((constValue == 0) && isLastExpression) {
|
||||
Match(expression, MethodNames.IS_EMPTY, noExpectedExpression = true)
|
||||
} else {
|
||||
val equalToExpression = expression.firstArg
|
||||
if (isForArrayOrCollection && (isCollectionSize(equalToExpression) || isArrayLength(equalToExpression)) ||
|
||||
isForString && (isCollectionSize(equalToExpression) || isArrayLength(equalToExpression) || isCharSequenceLength(equalToExpression))
|
||||
) {
|
||||
Match(expression, MethodNames.HAS_SAME_SIZE_AS, expectedIsCollection = true)
|
||||
} else {
|
||||
Match(expression, MethodNames.HAS_SIZE)
|
||||
}
|
||||
}
|
||||
} else {
|
||||
val isTestForEmpty = ((IS_LESS_THAN_OR_EQUAL_TO_INT.test(expression) && (constValue == 0))
|
||||
|| (IS_LESS_THAN_INT.test(expression) && (constValue == 1))
|
||||
|| IS_ZERO.test(expression))
|
||||
val isTestForNotEmpty = ((IS_GREATER_THAN_INT.test(expression) && (constValue == 0))
|
||||
|| (IS_GREATER_THAN_OR_EQUAL_TO_INT.test(expression) && (constValue == 1))
|
||||
|| IS_NOT_ZERO.test(expression))
|
||||
if ((isTestForEmpty && isLastExpression) || isTestForNotEmpty) {
|
||||
val replacementMethod = isTestForEmpty.map(MethodNames.IS_EMPTY, MethodNames.IS_NOT_EMPTY)
|
||||
return Match(expression, replacementMethod, noExpectedExpression = true)
|
||||
} else if (hasAssertJMethod(expression, ABSTRACT_ITERABLE_ASSERT_CLASSNAME, MethodNames.HAS_SIZE_LESS_THAN)) {
|
||||
// new stuff in AssertJ 13.2.0
|
||||
val replacementMethod = BONUS_EXPRESSIONS_CALL_MATCHER_MAP.find { it.first.test(expression) }?.second ?: return null
|
||||
return Match(expression, replacementMethod)
|
||||
}
|
||||
return null
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
override fun getDisplayName() = DISPLAY_NAME
|
||||
|
||||
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitExpressionStatement(statement: PsiExpressionStatement) {
|
||||
super.visitExpressionStatement(statement)
|
||||
if (!statement.hasAssertThat()) {
|
||||
return
|
||||
}
|
||||
val staticMethodCall = statement.findStaticMethodCall() ?: return
|
||||
if (!ASSERT_THAT_INT.test(staticMethodCall)) {
|
||||
return
|
||||
}
|
||||
val actualExpression = staticMethodCall.firstArg
|
||||
val isForArrayOrCollection = isArrayLength(actualExpression) || isCollectionSize(actualExpression)
|
||||
val isForString = isCharSequenceLength(actualExpression)
|
||||
if (!(isForArrayOrCollection || isForString)) {
|
||||
return
|
||||
}
|
||||
val matches = staticMethodCall.collectMethodCallsUpToStatement()
|
||||
.mapNotNull { getMatch(it, isForArrayOrCollection, isForString) }
|
||||
.toList()
|
||||
if (matches.isNotEmpty()) {
|
||||
if (matches.size == 1) {
|
||||
val match = matches.single()
|
||||
val expression = match.methodCall
|
||||
registerReplaceMethod(
|
||||
holder,
|
||||
expression,
|
||||
expression,
|
||||
match.replacementMethod
|
||||
)
|
||||
{ desc, method ->
|
||||
ReplaceSizeMethodCallQuickFix(desc, method, noExpectedExpression = match.noExpectedExpression, expectedIsCollection = match.expectedIsCollection)
|
||||
}
|
||||
} else {
|
||||
// I could try to create a quickfix for this, too, but it's probably not worth the effort
|
||||
holder.registerProblem(statement, REMOVE_ALL_MESSAGE)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
|
||||
super.visitMethodCallExpression(expression)
|
||||
if (!expression.hasAssertThat()) {
|
||||
return
|
||||
}
|
||||
val isHasSize = HAS_SIZE.test(expression)
|
||||
if (!(isHasSize)) {
|
||||
return
|
||||
}
|
||||
val actualExpression = expression.firstArg
|
||||
|
||||
val isForArrayOrCollection = isArrayLength(actualExpression) || isCollectionSize(actualExpression)
|
||||
val isForString = isCharSequenceLength(actualExpression)
|
||||
if (!(isForArrayOrCollection
|
||||
|| (isForString && checkAssertedType(expression, ABSTRACT_CHAR_SEQUENCE_ASSERT_CLASSNAME)))
|
||||
) {
|
||||
return
|
||||
}
|
||||
registerConciseMethod(
|
||||
REMOVE_SIZE_DESCRIPTION_TEMPLATE,
|
||||
holder,
|
||||
expression,
|
||||
expression,
|
||||
MethodNames.HAS_SAME_SIZE_AS,
|
||||
::ReplaceHasSizeMethodCallQuickFix
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
class Match(
|
||||
val methodCall: PsiMethodCallExpression,
|
||||
val replacementMethod: String,
|
||||
val noExpectedExpression: Boolean = false,
|
||||
val expectedIsCollection: Boolean = false
|
||||
)
|
||||
}
|
||||
+75
@@ -0,0 +1,75 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.*
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.MoveOutMethodCallExpressionQuickFix
|
||||
|
||||
class AssertThatStringExpressionInspection : AbstractAssertJInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Asserting a string specific expression"
|
||||
|
||||
private val MAPPINGS = listOf(
|
||||
Mapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "isEmpty").parameterCount(0)!!,
|
||||
MethodNames.IS_EMPTY, MethodNames.IS_NOT_EMPTY
|
||||
),
|
||||
Mapping(
|
||||
CallMatcher.anyOf(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "equals").parameterCount(1)!!,
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "contentEquals").parameterCount(1)!!
|
||||
),
|
||||
MethodNames.IS_EQUAL_TO, MethodNames.IS_NOT_EQUAL_TO
|
||||
),
|
||||
Mapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "equalsIgnoreCase").parameterTypes(CommonClassNames.JAVA_LANG_STRING)!!,
|
||||
MethodNames.IS_EQUAL_TO_IC, MethodNames.IS_NOT_EQUAL_TO_IC
|
||||
),
|
||||
Mapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "contains").parameterCount(1)!!,
|
||||
MethodNames.CONTAINS, MethodNames.DOES_NOT_CONTAIN
|
||||
),
|
||||
Mapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "startsWith").parameterTypes(CommonClassNames.JAVA_LANG_STRING)!!,
|
||||
MethodNames.STARTS_WITH, MethodNames.DOES_NOT_START_WITH
|
||||
),
|
||||
Mapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "endsWith").parameterTypes(CommonClassNames.JAVA_LANG_STRING)!!,
|
||||
MethodNames.ENDS_WITH, MethodNames.DOES_NOT_END_WITH
|
||||
)
|
||||
)
|
||||
}
|
||||
|
||||
override fun getDisplayName() = DISPLAY_NAME
|
||||
|
||||
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitExpressionStatement(statement: PsiExpressionStatement) {
|
||||
super.visitExpressionStatement(statement)
|
||||
if (!statement.hasAssertThat()) {
|
||||
return
|
||||
}
|
||||
val staticMethodCall = statement.findStaticMethodCall() ?: return
|
||||
if (!ASSERT_THAT_BOOLEAN.test(staticMethodCall)) {
|
||||
return
|
||||
}
|
||||
val assertThatArgument = staticMethodCall.firstArg as? PsiMethodCallExpression ?: return
|
||||
val mapping = MAPPINGS.firstOrNull { it.callMatcher.test(assertThatArgument) } ?: return
|
||||
|
||||
val expectedCallExpression = statement.findOutmostMethodCall() ?: return
|
||||
val expectedResult = expectedCallExpression.getAllTheSameExpectedBooleanConstants() ?: return
|
||||
|
||||
val replacementMethod = if (expectedResult) mapping.replacementForTrue else mapping.replacementForFalse
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, replacementMethod, ::MoveOutMethodCallExpressionQuickFix)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private class Mapping(
|
||||
val callMatcher: CallMatcher,
|
||||
val replacementForTrue: String,
|
||||
val replacementForFalse: String
|
||||
)
|
||||
}
|
||||
+9
-2
@@ -4,8 +4,11 @@ import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.JavaElementVisitor
|
||||
import com.intellij.psi.PsiElementVisitor
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.intellij.psi.PsiStatement
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_CHAR_SEQUENCE_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.MethodNames
|
||||
import de.platon42.intellij.plugins.cajon.calculateConstantParameterValue
|
||||
import de.platon42.intellij.plugins.cajon.hasAssertThat
|
||||
|
||||
class AssertThatStringIsEmptyInspection : AbstractAssertJInspection() {
|
||||
|
||||
@@ -19,9 +22,13 @@ class AssertThatStringIsEmptyInspection : AbstractAssertJInspection() {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
|
||||
super.visitMethodCallExpression(expression)
|
||||
if (!expression.hasAssertThat()) {
|
||||
return
|
||||
}
|
||||
val isEqual = IS_EQUAL_TO_OBJECT.test(expression)
|
||||
val hasSize = HAS_SIZE.test(expression)
|
||||
if (!(isEqual || hasSize)) {
|
||||
val isLastExpression = expression.parent is PsiStatement
|
||||
if (!((isEqual || hasSize) && isLastExpression)) {
|
||||
return
|
||||
}
|
||||
|
||||
@@ -29,7 +36,7 @@ class AssertThatStringIsEmptyInspection : AbstractAssertJInspection() {
|
||||
return
|
||||
}
|
||||
|
||||
val value = calculateConstantParameterValue(expression, 0) ?: return
|
||||
val value = expression.calculateConstantParameterValue(0) ?: return
|
||||
if ((isEqual && (value == "")) || (hasSize && (value == 0))) {
|
||||
registerSimplifyMethod(holder, expression, MethodNames.IS_EMPTY)
|
||||
}
|
||||
|
||||
+146
@@ -0,0 +1,146 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.codeInspection.ProblemHighlightType
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.*
|
||||
import de.platon42.intellij.plugins.cajon.hasAssertThat
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.ReplaceIfByAssumeThatQuickFix
|
||||
|
||||
class AssumeThatInsteadOfReturnInspection : AbstractAssertJInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Replace conditional test exits by assumeThat() statements with same actual expression"
|
||||
private const val REPLACE_RETURN_BY_ASSUME_THAT_DESCRIPTION = "Conditional return should probably be an assumeThat() statement instead"
|
||||
|
||||
private const val MAX_RECURSION_DEPTH = 5
|
||||
private const val MAX_STATEMENTS_COUNT = 50
|
||||
|
||||
private val TEST_ANNOTATIONS = listOf(
|
||||
"org.junit.Test",
|
||||
"org.junit.jupiter.api.Test",
|
||||
"org.junit.jupiter.api.TestTemplate",
|
||||
"org.junit.jupiter.api.params.ParameterizedTest"
|
||||
)
|
||||
|
||||
private fun hasEmptyReturn(statement: PsiStatement): Boolean {
|
||||
return when (statement) {
|
||||
is PsiBlockStatement -> {
|
||||
val psiReturnStatement = (statement.firstChild as? PsiCodeBlock)?.statements?.singleOrNull() as? PsiReturnStatement
|
||||
(psiReturnStatement != null) && (psiReturnStatement.returnValue == null)
|
||||
}
|
||||
is PsiReturnStatement -> statement.returnValue == null
|
||||
else -> false
|
||||
}
|
||||
}
|
||||
|
||||
private fun registerProblem(holder: ProblemsHolder, isOnTheFly: Boolean, statement: PsiStatement, removeElse: Boolean) {
|
||||
val problemDescriptor = holder.manager.createProblemDescriptor(
|
||||
statement,
|
||||
statement,
|
||||
REPLACE_RETURN_BY_ASSUME_THAT_DESCRIPTION,
|
||||
ProblemHighlightType.GENERIC_ERROR_OR_WARNING,
|
||||
isOnTheFly,
|
||||
ReplaceIfByAssumeThatQuickFix(removeElse)
|
||||
)
|
||||
holder.registerProblem(problemDescriptor)
|
||||
}
|
||||
}
|
||||
|
||||
override fun getDisplayName() = DISPLAY_NAME
|
||||
|
||||
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitMethod(method: PsiMethod) {
|
||||
super.visitMethod(method)
|
||||
if (TEST_ANNOTATIONS.none(method::hasAnnotation)) {
|
||||
return
|
||||
}
|
||||
val containingClass = method.containingClass ?: return
|
||||
val visitor: PsiElementVisitor = TestMethodVisitor(holder, isOnTheFly, containingClass)
|
||||
method.accept(visitor)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
class TestMethodVisitor(
|
||||
private val holder: ProblemsHolder,
|
||||
private val isOnTheFly: Boolean,
|
||||
private val containingClass: PsiClass
|
||||
) : JavaRecursiveElementWalkingVisitor() {
|
||||
|
||||
private var contSearch = true
|
||||
|
||||
override fun visitExpressionStatement(statement: PsiExpressionStatement) {
|
||||
if (contSearch) {
|
||||
val methodCallExpression = statement.expression as? PsiMethodCallExpression
|
||||
if (methodCallExpression != null) {
|
||||
if (methodCallExpression.hasAssertThat()) {
|
||||
contSearch = false
|
||||
} else {
|
||||
val method = methodCallExpression.resolveMethod()
|
||||
if (method?.containingClass == containingClass) {
|
||||
val recursionVisitor = CheckForAssertThatCallsVisitor(containingClass, 1)
|
||||
method.accept(recursionVisitor)
|
||||
if (recursionVisitor.aborted || recursionVisitor.foundAssertThat) {
|
||||
contSearch = false
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
if (contSearch) {
|
||||
super.visitExpressionStatement(statement)
|
||||
}
|
||||
}
|
||||
|
||||
override fun visitIfStatement(statement: PsiIfStatement) {
|
||||
if (contSearch) {
|
||||
checkBranch(statement, statement.thenBranch, false)
|
||||
checkBranch(statement, statement.elseBranch, true)
|
||||
}
|
||||
}
|
||||
|
||||
private fun checkBranch(statement: PsiIfStatement, branch: PsiStatement?, removeElse: Boolean) {
|
||||
if (branch != null) {
|
||||
if (hasEmptyReturn(branch)) {
|
||||
registerProblem(holder, isOnTheFly, statement, removeElse)
|
||||
} else {
|
||||
branch.accept(TestMethodVisitor(holder, isOnTheFly, containingClass))
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
class CheckForAssertThatCallsVisitor(private val containingClass: PsiClass, private var depth: Int) : JavaRecursiveElementWalkingVisitor() {
|
||||
var foundAssertThat = false
|
||||
private var statementCount = 0
|
||||
var aborted = false
|
||||
|
||||
override fun visitExpressionStatement(statement: PsiExpressionStatement) {
|
||||
if (foundAssertThat || aborted) {
|
||||
return
|
||||
}
|
||||
if (++statementCount > MAX_STATEMENTS_COUNT) {
|
||||
aborted = true
|
||||
return
|
||||
}
|
||||
super.visitExpressionStatement(statement)
|
||||
val methodCallExpression = statement.expression as? PsiMethodCallExpression
|
||||
if (methodCallExpression != null) {
|
||||
foundAssertThat = methodCallExpression.hasAssertThat()
|
||||
val method = methodCallExpression.resolveMethod()
|
||||
if (method?.containingClass == containingClass) {
|
||||
if (depth < MAX_RECURSION_DEPTH) {
|
||||
val recursionVisitor = CheckForAssertThatCallsVisitor(containingClass, depth + 1)
|
||||
method.accept(recursionVisitor)
|
||||
foundAssertThat = recursionVisitor.foundAssertThat
|
||||
statementCount += recursionVisitor.statementCount
|
||||
aborted = recursionVisitor.aborted
|
||||
} else {
|
||||
aborted = true
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
+3
-1
@@ -16,6 +16,8 @@ class JUnitAssertToAssertJInspection : AbstractJUnitAssertInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Convert JUnit assertions to AssertJ"
|
||||
private const val CONVERT_MESSAGE_TEMPLATE = "%s can be converted to AssertJ style"
|
||||
private const val CONVERT_DESCRIPTION_TEMPLATE = "Convert %s() to assertThat().%s()"
|
||||
|
||||
private val MAPPINGS = listOf(
|
||||
Mapping(
|
||||
@@ -142,7 +144,7 @@ class JUnitAssertToAssertJInspection : AbstractJUnitAssertInspection() {
|
||||
quickFixSupplier: (String, String) -> LocalQuickFix
|
||||
) {
|
||||
val originalMethod = getOriginalMethodName(expression) ?: return
|
||||
val description = REPLACE_DESCRIPTION_TEMPLATE.format(originalMethod, replacementMethod)
|
||||
val description = CONVERT_DESCRIPTION_TEMPLATE.format(originalMethod, replacementMethod)
|
||||
val message = CONVERT_MESSAGE_TEMPLATE.format(originalMethod)
|
||||
val quickfix = quickFixSupplier(description, replacementMethod)
|
||||
holder.registerProblem(expression, message, quickfix)
|
||||
|
||||
+93
@@ -0,0 +1,93 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.codeInspection.ProblemHighlightType
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.*
|
||||
import com.intellij.psi.util.PsiTreeUtil
|
||||
import com.siyeh.ig.psiutils.TrackingEquivalenceChecker
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.JoinStatementsQuickFix
|
||||
|
||||
class JoinAssertThatStatementsInspection : AbstractAssertJInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Join multiple assertThat() statements with same actual expression"
|
||||
private const val CAN_BE_JOINED_DESCRIPTION = "Multiple assertThat() statements can be joined together"
|
||||
}
|
||||
|
||||
override fun getDisplayName() = DISPLAY_NAME
|
||||
|
||||
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitCodeBlock(block: PsiCodeBlock) {
|
||||
super.visitCodeBlock(block)
|
||||
var lastActualExpression: PsiExpression? = null
|
||||
var sameCount = 0
|
||||
var firstStatement: PsiStatement? = null
|
||||
var lastStatement: PsiStatement? = null
|
||||
val equivalenceChecker = TrackingEquivalenceChecker()
|
||||
for (statement in block.statements) {
|
||||
val assertThatCall = isLegitAssertThatCall(statement)
|
||||
var reset = true
|
||||
var actualExpression: PsiExpression? = null
|
||||
if (assertThatCall != null) {
|
||||
reset = (lastActualExpression == null)
|
||||
actualExpression = assertThatCall.firstArg
|
||||
if (!reset) {
|
||||
val isSame = when (actualExpression) {
|
||||
is PsiMethodCallExpression -> equivalenceChecker.expressionsAreEquivalent(actualExpression, lastActualExpression)
|
||||
&& PsiTreeUtil.findChildrenOfAnyType(
|
||||
actualExpression,
|
||||
false,
|
||||
PsiMethodCallExpression::class.java
|
||||
).none { KNOWN_METHODS_WITH_SIDE_EFFECTS.test(it) }
|
||||
else -> equivalenceChecker.expressionsAreEquivalent(actualExpression, lastActualExpression)
|
||||
}
|
||||
if (isSame) {
|
||||
sameCount++
|
||||
lastStatement = statement
|
||||
} else {
|
||||
reset = true
|
||||
}
|
||||
}
|
||||
}
|
||||
if (reset) {
|
||||
if (sameCount > 1) {
|
||||
registerProblem(holder, isOnTheFly, firstStatement!!, lastStatement!!)
|
||||
}
|
||||
firstStatement = statement
|
||||
lastStatement = null
|
||||
lastActualExpression = actualExpression
|
||||
sameCount = 1
|
||||
}
|
||||
}
|
||||
if (sameCount > 1) {
|
||||
registerProblem(holder, isOnTheFly, firstStatement!!, lastStatement!!)
|
||||
}
|
||||
}
|
||||
|
||||
private fun isLegitAssertThatCall(statement: PsiStatement?): PsiMethodCallExpression? {
|
||||
if ((statement is PsiExpressionStatement) && (statement.expression is PsiMethodCallExpression)) {
|
||||
if (!statement.hasAssertThat()) {
|
||||
return null
|
||||
}
|
||||
val assertThatCall = PsiTreeUtil.findChildrenOfType(statement, PsiMethodCallExpression::class.java).find { ALL_ASSERT_THAT_MATCHERS.test(it) }
|
||||
return assertThatCall?.takeIf { it.findFluentCallTo(EXTRACTING_CALL_MATCHERS) == null }
|
||||
}
|
||||
return null
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private fun registerProblem(holder: ProblemsHolder, isOnTheFly: Boolean, firstStatement: PsiStatement, lastStatement: PsiStatement) {
|
||||
val problemDescriptor = holder.manager.createProblemDescriptor(
|
||||
firstStatement,
|
||||
lastStatement,
|
||||
CAN_BE_JOINED_DESCRIPTION,
|
||||
ProblemHighlightType.GENERIC_ERROR_OR_WARNING,
|
||||
isOnTheFly,
|
||||
JoinStatementsQuickFix()
|
||||
)
|
||||
holder.registerProblem(problemDescriptor)
|
||||
}
|
||||
}
|
||||
+2
-1
@@ -4,6 +4,7 @@ import com.intellij.codeInspection.LocalQuickFix
|
||||
|
||||
abstract class AbstractCommonQuickFix(private val description: String) : LocalQuickFix {
|
||||
|
||||
override fun getFamilyName() = description
|
||||
override fun getName() = description
|
||||
|
||||
override fun getFamilyName() = description
|
||||
}
|
||||
@@ -8,12 +8,13 @@ import com.intellij.psi.util.PsiTreeUtil
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
|
||||
class ForGuavaPostFix {
|
||||
|
||||
companion object {
|
||||
val REPLACE_BY_GUAVA_ASSERT_THAT_AND_STATIC_IMPORT: (Project, ProblemDescriptor) -> Unit = exit@
|
||||
{ _, descriptor ->
|
||||
val element = descriptor.startElement
|
||||
val statement = PsiTreeUtil.getParentOfType(element, PsiStatement::class.java) ?: return@exit
|
||||
val assertThatCall = PsiTreeUtil.findChildrenOfType(statement, PsiMethodCallExpression::class.java).find { CORE_ASSERT_THAT_MATCHER.test(it) } ?: return@exit
|
||||
val assertThatCall = statement.findStaticMethodCall() ?: return@exit
|
||||
|
||||
val newMethodCall = createGuavaAssertThat(element, assertThatCall.firstArg)
|
||||
newMethodCall.resolveMethod()?.addAsStaticImport(element, AssertJClassNames.ASSERTIONS_CLASSNAME)
|
||||
|
||||
+37
@@ -0,0 +1,37 @@
|
||||
package de.platon42.intellij.plugins.cajon.quickfixes
|
||||
|
||||
import com.intellij.codeInspection.ProblemDescriptor
|
||||
import com.intellij.openapi.project.Project
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.intellij.psi.PsiUnaryExpression
|
||||
import com.intellij.psi.util.PsiTreeUtil
|
||||
import com.intellij.psi.util.PsiUtil
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
|
||||
class InvertUnaryStatementQuickFix : AbstractCommonQuickFix(INVERT_CONDITION_DESCRIPTION) {
|
||||
|
||||
companion object {
|
||||
private const val INVERT_CONDITION_DESCRIPTION = "Invert condition in assertThat()"
|
||||
}
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val outmostCallExpression = descriptor.startElement as? PsiMethodCallExpression ?: return
|
||||
val assertThatMethodCall = outmostCallExpression.findStaticMethodCall() ?: return
|
||||
val assertExpression = assertThatMethodCall.firstArg as? PsiUnaryExpression ?: return
|
||||
val operand = PsiUtil.skipParenthesizedExprDown(assertExpression.operand) ?: return
|
||||
assertExpression.replace(operand)
|
||||
|
||||
var methodCall: PsiMethodCallExpression? = assertThatMethodCall
|
||||
while (methodCall != null) {
|
||||
val expectedResult = methodCall.getExpectedBooleanResult()
|
||||
val nextMethodCall = PsiTreeUtil.getParentOfType(methodCall, PsiMethodCallExpression::class.java)
|
||||
if (expectedResult != null) {
|
||||
val replacementMethod = expectedResult.map(MethodNames.IS_FALSE, MethodNames.IS_TRUE)
|
||||
val expectedExpression = createExpectedMethodCall(methodCall, replacementMethod)
|
||||
expectedExpression.replaceQualifierFromMethodCall(methodCall)
|
||||
methodCall.replace(expectedExpression)
|
||||
}
|
||||
methodCall = nextMethodCall
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,53 @@
|
||||
package de.platon42.intellij.plugins.cajon.quickfixes
|
||||
|
||||
import com.intellij.codeInspection.ProblemDescriptor
|
||||
import com.intellij.openapi.project.Project
|
||||
import com.intellij.psi.*
|
||||
import com.intellij.psi.util.PsiTreeUtil
|
||||
import de.platon42.intellij.plugins.cajon.findStaticMethodCall
|
||||
import de.platon42.intellij.plugins.cajon.shortenAndReformat
|
||||
|
||||
class JoinStatementsQuickFix : AbstractCommonQuickFix(JOIN_STATEMENTS_MESSAGE) {
|
||||
|
||||
companion object {
|
||||
private const val JOIN_STATEMENTS_MESSAGE = "Join assertThat() statements"
|
||||
}
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val firstStatement = descriptor.startElement as PsiExpressionStatement
|
||||
val lastStatement = descriptor.endElement as PsiExpressionStatement
|
||||
do {
|
||||
val commentsToKeep = ArrayList<PsiComment>()
|
||||
val stuffToDelete = ArrayList<PsiElement>()
|
||||
var previousStatement = lastStatement.prevSibling ?: throw IllegalStateException("Internal error")
|
||||
while (previousStatement !is PsiExpressionStatement) {
|
||||
if (previousStatement is PsiComment) {
|
||||
commentsToKeep.add(previousStatement.copy() as PsiComment)
|
||||
}
|
||||
stuffToDelete.add(previousStatement)
|
||||
previousStatement = previousStatement.prevSibling ?: throw IllegalStateException("Internal error")
|
||||
}
|
||||
stuffToDelete.forEach { if (it.isValid) it.delete() }
|
||||
|
||||
val statementComments = PsiTreeUtil.getChildrenOfAnyType(previousStatement, PsiComment::class.java)
|
||||
commentsToKeep.addAll(statementComments)
|
||||
|
||||
val assertThatCallOfCursorStatement = lastStatement.findStaticMethodCall() ?: throw IllegalStateException("Internal error")
|
||||
|
||||
val lastElementBeforeConcat = assertThatCallOfCursorStatement.parent
|
||||
commentsToKeep.forEach {
|
||||
lastElementBeforeConcat.addAfter(it, lastElementBeforeConcat.firstChild)
|
||||
val newLineNode =
|
||||
PsiParserFacade.SERVICE.getInstance(project).createWhiteSpaceFromText("\n\t")
|
||||
|
||||
lastElementBeforeConcat.addAfter(newLineNode, lastElementBeforeConcat.firstChild)
|
||||
}
|
||||
|
||||
val newLeaf = previousStatement.firstChild
|
||||
assertThatCallOfCursorStatement.replace(newLeaf)
|
||||
previousStatement.delete()
|
||||
} while (previousStatement !== firstStatement)
|
||||
val codeBlock = PsiTreeUtil.getParentOfType(lastStatement, PsiCodeBlock::class.java) ?: return
|
||||
codeBlock.shortenAndReformat()
|
||||
}
|
||||
}
|
||||
+44
@@ -0,0 +1,44 @@
|
||||
package de.platon42.intellij.plugins.cajon.quickfixes
|
||||
|
||||
import com.intellij.codeInspection.ProblemDescriptor
|
||||
import com.intellij.openapi.project.Project
|
||||
import com.intellij.psi.JavaPsiFacade
|
||||
import com.intellij.psi.PsiInstanceOfExpression
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.intellij.psi.util.PsiUtil
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
|
||||
class MoveOutInstanceOfExpressionQuickFix(description: String, private val replacementMethod: String) : AbstractCommonQuickFix(description) {
|
||||
|
||||
companion object {
|
||||
private const val REMOVE_INSTANCEOF_DESCRIPTION = "Move instanceof in actual expressions out of assertThat()"
|
||||
}
|
||||
|
||||
override fun getFamilyName(): String {
|
||||
return REMOVE_INSTANCEOF_DESCRIPTION
|
||||
}
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val outmostCallExpression = descriptor.startElement as? PsiMethodCallExpression ?: return
|
||||
val assertThatMethodCall = outmostCallExpression.findStaticMethodCall() ?: return
|
||||
val assertExpression = assertThatMethodCall.firstArg as? PsiInstanceOfExpression ?: return
|
||||
val expectedClass = assertExpression.checkType ?: return
|
||||
|
||||
val methodsToFix = assertThatMethodCall.collectMethodCallsUpToStatement()
|
||||
.filter { it.getExpectedBooleanResult() != null }
|
||||
.toList()
|
||||
|
||||
val factory = JavaPsiFacade.getElementFactory(project)
|
||||
val classObjectAccess = factory.createExpressionFromText("${expectedClass.type.canonicalText}.class", null)
|
||||
|
||||
val operand = PsiUtil.deparenthesizeExpression(assertExpression.operand) ?: return
|
||||
assertExpression.replace(operand)
|
||||
|
||||
methodsToFix
|
||||
.forEach {
|
||||
val expectedExpression = createExpectedMethodCall(it, replacementMethod, classObjectAccess)
|
||||
expectedExpression.replaceQualifierFromMethodCall(it)
|
||||
it.replace(expectedExpression)
|
||||
}
|
||||
}
|
||||
}
|
||||
+37
@@ -0,0 +1,37 @@
|
||||
package de.platon42.intellij.plugins.cajon.quickfixes
|
||||
|
||||
import com.intellij.codeInspection.ProblemDescriptor
|
||||
import com.intellij.openapi.project.Project
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
|
||||
class MoveOutMethodCallExpressionQuickFix(description: String, private val replacementMethod: String) : AbstractCommonQuickFix(description) {
|
||||
|
||||
companion object {
|
||||
private const val REMOVE_ACTUAL_EXPRESSION_DESCRIPTION = "Move method calls in actual expressions out of assertThat()"
|
||||
}
|
||||
|
||||
override fun getFamilyName(): String {
|
||||
return REMOVE_ACTUAL_EXPRESSION_DESCRIPTION
|
||||
}
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val outmostCallExpression = descriptor.startElement as? PsiMethodCallExpression ?: return
|
||||
val assertThatMethodCall = outmostCallExpression.findStaticMethodCall() ?: return
|
||||
val assertExpression = assertThatMethodCall.firstArg as? PsiMethodCallExpression ?: return
|
||||
val assertExpressionArg = assertExpression.getArgOrNull(0)?.copy()
|
||||
|
||||
val methodsToFix = assertThatMethodCall.collectMethodCallsUpToStatement()
|
||||
.filter { it.getExpectedBooleanResult() != null }
|
||||
.toList()
|
||||
|
||||
assertExpression.replace(assertExpression.qualifierExpression)
|
||||
|
||||
methodsToFix
|
||||
.forEach {
|
||||
val expectedExpression = createExpectedMethodCall(it, replacementMethod, *listOfNotNull(assertExpressionArg).toTypedArray())
|
||||
expectedExpression.replaceQualifierFromMethodCall(it)
|
||||
it.replace(expectedExpression)
|
||||
}
|
||||
}
|
||||
}
|
||||
+4
@@ -9,6 +9,10 @@ class QuickFixWithPostfixDelegate(
|
||||
private val postfix: (Project, ProblemDescriptor) -> Unit
|
||||
) : LocalQuickFix by mainFix {
|
||||
|
||||
override fun getName(): String {
|
||||
return mainFix.name
|
||||
}
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
mainFix.applyFix(project, descriptor)
|
||||
postfix(project, descriptor)
|
||||
|
||||
+21
-8
@@ -11,16 +11,29 @@ class RemoveActualOutmostMethodCallQuickFix(
|
||||
private val noExpectedExpression: Boolean = false
|
||||
) : AbstractCommonQuickFix(description) {
|
||||
|
||||
companion object {
|
||||
private const val REMOVE_ACTUAL_EXPRESSION_DESCRIPTION = "Remove method calls in actual expressions and use better assertion"
|
||||
}
|
||||
|
||||
override fun getFamilyName(): String {
|
||||
return REMOVE_ACTUAL_EXPRESSION_DESCRIPTION
|
||||
}
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val element = descriptor.startElement
|
||||
val methodCallExpression = element as? PsiMethodCallExpression ?: return
|
||||
val assertExpression = methodCallExpression.firstArg as? PsiMethodCallExpression ?: return
|
||||
val outmostCallExpression = descriptor.startElement as? PsiMethodCallExpression ?: return
|
||||
val assertThatMethodCall = outmostCallExpression.findStaticMethodCall() ?: return
|
||||
val assertExpression = assertThatMethodCall.firstArg as? PsiMethodCallExpression ?: return
|
||||
|
||||
val methodsToFix = assertThatMethodCall.gatherAssertionCalls()
|
||||
|
||||
assertExpression.replace(assertExpression.qualifierExpression)
|
||||
|
||||
val oldExpectedExpression = element.findOutmostMethodCall() ?: return
|
||||
val args = if (noExpectedExpression) emptyArray() else oldExpectedExpression.argumentList.expressions
|
||||
val expectedExpression = createExpectedMethodCall(element, replacementMethod, *args)
|
||||
expectedExpression.replaceQualifierFromMethodCall(oldExpectedExpression)
|
||||
oldExpectedExpression.replace(expectedExpression)
|
||||
methodsToFix
|
||||
.forEach {
|
||||
val args = if (noExpectedExpression) emptyArray() else it.argumentList.expressions
|
||||
val expectedExpression = createExpectedMethodCall(it, replacementMethod, *args)
|
||||
expectedExpression.replaceQualifierFromMethodCall(it)
|
||||
it.replace(expectedExpression)
|
||||
}
|
||||
}
|
||||
}
|
||||
+35
@@ -0,0 +1,35 @@
|
||||
package de.platon42.intellij.plugins.cajon.quickfixes
|
||||
|
||||
import com.intellij.codeInspection.ProblemDescriptor
|
||||
import com.intellij.openapi.project.Project
|
||||
import com.intellij.psi.PsiExpression
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.intellij.psi.PsiReferenceExpression
|
||||
import de.platon42.intellij.plugins.cajon.createExpectedMethodCall
|
||||
import de.platon42.intellij.plugins.cajon.firstArg
|
||||
import de.platon42.intellij.plugins.cajon.qualifierExpression
|
||||
import de.platon42.intellij.plugins.cajon.replaceQualifierFromMethodCall
|
||||
|
||||
class ReplaceHasSizeMethodCallQuickFix(description: String, private val replacementMethod: String) : AbstractCommonQuickFix(description) {
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val methodCallExpression = descriptor.startElement as? PsiMethodCallExpression ?: return
|
||||
|
||||
replaceCollectionSizeOrArrayLength(methodCallExpression.firstArg)
|
||||
|
||||
val expectedExpression = createExpectedMethodCall(methodCallExpression, replacementMethod, methodCallExpression.firstArg)
|
||||
|
||||
expectedExpression.replaceQualifierFromMethodCall(methodCallExpression)
|
||||
methodCallExpression.replace(expectedExpression)
|
||||
}
|
||||
|
||||
private fun replaceCollectionSizeOrArrayLength(assertExpression: PsiExpression) {
|
||||
assertExpression.replace(
|
||||
when (assertExpression) {
|
||||
is PsiReferenceExpression -> assertExpression.qualifierExpression!!
|
||||
is PsiMethodCallExpression -> assertExpression.qualifierExpression
|
||||
else -> return
|
||||
}
|
||||
)
|
||||
}
|
||||
}
|
||||
+49
@@ -0,0 +1,49 @@
|
||||
package de.platon42.intellij.plugins.cajon.quickfixes
|
||||
|
||||
import com.intellij.codeInspection.ProblemDescriptor
|
||||
import com.intellij.openapi.project.Project
|
||||
import com.intellij.psi.JavaPsiFacade
|
||||
import com.intellij.psi.PsiBlockStatement
|
||||
import com.intellij.psi.PsiDeclarationStatement
|
||||
import com.intellij.psi.PsiIfStatement
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
|
||||
class ReplaceIfByAssumeThatQuickFix(private val removeElse: Boolean) : AbstractCommonQuickFix(REPLACE_IF_MESSAGE) {
|
||||
|
||||
companion object {
|
||||
private const val REPLACE_IF_MESSAGE = "Replace if statement by assumeTrue()"
|
||||
}
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val ifStatement = descriptor.startElement as PsiIfStatement
|
||||
|
||||
val condition = ifStatement.condition ?: return
|
||||
val factory = JavaPsiFacade.getElementFactory(ifStatement.project)
|
||||
val assumptionExpression = if (removeElse) MethodNames.IS_TRUE else MethodNames.IS_FALSE
|
||||
val assumeThatStatement = factory.createStatementFromText(
|
||||
"${AssertJClassNames.ASSUMPTIONS_CLASSNAME}.${MethodNames.ASSUME_THAT}(true).$assumptionExpression();",
|
||||
ifStatement
|
||||
)
|
||||
val assumeThatMethodCall = assumeThatStatement.findStaticMethodCall() ?: return
|
||||
assumeThatMethodCall.firstArg.replace(condition)
|
||||
assumeThatMethodCall.resolveMethod()?.addAsStaticImport(ifStatement)
|
||||
|
||||
val branchToKeep = (if (removeElse) ifStatement.thenBranch else ifStatement.elseBranch)?.copy()
|
||||
val parentBlock = ifStatement.parent
|
||||
if (branchToKeep != null) {
|
||||
val anchorElement = ifStatement.nextSibling
|
||||
if (branchToKeep is PsiBlockStatement) {
|
||||
val codeBlock = branchToKeep.codeBlock
|
||||
val hasDeclarations = codeBlock.statements.any { it is PsiDeclarationStatement }
|
||||
if (hasDeclarations) {
|
||||
parentBlock.addAfter(branchToKeep, anchorElement)
|
||||
} else {
|
||||
parentBlock.addRangeAfter(codeBlock.firstBodyElement, codeBlock.lastBodyElement, anchorElement)
|
||||
}
|
||||
} else {
|
||||
parentBlock.addAfter(branchToKeep, anchorElement)
|
||||
}
|
||||
}
|
||||
ifStatement.replace(assumeThatStatement).shortenAndReformat()
|
||||
}
|
||||
}
|
||||
+8
@@ -10,6 +10,14 @@ import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.GUAVA_ASSE
|
||||
class ReplaceJUnitAssertMethodCallQuickFix(description: String, private val replacementMethod: String, private val noExpectedExpression: Boolean) :
|
||||
AbstractCommonQuickFix(description) {
|
||||
|
||||
companion object {
|
||||
private const val CONVERT_DESCRIPTION = "Convert JUnit assertions to assertJ"
|
||||
}
|
||||
|
||||
override fun getFamilyName(): String {
|
||||
return CONVERT_DESCRIPTION
|
||||
}
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val element = descriptor.startElement
|
||||
val methodCallExpression = element as? PsiMethodCallExpression ?: return
|
||||
|
||||
+8
@@ -8,6 +8,14 @@ import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.GUAVA_ASSE
|
||||
|
||||
class ReplaceJUnitDeltaAssertMethodCallQuickFix(description: String, private val replacementMethod: String) : AbstractCommonQuickFix(description) {
|
||||
|
||||
companion object {
|
||||
private const val CONVERT_DESCRIPTION = "Convert JUnit assertions to assertJ"
|
||||
}
|
||||
|
||||
override fun getFamilyName(): String {
|
||||
return CONVERT_DESCRIPTION
|
||||
}
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val element = descriptor.startElement
|
||||
val methodCallExpression = element as? PsiMethodCallExpression ?: return
|
||||
|
||||
+9
-4
@@ -6,10 +6,15 @@ import com.intellij.psi.PsiMethodCallExpression
|
||||
import de.platon42.intellij.plugins.cajon.createExpectedMethodCall
|
||||
import de.platon42.intellij.plugins.cajon.replaceQualifierFromMethodCall
|
||||
|
||||
class ReplaceSimpleMethodCallQuickFix(
|
||||
description: String,
|
||||
private val replacementMethod: String
|
||||
) : AbstractCommonQuickFix(description) {
|
||||
class ReplaceSimpleMethodCallQuickFix(description: String, private val replacementMethod: String) : AbstractCommonQuickFix(description) {
|
||||
|
||||
companion object {
|
||||
private const val REPLACE_DESCRIPTION = "Replace methods by better ones"
|
||||
}
|
||||
|
||||
override fun getFamilyName(): String {
|
||||
return REPLACE_DESCRIPTION
|
||||
}
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val element = descriptor.startElement
|
||||
|
||||
+20
-13
@@ -14,22 +14,29 @@ class ReplaceSizeMethodCallQuickFix(
|
||||
private val expectedIsCollection: Boolean = false
|
||||
) : AbstractCommonQuickFix(description) {
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val element = descriptor.startElement
|
||||
val methodCallExpression = element as? PsiMethodCallExpression ?: return
|
||||
val assertExpression = methodCallExpression.firstArg
|
||||
replaceCollectionSizeOrArrayLength(assertExpression)
|
||||
val oldExpectedExpression = element.findOutmostMethodCall() ?: return
|
||||
|
||||
if (expectedIsCollection) {
|
||||
replaceCollectionSizeOrArrayLength(oldExpectedExpression.firstArg)
|
||||
companion object {
|
||||
private const val REPLACE_DESCRIPTION = "Replace methods by better ones"
|
||||
}
|
||||
|
||||
val args = if (noExpectedExpression) emptyArray() else arrayOf(oldExpectedExpression.firstArg)
|
||||
val expectedExpression = createExpectedMethodCall(element, replacementMethod, *args)
|
||||
override fun getFamilyName(): String {
|
||||
return REPLACE_DESCRIPTION
|
||||
}
|
||||
|
||||
expectedExpression.replaceQualifierFromMethodCall(oldExpectedExpression)
|
||||
oldExpectedExpression.replace(expectedExpression)
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val outmostCallExpression = descriptor.startElement as? PsiMethodCallExpression ?: return
|
||||
val assertThatMethodCall = outmostCallExpression.findStaticMethodCall() ?: return
|
||||
val assertExpression = assertThatMethodCall.firstArg
|
||||
replaceCollectionSizeOrArrayLength(assertExpression)
|
||||
|
||||
if (expectedIsCollection) {
|
||||
replaceCollectionSizeOrArrayLength(outmostCallExpression.firstArg)
|
||||
}
|
||||
|
||||
val args = if (noExpectedExpression) emptyArray() else arrayOf(outmostCallExpression.firstArg)
|
||||
val expectedExpression = createExpectedMethodCall(outmostCallExpression, replacementMethod, *args)
|
||||
|
||||
expectedExpression.replaceQualifierFromMethodCall(outmostCallExpression)
|
||||
outmostCallExpression.replace(expectedExpression)
|
||||
}
|
||||
|
||||
private fun replaceCollectionSizeOrArrayLength(assertExpression: PsiExpression) {
|
||||
|
||||
+24
-11
@@ -4,10 +4,7 @@ import com.intellij.codeInspection.ProblemDescriptor
|
||||
import com.intellij.openapi.project.Project
|
||||
import com.intellij.psi.PsiBinaryExpression
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import de.platon42.intellij.plugins.cajon.createExpectedMethodCall
|
||||
import de.platon42.intellij.plugins.cajon.findOutmostMethodCall
|
||||
import de.platon42.intellij.plugins.cajon.firstArg
|
||||
import de.platon42.intellij.plugins.cajon.replaceQualifierFromMethodCall
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
|
||||
class SplitBinaryExpressionMethodCallQuickFix(
|
||||
description: String,
|
||||
@@ -16,17 +13,33 @@ class SplitBinaryExpressionMethodCallQuickFix(
|
||||
private val noExpectedExpression: Boolean = false
|
||||
) : AbstractCommonQuickFix(description) {
|
||||
|
||||
companion object {
|
||||
private const val SPLIT_EXPRESSION_DESCRIPTION = "Split binary expressions out of assertThat()"
|
||||
}
|
||||
|
||||
override fun getFamilyName(): String {
|
||||
return SPLIT_EXPRESSION_DESCRIPTION
|
||||
}
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val element = descriptor.startElement
|
||||
val methodCallExpression = element as? PsiMethodCallExpression ?: return
|
||||
val binaryExpression = methodCallExpression.firstArg as? PsiBinaryExpression ?: return
|
||||
val outmostCallExpression = descriptor.startElement as? PsiMethodCallExpression ?: return
|
||||
val assertThatMethodCall = outmostCallExpression.findStaticMethodCall() ?: return
|
||||
|
||||
val methodsToFix = assertThatMethodCall.collectMethodCallsUpToStatement()
|
||||
.filter { it.getExpectedBooleanResult() != null }
|
||||
.toList()
|
||||
|
||||
val binaryExpression = assertThatMethodCall.firstArg as? PsiBinaryExpression ?: return
|
||||
val expectedArgument = (if (pickRightOperand) binaryExpression.lOperand else binaryExpression.rOperand)?.copy() ?: return
|
||||
binaryExpression.replace(if (pickRightOperand) binaryExpression.rOperand!! else binaryExpression.lOperand)
|
||||
|
||||
val oldExpectedExpression = element.findOutmostMethodCall() ?: return
|
||||
val args = if (noExpectedExpression) emptyArray() else arrayOf(expectedArgument)
|
||||
val expectedExpression = createExpectedMethodCall(element, replacementMethod, *args)
|
||||
expectedExpression.replaceQualifierFromMethodCall(oldExpectedExpression)
|
||||
oldExpectedExpression.replace(expectedExpression)
|
||||
|
||||
methodsToFix
|
||||
.forEach {
|
||||
val expectedExpression = createExpectedMethodCall(it, replacementMethod, *args)
|
||||
expectedExpression.replaceQualifierFromMethodCall(it)
|
||||
it.replace(expectedExpression)
|
||||
}
|
||||
}
|
||||
}
|
||||
-22
@@ -1,22 +0,0 @@
|
||||
package de.platon42.intellij.plugins.cajon.quickfixes
|
||||
|
||||
import com.intellij.codeInspection.ProblemDescriptor
|
||||
import com.intellij.openapi.project.Project
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
|
||||
class SplitEqualsExpressionMethodCallQuickFix(description: String, private val replacementMethod: String) : AbstractCommonQuickFix(description) {
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val element = descriptor.startElement
|
||||
val methodCallExpression = element as? PsiMethodCallExpression ?: return
|
||||
val equalsMethodCall = methodCallExpression.firstArg as? PsiMethodCallExpression ?: return
|
||||
val expectedArgument = equalsMethodCall.firstArg.copy()
|
||||
equalsMethodCall.replace(equalsMethodCall.qualifierExpression)
|
||||
|
||||
val oldExpectedExpression = element.findOutmostMethodCall() ?: return
|
||||
val expectedExpression = createExpectedMethodCall(element, replacementMethod, expectedArgument)
|
||||
expectedExpression.replaceQualifierFromMethodCall(oldExpectedExpression)
|
||||
oldExpectedExpression.replace(expectedExpression)
|
||||
}
|
||||
}
|
||||
+9
-1
@@ -8,7 +8,15 @@ import de.platon42.intellij.plugins.cajon.findOutmostMethodCall
|
||||
import de.platon42.intellij.plugins.cajon.firstArg
|
||||
import de.platon42.intellij.plugins.cajon.replaceQualifierFromMethodCall
|
||||
|
||||
class RemoveExpectedOutmostMethodCallQuickFix(description: String, private val replacementMethod: String) : AbstractCommonQuickFix(description) {
|
||||
class UnwrapExpectedStaticMethodCallQuickFix(description: String, private val replacementMethod: String) : AbstractCommonQuickFix(description) {
|
||||
|
||||
companion object {
|
||||
private const val REMOVE_EXPECTED_OUTMOST_DESCRIPTION = "Unwrap expected expressions and use better assertion"
|
||||
}
|
||||
|
||||
override fun getFamilyName(): String {
|
||||
return REMOVE_EXPECTED_OUTMOST_DESCRIPTION
|
||||
}
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val element = descriptor.startElement
|
||||
+8
-12
@@ -7,21 +7,14 @@ import com.intellij.psi.*
|
||||
import com.intellij.psi.util.PropertyUtilBase
|
||||
import com.intellij.psi.util.PsiTreeUtil
|
||||
import com.intellij.psi.util.PsiTypesUtil
|
||||
import com.intellij.util.ArrayUtil
|
||||
import com.intellij.util.ProcessingContext
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames
|
||||
import de.platon42.intellij.plugins.cajon.CORE_ASSERT_THAT_MATCHER
|
||||
import de.platon42.intellij.plugins.cajon.firstArg
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
|
||||
class ExtractorReferenceContributor : PsiReferenceContributor() {
|
||||
|
||||
companion object {
|
||||
|
||||
private val EXTRACTING_FROM_OBJECT = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_OBJECT_ASSERT_CLASSNAME, "extracting")
|
||||
private val EXTRACTING_FROM_ITERABLE = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_ITERABLE_ASSERT_CLASSNAME, "extracting")
|
||||
private val FLAT_EXTRACTING_FROM_ITERABLE = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_ITERABLE_ASSERT_CLASSNAME, "flatExtracting")
|
||||
private val EXTRACTING_RESULT_OF_FROM_ITERABLE = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_ITERABLE_ASSERT_CLASSNAME, "extractingResultOf")
|
||||
|
||||
private val BY_NAME = CallMatcher.staticCall(AssertJClassNames.EXTRACTORS_CLASSNAME, "byName")
|
||||
private val RESULT_OF = CallMatcher.staticCall(AssertJClassNames.EXTRACTORS_CLASSNAME, "resultOf")
|
||||
.parameterTypes(CommonClassNames.JAVA_LANG_STRING)!!
|
||||
@@ -57,9 +50,8 @@ class ExtractorReferenceContributor : PsiReferenceContributor() {
|
||||
}
|
||||
|
||||
private fun findActualType(element: PsiElement): PsiClassType? {
|
||||
val assertThatCall = PsiTreeUtil.findChildrenOfType(element, PsiMethodCallExpression::class.java)
|
||||
.find { CORE_ASSERT_THAT_MATCHER.test(it) } ?: return null
|
||||
return assertThatCall.firstArg.type as? PsiClassType
|
||||
val assertThatCall = element.findStaticMethodCall()
|
||||
return assertThatCall?.firstArg?.type as? PsiClassType
|
||||
}
|
||||
|
||||
private fun findAndCreateReferences(element: PsiElement, finder: (PsiLiteralExpression) -> List<Pair<TextRange, List<PsiElement>>>?): Array<PsiReference> {
|
||||
@@ -81,6 +73,10 @@ class ExtractorReferenceContributor : PsiReferenceContributor() {
|
||||
class ExtractorReference(literal: PsiLiteralExpression, range: TextRange, private val targets: List<PsiElement>) :
|
||||
PsiPolyVariantReferenceBase<PsiLiteralExpression>(literal, range, true) {
|
||||
|
||||
override fun getVariants(): Array<Any> {
|
||||
return ArrayUtil.EMPTY_OBJECT_ARRAY
|
||||
}
|
||||
|
||||
override fun resolve(): PsiElement? {
|
||||
return multiResolve(false).map(ResolveResult::getElement).firstOrNull()
|
||||
}
|
||||
|
||||
@@ -5,13 +5,14 @@
|
||||
|
||||
<description><![CDATA[
|
||||
Cajon is an IntelliJ IDEA Plugin for shortening and optimizing AssertJ assertions.
|
||||
It adds inspections and quick fixes to fully make use of the AssertJ methods
|
||||
to make the intention clear and concise. It can also convert JUnit 4 assertions to AssertJ.
|
||||
It adds several inspections and quick fixes to fully use the fluent assertion methods
|
||||
and thus makes the intention clear and concise, also generating better messages on test failures.
|
||||
It can also be used to convert JUnit 4 assertions to AssertJ.
|
||||
It supports referencing inside extracting()-methods with strings, adding refactoring safety.
|
||||
]]></description>
|
||||
|
||||
<!-- please see http://www.jetbrains.org/intellij/sdk/docs/basics/getting_started/build_number_ranges.html for description -->
|
||||
<idea-version since-build="173.2290.1"/>
|
||||
<idea-version since-build="173.2696.26"/>
|
||||
|
||||
<!-- please see http://www.jetbrains.org/intellij/sdk/docs/basics/getting_started/plugin_compatibility.html
|
||||
on how to target different products -->
|
||||
@@ -23,8 +24,12 @@
|
||||
<psi.referenceContributor implementation="de.platon42.intellij.plugins.cajon.references.ExtractorReferenceContributor"/>
|
||||
<localInspection groupPath="Java" shortName="AssertThatObjectIsNullOrNotNull" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatObjectIsNullOrNotNullInspection"/>
|
||||
<localInspection groupPath="Java" shortName="AssertThatBooleanIsTrueOrFalse" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatBooleanIsTrueOrFalseInspection"/>
|
||||
<localInspection groupPath="Java" shortName="AssertThatBooleanCondition" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatBooleanConditionInspection"/>
|
||||
<localInspection groupPath="Java" shortName="AssertThatInvertedBooleanCondition" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatInvertedBooleanConditionInspection"/>
|
||||
<localInspection groupPath="Java" shortName="AssertThatInstanceOf" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatInstanceOfInspection"/>
|
||||
<localInspection groupPath="Java" shortName="AssertThatStringIsEmpty" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatStringIsEmptyInspection"/>
|
||||
<localInspection groupPath="Java" shortName="AssertThatEnumerableIsEmpty" enabledByDefault="true" level="WARNING"
|
||||
@@ -33,8 +38,15 @@
|
||||
<localInspection groupPath="Java" shortName="AssertThatSize" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatSizeInspection"/>
|
||||
|
||||
<localInspection groupPath="Java" shortName="AssertThatBinaryExpressionIsTrueOrFalse" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatBinaryExpressionIsTrueOrFalseInspection"/>
|
||||
<localInspection groupPath="Java" shortName="AssertThatBinaryExpression" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatBinaryExpressionInspection"/>
|
||||
<localInspection groupPath="Java" shortName="AssertThatStringExpression" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatStringExpressionInspection"/>
|
||||
|
||||
<localInspection groupPath="Java" shortName="JoinAssertThatStatements" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.JoinAssertThatStatementsInspection"/>
|
||||
<localInspection groupPath="Java" shortName="AssumeThatInsteadOfReturnInspection" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssumeThatInsteadOfReturnInspection"/>
|
||||
|
||||
<localInspection groupPath="Java" shortName="AssertThatJava8Optional" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatJava8OptionalInspection"/>
|
||||
|
||||
+1
-1
@@ -2,6 +2,6 @@
|
||||
<body>
|
||||
Turns assertThat(condition).isEqualTo(true/false) into assertThat(condition).isTrue()/isFalse().
|
||||
<!-- tooltip end -->
|
||||
Also works with constant expressions and Boolean.TRUE/FALSE.
|
||||
<br>Also works with constant expressions and Boolean.TRUE/FALSE.
|
||||
</body>
|
||||
</html>
|
||||
@@ -3,6 +3,6 @@
|
||||
Looks at expected and actual expression being of Guava Optional type and whether the statement effectively tries to assert the
|
||||
presence, absence or content and then replaces the statement by isPresent(), isAbsent(), or contains().
|
||||
<!-- tooltip end -->
|
||||
Requires AssertJ-Guava to be in classpath.
|
||||
<br>Requires AssertJ-Guava to be in classpath.
|
||||
</body>
|
||||
</html>
|
||||
@@ -0,0 +1,7 @@
|
||||
<html>
|
||||
<body>
|
||||
Turns assertThat(object instanceof classname).isEqualTo(true/false) into assertThat(object).is(Not)InstanceOf(classname.class).
|
||||
<!-- tooltip end -->
|
||||
<br>Also works with constant expressions and Boolean.TRUE/FALSE.
|
||||
</body>
|
||||
</html>
|
||||
@@ -0,0 +1,7 @@
|
||||
<html>
|
||||
<body>
|
||||
Turns assertThat(!condition).isEqualTo(true/false) into assertThat(condition).isFalse()/isTrue().
|
||||
<!-- tooltip end -->
|
||||
<br>Also works with constant expressions and Boolean.TRUE/FALSE.
|
||||
</body>
|
||||
</html>
|
||||
@@ -1,6 +1,7 @@
|
||||
<html>
|
||||
<body>
|
||||
Makes assertions on sizes of arrays or collections more concise by replacing them with isEmpty(), isNotEmpty(), hasSize(), or hasSameSizeAs().
|
||||
Makes assertions on sizes of arrays, collections, strings, or CharSequences more concise by replacing them with isEmpty(), isNotEmpty(), hasSize(), or hasSameSizeAs().
|
||||
<!-- tooltip end -->
|
||||
<br>Several more conversions are available with AssertJ 13.2.0 or later.
|
||||
</body>
|
||||
</html>
|
||||
@@ -0,0 +1,7 @@
|
||||
<html>
|
||||
<body>
|
||||
Turns assertThat(string.someMethod(arg)).isTrue/isFalse() into assertThat(string).someMethod(arg).
|
||||
<!-- tooltip end -->
|
||||
<br>someMethod() can be equals(), equalsIgnoreCase(), contentEquals(), contains(), startsWith(), and endsWith().
|
||||
</body>
|
||||
</html>
|
||||
@@ -0,0 +1,18 @@
|
||||
<html>
|
||||
<body>
|
||||
Tries to detect bogus uses of return statements in test methods and replaces them by assumeThat() calls.
|
||||
<!-- tooltip end -->
|
||||
<br>
|
||||
Novices will use these to skip test execution by bailing out early on some preconditions not met.
|
||||
However, this suggests that the test has actually been run and passed instead of showing the test
|
||||
as being skipped.
|
||||
<p>Return statements in if statements in main test methods
|
||||
(must be annotated with JUnit 4 or Jupiter @Test annotations)
|
||||
will be verified to have at least one assertThat() statement in the code flow.
|
||||
Method calls within the same class will be examined for assertThat() statements, too.
|
||||
However, at most 50 statements and down to five recursions will be tolerated before giving up.
|
||||
</p>
|
||||
<p>Currently, the quickfix may lose some comments during operation. The other branch of the if statement
|
||||
will be inlined (blocks with declarations will remain a code block due to variable scope).</p>
|
||||
</body>
|
||||
</html>
|
||||
@@ -1,10 +1,11 @@
|
||||
<html>
|
||||
<body>
|
||||
Tries to convert most of the JUnit 4 assertions to AssertJ-Format.
|
||||
Tries to convert most of the JUnit 4 assertions to AssertJ format.
|
||||
<!-- tooltip end -->
|
||||
<br>Works for assertTrue(), assertFalse(), assertNull(), assertNotNull(), assertEquals(), assertNotEquals(), assertSame() assertNotSame(), assertArrayEquals().
|
||||
Copes with variants with message and without, handles special versions for double and float types (including arrays).
|
||||
<p></p>
|
||||
<p>
|
||||
Does not support Hamcrest-Matchers. If you need that kind of conversion, you might want to check out the Assertions2AssertJ plugin by Ric Emery.
|
||||
</p>
|
||||
</body>
|
||||
</html>
|
||||
@@ -0,0 +1,7 @@
|
||||
<html>
|
||||
<body>
|
||||
Joins consecutive assertThat() statements with the same actual expression together.
|
||||
<!-- tooltip end -->
|
||||
<br>Retains comments during operation. If the AssertThat()-Statement contains .extracting() methods, they will not be joined.
|
||||
</body>
|
||||
</html>
|
||||
@@ -1,370 +0,0 @@
|
||||
package de.platon42.intellij.playground;
|
||||
|
||||
import org.assertj.core.api.ListAssert;
|
||||
import org.assertj.core.data.Offset;
|
||||
import org.assertj.core.extractor.Extractors;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.Collections;
|
||||
import java.util.List;
|
||||
import java.util.Optional;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.data.Offset.offset;
|
||||
import static org.assertj.guava.api.Assertions.assertThat;
|
||||
import static org.junit.Assert.*;
|
||||
|
||||
public class Playground {
|
||||
|
||||
private void sizeOfList() {
|
||||
assertThat("string").as("foo").hasSize(0);
|
||||
assertThat(new StringBuilder()).as("bar").hasSize(0);
|
||||
ListAssert<String> etc = assertThat(new ArrayList<String>()).as("etc");
|
||||
etc.hasSize(0);
|
||||
assertThat(new Long[1]).as("etc").hasSize(0);
|
||||
|
||||
assertThat("string").as("foo").isEmpty();
|
||||
assertThat(new StringBuilder()).as("bar").isEmpty();
|
||||
assertThat(new ArrayList<Long>()).as("etc").isEmpty();
|
||||
assertThat(new Long[1]).as("etc").isEmpty();
|
||||
|
||||
assertThat(new ArrayList<>().size()).isEqualTo(1);
|
||||
assertThat(new ArrayList<String>().size()).isEqualTo(1);
|
||||
assertThat(new ArrayList<String>().size()).isGreaterThanOrEqualTo(1);
|
||||
assertThat(new ArrayList<String>().size()).isZero();
|
||||
assertThat(new ArrayList<String>()).hasSizeGreaterThan(1);
|
||||
assertThat(new ArrayList<String>()).hasSameSizeAs(new ArrayList<>());
|
||||
assertThat(new Long[1]).as("etc").hasSameSizeAs(new Long[2]);
|
||||
}
|
||||
|
||||
private void sizeOfArray() {
|
||||
assertThat(new String[1].length).isLessThanOrEqualTo(1);
|
||||
assertThat(new String[1]).hasSameSizeAs(new Object());
|
||||
assertThat("").isEqualTo(null);
|
||||
assertThat(true).isTrue();
|
||||
assertThat(true).isEqualTo(true);
|
||||
assertThat(Boolean.TRUE).isEqualTo(Boolean.FALSE);
|
||||
assertThat(Boolean.TRUE).isEqualTo(true);
|
||||
}
|
||||
|
||||
private void booleanIsTrueOrFalse() {
|
||||
boolean primitive = false;
|
||||
Boolean object = java.lang.Boolean.TRUE;
|
||||
|
||||
assertThat(primitive).isEqualTo(Boolean.TRUE);
|
||||
assertThat(primitive).isEqualTo(Boolean.FALSE);
|
||||
assertThat(object).isEqualTo(Boolean.TRUE);
|
||||
assertThat(object).isEqualTo(Boolean.FALSE);
|
||||
assertThat(primitive).isEqualTo(true);
|
||||
assertThat(primitive).isEqualTo(false);
|
||||
assertThat(object).isEqualTo(true);
|
||||
assertThat(object).isEqualTo(false);
|
||||
|
||||
assertThat(primitive).isNotEqualTo(Boolean.TRUE);
|
||||
assertThat(primitive).isNotEqualTo(Boolean.FALSE);
|
||||
assertThat(object).isNotEqualTo(Boolean.TRUE);
|
||||
assertThat(object).isNotEqualTo(Boolean.FALSE);
|
||||
assertThat(primitive).isNotEqualTo(true);
|
||||
assertThat(primitive).isNotEqualTo(false);
|
||||
assertThat(object).isNotEqualTo(true);
|
||||
assertThat(object).isNotEqualTo(false);
|
||||
|
||||
assertThat(primitive).as("nah").isEqualTo(true && !true);
|
||||
assertThat(object).isEqualTo(Boolean.TRUE && !Boolean.TRUE);
|
||||
|
||||
assertThat("").isEqualTo(Boolean.TRUE);
|
||||
}
|
||||
|
||||
private void binaryExpression() {
|
||||
int primExp = 42;
|
||||
int primAct = 1337;
|
||||
Double numberObjExp = 42.0;
|
||||
Double numberObjAct = 1337.0;
|
||||
String stringExp = "foo";
|
||||
String stringAct = "bar";
|
||||
|
||||
assertThat(primAct == primExp).isTrue();
|
||||
assertThat(primAct == 1).isTrue();
|
||||
assertThat(primAct == primExp).isEqualTo(false);
|
||||
assertThat(primAct != primExp).isEqualTo(true);
|
||||
assertThat(1 != primAct).isTrue();
|
||||
assertThat(primAct != primExp).isNotEqualTo(true);
|
||||
assertThat(primAct > primExp).isNotEqualTo(false);
|
||||
assertThat(primAct > primExp).isFalse();
|
||||
assertThat(primAct > 1).isFalse();
|
||||
assertThat(primAct >= 1).isTrue();
|
||||
assertThat(primAct >= primExp).isEqualTo(false);
|
||||
assertThat(1 <= primAct).isFalse();
|
||||
assertThat(1 > primAct).isTrue();
|
||||
assertThat(primAct < primExp).isNotEqualTo(true);
|
||||
assertThat(primAct <= primExp).isNotEqualTo(false);
|
||||
assertThat(primAct <= primExp).isFalse();
|
||||
assertThat(primAct <= 1).isFalse();
|
||||
assertThat(numberObjAct == 1).isTrue();
|
||||
assertThat(numberObjAct == numberObjExp).isEqualTo(false);
|
||||
assertThat(numberObjAct != numberObjExp).isEqualTo(true);
|
||||
assertThat(1 != numberObjAct).isTrue();
|
||||
assertThat(numberObjAct != numberObjExp).isNotEqualTo(true);
|
||||
assertThat(numberObjAct > numberObjExp).isNotEqualTo(false);
|
||||
assertThat(numberObjAct > 1).isFalse();
|
||||
assertThat(numberObjAct >= numberObjExp).isTrue();
|
||||
assertThat(numberObjAct >= numberObjExp).isEqualTo(false);
|
||||
assertThat(1 <= numberObjAct).isFalse();
|
||||
assertThat(numberObjAct < numberObjExp).isEqualTo(true);
|
||||
assertThat(numberObjAct < numberObjExp).isNotEqualTo(true);
|
||||
assertThat(numberObjAct <= numberObjExp).isNotEqualTo(false);
|
||||
assertThat(numberObjAct <= 1).isFalse();
|
||||
assertThat(numberObjAct.equals(numberObjExp)).isFalse();
|
||||
assertThat(stringAct == stringExp).isNotEqualTo(false);
|
||||
assertThat(stringAct.equals(stringExp)).isEqualTo(true);
|
||||
assertThat(stringAct != stringExp).isFalse();
|
||||
assertThat(stringAct == null).isNotEqualTo(true);
|
||||
assertThat(null == stringAct).isEqualTo(false);
|
||||
|
||||
assertThat(null == null).isTrue();
|
||||
assertThat(!false).isTrue();
|
||||
}
|
||||
|
||||
private void stringStuff() {
|
||||
String foo = "bar";
|
||||
assertThat(foo).isEqualTo("");
|
||||
assertThat(foo).hasSize(0);
|
||||
assertThat(foo.contains("foobar")).isTrue();
|
||||
assertThat(foo).contains("foobar");
|
||||
assertThat(foo.startsWith("foobar")).isTrue();
|
||||
assertThat(foo).startsWith("foobar");
|
||||
assertThat(foo.endsWith("foobar")).isTrue();
|
||||
assertThat(foo).endsWith("foobar");
|
||||
assertThat(foo.equalsIgnoreCase("foo")).isTrue();
|
||||
assertThat(foo).isEqualToIgnoringCase("foo");
|
||||
|
||||
assertThat(foo.contains("foobar")).isFalse();
|
||||
assertThat(foo).doesNotContain("foobar");
|
||||
assertThat(foo.startsWith("foobar")).isFalse();
|
||||
assertThat(foo).doesNotStartWith("foobar");
|
||||
assertThat(foo.endsWith("foobar")).isFalse();
|
||||
assertThat(foo).doesNotEndWith("foobar");
|
||||
assertThat(foo.equalsIgnoreCase("foo")).isFalse();
|
||||
assertThat(foo).isNotEqualToIgnoringCase("foo");
|
||||
}
|
||||
|
||||
private void java8Optional() {
|
||||
Optional<String> opt = Optional.empty();
|
||||
|
||||
assertThat(opt.isPresent()).isEqualTo(true);
|
||||
assertThat(opt.isPresent()).isEqualTo(Boolean.TRUE);
|
||||
assertThat(opt.isPresent()).isNotEqualTo(false);
|
||||
assertThat(opt.isPresent()).isNotEqualTo(Boolean.FALSE);
|
||||
assertThat(opt.isPresent()).isTrue();
|
||||
|
||||
assertThat(opt.isPresent()).isEqualTo(false);
|
||||
assertThat(opt.isPresent()).isEqualTo(Boolean.FALSE);
|
||||
assertThat(opt.isPresent()).isNotEqualTo(true);
|
||||
assertThat(opt.isPresent()).isNotEqualTo(Boolean.TRUE);
|
||||
assertThat(opt.isPresent()).isFalse();
|
||||
|
||||
assertThat(opt.get()).isEqualTo("foo");
|
||||
assertThat(opt.get()).isSameAs("foo");
|
||||
|
||||
assertThat(opt).isEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).isEqualTo(Optional.ofNullable("foo"));
|
||||
assertThat(opt).isNotEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).isNotEqualTo(Optional.ofNullable("foo"));
|
||||
|
||||
assertThat(opt).isEqualTo(Optional.empty());
|
||||
assertThat(opt).isNotEqualTo(Optional.empty());
|
||||
assertThat(opt).isPresent();
|
||||
}
|
||||
|
||||
private void assertThatGuavaOptional() {
|
||||
com.google.common.base.Optional<String> opt = com.google.common.base.Optional.absent();
|
||||
|
||||
assertThat(opt.isPresent()).isEqualTo(true);
|
||||
assertThat(opt.isPresent()).isEqualTo(Boolean.TRUE);
|
||||
assertThat(opt.isPresent()).isNotEqualTo(false);
|
||||
assertThat(opt.isPresent()).isNotEqualTo(Boolean.FALSE);
|
||||
assertThat(opt.isPresent()).isTrue();
|
||||
|
||||
assertThat(opt.isPresent()).isEqualTo(false);
|
||||
assertThat(opt.isPresent()).isEqualTo(Boolean.FALSE);
|
||||
assertThat(opt.isPresent()).isNotEqualTo(true);
|
||||
assertThat(opt.isPresent()).isNotEqualTo(Boolean.TRUE);
|
||||
assertThat(opt.isPresent()).isFalse();
|
||||
|
||||
assertThat(opt.get()).isEqualTo("foo");
|
||||
assertThat(opt.get()).isSameAs("foo");
|
||||
assertThat(opt.get()).isNotEqualTo("foo");
|
||||
assertThat(opt.get()).isNotSameAs("foo");
|
||||
|
||||
assertThat(opt).isEqualTo(com.google.common.base.Optional.of("foo"));
|
||||
assertThat(opt).isEqualTo(com.google.common.base.Optional.fromNullable("foo"));
|
||||
assertThat(opt).isNotEqualTo(com.google.common.base.Optional.of("foo"));
|
||||
assertThat(opt).isNotEqualTo(com.google.common.base.Optional.fromNullable("foo"));
|
||||
|
||||
assertThat(opt).isEqualTo(com.google.common.base.Optional.absent());
|
||||
assertThat(opt).isNotEqualTo(com.google.common.base.Optional.absent());
|
||||
assertThat(opt).isAbsent();
|
||||
}
|
||||
|
||||
private void junitAssertions() {
|
||||
assertTrue(true);
|
||||
assertTrue("message", true);
|
||||
assertFalse(true);
|
||||
assertFalse("message", true);
|
||||
assertEquals(1L, 2L);
|
||||
assertEquals("message", 1L, 2L);
|
||||
assertNotEquals(1L, 2L);
|
||||
assertNotEquals("message", 1L, 2L);
|
||||
assertEquals(4.0, 4.4, 3.3);
|
||||
assertThat(3.0).isCloseTo(4.0, Offset.offset(2.3));
|
||||
assertThat(new int[1]).isEqualTo(new int[2]);
|
||||
|
||||
String foo = "foo";
|
||||
String bar = "bar";
|
||||
|
||||
assertTrue(foo == "foo");
|
||||
assertTrue("oh no!", foo == "foo");
|
||||
assertFalse(foo == "bar");
|
||||
assertFalse("boom!", foo == "bar");
|
||||
|
||||
assertNull(foo);
|
||||
assertNull("oh no!", foo);
|
||||
assertNotNull(foo);
|
||||
assertNotNull("oh no!", foo);
|
||||
|
||||
assertEquals(bar, foo);
|
||||
assertEquals("equals", bar, foo);
|
||||
assertNotEquals(bar, foo);
|
||||
assertNotEquals("equals", bar, foo);
|
||||
|
||||
assertSame(bar, foo);
|
||||
assertSame("same", bar, foo);
|
||||
assertNotSame(bar, foo);
|
||||
assertNotSame("same", bar, foo);
|
||||
|
||||
assertEquals(1.0, 2.0, 0.1);
|
||||
assertEquals("equals", 1.0, 2.0, 0.1);
|
||||
assertEquals(1.0f, 2.0f, 0.1f);
|
||||
assertEquals("equals", 1.0f, 2.0f, 0.1f);
|
||||
|
||||
assertNotEquals(1.0, 2.0);
|
||||
assertNotEquals(1.0, 2.0, 0.1);
|
||||
assertNotEquals("equals", 1.0, 2.0);
|
||||
assertNotEquals("equals", 1.0, 2.0, 0.1);
|
||||
assertNotEquals(1.0f, 2.0f);
|
||||
assertNotEquals(1.0f, 2.0f, 0.1f);
|
||||
assertNotEquals("equals", 1.0f, 2.0f);
|
||||
assertNotEquals("equals", 1.0f, 2.0f, 0.1f);
|
||||
|
||||
assertArrayEquals(new int[2], new int[1]);
|
||||
assertArrayEquals("array equals", new int[2], new int[1]);
|
||||
|
||||
assertArrayEquals(new double[2], new double[1], 1.0);
|
||||
assertArrayEquals("array equals", new double[2], new double[1], 1.0);
|
||||
assertArrayEquals(new float[2], new float[1], 1.0f);
|
||||
assertArrayEquals("array equals", new float[2], new float[1], 1.0f);
|
||||
|
||||
|
||||
assertThat(foo == "foo").isTrue();
|
||||
assertThat(foo == "foo").as("oh no!").isTrue();
|
||||
assertThat(foo == "bar").isFalse();
|
||||
assertThat(foo == "bar").as("boom!").isFalse();
|
||||
|
||||
assertThat(foo).isNull();
|
||||
assertThat(foo).as("oh no!").isNull();
|
||||
assertThat(foo).isNotNull();
|
||||
assertThat(foo).as("oh no!").isNotNull();
|
||||
|
||||
assertThat(foo).isEqualTo(bar);
|
||||
assertThat(foo).as("equals").isEqualTo(bar);
|
||||
assertThat(foo).isNotEqualTo(bar);
|
||||
assertThat(foo).as("equals").isNotEqualTo(bar);
|
||||
|
||||
assertThat(foo).isSameAs(bar);
|
||||
assertThat(foo).as("same").isSameAs(bar);
|
||||
assertThat(foo).isNotSameAs(bar);
|
||||
assertThat(foo).as("same").isNotSameAs(bar);
|
||||
|
||||
assertThat(2.0).isEqualTo(1.0);
|
||||
assertThat(2.0).isCloseTo(1.0, offset(0.1));
|
||||
assertThat(2.0).as("equals").isEqualTo(1.0);
|
||||
assertThat(2.0).as("equals").isCloseTo(1.0, offset(0.1));
|
||||
assertThat(2.0f).isEqualTo(1.0f);
|
||||
assertThat(2.0f).isCloseTo(1.0f, offset(0.1f));
|
||||
assertThat(2.0f).as("equals").isEqualTo(1.0f);
|
||||
assertThat(2.0f).as("equals").isCloseTo(1.0f, offset(0.1f));
|
||||
|
||||
assertThat(2.0).isNotEqualTo(1.0);
|
||||
assertThat(2.0).isNotCloseTo(1.0, offset(0.1));
|
||||
assertThat(2.0).as("equals").isNotEqualTo(1.0);
|
||||
assertThat(2.0).as("equals").isNotCloseTo(1.0, offset(0.1));
|
||||
assertThat(2.0f).isNotEqualTo(1.0f);
|
||||
assertThat(2.0f).isNotCloseTo(1.0f, offset(0.1f));
|
||||
assertThat(2.0f).as("equals").isNotEqualTo(1.0f);
|
||||
assertThat(2.0f).as("equals").isNotCloseTo(1.0f, offset(0.1f));
|
||||
|
||||
assertThat(new int[1]).isEqualTo(new int[2]);
|
||||
assertThat(new int[1]).as("array equals").isEqualTo(new int[2]);
|
||||
|
||||
assertThat(new double[1]).containsExactly(new double[2], offset(1.0));
|
||||
assertThat(new double[1]).as("array equals").containsExactly(new double[2], offset(1.0));
|
||||
assertThat(new float[1]).containsExactly(new float[2], offset(1.0f));
|
||||
assertThat(new float[1]).as("array equals").containsExactly(new float[2], offset(1.0f));
|
||||
|
||||
assertThat(new Object()).extracting("toString");
|
||||
assertThat(new Object()).extracting(Object::toString, Object::hashCode);
|
||||
}
|
||||
|
||||
|
||||
private void findReferences() {
|
||||
Contact contact = new Contact();
|
||||
List<Contact> contactList = Collections.emptyList();
|
||||
|
||||
assertThat(contact).extracting("name").isEqualTo("foo");
|
||||
assertThat(contact).extracting("age", "country", "address.street", "street", "address.noMailings", "address.REALLYnoMAILINGS").containsExactly(1, "Elmst. 42");
|
||||
assertThat(contact).extracting(Extractors.byName("name")).isEqualTo("foo");
|
||||
assertThat(contact).extracting(Extractors.resultOf("getStreet")).isEqualTo("foo");
|
||||
assertThat(contact).extracting(Extractors.resultOf("getStreet"), Extractors.byName("narf")).isEqualTo("foo");
|
||||
|
||||
assertThat(contactList).extracting("name").isEqualTo("foo");
|
||||
assertThat(contactList).extracting("name", "moar").isEqualTo("foo");
|
||||
assertThat(contactList).extracting("name", String.class).isEqualTo("foo");
|
||||
assertThat(contactList).extracting(Extractors.byName("name")).isEqualTo("foo");
|
||||
assertThat(contactList).extracting(Extractors.resultOf("getStreet"), Extractors.byName("narf")).isEqualTo("foo");
|
||||
assertThat(contactList).extractingResultOf("getStreet").isEqualTo("foo");
|
||||
assertThat(contactList).extractingResultOf("getStreet", String.class).isEqualTo("foo");
|
||||
assertThat(contactList).flatExtracting("age", "address.street", "street").containsExactly(1, "Elmst. 42");
|
||||
assertThat(contactList).flatExtracting("age").containsExactly(1, "Elmst. 42");
|
||||
}
|
||||
|
||||
public class Contact {
|
||||
private String name;
|
||||
private Integer age;
|
||||
private Address address;
|
||||
|
||||
public String getStreet() {
|
||||
return address.getStreet();
|
||||
}
|
||||
}
|
||||
|
||||
public class Address {
|
||||
private String street;
|
||||
private String country;
|
||||
|
||||
public String getStreet() {
|
||||
return street;
|
||||
}
|
||||
|
||||
public String getCountry() {
|
||||
return country;
|
||||
}
|
||||
|
||||
public boolean isNoMailings() {
|
||||
return true;
|
||||
}
|
||||
|
||||
public Boolean getREALLYnoMAILINGS() {
|
||||
return true;
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -11,13 +11,17 @@ import de.platon42.intellij.jupiter.TestDataPath
|
||||
import de.platon42.intellij.jupiter.TestJdk
|
||||
import org.assertj.core.api.Assertions
|
||||
import org.assertj.core.api.Assertions.assertThat
|
||||
import org.junit.jupiter.api.DisplayNameGeneration
|
||||
import org.junit.jupiter.api.DisplayNameGenerator
|
||||
import org.junit.jupiter.api.extension.ExtendWith
|
||||
import java.lang.reflect.InvocationTargetException
|
||||
import java.lang.reflect.Method
|
||||
|
||||
@ExtendWith(LightCodeInsightExtension::class)
|
||||
@TestDataPath("src/test/resources")
|
||||
@TestJdk(LanguageLevel.JDK_1_8, annotations = true, useInternal = true)
|
||||
@AddLocalJarToModule(Assertions::class)
|
||||
@DisplayNameGeneration(AbstractCajonTest.CutOffFixtureDisplayNameGenerator::class)
|
||||
abstract class AbstractCajonTest {
|
||||
|
||||
// See https://github.com/junit-team/junit5/issues/157, should be resolved with junit5 5.5 M2
|
||||
@@ -60,8 +64,15 @@ abstract class AbstractCajonTest {
|
||||
}
|
||||
|
||||
protected fun executeQuickFixes(myFixture: JavaCodeInsightTestFixture, regex: Regex, expectedFixes: Int) {
|
||||
val quickfixes = myFixture.getAllQuickFixes().filter { it.familyName.matches(regex) }
|
||||
assertThat(quickfixes).`as`("Fixes matched by $regex: ${myFixture.getAllQuickFixes().map { it.familyName }}").hasSize(expectedFixes)
|
||||
val quickfixes = myFixture.getAllQuickFixes().filter { it.text.matches(regex) }
|
||||
assertThat(quickfixes).`as`("Fixes matched by $regex: ${myFixture.getAllQuickFixes().map { it.text }}").hasSize(expectedFixes)
|
||||
quickfixes.forEach(myFixture::launchAction)
|
||||
}
|
||||
|
||||
class CutOffFixtureDisplayNameGenerator : DisplayNameGenerator.ReplaceUnderscores() {
|
||||
override fun generateDisplayNameForMethod(testClass: Class<*>?, testMethod: Method?): String {
|
||||
val nameForMethod = super.generateDisplayNameForMethod(testClass, testMethod)
|
||||
return nameForMethod.substringBefore("$")
|
||||
}
|
||||
}
|
||||
}
|
||||
+4
-4
@@ -6,16 +6,16 @@ import de.platon42.intellij.jupiter.TestDataSubPath
|
||||
import de.platon42.intellij.plugins.cajon.AbstractCajonTest
|
||||
import org.junit.jupiter.api.Test
|
||||
|
||||
internal class AssertThatBinaryExpressionIsTrueOrFalseInspectionTest : AbstractCajonTest() {
|
||||
internal class AssertThatBinaryExpressionInspectionTest : AbstractCajonTest() {
|
||||
|
||||
@Test
|
||||
@TestDataSubPath("inspections/BinaryExpression")
|
||||
internal fun assertThat_of_binary_expression_can_be_moved_out(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
runTest {
|
||||
myFixture.enableInspections(AssertThatBinaryExpressionIsTrueOrFalseInspection::class.java)
|
||||
myFixture.enableInspections(AssertThatBinaryExpressionInspection::class.java)
|
||||
myFixture.configureByFile("BinaryExpressionBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Split binary expression out of assertThat()"), 148)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Split equals() expression out of assertThat()"), 12)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Split binary expression out of assertThat()"), 149)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Split equals() expression out of assertThat()"), 13)
|
||||
myFixture.checkResultByFile("BinaryExpressionAfter.java")
|
||||
}
|
||||
}
|
||||
+6
-6
@@ -6,19 +6,19 @@ import de.platon42.intellij.jupiter.TestDataSubPath
|
||||
import de.platon42.intellij.plugins.cajon.AbstractCajonTest
|
||||
import org.junit.jupiter.api.Test
|
||||
|
||||
internal class AssertThatBooleanIsTrueOrFalseInspectionTest : AbstractCajonTest() {
|
||||
internal class AssertThatBooleanConditionInspectionTest : AbstractCajonTest() {
|
||||
|
||||
@Test
|
||||
@TestDataSubPath("inspections/BooleanIsTrueOrFalse")
|
||||
@TestDataSubPath("inspections/BooleanCondition")
|
||||
internal fun assertThat_with_isEqualTo_true_or_false_can_use_isTrue_or_isFalse(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
runTest {
|
||||
myFixture.enableInspections(AssertThatBooleanIsTrueOrFalseInspection::class.java)
|
||||
myFixture.configureByFile("BooleanIsTrueOrFalseBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isTrue()"), 4)
|
||||
myFixture.enableInspections(AssertThatBooleanConditionInspection::class.java)
|
||||
myFixture.configureByFile("BooleanConditionBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isTrue()"), 6)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isFalse()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotEqualTo() with isTrue()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotEqualTo() with isFalse()"), 4)
|
||||
myFixture.checkResultByFile("BooleanIsTrueOrFalseAfter.java")
|
||||
myFixture.checkResultByFile("BooleanConditionAfter.java")
|
||||
}
|
||||
}
|
||||
}
|
||||
+1
-1
@@ -14,7 +14,7 @@ internal class AssertThatEnumerableIsEmptyInspectionTest : AbstractCajonTest() {
|
||||
runTest {
|
||||
myFixture.enableInspections(AssertThatEnumerableIsEmptyInspection::class.java)
|
||||
myFixture.configureByFile("EnumerableIsEmptyBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace hasSize() with isEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace hasSize() with isEmpty()"), 5)
|
||||
myFixture.checkResultByFile("EnumerableIsEmptyAfter.java")
|
||||
}
|
||||
}
|
||||
|
||||
+13
-15
@@ -9,25 +9,21 @@ import org.assertj.core.api.Assertions
|
||||
import org.junit.jupiter.api.Test
|
||||
|
||||
@AddLocalJarToModule(com.google.common.base.Optional::class, org.assertj.guava.api.Assertions::class, Assertions::class)
|
||||
@TestDataSubPath("inspections/AssertThatGuavaOptional")
|
||||
@TestDataSubPath("inspections/GuavaOptional")
|
||||
internal class AssertThatGuavaOptionalInspectionTest : AbstractCajonTest() {
|
||||
|
||||
@Test
|
||||
internal fun assertThat_get_or_isPresent_for_Guava_Optional_can_be_simplified(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
runTest {
|
||||
myFixture.enableInspections(AssertThatGuavaOptionalInspection::class.java)
|
||||
myFixture.configureByFile("AssertThatGuavaOptionalBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isEqualTo() with isPresent()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isNotEqualTo() with isPresent()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotEqualTo() with isPresent()"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isEqualTo() with isAbsent()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isAbsent()"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isNotEqualTo() with isAbsent()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isTrue() with isPresent()"), 1)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isFalse() with isAbsent()"), 1)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isEqualTo() with contains()"), 1)
|
||||
myFixture.configureByFile("GuavaOptionalBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove isPresent() of actual expression and use assertThat().isPresent() instead"), 6)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove isPresent() of actual expression and use assertThat().isAbsent() instead"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().contains() instead"), 1)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap expected expression and replace isEqualTo() with contains()"), 6)
|
||||
myFixture.checkResultByFile("AssertThatGuavaOptionalAfter.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with Guava assertThat().isAbsent()"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotEqualTo() with Guava assertThat().isPresent()"), 3)
|
||||
myFixture.checkResultByFile("GuavaOptionalAfter.java")
|
||||
}
|
||||
}
|
||||
|
||||
@@ -36,7 +32,8 @@ internal class AssertThatGuavaOptionalInspectionTest : AbstractCajonTest() {
|
||||
runTest {
|
||||
myFixture.enableInspections(AssertThatGuavaOptionalInspection::class.java)
|
||||
myFixture.configureByFile("WithoutPriorGuavaImportBefore.java")
|
||||
executeQuickFixes(myFixture, Regex(".*eplace .* with .*"), 7)
|
||||
executeQuickFixes(myFixture, Regex(".*eplace .* with .*"), 4)
|
||||
executeQuickFixes(myFixture, Regex("Remove .*"), 3)
|
||||
myFixture.checkResultByFile("WithoutPriorGuavaImportAfter.java")
|
||||
}
|
||||
}
|
||||
@@ -46,8 +43,9 @@ internal class AssertThatGuavaOptionalInspectionTest : AbstractCajonTest() {
|
||||
runTest {
|
||||
myFixture.enableInspections(AssertThatGuavaOptionalInspection::class.java)
|
||||
myFixture.configureByFile("WithoutPriorGuavaImportBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isAbsent()"), 1)
|
||||
executeQuickFixes(myFixture, Regex(".*eplace .* with .*"), 6)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with Guava assertThat().isAbsent()"), 1)
|
||||
executeQuickFixes(myFixture, Regex(".*eplace .* with .*"), 3)
|
||||
executeQuickFixes(myFixture, Regex("Remove .*"), 3)
|
||||
myFixture.checkResultByFile("WithoutPriorGuavaImportAfter.java")
|
||||
}
|
||||
}
|
||||
|
||||
+22
@@ -0,0 +1,22 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
|
||||
import de.platon42.intellij.jupiter.MyFixture
|
||||
import de.platon42.intellij.jupiter.TestDataSubPath
|
||||
import de.platon42.intellij.plugins.cajon.AbstractCajonTest
|
||||
import org.junit.jupiter.api.Test
|
||||
|
||||
internal class AssertThatInstanceOfInspectionTest : AbstractCajonTest() {
|
||||
|
||||
@Test
|
||||
@TestDataSubPath("inspections/InstanceOf")
|
||||
internal fun assertThat_with_instanceof_can_be_moved_out(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
runTest {
|
||||
myFixture.enableInspections(AssertThatInstanceOfInspection::class.java)
|
||||
myFixture.configureByFile("InstanceOfBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove instanceof in actual expression and use assertThat().isInstanceOf() instead"), 6)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove instanceof in actual expression and use assertThat().isNotInstanceOf() instead"), 6)
|
||||
myFixture.checkResultByFile("InstanceOfAfter.java")
|
||||
}
|
||||
}
|
||||
}
|
||||
+21
@@ -0,0 +1,21 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
|
||||
import de.platon42.intellij.jupiter.MyFixture
|
||||
import de.platon42.intellij.jupiter.TestDataSubPath
|
||||
import de.platon42.intellij.plugins.cajon.AbstractCajonTest
|
||||
import org.junit.jupiter.api.Test
|
||||
|
||||
internal class AssertThatInvertedBooleanConditionInspectionTest : AbstractCajonTest() {
|
||||
|
||||
@Test
|
||||
@TestDataSubPath("inspections/InvertedBooleanCondition")
|
||||
internal fun assertThat_with_inverted_boolean_condition_can_be_inverted(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
runTest {
|
||||
myFixture.enableInspections(AssertThatInvertedBooleanConditionInspection::class.java)
|
||||
myFixture.configureByFile("InvertedBooleanConditionBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Invert condition in assertThat()"), 25)
|
||||
myFixture.checkResultByFile("InvertedBooleanConditionAfter.java")
|
||||
}
|
||||
}
|
||||
}
|
||||
+7
-11
@@ -9,23 +9,19 @@ import org.junit.jupiter.api.Test
|
||||
internal class AssertThatJava8OptionalInspectionTest : AbstractCajonTest() {
|
||||
|
||||
@Test
|
||||
@TestDataSubPath("inspections/AssertThatJava8Optional")
|
||||
@TestDataSubPath("inspections/Java8Optional")
|
||||
internal fun assertThat_get_or_isPresent_for_Java8_Optional_can_be_simplified(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
runTest {
|
||||
myFixture.enableInspections(AssertThatJava8OptionalInspection::class.java)
|
||||
myFixture.configureByFile("AssertThatJava8OptionalBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isEqualTo() with isPresent()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isNotEqualTo() with isPresent()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isEqualTo() with isNotPresent()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isNotEqualTo() with isNotPresent()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isTrue() with isPresent()"), 1)
|
||||
myFixture.configureByFile("Java8OptionalBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove isPresent() of actual expression and use assertThat().isPresent() instead"), 6)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove isPresent() of actual expression and use assertThat().isNotPresent() instead"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().contains() instead"), 1)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsSame() instead"), 1)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isNotPresent()"), 1)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotEqualTo() with isPresent()"), 1)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isFalse() with isNotPresent()"), 1)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap expected expression and replace isEqualTo() with contains()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isEqualTo() with contains()"), 1)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Unwrap actual expression and replace isSameAs() with containsSame()"), 1)
|
||||
myFixture.checkResultByFile("AssertThatJava8OptionalAfter.java")
|
||||
myFixture.checkResultByFile("Java8OptionalAfter.java")
|
||||
}
|
||||
}
|
||||
}
|
||||
+2
-2
@@ -14,8 +14,8 @@ internal class AssertThatObjectIsNullOrNotNullInspectionTest : AbstractCajonTest
|
||||
runTest {
|
||||
myFixture.enableInspections(AssertThatObjectIsNullOrNotNullInspection::class.java)
|
||||
myFixture.configureByFile("ObjectIsNullOrNotNullBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isNull()"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotEqualTo() with isNotNull()"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isNull()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotEqualTo() with isNotNull()"), 5)
|
||||
myFixture.checkResultByFile("ObjectIsNullOrNotNullAfter.java")
|
||||
}
|
||||
}
|
||||
|
||||
+21
-16
@@ -4,30 +4,35 @@ import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
|
||||
import de.platon42.intellij.jupiter.MyFixture
|
||||
import de.platon42.intellij.jupiter.TestDataSubPath
|
||||
import de.platon42.intellij.plugins.cajon.AbstractCajonTest
|
||||
import org.assertj.core.api.Assertions.assertThat
|
||||
import org.assertj.core.api.extrakting
|
||||
import org.junit.jupiter.api.Test
|
||||
|
||||
internal class AssertThatSizeInspectionTest : AbstractCajonTest() {
|
||||
|
||||
@Test
|
||||
@TestDataSubPath("inspections/AssertThatSize")
|
||||
@TestDataSubPath("inspections/Size")
|
||||
internal fun assertThat_size_of_array_or_collection_can_be_simplified(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
runTest {
|
||||
myFixture.enableInspections(AssertThatSizeInspection::class.java)
|
||||
myFixture.configureByFile("AssertThatSizeBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isEmpty()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isZero() with isEmpty()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotZero() with isNotEmpty()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThan() with isNotEmpty()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThanOrEqualTo() with isNotEmpty()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThan() with isEmpty()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThanOrEqualTo() with isEmpty()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with hasSameSizeAs()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with hasSize()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThan() with hasSizeGreaterThan()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThanOrEqualTo() with hasSizeGreaterThanOrEqualTo()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThan() with hasSizeLessThan()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThanOrEqualTo() with hasSizeLessThanOrEqualTo()"), 2)
|
||||
myFixture.checkResultByFile("AssertThatSizeAfter.java")
|
||||
myFixture.configureByFile("SizeBefore.java")
|
||||
assertThat(myFixture.doHighlighting()).extrakting { it.description }.containsOnlyOnce("Try to operate on the iterable itself rather than its size")
|
||||
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isZero() with isEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotZero() with isNotEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThan() with isNotEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThanOrEqualTo() with isNotEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThan() with isEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThanOrEqualTo() with isEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with hasSameSizeAs()"), 12)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with hasSize()"), 8)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThan() with hasSizeGreaterThan()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThanOrEqualTo() with hasSizeGreaterThanOrEqualTo()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThan() with hasSizeLessThan()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThanOrEqualTo() with hasSizeLessThanOrEqualTo()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove size determination of expected expression and replace hasSize() with hasSameSizeAs()"), 14)
|
||||
myFixture.checkResultByFile("SizeAfter.java")
|
||||
}
|
||||
}
|
||||
}
|
||||
+34
@@ -0,0 +1,34 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
|
||||
import de.platon42.intellij.jupiter.MyFixture
|
||||
import de.platon42.intellij.jupiter.TestDataSubPath
|
||||
import de.platon42.intellij.plugins.cajon.AbstractCajonTest
|
||||
import org.junit.jupiter.api.Test
|
||||
|
||||
internal class AssertThatStringExpressionInspectionTest : AbstractCajonTest() {
|
||||
|
||||
@Test
|
||||
@TestDataSubPath("inspections/StringExpression")
|
||||
internal fun assertThat_with_certain_String_methods(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
runTest {
|
||||
myFixture.enableInspections(AssertThatStringExpressionInspection::class.java)
|
||||
myFixture.configureByFile("StringExpressionBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isEmpty() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove equals() of actual expression and use assertThat().isEqualTo() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove equalsIgnoreCase() of actual expression and use assertThat().isEqualToIgnoringCase() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove contentEquals() of actual expression and use assertThat().isEqualTo() instead"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove contains() of actual expression and use assertThat().contains() instead"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove startsWith() of actual expression and use assertThat().startsWith() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove endsWith() of actual expression and use assertThat().endsWith() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isNotEmpty() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove equals() of actual expression and use assertThat().isNotEqualTo() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove equalsIgnoreCase() of actual expression and use assertThat().isNotEqualToIgnoringCase() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove contentEquals() of actual expression and use assertThat().isNotEqualTo() instead"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove contains() of actual expression and use assertThat().doesNotContain() instead"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove startsWith() of actual expression and use assertThat().doesNotStartWith() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove endsWith() of actual expression and use assertThat().doesNotEndWith() instead"), 3)
|
||||
myFixture.checkResultByFile("StringExpressionAfter.java")
|
||||
}
|
||||
}
|
||||
}
|
||||
+9
-2
@@ -4,6 +4,8 @@ import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
|
||||
import de.platon42.intellij.jupiter.MyFixture
|
||||
import de.platon42.intellij.jupiter.TestDataSubPath
|
||||
import de.platon42.intellij.plugins.cajon.AbstractCajonTest
|
||||
import org.assertj.core.api.Assertions.assertThat
|
||||
import org.assertj.core.api.extrakting
|
||||
import org.junit.jupiter.api.Test
|
||||
|
||||
internal class AssertThatStringIsEmptyInspectionTest : AbstractCajonTest() {
|
||||
@@ -14,8 +16,13 @@ internal class AssertThatStringIsEmptyInspectionTest : AbstractCajonTest() {
|
||||
runTest {
|
||||
myFixture.enableInspections(AssertThatStringIsEmptyInspection::class.java)
|
||||
myFixture.configureByFile("StringIsEmptyBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isEmpty()"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace hasSize() with isEmpty()"), 2)
|
||||
val highlights = myFixture.doHighlighting()
|
||||
.asSequence()
|
||||
.filter { it.description?.contains(" can be simplified to") ?: false }
|
||||
.toList()
|
||||
assertThat(highlights).hasSize(6).extrakting { it.text }.doesNotContain("assertThat")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isEmpty()"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace hasSize() with isEmpty()"), 3)
|
||||
myFixture.checkResultByFile("StringIsEmptyAfter.java")
|
||||
}
|
||||
}
|
||||
|
||||
+24
@@ -0,0 +1,24 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
|
||||
import de.platon42.intellij.jupiter.AddLocalJarToModule
|
||||
import de.platon42.intellij.jupiter.MyFixture
|
||||
import de.platon42.intellij.jupiter.TestDataSubPath
|
||||
import de.platon42.intellij.plugins.cajon.AbstractCajonTest
|
||||
import org.assertj.core.api.Assertions
|
||||
import org.junit.jupiter.api.Test
|
||||
|
||||
@AddLocalJarToModule(Assertions::class, Test::class, org.junit.Test::class)
|
||||
internal class AssumeThatInsteadOfReturnInspectionTest : AbstractCajonTest() {
|
||||
|
||||
@Test
|
||||
@TestDataSubPath("inspections/AssumeThat")
|
||||
internal fun conditional_returns_can_be_replaced_by_assumeThat(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
runTest {
|
||||
myFixture.enableInspections(AssumeThatInsteadOfReturnInspection::class.java)
|
||||
myFixture.configureByFile("AssumeThatBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace if statement by assumeTrue()"), 4)
|
||||
myFixture.checkResultByFile("AssumeThatAfter.java")
|
||||
}
|
||||
}
|
||||
}
|
||||
+1
-1
@@ -18,7 +18,7 @@ internal class JUnitAssertToAssertJInspectionTest : AbstractCajonTest() {
|
||||
runTest {
|
||||
myFixture.enableInspections(JUnitAssertToAssertJInspection::class.java)
|
||||
myFixture.configureByFile("JUnitAssertToAssertJInspectionBefore.java")
|
||||
executeQuickFixes(myFixture, Regex("Replace .*"), 38)
|
||||
executeQuickFixes(myFixture, Regex("Convert assert.*\\(\\) to assertThat\\(\\).*"), 38)
|
||||
myFixture.checkResultByFile("JUnitAssertToAssertJInspectionAfter.java")
|
||||
}
|
||||
}
|
||||
|
||||
+21
@@ -0,0 +1,21 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
|
||||
import de.platon42.intellij.jupiter.MyFixture
|
||||
import de.platon42.intellij.jupiter.TestDataSubPath
|
||||
import de.platon42.intellij.plugins.cajon.AbstractCajonTest
|
||||
import org.junit.jupiter.api.Test
|
||||
|
||||
internal class JoinAssertThatStatementsInspectionTest : AbstractCajonTest() {
|
||||
|
||||
@Test
|
||||
@TestDataSubPath("inspections/JoinStatements")
|
||||
internal fun assertThat_statements_can_be_joined_together(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
runTest {
|
||||
myFixture.enableInspections(JoinAssertThatStatementsInspection::class.java)
|
||||
myFixture.configureByFile("JoinStatementsBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Join assertThat() statements"), 5)
|
||||
myFixture.checkResultByFile("JoinStatementsAfter.java")
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,19 @@
|
||||
package org.assertj.core.api
|
||||
|
||||
import org.assertj.core.groups.FieldsOrPropertiesExtractor
|
||||
import java.util.*
|
||||
|
||||
// Workaround for ambiguous method signature of .extracting() see https://github.com/joel-costigliola/assertj-core/issues/1499
|
||||
fun <SELF : AbstractIterableAssert<SELF, ACTUAL, ELEMENT, ELEMENT_ASSERT>,
|
||||
ACTUAL : Iterable<ELEMENT>,
|
||||
ELEMENT,
|
||||
ELEMENT_ASSERT : AbstractAssert<ELEMENT_ASSERT, ELEMENT>,
|
||||
V>
|
||||
AbstractIterableAssert<SELF, ACTUAL, ELEMENT, ELEMENT_ASSERT>.extrakting(extractor: (ELEMENT) -> V): AbstractListAssert<*, List<V>, V, ObjectAssert<V>> {
|
||||
val values = FieldsOrPropertiesExtractor.extract(actual, extractor)
|
||||
if (actual is SortedSet<*>) {
|
||||
usingDefaultElementComparator()
|
||||
}
|
||||
@Suppress("UNCHECKED_CAST")
|
||||
return newListAssertInstance(values).withAssertionState(myself) as AbstractListAssert<*, List<V>, V, ObjectAssert<V>>
|
||||
}
|
||||
@@ -1,43 +0,0 @@
|
||||
import java.util.ArrayList;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class AssertThatSize {
|
||||
|
||||
private void assertThatSize() {
|
||||
ArrayList<String> list = new ArrayList<>();
|
||||
ArrayList<String> otherList = new ArrayList<>();
|
||||
long[] array = new long[5];
|
||||
long[] otherArray = new long[4];
|
||||
|
||||
assertThat(list).isEmpty();
|
||||
assertThat(list).isEmpty();
|
||||
assertThat(list).isNotEmpty();
|
||||
assertThat(list).as("hi").isNotEmpty();
|
||||
assertThat(list).isNotEmpty();
|
||||
assertThat(list).isEmpty();
|
||||
assertThat(list).isEmpty();
|
||||
assertThat(list).hasSameSizeAs(otherList);
|
||||
assertThat(list).hasSameSizeAs(array);
|
||||
assertThat(list).hasSize(1);
|
||||
assertThat(list).hasSizeGreaterThan(list.size() * 2);
|
||||
assertThat(list).hasSizeGreaterThanOrEqualTo(list.size() * 2);
|
||||
assertThat(list).hasSizeLessThan(list.size() * 2);
|
||||
assertThat(list).hasSizeLessThanOrEqualTo(list.size() * 2);
|
||||
|
||||
assertThat(array).isEmpty();
|
||||
assertThat(array).isEmpty();
|
||||
assertThat(array).isNotEmpty();
|
||||
assertThat(array).as("hi").isNotEmpty();
|
||||
assertThat(array).isNotEmpty();
|
||||
assertThat(array).isEmpty();
|
||||
assertThat(array).isEmpty();
|
||||
assertThat(array).hasSameSizeAs(list);
|
||||
assertThat(array).hasSameSizeAs(otherArray);
|
||||
assertThat(array).hasSize(1);
|
||||
assertThat(array).hasSizeGreaterThan(otherArray.length - 1);
|
||||
assertThat(array).hasSizeGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
assertThat(array).hasSizeLessThan(otherArray.length - 3);
|
||||
assertThat(array).hasSizeLessThanOrEqualTo(1 - otherArray.length);
|
||||
}
|
||||
}
|
||||
@@ -1,43 +0,0 @@
|
||||
import java.util.ArrayList;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class AssertThatSize {
|
||||
|
||||
private void assertThatSize() {
|
||||
ArrayList<String> list = new ArrayList<>();
|
||||
ArrayList<String> otherList = new ArrayList<>();
|
||||
long[] array = new long[5];
|
||||
long[] otherArray = new long[4];
|
||||
|
||||
assertThat(list.size()).isEqualTo(0);
|
||||
assertThat(list.size()).isZero();
|
||||
assertThat(list.size()).isNotZero();
|
||||
assertThat(list.size()).as("hi").isGreaterThan(0);
|
||||
assertThat(list.size()).isGreaterThanOrEqualTo(1);
|
||||
assertThat(list.size()).isLessThan(1);
|
||||
assertThat(list.size()).isLessThanOrEqualTo(0);
|
||||
assertThat(list.size()).isEqualTo(otherList.size());
|
||||
assertThat(list.size()).isEqualTo(array.length);
|
||||
assertThat(list.size()).isEqualTo(1);
|
||||
assertThat(list.size()).isGreaterThan(list.size() * 2);
|
||||
assertThat(list.size()).isGreaterThanOrEqualTo(list.size() * 2);
|
||||
assertThat(list.size()).isLessThan(list.size() * 2);
|
||||
assertThat(list.size()).isLessThanOrEqualTo(list.size() * 2);
|
||||
|
||||
assertThat(array.length).isEqualTo(0);
|
||||
assertThat(array.length).isZero();
|
||||
assertThat(array.length).isNotZero();
|
||||
assertThat(array.length).as("hi").isGreaterThan(0);
|
||||
assertThat(array.length).isGreaterThanOrEqualTo(1);
|
||||
assertThat(array.length).isLessThan(1);
|
||||
assertThat(array.length).isLessThanOrEqualTo(0);
|
||||
assertThat(array.length).isEqualTo(list.size());
|
||||
assertThat(array.length).isEqualTo(otherArray.length);
|
||||
assertThat(array.length).isEqualTo(1);
|
||||
assertThat(array.length).isGreaterThan(otherArray.length - 1);
|
||||
assertThat(array.length).isGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
assertThat(array.length).isLessThan(otherArray.length - 3);
|
||||
assertThat(array.length).isLessThanOrEqualTo(1 - otherArray.length);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,151 @@
|
||||
import org.junit.Test;
|
||||
|
||||
import java.util.*;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assumptions.assumeThat;
|
||||
|
||||
public class AssumeThat {
|
||||
|
||||
@Test
|
||||
public void junit4_return_very_early() {
|
||||
assumeThat(new Random().nextBoolean()).isFalse();
|
||||
System.out.println("sweet!"); // single else statement
|
||||
String foobar = System.getProperty("foobar");
|
||||
assertThat(foobar).isNotEmpty();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void junit4_return_in_else_branch_with_declaration_in_code_block_and_lots_of_comments() {
|
||||
// primary comments
|
||||
assumeThat(new Random().nextBoolean()).isTrue();
|
||||
{
|
||||
// Block start comment will be retained
|
||||
String anotherString = "narf"; // This one is likely to be kept
|
||||
assertThat(foobar).isNotEmpty();
|
||||
assertThat(foobar).isEqualTo(anotherString);
|
||||
// Block end comment is also going to be retained
|
||||
} /* weird places */
|
||||
// well, well, let's do some checks
|
||||
String foobar = System.getProperty("foobar");
|
||||
assertThat(foobar).isNotEmpty();
|
||||
}
|
||||
|
||||
@org.junit.jupiter.api.Test
|
||||
public void junit5_return_after_call_without_else_branch() {
|
||||
String foobar = System.getProperty("car_manufacturer");
|
||||
assumeThat(foobar.equals("Volkswagen")).isFalse();
|
||||
assertThat(foobar).isNotEmpty();
|
||||
}
|
||||
|
||||
@org.junit.jupiter.api.TestTemplate
|
||||
public void junit5_return_inside_recursion_with_comments() {
|
||||
String foobar = System.getProperty("car_manufacturer");
|
||||
if (foobar != null) {
|
||||
assumeThat(!foobar.equals("Volkswagen")).isTrue();
|
||||
// I doubted this comment will be retained -- but surprise!
|
||||
assertThat(foobar).isNotEmpty();
|
||||
// we might keep this one alright.
|
||||
foobar = "narf";
|
||||
// And the final one? Again what learned.
|
||||
}
|
||||
assertThat(foobar).startsWith("another ecology rapist");
|
||||
if(foobar.length() == 0)
|
||||
{
|
||||
return;
|
||||
}
|
||||
assertThat(foobar).endsWith("!!!");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void junit4_return_after_assertion() {
|
||||
String foobar = System.getProperty("car_manufacturer");
|
||||
assertThat(foobar).isNotNull();
|
||||
if (!foobar.equals("Volkswagen")) {
|
||||
assertThat(foobar).isNotEmpty();
|
||||
} else {
|
||||
return;
|
||||
}
|
||||
assertThat(foobar).startsWith("another ecology rapist");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void junit4_return_after_assertions_in_subroutine() {
|
||||
String foobar = System.getProperty("car_manufacturer");
|
||||
assertStuff(foobar);
|
||||
if (!foobar.equals("Volkswagen")) {
|
||||
assertThat(foobar).isNotEmpty();
|
||||
} else {
|
||||
return;
|
||||
}
|
||||
assertThat(foobar).startsWith("another ecology rapist");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void junit4_return_after_assertions_in_deep_subroutine() {
|
||||
String foobar = System.getProperty("car_manufacturer");
|
||||
firstMethod();
|
||||
if (!foobar.equals("Volkswagen")) {
|
||||
assertThat(foobar).isNotEmpty();
|
||||
} else {
|
||||
return;
|
||||
}
|
||||
assertThat(foobar).startsWith("another ecology rapist");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void junit4_return_after_assertions_in_deep_subroutine_with_recursion() {
|
||||
String foobar = System.getProperty("car_manufacturer");
|
||||
firstMethodWithPotentialRecursion();
|
||||
if (!foobar.equals("Volkswagen")) {
|
||||
assertThat(foobar).isNotEmpty();
|
||||
} else {
|
||||
return;
|
||||
}
|
||||
assertThat(foobar).startsWith("another ecology rapist");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void junit4_no_harm_with_infinite_recursion() {
|
||||
String foobar = System.getProperty("car_manufacturer");
|
||||
infiniteRecursion();
|
||||
if (!foobar.equals("Volkswagen")) {
|
||||
assertThat(foobar).isNotEmpty();
|
||||
} else {
|
||||
return;
|
||||
}
|
||||
assertThat(foobar).startsWith("another ecology rapist");
|
||||
}
|
||||
|
||||
private void assertStuff(String foobar) {
|
||||
if (new Random().nextBoolean()) {
|
||||
assertThat(foobar).isNotEmpty();
|
||||
} else {
|
||||
assertThat(foobar).isNull();
|
||||
}
|
||||
}
|
||||
|
||||
private void firstMethod() {
|
||||
if (new Random().nextBoolean()) {
|
||||
assertStuff("narf");
|
||||
}
|
||||
}
|
||||
|
||||
private void firstMethodWithPotentialRecursion() {
|
||||
if (new Random().nextBoolean()) {
|
||||
assertStuff("narf");
|
||||
} else {
|
||||
infiniteRecursion();
|
||||
}
|
||||
}
|
||||
|
||||
private void infiniteRecursion() {
|
||||
secondaryRecursion();
|
||||
secondaryRecursion();
|
||||
}
|
||||
|
||||
private void secondaryRecursion() {
|
||||
infiniteRecursion();
|
||||
infiniteRecursion();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,156 @@
|
||||
import org.junit.Test;
|
||||
|
||||
import java.util.*;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class AssumeThat {
|
||||
|
||||
@Test
|
||||
public void junit4_return_very_early() {
|
||||
if (new Random().nextBoolean()) {
|
||||
return;
|
||||
} else System.out.println("sweet!"); // single else statement
|
||||
String foobar = System.getProperty("foobar");
|
||||
assertThat(foobar).isNotEmpty();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void junit4_return_in_else_branch_with_declaration_in_code_block_and_lots_of_comments() {
|
||||
// primary comments
|
||||
if (new Random().nextBoolean()) /* strange place for a comment */ {
|
||||
// Block start comment will be retained
|
||||
String anotherString = "narf"; // This one is likely to be kept
|
||||
assertThat(foobar).isNotEmpty();
|
||||
assertThat(foobar).isEqualTo(anotherString);
|
||||
// Block end comment is also going to be retained
|
||||
} /* weird places */ else /* more weird places */ { // this one is lost
|
||||
return; // Would be sweet to keep this comment, too.
|
||||
} // another comment lost
|
||||
// well, well, let's do some checks
|
||||
String foobar = System.getProperty("foobar");
|
||||
assertThat(foobar).isNotEmpty();
|
||||
}
|
||||
|
||||
@org.junit.jupiter.api.Test
|
||||
public void junit5_return_after_call_without_else_branch() {
|
||||
String foobar = System.getProperty("car_manufacturer");
|
||||
if (foobar.equals("Volkswagen")) return; // no need for Volkswagen to perform tests
|
||||
assertThat(foobar).isNotEmpty();
|
||||
}
|
||||
|
||||
@org.junit.jupiter.api.TestTemplate
|
||||
public void junit5_return_inside_recursion_with_comments() {
|
||||
String foobar = System.getProperty("car_manufacturer");
|
||||
if (foobar != null) {
|
||||
if (!foobar.equals("Volkswagen")) {
|
||||
// I doubted this comment will be retained -- but surprise!
|
||||
assertThat(foobar).isNotEmpty();
|
||||
// we might keep this one alright.
|
||||
foobar = "narf";
|
||||
// And the final one? Again what learned.
|
||||
} else {
|
||||
// ooops, how did that happen?
|
||||
return;
|
||||
}
|
||||
}
|
||||
assertThat(foobar).startsWith("another ecology rapist");
|
||||
if(foobar.length() == 0)
|
||||
{
|
||||
return;
|
||||
}
|
||||
assertThat(foobar).endsWith("!!!");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void junit4_return_after_assertion() {
|
||||
String foobar = System.getProperty("car_manufacturer");
|
||||
assertThat(foobar).isNotNull();
|
||||
if (!foobar.equals("Volkswagen")) {
|
||||
assertThat(foobar).isNotEmpty();
|
||||
} else {
|
||||
return;
|
||||
}
|
||||
assertThat(foobar).startsWith("another ecology rapist");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void junit4_return_after_assertions_in_subroutine() {
|
||||
String foobar = System.getProperty("car_manufacturer");
|
||||
assertStuff(foobar);
|
||||
if (!foobar.equals("Volkswagen")) {
|
||||
assertThat(foobar).isNotEmpty();
|
||||
} else {
|
||||
return;
|
||||
}
|
||||
assertThat(foobar).startsWith("another ecology rapist");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void junit4_return_after_assertions_in_deep_subroutine() {
|
||||
String foobar = System.getProperty("car_manufacturer");
|
||||
firstMethod();
|
||||
if (!foobar.equals("Volkswagen")) {
|
||||
assertThat(foobar).isNotEmpty();
|
||||
} else {
|
||||
return;
|
||||
}
|
||||
assertThat(foobar).startsWith("another ecology rapist");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void junit4_return_after_assertions_in_deep_subroutine_with_recursion() {
|
||||
String foobar = System.getProperty("car_manufacturer");
|
||||
firstMethodWithPotentialRecursion();
|
||||
if (!foobar.equals("Volkswagen")) {
|
||||
assertThat(foobar).isNotEmpty();
|
||||
} else {
|
||||
return;
|
||||
}
|
||||
assertThat(foobar).startsWith("another ecology rapist");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void junit4_no_harm_with_infinite_recursion() {
|
||||
String foobar = System.getProperty("car_manufacturer");
|
||||
infiniteRecursion();
|
||||
if (!foobar.equals("Volkswagen")) {
|
||||
assertThat(foobar).isNotEmpty();
|
||||
} else {
|
||||
return;
|
||||
}
|
||||
assertThat(foobar).startsWith("another ecology rapist");
|
||||
}
|
||||
|
||||
private void assertStuff(String foobar) {
|
||||
if (new Random().nextBoolean()) {
|
||||
assertThat(foobar).isNotEmpty();
|
||||
} else {
|
||||
assertThat(foobar).isNull();
|
||||
}
|
||||
}
|
||||
|
||||
private void firstMethod() {
|
||||
if (new Random().nextBoolean()) {
|
||||
assertStuff("narf");
|
||||
}
|
||||
}
|
||||
|
||||
private void firstMethodWithPotentialRecursion() {
|
||||
if (new Random().nextBoolean()) {
|
||||
assertStuff("narf");
|
||||
} else {
|
||||
infiniteRecursion();
|
||||
}
|
||||
}
|
||||
|
||||
private void infiniteRecursion() {
|
||||
secondaryRecursion();
|
||||
secondaryRecursion();
|
||||
}
|
||||
|
||||
private void secondaryRecursion() {
|
||||
infiniteRecursion();
|
||||
infiniteRecursion();
|
||||
}
|
||||
}
|
||||
@@ -10,7 +10,7 @@ public class BinaryExpression {
|
||||
String stringExp = "foo";
|
||||
String stringAct = "bar";
|
||||
|
||||
assertThat(primAct).isEqualTo(primExp);
|
||||
assertThat(primAct).as("doh!").isEqualTo(primExp);
|
||||
assertThat(primAct).isEqualTo(primExp);
|
||||
assertThat(primAct).isEqualTo(primExp);
|
||||
assertThat(primAct).isEqualTo(primExp);
|
||||
@@ -25,7 +25,7 @@ public class BinaryExpression {
|
||||
assertThat(primAct).isNotEqualTo(1);
|
||||
assertThat(primAct).isNotEqualTo(1);
|
||||
|
||||
assertThat(primAct).isNotEqualTo(primExp);
|
||||
assertThat(primAct).as("doh!").isNotEqualTo(primExp);
|
||||
assertThat(primAct).isNotEqualTo(primExp);
|
||||
assertThat(primAct).isNotEqualTo(primExp);
|
||||
assertThat(primAct).isNotEqualTo(1);
|
||||
@@ -36,7 +36,7 @@ public class BinaryExpression {
|
||||
assertThat(primAct).isEqualTo(1);
|
||||
assertThat(primAct).isEqualTo(1);
|
||||
|
||||
assertThat(primAct).isGreaterThan(primExp);
|
||||
assertThat(primAct).as("doh!").isGreaterThan(primExp);
|
||||
assertThat(primAct).isGreaterThan(primExp);
|
||||
assertThat(primAct).isGreaterThan(primExp);
|
||||
assertThat(primAct).isGreaterThan(1);
|
||||
@@ -47,7 +47,7 @@ public class BinaryExpression {
|
||||
assertThat(primAct).isLessThanOrEqualTo(1);
|
||||
assertThat(primAct).isLessThanOrEqualTo(1);
|
||||
|
||||
assertThat(primAct).isGreaterThanOrEqualTo(primExp);
|
||||
assertThat(primAct).as("doh!").isGreaterThanOrEqualTo(primExp);
|
||||
assertThat(primAct).isGreaterThanOrEqualTo(primExp);
|
||||
assertThat(primAct).isGreaterThanOrEqualTo(primExp);
|
||||
assertThat(primAct).isGreaterThanOrEqualTo(1);
|
||||
@@ -58,7 +58,7 @@ public class BinaryExpression {
|
||||
assertThat(primAct).isLessThan(1);
|
||||
assertThat(primAct).isLessThan(1);
|
||||
|
||||
assertThat(primAct).isLessThan(primExp);
|
||||
assertThat(primAct).as("doh!").isLessThan(primExp);
|
||||
assertThat(primAct).isLessThan(primExp);
|
||||
assertThat(primAct).isLessThan(primExp);
|
||||
assertThat(primAct).isLessThan(1);
|
||||
@@ -69,7 +69,7 @@ public class BinaryExpression {
|
||||
assertThat(primAct).isGreaterThanOrEqualTo(1);
|
||||
assertThat(primAct).isGreaterThanOrEqualTo(1);
|
||||
|
||||
assertThat(primAct).isLessThanOrEqualTo(primExp);
|
||||
assertThat(primAct).as("doh!").isLessThanOrEqualTo(primExp);
|
||||
assertThat(primAct).isLessThanOrEqualTo(primExp);
|
||||
assertThat(primAct).isLessThanOrEqualTo(primExp);
|
||||
assertThat(primAct).isLessThanOrEqualTo(1);
|
||||
@@ -80,7 +80,7 @@ public class BinaryExpression {
|
||||
assertThat(primAct).isGreaterThan(1);
|
||||
assertThat(primAct).isGreaterThan(1);
|
||||
|
||||
assertThat(numberObjAct).isEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).as("doh!").isEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isEqualTo(1);
|
||||
@@ -91,7 +91,7 @@ public class BinaryExpression {
|
||||
assertThat(numberObjAct).isNotEqualTo(1);
|
||||
assertThat(numberObjAct).isNotEqualTo(1);
|
||||
|
||||
assertThat(numberObjAct).isNotEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).as("doh!").isNotEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isNotEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isNotEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isNotEqualTo(1);
|
||||
@@ -102,7 +102,7 @@ public class BinaryExpression {
|
||||
assertThat(numberObjAct).isEqualTo(1);
|
||||
assertThat(numberObjAct).isEqualTo(1);
|
||||
|
||||
assertThat(numberObjAct).isGreaterThan(numberObjExp);
|
||||
assertThat(numberObjAct).as("doh!").isGreaterThan(numberObjExp);
|
||||
assertThat(numberObjAct).isGreaterThan(numberObjExp);
|
||||
assertThat(numberObjAct).isGreaterThan(numberObjExp);
|
||||
assertThat(numberObjAct).isGreaterThan(1);
|
||||
@@ -113,7 +113,7 @@ public class BinaryExpression {
|
||||
assertThat(numberObjAct).isLessThanOrEqualTo(1);
|
||||
assertThat(numberObjAct).isLessThanOrEqualTo(1);
|
||||
|
||||
assertThat(numberObjAct).isGreaterThanOrEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).as("doh!").isGreaterThanOrEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isGreaterThanOrEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isGreaterThanOrEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isGreaterThanOrEqualTo(1);
|
||||
@@ -124,7 +124,7 @@ public class BinaryExpression {
|
||||
assertThat(numberObjAct).isLessThan(1);
|
||||
assertThat(numberObjAct).isLessThan(1);
|
||||
|
||||
assertThat(numberObjAct).isLessThan(numberObjExp);
|
||||
assertThat(numberObjAct).as("doh!").isLessThan(numberObjExp);
|
||||
assertThat(numberObjAct).isLessThan(numberObjExp);
|
||||
assertThat(numberObjAct).isLessThan(numberObjExp);
|
||||
assertThat(numberObjAct).isLessThan(1);
|
||||
@@ -135,7 +135,7 @@ public class BinaryExpression {
|
||||
assertThat(numberObjAct).isGreaterThanOrEqualTo(1);
|
||||
assertThat(numberObjAct).isGreaterThanOrEqualTo(1);
|
||||
|
||||
assertThat(numberObjAct).isLessThanOrEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).as("doh!").isLessThanOrEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isLessThanOrEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isLessThanOrEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isLessThanOrEqualTo(1);
|
||||
@@ -146,42 +146,42 @@ public class BinaryExpression {
|
||||
assertThat(numberObjAct).isGreaterThan(1);
|
||||
assertThat(numberObjAct).isGreaterThan(1);
|
||||
|
||||
assertThat(numberObjAct).isEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).as("doh!").isEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isNotEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isNotEqualTo(numberObjExp);
|
||||
assertThat(numberObjAct).isNotEqualTo(numberObjExp);
|
||||
|
||||
assertThat(stringAct).isSameAs(stringExp);
|
||||
assertThat(stringAct).as("doh!").isSameAs(stringExp);
|
||||
assertThat(stringAct).isSameAs(stringExp);
|
||||
assertThat(stringAct).isSameAs(stringExp);
|
||||
assertThat(stringAct).isNotSameAs(stringExp);
|
||||
assertThat(stringAct).isNotSameAs(stringExp);
|
||||
assertThat(stringAct).isNotSameAs(stringExp);
|
||||
|
||||
assertThat(stringAct).isEqualTo(stringExp);
|
||||
assertThat(stringAct).as("doh!").isEqualTo(stringExp);
|
||||
assertThat(stringAct).isEqualTo(stringExp);
|
||||
assertThat(stringAct).isEqualTo(stringExp);
|
||||
assertThat(stringAct).isNotEqualTo(stringExp);
|
||||
assertThat(stringAct).isNotEqualTo(stringExp);
|
||||
assertThat(stringAct).isNotEqualTo(stringExp);
|
||||
|
||||
assertThat(stringAct).isNotSameAs(stringExp);
|
||||
assertThat(stringAct).as("doh!").isNotSameAs(stringExp);
|
||||
assertThat(stringAct).isNotSameAs(stringExp);
|
||||
assertThat(stringAct).isNotSameAs(stringExp);
|
||||
assertThat(stringAct).isSameAs(stringExp);
|
||||
assertThat(stringAct).isSameAs(stringExp);
|
||||
assertThat(stringAct).isSameAs(stringExp);
|
||||
|
||||
assertThat(stringAct).isNull();
|
||||
assertThat(stringAct).as("doh!").isNull();
|
||||
assertThat(stringAct).isNull();
|
||||
assertThat(stringAct).isNull();
|
||||
assertThat(stringAct).isNotNull();
|
||||
assertThat(stringAct).isNotNull();
|
||||
assertThat(stringAct).isNotNull();
|
||||
|
||||
assertThat(stringAct).isNull();
|
||||
assertThat(stringAct).as("doh!").isNull();
|
||||
assertThat(stringAct).isNull();
|
||||
assertThat(stringAct).isNull();
|
||||
assertThat(stringAct).isNotNull();
|
||||
@@ -190,5 +190,10 @@ public class BinaryExpression {
|
||||
|
||||
assertThat(null == null).isTrue();
|
||||
assertThat(!false).isTrue();
|
||||
|
||||
assertThat(primAct).as("doh!").isEqualTo(primExp).isEqualTo(primExp);
|
||||
assertThat(primAct == primExp).isFalse().as("doh!").isEqualTo(true);
|
||||
|
||||
assertThat(numberObjAct).as("doh!").isEqualTo(numberObjExp).isEqualTo(numberObjExp);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -10,7 +10,7 @@ public class BinaryExpression {
|
||||
String stringExp = "foo";
|
||||
String stringAct = "bar";
|
||||
|
||||
assertThat(primAct == primExp).isTrue();
|
||||
assertThat(primAct == primExp).as("doh!").isTrue();
|
||||
assertThat(primAct == primExp).isEqualTo(true);
|
||||
assertThat(primAct == primExp).isEqualTo(Boolean.TRUE);
|
||||
assertThat(primAct == primExp).isNotEqualTo(false);
|
||||
@@ -25,7 +25,7 @@ public class BinaryExpression {
|
||||
assertThat(primAct == 1).isFalse();
|
||||
assertThat(1 == primAct).isFalse();
|
||||
|
||||
assertThat(primAct != primExp).isTrue();
|
||||
assertThat(primAct != primExp).as("doh!").isTrue();
|
||||
assertThat(primAct != primExp).isEqualTo(true);
|
||||
assertThat(primAct != primExp).isNotEqualTo(false);
|
||||
assertThat(primAct != 1).isTrue();
|
||||
@@ -36,7 +36,7 @@ public class BinaryExpression {
|
||||
assertThat(primAct != 1).isFalse();
|
||||
assertThat(1 != primAct).isFalse();
|
||||
|
||||
assertThat(primAct > primExp).isTrue();
|
||||
assertThat(primAct > primExp).as("doh!").isTrue();
|
||||
assertThat(primAct > primExp).isEqualTo(true);
|
||||
assertThat(primAct > primExp).isNotEqualTo(false);
|
||||
assertThat(primAct > 1).isTrue();
|
||||
@@ -47,7 +47,7 @@ public class BinaryExpression {
|
||||
assertThat(primAct > 1).isFalse();
|
||||
assertThat(1 < primAct).isFalse();
|
||||
|
||||
assertThat(primAct >= primExp).isTrue();
|
||||
assertThat(primAct >= primExp).as("doh!").isTrue();
|
||||
assertThat(primAct >= primExp).isEqualTo(true);
|
||||
assertThat(primAct >= primExp).isNotEqualTo(false);
|
||||
assertThat(primAct >= 1).isTrue();
|
||||
@@ -58,7 +58,7 @@ public class BinaryExpression {
|
||||
assertThat(primAct >= 1).isFalse();
|
||||
assertThat(1 <= primAct).isFalse();
|
||||
|
||||
assertThat(primAct < primExp).isTrue();
|
||||
assertThat(primAct < primExp).as("doh!").isTrue();
|
||||
assertThat(primAct < primExp).isEqualTo(true);
|
||||
assertThat(primAct < primExp).isNotEqualTo(false);
|
||||
assertThat(primAct < 1).isTrue();
|
||||
@@ -69,7 +69,7 @@ public class BinaryExpression {
|
||||
assertThat(primAct < 1).isFalse();
|
||||
assertThat(1 > primAct).isFalse();
|
||||
|
||||
assertThat(primAct <= primExp).isTrue();
|
||||
assertThat(primAct <= primExp).as("doh!").isTrue();
|
||||
assertThat(primAct <= primExp).isEqualTo(true);
|
||||
assertThat(primAct <= primExp).isNotEqualTo(false);
|
||||
assertThat(primAct <= 1).isTrue();
|
||||
@@ -80,7 +80,7 @@ public class BinaryExpression {
|
||||
assertThat(primAct <= 1).isFalse();
|
||||
assertThat(1 >= primAct).isFalse();
|
||||
|
||||
assertThat(numberObjAct == numberObjExp).isTrue();
|
||||
assertThat(numberObjAct == numberObjExp).as("doh!").isTrue();
|
||||
assertThat(numberObjAct == numberObjExp).isEqualTo(true);
|
||||
assertThat(numberObjAct == numberObjExp).isNotEqualTo(false);
|
||||
assertThat(numberObjAct == 1).isTrue();
|
||||
@@ -91,7 +91,7 @@ public class BinaryExpression {
|
||||
assertThat(numberObjAct == 1).isFalse();
|
||||
assertThat(1 == numberObjAct).isFalse();
|
||||
|
||||
assertThat(numberObjAct != numberObjExp).isTrue();
|
||||
assertThat(numberObjAct != numberObjExp).as("doh!").isTrue();
|
||||
assertThat(numberObjAct != numberObjExp).isEqualTo(true);
|
||||
assertThat(numberObjAct != numberObjExp).isNotEqualTo(false);
|
||||
assertThat(numberObjAct != 1).isTrue();
|
||||
@@ -102,7 +102,7 @@ public class BinaryExpression {
|
||||
assertThat(numberObjAct != 1).isFalse();
|
||||
assertThat(1 != numberObjAct).isFalse();
|
||||
|
||||
assertThat(numberObjAct > numberObjExp).isTrue();
|
||||
assertThat(numberObjAct > numberObjExp).as("doh!").isTrue();
|
||||
assertThat(numberObjAct > numberObjExp).isEqualTo(true);
|
||||
assertThat(numberObjAct > numberObjExp).isNotEqualTo(false);
|
||||
assertThat(numberObjAct > 1).isTrue();
|
||||
@@ -113,7 +113,7 @@ public class BinaryExpression {
|
||||
assertThat(numberObjAct > 1).isFalse();
|
||||
assertThat(1 < numberObjAct).isFalse();
|
||||
|
||||
assertThat(numberObjAct >= numberObjExp).isTrue();
|
||||
assertThat(numberObjAct >= numberObjExp).as("doh!").isTrue();
|
||||
assertThat(numberObjAct >= numberObjExp).isEqualTo(true);
|
||||
assertThat(numberObjAct >= numberObjExp).isNotEqualTo(false);
|
||||
assertThat(numberObjAct >= 1).isTrue();
|
||||
@@ -124,7 +124,7 @@ public class BinaryExpression {
|
||||
assertThat(numberObjAct >= 1).isFalse();
|
||||
assertThat(1 <= numberObjAct).isFalse();
|
||||
|
||||
assertThat(numberObjAct < numberObjExp).isTrue();
|
||||
assertThat(numberObjAct < numberObjExp).as("doh!").isTrue();
|
||||
assertThat(numberObjAct < numberObjExp).isEqualTo(true);
|
||||
assertThat(numberObjAct < numberObjExp).isNotEqualTo(false);
|
||||
assertThat(numberObjAct < 1).isTrue();
|
||||
@@ -135,7 +135,7 @@ public class BinaryExpression {
|
||||
assertThat(numberObjAct < 1).isFalse();
|
||||
assertThat(1 > numberObjAct).isFalse();
|
||||
|
||||
assertThat(numberObjAct <= numberObjExp).isTrue();
|
||||
assertThat(numberObjAct <= numberObjExp).as("doh!").isTrue();
|
||||
assertThat(numberObjAct <= numberObjExp).isEqualTo(true);
|
||||
assertThat(numberObjAct <= numberObjExp).isNotEqualTo(false);
|
||||
assertThat(numberObjAct <= 1).isTrue();
|
||||
@@ -146,42 +146,42 @@ public class BinaryExpression {
|
||||
assertThat(numberObjAct <= 1).isFalse();
|
||||
assertThat(1 >= numberObjAct).isFalse();
|
||||
|
||||
assertThat(numberObjAct.equals(numberObjExp)).isTrue();
|
||||
assertThat(numberObjAct.equals(numberObjExp)).as("doh!").isTrue();
|
||||
assertThat(numberObjAct.equals(numberObjExp)).isEqualTo(true);
|
||||
assertThat(numberObjAct.equals(numberObjExp)).isNotEqualTo(false);
|
||||
assertThat(numberObjAct.equals(numberObjExp)).isFalse();
|
||||
assertThat(numberObjAct.equals(numberObjExp)).isEqualTo(false);
|
||||
assertThat(numberObjAct.equals(numberObjExp)).isNotEqualTo(true);
|
||||
|
||||
assertThat(stringAct == stringExp).isTrue();
|
||||
assertThat(stringAct == stringExp).as("doh!").isTrue();
|
||||
assertThat(stringAct == stringExp).isEqualTo(true);
|
||||
assertThat(stringAct == stringExp).isNotEqualTo(false);
|
||||
assertThat(stringAct == stringExp).isFalse();
|
||||
assertThat(stringAct == stringExp).isEqualTo(false);
|
||||
assertThat(stringAct == stringExp).isNotEqualTo(true);
|
||||
|
||||
assertThat(stringAct.equals(stringExp)).isTrue();
|
||||
assertThat(stringAct.equals(stringExp)).as("doh!").isTrue();
|
||||
assertThat(stringAct.equals(stringExp)).isEqualTo(true);
|
||||
assertThat(stringAct.equals(stringExp)).isNotEqualTo(false);
|
||||
assertThat(stringAct.equals(stringExp)).isFalse();
|
||||
assertThat(stringAct.equals(stringExp)).isEqualTo(false);
|
||||
assertThat(stringAct.equals(stringExp)).isNotEqualTo(true);
|
||||
|
||||
assertThat(stringAct != stringExp).isTrue();
|
||||
assertThat(stringAct != stringExp).as("doh!").isTrue();
|
||||
assertThat(stringAct != stringExp).isEqualTo(true);
|
||||
assertThat(stringAct != stringExp).isNotEqualTo(false);
|
||||
assertThat(stringAct != stringExp).isFalse();
|
||||
assertThat(stringAct != stringExp).isEqualTo(false);
|
||||
assertThat(stringAct != stringExp).isNotEqualTo(true);
|
||||
|
||||
assertThat(stringAct == null).isTrue();
|
||||
assertThat(stringAct == null).as("doh!").isTrue();
|
||||
assertThat(stringAct == null).isEqualTo(true);
|
||||
assertThat(stringAct == null).isNotEqualTo(false);
|
||||
assertThat(stringAct == null).isFalse();
|
||||
assertThat(stringAct == null).isEqualTo(false);
|
||||
assertThat(stringAct == null).isNotEqualTo(true);
|
||||
|
||||
assertThat(null == stringAct).isTrue();
|
||||
assertThat(null == stringAct).as("doh!").isTrue();
|
||||
assertThat(null == stringAct).isEqualTo(true);
|
||||
assertThat(null == stringAct).isNotEqualTo(false);
|
||||
assertThat(null == stringAct).isFalse();
|
||||
@@ -190,5 +190,10 @@ public class BinaryExpression {
|
||||
|
||||
assertThat(null == null).isTrue();
|
||||
assertThat(!false).isTrue();
|
||||
|
||||
assertThat(primAct == primExp).as("doh!").isTrue().isEqualTo(true);
|
||||
assertThat(primAct == primExp).isFalse().as("doh!").isEqualTo(true);
|
||||
|
||||
assertThat(numberObjAct.equals(numberObjExp)).as("doh!").isTrue().isEqualTo(true);
|
||||
}
|
||||
}
|
||||
|
||||
+6
-4
@@ -1,12 +1,12 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class BooleanIsTrueOrFalse {
|
||||
public class BooleanCondition {
|
||||
|
||||
private void booleanIsTrueOrFalse() {
|
||||
private void booleanCondition() {
|
||||
boolean primitive = false;
|
||||
Boolean object = Boolean.TRUE;
|
||||
|
||||
assertThat(primitive).isTrue();
|
||||
assertThat(primitive).as("foo").isTrue();
|
||||
assertThat(primitive).isFalse();
|
||||
assertThat(object).isTrue();
|
||||
assertThat(object).isFalse();
|
||||
@@ -15,7 +15,7 @@ public class BooleanIsTrueOrFalse {
|
||||
assertThat(object).isTrue();
|
||||
assertThat(object).isFalse();
|
||||
|
||||
assertThat(primitive).isFalse();
|
||||
assertThat(primitive).as("foo").isFalse();
|
||||
assertThat(primitive).isTrue();
|
||||
assertThat(object).isFalse();
|
||||
assertThat(object).isTrue();
|
||||
@@ -28,5 +28,7 @@ public class BooleanIsTrueOrFalse {
|
||||
assertThat(object).isEqualTo(Boolean.TRUE && !Boolean.TRUE);
|
||||
|
||||
assertThat("").isEqualTo(Boolean.TRUE);
|
||||
|
||||
assertThat(primitive).isTrue().as("foo").isTrue().as("bar").isTrue().isFalse();
|
||||
}
|
||||
}
|
||||
+6
-4
@@ -1,12 +1,12 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class BooleanIsTrueOrFalse {
|
||||
public class BooleanCondition {
|
||||
|
||||
private void booleanIsTrueOrFalse() {
|
||||
private void booleanCondition() {
|
||||
boolean primitive = false;
|
||||
Boolean object = Boolean.TRUE;
|
||||
|
||||
assertThat(primitive).isEqualTo(Boolean.TRUE);
|
||||
assertThat(primitive).as("foo").isEqualTo(Boolean.TRUE);
|
||||
assertThat(primitive).isEqualTo(Boolean.FALSE);
|
||||
assertThat(object).isEqualTo(Boolean.TRUE);
|
||||
assertThat(object).isEqualTo(Boolean.FALSE);
|
||||
@@ -15,7 +15,7 @@ public class BooleanIsTrueOrFalse {
|
||||
assertThat(object).isEqualTo(true);
|
||||
assertThat(object).isEqualTo(false);
|
||||
|
||||
assertThat(primitive).isNotEqualTo(Boolean.TRUE);
|
||||
assertThat(primitive).as("foo").isNotEqualTo(Boolean.TRUE);
|
||||
assertThat(primitive).isNotEqualTo(Boolean.FALSE);
|
||||
assertThat(object).isNotEqualTo(Boolean.TRUE);
|
||||
assertThat(object).isNotEqualTo(Boolean.FALSE);
|
||||
@@ -28,5 +28,7 @@ public class BooleanIsTrueOrFalse {
|
||||
assertThat(object).isEqualTo(Boolean.TRUE && !Boolean.TRUE);
|
||||
|
||||
assertThat("").isEqualTo(Boolean.TRUE);
|
||||
|
||||
assertThat(primitive).isEqualTo(Boolean.TRUE).as("foo").isEqualTo(true).as("bar").isTrue().isFalse();
|
||||
}
|
||||
}
|
||||
@@ -14,5 +14,7 @@ public class EnumerableIsEmpty {
|
||||
assertThat(new StringBuilder()).as("bar").hasSize(1);
|
||||
assertThat(new ArrayList<Long>()).as("etc").hasSize(1);
|
||||
assertThat(new Long[1]).as("etc").hasSize(1);
|
||||
|
||||
assertThat("string").as("foo").hasSize(0).hasSameSizeAs("foo").isEmpty();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -14,5 +14,7 @@ public class EnumerableIsEmpty {
|
||||
assertThat(new StringBuilder()).as("bar").hasSize(1);
|
||||
assertThat(new ArrayList<Long>()).as("etc").hasSize(1);
|
||||
assertThat(new Long[1]).as("etc").hasSize(1);
|
||||
|
||||
assertThat("string").as("foo").hasSize(0).hasSameSizeAs("foo").hasSize(0);
|
||||
}
|
||||
}
|
||||
|
||||
+15
-12
@@ -3,29 +3,29 @@ import com.google.common.base.Optional;
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.guava.api.Assertions.assertThat;
|
||||
|
||||
public class AssertThatGuavaOptional {
|
||||
public class GuavaOptional {
|
||||
|
||||
private void assertThatGuavaOptional() {
|
||||
private void guavaOptional() {
|
||||
Optional<String> opt = Optional.absent();
|
||||
|
||||
assertThat(opt).isPresent();
|
||||
assertThat(opt).as("foo").isPresent();
|
||||
assertThat(opt).isPresent();
|
||||
assertThat(opt).isPresent();
|
||||
assertThat(opt).isPresent();
|
||||
assertThat(opt).isPresent();
|
||||
|
||||
assertThat(opt).isAbsent();
|
||||
assertThat(opt).as("foo").isAbsent();
|
||||
assertThat(opt).isAbsent();
|
||||
assertThat(opt).isAbsent();
|
||||
assertThat(opt).isAbsent();
|
||||
assertThat(opt).isAbsent();
|
||||
|
||||
assertThat(opt).contains("foo");
|
||||
assertThat(opt).as("foo").contains("foo");
|
||||
assertThat(opt.get()).isSameAs("foo");
|
||||
assertThat(opt.get()).isNotEqualTo("foo");
|
||||
assertThat(opt.get()).isNotSameAs("foo");
|
||||
|
||||
assertThat(opt).contains("foo");
|
||||
assertThat(opt).as("foo").contains("foo");
|
||||
assertThat(opt).contains("foo");
|
||||
assertThat(opt).isNotEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).isNotEqualTo(Optional.fromNullable("foo"));
|
||||
@@ -33,20 +33,23 @@ public class AssertThatGuavaOptional {
|
||||
assertThat(opt).isAbsent();
|
||||
assertThat(opt).isPresent();
|
||||
|
||||
org.assertj.guava.api.Assertions.assertThat(opt).contains("foo");
|
||||
org.assertj.guava.api.Assertions.assertThat(opt).contains("foo");
|
||||
assertThat(opt).as("foo").contains("foo");
|
||||
assertThat(opt).contains("foo");
|
||||
org.assertj.guava.api.Assertions.assertThat(opt).isNotEqualTo(Optional.of("foo"));
|
||||
org.assertj.guava.api.Assertions.assertThat(opt).isNotEqualTo(Optional.fromNullable("foo"));
|
||||
|
||||
org.assertj.guava.api.Assertions.assertThat(opt).isAbsent();
|
||||
org.assertj.guava.api.Assertions.assertThat(opt).isPresent();
|
||||
assertThat(opt).as("foo").isAbsent();
|
||||
assertThat(opt).isPresent();
|
||||
|
||||
assertThat(opt).contains("foo");
|
||||
assertThat(opt).as("foo").contains("foo");
|
||||
assertThat(opt).contains("foo");
|
||||
org.assertj.core.api.Assertions.assertThat(opt).isNotEqualTo(Optional.of("foo"));
|
||||
org.assertj.core.api.Assertions.assertThat(opt).isNotEqualTo(Optional.fromNullable("foo"));
|
||||
|
||||
assertThat(opt).isAbsent();
|
||||
assertThat(opt).as("foo").isAbsent();
|
||||
assertThat(opt).isPresent();
|
||||
|
||||
assertThat(opt).as("foo").isPresent().as("bar").isPresent();
|
||||
assertThat(opt.isPresent()).as("foo").isEqualTo(true).as("bar").isEqualTo(Boolean.FALSE);
|
||||
}
|
||||
}
|
||||
+13
-10
@@ -3,29 +3,29 @@ import com.google.common.base.Optional;
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.guava.api.Assertions.assertThat;
|
||||
|
||||
public class AssertThatGuavaOptional {
|
||||
public class GuavaOptional {
|
||||
|
||||
private void assertThatGuavaOptional() {
|
||||
private void guavaOptional() {
|
||||
Optional<String> opt = Optional.absent();
|
||||
|
||||
assertThat(opt.isPresent()).isEqualTo(true);
|
||||
assertThat(opt.isPresent()).as("foo").isEqualTo(true);
|
||||
assertThat(opt.isPresent()).isEqualTo(Boolean.TRUE);
|
||||
assertThat(opt.isPresent()).isNotEqualTo(false);
|
||||
assertThat(opt.isPresent()).isNotEqualTo(Boolean.FALSE);
|
||||
assertThat(opt.isPresent()).isTrue();
|
||||
|
||||
assertThat(opt.isPresent()).isEqualTo(false);
|
||||
assertThat(opt.isPresent()).as("foo").isEqualTo(false);
|
||||
assertThat(opt.isPresent()).isEqualTo(Boolean.FALSE);
|
||||
assertThat(opt.isPresent()).isNotEqualTo(true);
|
||||
assertThat(opt.isPresent()).isNotEqualTo(Boolean.TRUE);
|
||||
assertThat(opt.isPresent()).isFalse();
|
||||
|
||||
assertThat(opt.get()).isEqualTo("foo");
|
||||
assertThat(opt.get()).as("foo").isEqualTo("foo");
|
||||
assertThat(opt.get()).isSameAs("foo");
|
||||
assertThat(opt.get()).isNotEqualTo("foo");
|
||||
assertThat(opt.get()).isNotSameAs("foo");
|
||||
|
||||
assertThat(opt).isEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).as("foo").isEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).isEqualTo(Optional.fromNullable("foo"));
|
||||
assertThat(opt).isNotEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).isNotEqualTo(Optional.fromNullable("foo"));
|
||||
@@ -33,20 +33,23 @@ public class AssertThatGuavaOptional {
|
||||
assertThat(opt).isEqualTo(Optional.absent());
|
||||
assertThat(opt).isNotEqualTo(Optional.absent());
|
||||
|
||||
org.assertj.guava.api.Assertions.assertThat(opt).isEqualTo(Optional.of("foo"));
|
||||
org.assertj.guava.api.Assertions.assertThat(opt).as("foo").isEqualTo(Optional.of("foo"));
|
||||
org.assertj.guava.api.Assertions.assertThat(opt).isEqualTo(Optional.fromNullable("foo"));
|
||||
org.assertj.guava.api.Assertions.assertThat(opt).isNotEqualTo(Optional.of("foo"));
|
||||
org.assertj.guava.api.Assertions.assertThat(opt).isNotEqualTo(Optional.fromNullable("foo"));
|
||||
|
||||
org.assertj.guava.api.Assertions.assertThat(opt).isEqualTo(Optional.absent());
|
||||
org.assertj.guava.api.Assertions.assertThat(opt).as("foo").isEqualTo(Optional.absent());
|
||||
org.assertj.guava.api.Assertions.assertThat(opt).isNotEqualTo(Optional.absent());
|
||||
|
||||
org.assertj.core.api.Assertions.assertThat(opt).isEqualTo(Optional.of("foo"));
|
||||
org.assertj.core.api.Assertions.assertThat(opt).as("foo").isEqualTo(Optional.of("foo"));
|
||||
org.assertj.core.api.Assertions.assertThat(opt).isEqualTo(Optional.fromNullable("foo"));
|
||||
org.assertj.core.api.Assertions.assertThat(opt).isNotEqualTo(Optional.of("foo"));
|
||||
org.assertj.core.api.Assertions.assertThat(opt).isNotEqualTo(Optional.fromNullable("foo"));
|
||||
|
||||
org.assertj.core.api.Assertions.assertThat(opt).isEqualTo(Optional.absent());
|
||||
org.assertj.core.api.Assertions.assertThat(opt).as("foo").isEqualTo(Optional.absent());
|
||||
org.assertj.core.api.Assertions.assertThat(opt).isNotEqualTo(Optional.absent());
|
||||
|
||||
assertThat(opt.isPresent()).as("foo").isEqualTo(true).as("bar").isEqualTo(Boolean.TRUE);
|
||||
assertThat(opt.isPresent()).as("foo").isEqualTo(true).as("bar").isEqualTo(Boolean.FALSE);
|
||||
}
|
||||
}
|
||||
+2
-2
@@ -3,9 +3,9 @@ import com.google.common.base.Optional;
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.guava.api.Assertions.assertThat;
|
||||
|
||||
public class AssertThatGuavaOptional {
|
||||
public class GuavaOptional {
|
||||
|
||||
private void assertThatGuavaOptional() {
|
||||
private void guavaOptional() {
|
||||
Optional<String> opt = Optional.absent();
|
||||
|
||||
assertThat(opt).contains("foo");
|
||||
+2
-2
@@ -2,9 +2,9 @@ import com.google.common.base.Optional;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class AssertThatGuavaOptional {
|
||||
public class GuavaOptional {
|
||||
|
||||
private void assertThatGuavaOptional() {
|
||||
private void guavaOptional() {
|
||||
Optional<String> opt = Optional.absent();
|
||||
|
||||
assertThat(opt).isEqualTo(Optional.of("foo"));
|
||||
@@ -0,0 +1,25 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class InstanceOf {
|
||||
|
||||
private void instanceOf() {
|
||||
Boolean object = Boolean.TRUE;
|
||||
|
||||
assertThat(object).as("foo").isInstanceOf(Boolean.class);
|
||||
assertThat(object).isInstanceOf(Boolean.class);
|
||||
assertThat(object).isInstanceOf(Boolean.class);
|
||||
assertThat(object).isInstanceOf(Boolean.class);
|
||||
assertThat(object).isInstanceOf(Boolean.class);
|
||||
|
||||
assertThat(object).as("foo").isNotInstanceOf(Boolean.class);
|
||||
assertThat(object).isNotInstanceOf(Boolean.class);
|
||||
assertThat(object).isNotInstanceOf(Boolean.class);
|
||||
assertThat(object).isNotInstanceOf(Boolean.class);
|
||||
assertThat(object).isNotInstanceOf(Boolean.class);
|
||||
|
||||
assertThat(object).as("nah").isNotInstanceOf(Boolean.class);
|
||||
|
||||
assertThat(object).as("foo").isInstanceOf(Boolean.class).as("bar").isInstanceOf(Boolean.class);
|
||||
assertThat(object instanceof Boolean).as("foo").isEqualTo(Boolean.TRUE).as("bar").isEqualTo(false);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,25 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class InstanceOf {
|
||||
|
||||
private void instanceOf() {
|
||||
Boolean object = Boolean.TRUE;
|
||||
|
||||
assertThat(object instanceof Boolean).as("foo").isEqualTo(Boolean.TRUE);
|
||||
assertThat(object instanceof Boolean).isEqualTo(true);
|
||||
assertThat(object instanceof Boolean).isNotEqualTo(Boolean.FALSE);
|
||||
assertThat(object instanceof Boolean).isNotEqualTo(false);
|
||||
assertThat(object instanceof Boolean).isTrue();
|
||||
|
||||
assertThat(object instanceof Boolean).as("foo").isEqualTo(Boolean.FALSE);
|
||||
assertThat(object instanceof Boolean).isEqualTo(false);
|
||||
assertThat(object instanceof Boolean).isNotEqualTo(Boolean.TRUE);
|
||||
assertThat(object instanceof Boolean).isNotEqualTo(true);
|
||||
assertThat(object instanceof Boolean).isFalse();
|
||||
|
||||
assertThat(((object)) instanceof Boolean).as("nah").isEqualTo(true && !true);
|
||||
|
||||
assertThat(object instanceof Boolean).as("foo").isEqualTo(Boolean.TRUE).as("bar").isEqualTo(true);
|
||||
assertThat(object instanceof Boolean).as("foo").isEqualTo(Boolean.TRUE).as("bar").isEqualTo(false);
|
||||
}
|
||||
}
|
||||
+39
@@ -0,0 +1,39 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class InvertedBooleanCondition {
|
||||
|
||||
private void invertedBooleanCondition() {
|
||||
boolean primitive = false;
|
||||
Boolean object = Boolean.TRUE;
|
||||
|
||||
assertThat(primitive).as("foo").isFalse();
|
||||
assertThat(primitive).isFalse();
|
||||
assertThat(primitive).isFalse();
|
||||
assertThat(primitive).isFalse();
|
||||
assertThat(primitive).isFalse();
|
||||
|
||||
assertThat(object).as("foo").isFalse();
|
||||
assertThat(object).isFalse();
|
||||
assertThat(object).isFalse();
|
||||
assertThat(object).isFalse();
|
||||
assertThat(object).isFalse();
|
||||
|
||||
assertThat(primitive).as("foo").isTrue();
|
||||
assertThat(primitive).isTrue();
|
||||
assertThat(primitive).isTrue();
|
||||
assertThat(primitive).isTrue();
|
||||
assertThat(primitive).isTrue();
|
||||
|
||||
assertThat(object).as("foo").isTrue();
|
||||
assertThat(object).isTrue();
|
||||
assertThat(object).isTrue();
|
||||
assertThat(object).isTrue();
|
||||
assertThat(object).isTrue();
|
||||
|
||||
assertThat(!((primitive))).as("nah").isTrue();
|
||||
assertThat(!object).isEqualTo(Boolean.TRUE && !Boolean.TRUE);
|
||||
|
||||
assertThat(primitive).as("foo").isFalse().as("bar").isFalse();
|
||||
assertThat(primitive).as("foo").isFalse().as("bar").isTrue();
|
||||
}
|
||||
}
|
||||
+39
@@ -0,0 +1,39 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class InvertedBooleanCondition {
|
||||
|
||||
private void invertedBooleanCondition() {
|
||||
boolean primitive = false;
|
||||
Boolean object = Boolean.TRUE;
|
||||
|
||||
assertThat(!primitive).as("foo").isEqualTo(Boolean.TRUE);
|
||||
assertThat(!primitive).isEqualTo(true);
|
||||
assertThat(!primitive).isNotEqualTo(Boolean.FALSE);
|
||||
assertThat(!primitive).isNotEqualTo(false);
|
||||
assertThat(!primitive).isTrue();
|
||||
|
||||
assertThat(!object).as("foo").isEqualTo(Boolean.TRUE);
|
||||
assertThat(!object).isEqualTo(true);
|
||||
assertThat(!object).isNotEqualTo(Boolean.FALSE);
|
||||
assertThat(!object).isNotEqualTo(false);
|
||||
assertThat(!object).isTrue();
|
||||
|
||||
assertThat(!primitive).as("foo").isEqualTo(Boolean.FALSE);
|
||||
assertThat(!primitive).isEqualTo(false);
|
||||
assertThat(!primitive).isNotEqualTo(Boolean.TRUE);
|
||||
assertThat(!primitive).isNotEqualTo(true);
|
||||
assertThat(!primitive).isFalse();
|
||||
|
||||
assertThat(!object).as("foo").isEqualTo(Boolean.FALSE);
|
||||
assertThat(!object).isEqualTo(false);
|
||||
assertThat(!object).isNotEqualTo(Boolean.TRUE);
|
||||
assertThat(!object).isNotEqualTo(true);
|
||||
assertThat(!object).isFalse();
|
||||
|
||||
assertThat(!(((!((primitive)))))).as("nah").isEqualTo(true && !true);
|
||||
assertThat(!object).isEqualTo(Boolean.TRUE && !Boolean.TRUE);
|
||||
|
||||
assertThat(!primitive).as("foo").isEqualTo(Boolean.TRUE).as("bar").isNotEqualTo(false);
|
||||
assertThat(!primitive).as("foo").isEqualTo(Boolean.TRUE).as("bar").isNotEqualTo(true);
|
||||
}
|
||||
}
|
||||
+11
-6
@@ -2,12 +2,12 @@ import java.util.Optional;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class AssertThatJava8Optional {
|
||||
public class Java8Optional {
|
||||
|
||||
private void assertThatJava8Optional() {
|
||||
private void java8Optional() {
|
||||
Optional<String> opt = Optional.empty();
|
||||
|
||||
assertThat(opt).isPresent();
|
||||
assertThat(opt).as("foo").isPresent();
|
||||
assertThat(opt).isPresent();
|
||||
assertThat(opt).isPresent();
|
||||
assertThat(opt).isPresent();
|
||||
@@ -19,17 +19,22 @@ public class AssertThatJava8Optional {
|
||||
assertThat(opt).isNotPresent();
|
||||
assertThat(opt).isNotPresent();
|
||||
|
||||
assertThat(opt).contains("foo");
|
||||
assertThat(opt).as("foo").contains("foo");
|
||||
assertThat(opt).containsSame("foo");
|
||||
assertThat(opt.get()).isNotEqualTo("foo");
|
||||
assertThat(opt.get()).isNotSameAs("foo");
|
||||
|
||||
assertThat(opt).contains("foo");
|
||||
assertThat(opt).as("foo").contains("foo");
|
||||
assertThat(opt).contains("foo");
|
||||
assertThat(opt).isNotEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).isNotEqualTo(Optional.ofNullable("foo"));
|
||||
|
||||
assertThat(opt).isNotPresent();
|
||||
assertThat(opt).as("foo").isNotPresent();
|
||||
assertThat(opt).isPresent();
|
||||
|
||||
assertThat(opt).as("foo").isPresent().as("bar").isPresent();
|
||||
assertThat(opt.isPresent()).as("foo").isEqualTo(false).as("bar").isTrue();
|
||||
|
||||
assertThat(opt.get()).isEqualTo("foo").isSameAs("foo").isNotEqualTo("foo").isNotSameAs("foo");
|
||||
}
|
||||
}
|
||||
+11
-6
@@ -2,12 +2,12 @@ import java.util.Optional;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class AssertThatJava8Optional {
|
||||
public class Java8Optional {
|
||||
|
||||
private void assertThatJava8Optional() {
|
||||
private void java8Optional() {
|
||||
Optional<String> opt = Optional.empty();
|
||||
|
||||
assertThat(opt.isPresent()).isEqualTo(true);
|
||||
assertThat(opt.isPresent()).as("foo").isEqualTo(true);
|
||||
assertThat(opt.isPresent()).isEqualTo(Boolean.TRUE);
|
||||
assertThat(opt.isPresent()).isNotEqualTo(false);
|
||||
assertThat(opt.isPresent()).isNotEqualTo(Boolean.FALSE);
|
||||
@@ -19,17 +19,22 @@ public class AssertThatJava8Optional {
|
||||
assertThat(opt.isPresent()).isNotEqualTo(Boolean.TRUE);
|
||||
assertThat(opt.isPresent()).isFalse();
|
||||
|
||||
assertThat(opt.get()).isEqualTo("foo");
|
||||
assertThat(opt.get()).as("foo").isEqualTo("foo");
|
||||
assertThat(opt.get()).isSameAs("foo");
|
||||
assertThat(opt.get()).isNotEqualTo("foo");
|
||||
assertThat(opt.get()).isNotSameAs("foo");
|
||||
|
||||
assertThat(opt).isEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).as("foo").isEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).isEqualTo(Optional.ofNullable("foo"));
|
||||
assertThat(opt).isNotEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).isNotEqualTo(Optional.ofNullable("foo"));
|
||||
|
||||
assertThat(opt).isEqualTo(Optional.empty());
|
||||
assertThat(opt).as("foo").isEqualTo(Optional.empty());
|
||||
assertThat(opt).isNotEqualTo(Optional.empty());
|
||||
|
||||
assertThat(opt.isPresent()).as("foo").isEqualTo(true).as("bar").isTrue();
|
||||
assertThat(opt.isPresent()).as("foo").isEqualTo(false).as("bar").isTrue();
|
||||
|
||||
assertThat(opt.get()).isEqualTo("foo").isSameAs("foo").isNotEqualTo("foo").isNotSameAs("foo");
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,52 @@
|
||||
import java.util.*;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class JoinStatements {
|
||||
|
||||
private void joinStatements() {
|
||||
List<String> list = new ArrayList<>();
|
||||
List<String> otherList = new ArrayList<>();
|
||||
|
||||
// the future is always born in pain
|
||||
/* tricky */
|
||||
assertThat(list).as("foo").hasSize(2)
|
||||
/* do another */
|
||||
/* do one */.as("bar").contains("barbar")
|
||||
// comment to keep
|
||||
.doesNotContain("barbara") // another comment to keep
|
||||
.doesNotContain("wrzlbrmpft")
|
||||
/* and a multi line comment
|
||||
after the statement */
|
||||
// across two lines
|
||||
.as("etc")/* what a nasty comment */.contains("etcetc")
|
||||
// moar!
|
||||
.doesNotContain("foobar");
|
||||
|
||||
assertThat("narf").isNotEqualTo("puit");
|
||||
assertThat(list).as("bar").contains("barbar").as("foo").hasSize(2);
|
||||
assertThat(list).as("evil").extracting(String::length).contains(2);
|
||||
|
||||
assertThat(list).as("bar").contains("barbar");
|
||||
assertThat(otherList).contains("puit");
|
||||
assertThat(list).as("foo").hasSize(2);
|
||||
if (true) {
|
||||
assertThat(list).doesNotContain("narf").as("bar").contains("barbar");
|
||||
}
|
||||
assertThat(list.get(0)).isNotEmpty().hasSize(3).isEqualTo("bar");
|
||||
|
||||
assertThat(otherList.get(0)).isNotEmpty();
|
||||
assertThat(list.get(0)).hasSize(3);
|
||||
|
||||
assertThat(list.get(0) + "foo").isEqualTo("bar").doesNotStartWith("foo");
|
||||
|
||||
assertThat(otherList.get(0) + "foo").isEqualTo("bar");
|
||||
assertThat(list.get(0) + "foo").doesNotStartWith("foo");
|
||||
|
||||
Iterator<String> iterator = list.iterator();
|
||||
assertThat(iterator.next()).isEqualTo("foo");
|
||||
assertThat(iterator.next()).isEqualTo("bar");
|
||||
assertThat(iterator.next().toLowerCase()).isEqualTo("foo");
|
||||
assertThat(iterator.next().toLowerCase()).isEqualTo("bar");
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,54 @@
|
||||
import java.util.*;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class JoinStatements {
|
||||
|
||||
private void joinStatements() {
|
||||
List<String> list = new ArrayList<>();
|
||||
List<String> otherList = new ArrayList<>();
|
||||
|
||||
// the future is always born in pain
|
||||
/* tricky */assertThat(list).as("foo").hasSize(2); /* do one */ /* do another */
|
||||
assertThat(list).as("bar").contains("barbar"); // comment to keep
|
||||
assertThat(list).doesNotContain("barbara") // another comment to keep
|
||||
.doesNotContain("wrzlbrmpft") // across two lines
|
||||
; /* and a multi line comment
|
||||
after the statement */
|
||||
assertThat(list).as("etc")/* what a nasty comment */.contains("etcetc");
|
||||
|
||||
// moar!
|
||||
assertThat(list).doesNotContain("foobar");
|
||||
|
||||
assertThat("narf").isNotEqualTo("puit");
|
||||
assertThat(list).as("bar").contains("barbar");
|
||||
assertThat(list).as("foo").hasSize(2);
|
||||
assertThat(list).as("evil").extracting(String::length).contains(2);
|
||||
|
||||
assertThat(list).as("bar").contains("barbar");
|
||||
assertThat(otherList).contains("puit");
|
||||
assertThat(list).as("foo").hasSize(2);
|
||||
if (true) {
|
||||
assertThat(list).doesNotContain("narf");
|
||||
assertThat(list).as("bar").contains("barbar");
|
||||
}
|
||||
assertThat(list.get(0)).isNotEmpty();
|
||||
assertThat(list.get(0)).hasSize(3);
|
||||
assertThat(list.get(0)).isEqualTo("bar");
|
||||
|
||||
assertThat(otherList.get(0)).isNotEmpty();
|
||||
assertThat(list.get(0)).hasSize(3);
|
||||
|
||||
assertThat(list.get(0) + "foo").isEqualTo("bar");
|
||||
assertThat(list.get(0) + "foo").doesNotStartWith("foo");
|
||||
|
||||
assertThat(otherList.get(0) + "foo").isEqualTo("bar");
|
||||
assertThat(list.get(0) + "foo").doesNotStartWith("foo");
|
||||
|
||||
Iterator<String> iterator = list.iterator();
|
||||
assertThat(iterator.next()).isEqualTo("foo");
|
||||
assertThat(iterator.next()).isEqualTo("bar");
|
||||
assertThat(iterator.next().toLowerCase()).isEqualTo("foo");
|
||||
assertThat(iterator.next().toLowerCase()).isEqualTo("bar");
|
||||
}
|
||||
}
|
||||
@@ -10,5 +10,8 @@ public class ObjectIsNull {
|
||||
assertThat("").isNotNull();
|
||||
assertThat("").as("nah").isNotNull();
|
||||
assertThat(new Object()).isNotNull();
|
||||
|
||||
assertThat(new Object()).as("foo").isNotNull().as("bar").isEqualTo(new Object()).as("etc").isNull();
|
||||
assertThat(new Object()).as("foo").isEqualTo(null).as("bar").isEqualTo(new Object()).as("etc").isNotNull();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -10,5 +10,8 @@ public class ObjectIsNull {
|
||||
assertThat("").isNotEqualTo(null);
|
||||
assertThat("").as("nah").isNotEqualTo(null);
|
||||
assertThat(new Object()).isNotEqualTo(null);
|
||||
|
||||
assertThat(new Object()).as("foo").isNotEqualTo(null).as("bar").isEqualTo(new Object()).as("etc").isEqualTo(null);
|
||||
assertThat(new Object()).as("foo").isEqualTo(null).as("bar").isEqualTo(new Object()).as("etc").isNotEqualTo(null);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,103 @@
|
||||
import java.util.ArrayList;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class Size {
|
||||
|
||||
private void size() {
|
||||
ArrayList<String> list = new ArrayList<>();
|
||||
ArrayList<String> otherList = new ArrayList<>();
|
||||
long[] array = new long[5];
|
||||
long[] otherArray = new long[4];
|
||||
String string = "string";
|
||||
StringBuilder stringBuilder = new StringBuilder();
|
||||
|
||||
assertThat(list).isEmpty();
|
||||
assertThat(list).isEmpty();
|
||||
assertThat(list).isNotEmpty();
|
||||
assertThat(list).as("hi").isNotEmpty();
|
||||
assertThat(list).isNotEmpty();
|
||||
assertThat(list).isEmpty();
|
||||
assertThat(list).isEmpty();
|
||||
assertThat(list).hasSameSizeAs(otherList);
|
||||
assertThat(list).hasSameSizeAs(array);
|
||||
assertThat(list).hasSize(string.length());
|
||||
assertThat(list).hasSize(stringBuilder.length());
|
||||
assertThat(list).hasSize(1);
|
||||
assertThat(list).hasSizeGreaterThan(otherList.size() * 2);
|
||||
assertThat(list).hasSizeGreaterThanOrEqualTo(otherList.size() * 2);
|
||||
assertThat(list).hasSizeLessThan(otherList.size() * 2);
|
||||
assertThat(list).hasSizeLessThanOrEqualTo(otherList.size() * 2);
|
||||
assertThat(list).hasSameSizeAs(otherList);
|
||||
assertThat(list).hasSameSizeAs(array);
|
||||
assertThat(list).hasSize(string.length());
|
||||
assertThat(list).hasSize(stringBuilder.length());
|
||||
|
||||
assertThat(array).isEmpty();
|
||||
assertThat(array).isEmpty();
|
||||
assertThat(array).isNotEmpty();
|
||||
assertThat(array).as("hi").isNotEmpty();
|
||||
assertThat(array).isNotEmpty();
|
||||
assertThat(array).isEmpty();
|
||||
assertThat(array).isEmpty();
|
||||
assertThat(array).hasSameSizeAs(list);
|
||||
assertThat(array).hasSameSizeAs(otherArray);
|
||||
assertThat(array).hasSize(string.length());
|
||||
assertThat(array).hasSize(stringBuilder.length());
|
||||
assertThat(array).hasSize(1);
|
||||
assertThat(array).hasSizeGreaterThan(otherArray.length - 1);
|
||||
assertThat(array).hasSizeGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
assertThat(array).hasSizeLessThan(otherArray.length - 3);
|
||||
assertThat(array).hasSizeLessThanOrEqualTo(1 - otherArray.length);
|
||||
assertThat(array).hasSameSizeAs(list);
|
||||
assertThat(array).hasSameSizeAs(otherArray);
|
||||
assertThat(array).hasSize(string.length());
|
||||
assertThat(array).hasSize(stringBuilder.length());
|
||||
|
||||
assertThat(string).isEmpty();
|
||||
assertThat(string).isEmpty();
|
||||
assertThat(string).isNotEmpty();
|
||||
assertThat(string).as("hi").isNotEmpty();
|
||||
assertThat(string).isNotEmpty();
|
||||
assertThat(string).isEmpty();
|
||||
assertThat(string).isEmpty();
|
||||
assertThat(string).hasSameSizeAs(list);
|
||||
assertThat(string).hasSameSizeAs(otherArray);
|
||||
assertThat(string).hasSameSizeAs(string);
|
||||
assertThat(string).hasSameSizeAs(stringBuilder);
|
||||
assertThat(string).hasSize(1);
|
||||
assertThat(string).hasSizeGreaterThan(otherArray.length - 1);
|
||||
assertThat(string).hasSizeGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
assertThat(string).hasSizeLessThan(otherArray.length - 3);
|
||||
assertThat(string).hasSizeLessThanOrEqualTo(1 - otherArray.length);
|
||||
assertThat(string).hasSameSizeAs(otherList);
|
||||
assertThat(string).hasSameSizeAs(array);
|
||||
assertThat(string).hasSameSizeAs(string);
|
||||
assertThat(string).hasSameSizeAs(stringBuilder);
|
||||
|
||||
assertThat(stringBuilder).isEmpty();
|
||||
assertThat(stringBuilder).isEmpty();
|
||||
assertThat(stringBuilder).isNotEmpty();
|
||||
assertThat(stringBuilder).as("hi").isNotEmpty();
|
||||
assertThat(stringBuilder).isNotEmpty();
|
||||
assertThat(stringBuilder).isEmpty();
|
||||
assertThat(stringBuilder).isEmpty();
|
||||
assertThat(stringBuilder).hasSameSizeAs(list);
|
||||
assertThat(stringBuilder).hasSameSizeAs(otherArray);
|
||||
assertThat(stringBuilder).hasSameSizeAs(string);
|
||||
assertThat(stringBuilder).hasSameSizeAs(stringBuilder);
|
||||
assertThat(stringBuilder).hasSize(1);
|
||||
assertThat(stringBuilder).hasSizeGreaterThan(otherArray.length - 1);
|
||||
assertThat(stringBuilder).hasSizeGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
assertThat(stringBuilder).hasSizeLessThan(otherArray.length - 3);
|
||||
assertThat(stringBuilder).hasSizeLessThanOrEqualTo(1 - otherArray.length);
|
||||
assertThat(stringBuilder).hasSameSizeAs(otherList);
|
||||
assertThat(stringBuilder).hasSameSizeAs(array);
|
||||
assertThat(stringBuilder).hasSameSizeAs(string);
|
||||
assertThat(stringBuilder).hasSameSizeAs(stringBuilder);
|
||||
|
||||
assertThat(stringBuilder.length()).as("foo").isEqualTo(0).isZero().as("bar").isNotZero().isEqualTo(10);
|
||||
|
||||
assertThat(stringBuilder).as("foo").isNotEmpty().hasSize(2).as("bar").hasSameSizeAs(otherList).hasSameSizeAs(array);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,103 @@
|
||||
import java.util.ArrayList;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class Size {
|
||||
|
||||
private void size() {
|
||||
ArrayList<String> list = new ArrayList<>();
|
||||
ArrayList<String> otherList = new ArrayList<>();
|
||||
long[] array = new long[5];
|
||||
long[] otherArray = new long[4];
|
||||
String string = "string";
|
||||
StringBuilder stringBuilder = new StringBuilder();
|
||||
|
||||
assertThat(list.size()).isEqualTo(0);
|
||||
assertThat(list.size()).isZero();
|
||||
assertThat(list.size()).isNotZero();
|
||||
assertThat(list.size()).as("hi").isGreaterThan(0);
|
||||
assertThat(list.size()).isGreaterThanOrEqualTo(1);
|
||||
assertThat(list.size()).isLessThan(1);
|
||||
assertThat(list.size()).isLessThanOrEqualTo(0);
|
||||
assertThat(list.size()).isEqualTo(otherList.size());
|
||||
assertThat(list.size()).isEqualTo(array.length);
|
||||
assertThat(list.size()).isEqualTo(string.length());
|
||||
assertThat(list.size()).isEqualTo(stringBuilder.length());
|
||||
assertThat(list.size()).isEqualTo(1);
|
||||
assertThat(list.size()).isGreaterThan(otherList.size() * 2);
|
||||
assertThat(list.size()).isGreaterThanOrEqualTo(otherList.size() * 2);
|
||||
assertThat(list.size()).isLessThan(otherList.size() * 2);
|
||||
assertThat(list.size()).isLessThanOrEqualTo(otherList.size() * 2);
|
||||
assertThat(list).hasSize(otherList.size());
|
||||
assertThat(list).hasSize(array.length);
|
||||
assertThat(list).hasSize(string.length());
|
||||
assertThat(list).hasSize(stringBuilder.length());
|
||||
|
||||
assertThat(array.length).isEqualTo(0);
|
||||
assertThat(array.length).isZero();
|
||||
assertThat(array.length).isNotZero();
|
||||
assertThat(array.length).as("hi").isGreaterThan(0);
|
||||
assertThat(array.length).isGreaterThanOrEqualTo(1);
|
||||
assertThat(array.length).isLessThan(1);
|
||||
assertThat(array.length).isLessThanOrEqualTo(0);
|
||||
assertThat(array.length).isEqualTo(list.size());
|
||||
assertThat(array.length).isEqualTo(otherArray.length);
|
||||
assertThat(array.length).isEqualTo(string.length());
|
||||
assertThat(array.length).isEqualTo(stringBuilder.length());
|
||||
assertThat(array.length).isEqualTo(1);
|
||||
assertThat(array.length).isGreaterThan(otherArray.length - 1);
|
||||
assertThat(array.length).isGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
assertThat(array.length).isLessThan(otherArray.length - 3);
|
||||
assertThat(array.length).isLessThanOrEqualTo(1 - otherArray.length);
|
||||
assertThat(array).hasSize(list.size());
|
||||
assertThat(array).hasSize(otherArray.length);
|
||||
assertThat(array).hasSize(string.length());
|
||||
assertThat(array).hasSize(stringBuilder.length());
|
||||
|
||||
assertThat(string.length()).isEqualTo(0);
|
||||
assertThat(string.length()).isZero();
|
||||
assertThat(string.length()).isNotZero();
|
||||
assertThat(string.length()).as("hi").isGreaterThan(0);
|
||||
assertThat(string.length()).isGreaterThanOrEqualTo(1);
|
||||
assertThat(string.length()).isLessThan(1);
|
||||
assertThat(string.length()).isLessThanOrEqualTo(0);
|
||||
assertThat(string.length()).isEqualTo(list.size());
|
||||
assertThat(string.length()).isEqualTo(otherArray.length);
|
||||
assertThat(string.length()).isEqualTo(string.length());
|
||||
assertThat(string.length()).isEqualTo(stringBuilder.length());
|
||||
assertThat(string.length()).isEqualTo(1);
|
||||
assertThat(string.length()).isGreaterThan(otherArray.length - 1);
|
||||
assertThat(string.length()).isGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
assertThat(string.length()).isLessThan(otherArray.length - 3);
|
||||
assertThat(string.length()).isLessThanOrEqualTo(1 - otherArray.length);
|
||||
assertThat(string).hasSize(otherList.size());
|
||||
assertThat(string).hasSize(array.length);
|
||||
assertThat(string).hasSize(string.length());
|
||||
assertThat(string).hasSize(stringBuilder.length());
|
||||
|
||||
assertThat(stringBuilder.length()).isEqualTo(0);
|
||||
assertThat(stringBuilder.length()).isZero();
|
||||
assertThat(stringBuilder.length()).isNotZero();
|
||||
assertThat(stringBuilder.length()).as("hi").isGreaterThan(0);
|
||||
assertThat(stringBuilder.length()).isGreaterThanOrEqualTo(1);
|
||||
assertThat(stringBuilder.length()).isLessThan(1);
|
||||
assertThat(stringBuilder.length()).isLessThanOrEqualTo(0);
|
||||
assertThat(stringBuilder.length()).isEqualTo(list.size());
|
||||
assertThat(stringBuilder.length()).isEqualTo(otherArray.length);
|
||||
assertThat(stringBuilder.length()).isEqualTo(string.length());
|
||||
assertThat(stringBuilder.length()).isEqualTo(stringBuilder.length());
|
||||
assertThat(stringBuilder.length()).isEqualTo(1);
|
||||
assertThat(stringBuilder.length()).isGreaterThan(otherArray.length - 1);
|
||||
assertThat(stringBuilder.length()).isGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
assertThat(stringBuilder.length()).isLessThan(otherArray.length - 3);
|
||||
assertThat(stringBuilder.length()).isLessThanOrEqualTo(1 - otherArray.length);
|
||||
assertThat(stringBuilder).hasSize(otherList.size());
|
||||
assertThat(stringBuilder).hasSize(array.length);
|
||||
assertThat(stringBuilder).hasSize(string.length());
|
||||
assertThat(stringBuilder).hasSize(stringBuilder.length());
|
||||
|
||||
assertThat(stringBuilder.length()).as("foo").isEqualTo(0).isZero().as("bar").isNotZero().isEqualTo(10);
|
||||
|
||||
assertThat(stringBuilder).as("foo").isNotEmpty().hasSize(2).as("bar").hasSize(otherList.size()).hasSize(array.length);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,51 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class StringExpression {
|
||||
|
||||
private void stringExpression() {
|
||||
String string = "string";
|
||||
StringBuilder stringBuilder = new StringBuilder();
|
||||
|
||||
assertThat(string).as("foo").isEmpty();
|
||||
assertThat(string).isEmpty();
|
||||
assertThat(string).isEqualTo("foo");
|
||||
assertThat(string).isEqualTo("foo");
|
||||
assertThat(string).isEqualToIgnoringCase("foo");
|
||||
assertThat(string).isEqualToIgnoringCase("foo");
|
||||
assertThat(string).isEqualTo("foo");
|
||||
assertThat(string).isEqualTo("foo");
|
||||
assertThat(string).isEqualTo(stringBuilder);
|
||||
assertThat(string).isEqualTo(stringBuilder);
|
||||
assertThat(string).contains("foo");
|
||||
assertThat(string).contains("foo");
|
||||
assertThat(string).contains(stringBuilder);
|
||||
assertThat(string).contains(stringBuilder);
|
||||
assertThat(string).startsWith("foo");
|
||||
assertThat(string).startsWith("foo");
|
||||
assertThat(string).endsWith("foo");
|
||||
assertThat(string).endsWith("foo");
|
||||
|
||||
assertThat(string).as("foo").isNotEmpty();
|
||||
assertThat(string).isNotEmpty();
|
||||
assertThat(string).isNotEqualTo("foo");
|
||||
assertThat(string).isNotEqualTo("foo");
|
||||
assertThat(string).isNotEqualToIgnoringCase("foo");
|
||||
assertThat(string).isNotEqualToIgnoringCase("foo");
|
||||
assertThat(string).isNotEqualTo("foo");
|
||||
assertThat(string).isNotEqualTo("foo");
|
||||
assertThat(string).isNotEqualTo(stringBuilder);
|
||||
assertThat(string).isNotEqualTo(stringBuilder);
|
||||
assertThat(string).doesNotContain("foo");
|
||||
assertThat(string).doesNotContain("foo");
|
||||
assertThat(string).doesNotContain(stringBuilder);
|
||||
assertThat(string).doesNotContain(stringBuilder);
|
||||
assertThat(string).doesNotStartWith("foo");
|
||||
assertThat(string).doesNotStartWith("foo");
|
||||
assertThat(string).doesNotEndWith("foo");
|
||||
assertThat(string).doesNotEndWith("foo");
|
||||
|
||||
assertThat(string).as("foo").doesNotEndWith("foo").as("bar").doesNotEndWith("foo");
|
||||
assertThat(string.endsWith("foo")).as("foo").isEqualTo(false).as("bar").isTrue();
|
||||
assertThat(string.endsWith("foo")).as("foo").satisfies(it -> it.booleanValue()).as("bar").isFalse();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,51 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class StringExpression {
|
||||
|
||||
private void stringExpression() {
|
||||
String string = "string";
|
||||
StringBuilder stringBuilder = new StringBuilder();
|
||||
|
||||
assertThat(string.isEmpty()).as("foo").isEqualTo(true);
|
||||
assertThat(string.isEmpty()).isTrue();
|
||||
assertThat(string.equals("foo")).isEqualTo(true);
|
||||
assertThat(string.equals("foo")).isTrue();
|
||||
assertThat(string.equalsIgnoreCase("foo")).isEqualTo(true);
|
||||
assertThat(string.equalsIgnoreCase("foo")).isTrue();
|
||||
assertThat(string.contentEquals("foo")).isEqualTo(true);
|
||||
assertThat(string.contentEquals("foo")).isTrue();
|
||||
assertThat(string.contentEquals(stringBuilder)).isEqualTo(true);
|
||||
assertThat(string.contentEquals(stringBuilder)).isTrue();
|
||||
assertThat(string.contains("foo")).isEqualTo(true);
|
||||
assertThat(string.contains("foo")).isTrue();
|
||||
assertThat(string.contains(stringBuilder)).isEqualTo(true);
|
||||
assertThat(string.contains(stringBuilder)).isTrue();
|
||||
assertThat(string.startsWith("foo")).isEqualTo(true);
|
||||
assertThat(string.startsWith("foo")).isTrue();
|
||||
assertThat(string.endsWith("foo")).isEqualTo(true);
|
||||
assertThat(string.endsWith("foo")).isTrue();
|
||||
|
||||
assertThat(string.isEmpty()).as("foo").isEqualTo(false);
|
||||
assertThat(string.isEmpty()).isFalse();
|
||||
assertThat(string.equals("foo")).isEqualTo(false);
|
||||
assertThat(string.equals("foo")).isFalse();
|
||||
assertThat(string.equalsIgnoreCase("foo")).isEqualTo(false);
|
||||
assertThat(string.equalsIgnoreCase("foo")).isFalse();
|
||||
assertThat(string.contentEquals("foo")).isEqualTo(false);
|
||||
assertThat(string.contentEquals("foo")).isFalse();
|
||||
assertThat(string.contentEquals(stringBuilder)).isEqualTo(false);
|
||||
assertThat(string.contentEquals(stringBuilder)).isFalse();
|
||||
assertThat(string.contains("foo")).isEqualTo(false);
|
||||
assertThat(string.contains("foo")).isFalse();
|
||||
assertThat(string.contains(stringBuilder)).isEqualTo(false);
|
||||
assertThat(string.contains(stringBuilder)).isFalse();
|
||||
assertThat(string.startsWith("foo")).isEqualTo(false);
|
||||
assertThat(string.startsWith("foo")).isFalse();
|
||||
assertThat(string.endsWith("foo")).isEqualTo(false);
|
||||
assertThat(string.endsWith("foo")).isFalse();
|
||||
|
||||
assertThat(string.endsWith("foo")).as("foo").isEqualTo(false).as("bar").isFalse();
|
||||
assertThat(string.endsWith("foo")).as("foo").isEqualTo(false).as("bar").isTrue();
|
||||
assertThat(string.endsWith("foo")).as("foo").satisfies(it -> it.booleanValue()).as("bar").isFalse();
|
||||
}
|
||||
}
|
||||
@@ -15,5 +15,8 @@ public class StringIsEmpty {
|
||||
assertThat(stringBuilder).as("bar").isEmpty();
|
||||
|
||||
assertThat(new Object()).isEqualTo("");
|
||||
|
||||
assertThat(string).as("foo").isEqualTo("").as("bar").hasSize(0).hasSameSizeAs("foo").isEmpty();
|
||||
assertThat(string).as("foo").isEqualTo("").as("bar").hasSize(0).hasSameSizeAs("foo").isEmpty();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -15,5 +15,8 @@ public class StringIsEmpty {
|
||||
assertThat(stringBuilder).as("bar").hasSize(0);
|
||||
|
||||
assertThat(new Object()).isEqualTo("");
|
||||
|
||||
assertThat(string).as("foo").isEqualTo("").as("bar").hasSize(0).hasSameSizeAs("foo").isEqualTo("");
|
||||
assertThat(string).as("foo").isEqualTo("").as("bar").hasSize(0).hasSameSizeAs("foo").hasSize(0);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user