Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
341d1877df | ||
|
|
05dc4905ca | ||
|
|
315b93d90d | ||
|
|
36f63d26d2 | ||
|
|
a4535afbbb | ||
|
|
df11939589 | ||
|
|
4420a0a392 | ||
|
|
8fb3ecce95 | ||
|
|
5048c898ec | ||
|
|
b84a781134 |
@@ -92,6 +92,23 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
The behavior regarding the insertion of line breaks between the expressions can be configured in the
|
||||
inspection settings.
|
||||
|
||||
- JoinVarArgsContains
|
||||
|
||||
Looks for ```.contains()```, ```.doesNotContain()```, and .```containsOnlyOnce()``` calls for iterables
|
||||
within the same statement. The available quickfix can join the arguments to variadic version of the call
|
||||
and remove the surplus one.
|
||||
|
||||
```
|
||||
from: assertThat(expected).contains("foo").doesNotContain("bar").contains("etc").doesNotContain("huh");
|
||||
to: assertThat(expected).contains("foo", "etc").doesNotContain("bar", "huh");
|
||||
```
|
||||
Will not be performed on more complex statements with ```.extracting()``` or ```.as()``` to avoid
|
||||
changing semantics or losing descriptions.
|
||||
|
||||
Note that the quickfix does not handle comments very well and might remove them during the operation.
|
||||
|
||||
You may need to perform some manual reformatting, if the line gets too long after applying the fix.
|
||||
|
||||
- AssertThatObjectIsNullOrNotNull
|
||||
|
||||
Uses ```isNull()``` and ```isNotNull()``` instead.
|
||||
@@ -215,6 +232,22 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
```
|
||||
Analogously with ```isFalse()``` (except for ```containsAll()```).
|
||||
|
||||
Additional transformations for maps:
|
||||
|
||||
```
|
||||
from: assertThat(map.get(key)).isEqualTo(value);
|
||||
to: assertThat(map).containsEntry(key, value);
|
||||
|
||||
from: assertThat(map.get(key)).isNotEqualTo(value);
|
||||
to: assertThat(map).doesNotContainEntry(key, value);
|
||||
|
||||
from: assertThat(map.get(key)).isNotNull();
|
||||
to: assertThat(map).containsKey(key);
|
||||
|
||||
from: assertThat(map.get(key)).isNull();
|
||||
to: assertThat(map).doesNotContainKey(key);
|
||||
```
|
||||
|
||||
- AssertThatEnumerableIsEmpty
|
||||
|
||||
Uses ```isEmpty()``` for ```hasSize(0)``` iterable assertions instead.
|
||||
@@ -226,7 +259,7 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
|
||||
- AssertThatSize
|
||||
|
||||
Makes assertions on sizes of arrays, collections, strings,
|
||||
Makes assertions on sizes of arrays, collections, maps, strings,
|
||||
or ```CharSequence```s more concise.
|
||||
|
||||
```
|
||||
@@ -248,7 +281,7 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
to: assertThat(array).hasSameSizeAs(anotherArray);
|
||||
```
|
||||
|
||||
and additionally with AssertJ 13.2.0 or later
|
||||
and additionally with AssertJ 3.12.0 or later
|
||||
|
||||
```
|
||||
from: assertThat(array.length).isLessThanOrEqualTo(expression);
|
||||
@@ -263,14 +296,14 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
from: assertThat(array.length).isGreaterThanOrEqualTo(expression);
|
||||
to: assertThat(array).hasSizeGreaterThanOrEqualTo(expression);
|
||||
```
|
||||
and analogously for collections, strings and CharSequences, e.g:
|
||||
and analogously for collections, maps, strings and CharSequences, e.g:
|
||||
|
||||
```
|
||||
from: assertThat("string".length()).isLessThan(1);
|
||||
to: assertThat("string").isEmpty();
|
||||
|
||||
from: assertThat("string".length()).isEqualTo(collection.size())
|
||||
to: assertThat("string").hasSameSizeAs(collection);
|
||||
from: assertThat("string".length()).isEqualTo(map.size())
|
||||
to: assertThat("string").hasSameSizeAs(map);
|
||||
|
||||
from: assertThat("string".length()).hasSize("strong".length())
|
||||
to: assertThat("string").hasSameSizeAs("strong");
|
||||
@@ -343,7 +376,7 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
to: assertThat(opt).isPresent();
|
||||
|
||||
from: assertThat(opt).isEqualTo(Optional.of("foo"));
|
||||
from: assertThat(opt).isEqualTo(Optional.ofNullable("foo"));
|
||||
from: assertThat(opt).isEqualTo(Optional.ofNullable("foo")); // only for constant "foo"
|
||||
to: assertThat(opt).contains("foo");
|
||||
|
||||
from: assertThat(opt).isEqualTo(Optional.empty());
|
||||
@@ -380,7 +413,7 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
to: assertThat(opt).isPresent();
|
||||
|
||||
from: assertThat(opt).isEqualTo(Optional.of("foo"));
|
||||
from: assertThat(opt).isEqualTo(Optional.fromNullable("foo"));
|
||||
from: assertThat(opt).isEqualTo(Optional.fromNullable("foo")); // only for constant "foo"
|
||||
to: assertThat(opt).contains("foo");
|
||||
|
||||
from: assertThat(opt).isEqualTo(Optional.absent());
|
||||
@@ -509,7 +542,8 @@ The IntelliJ framework actually uses the JUnit 3 TestCase for plugin testing and
|
||||
Feel free to use the code (in package ```de.platon42.intellij.jupiter```) for your projects (with attribution).
|
||||
|
||||
## Planned features
|
||||
- Joining .contains() expressions
|
||||
- More Optional fixes such as opt1.get() == opt2.get() etc.
|
||||
- More moving out of methods for File, Path, LocalDate/Time etc.
|
||||
- Converting ```foo.compareTo(bar) == 0``` to ```isEqualTo()``` (yes, I've *really* seen code like that)
|
||||
- Extraction with property names to lambda with Java 8
|
||||
|
||||
@@ -520,6 +554,19 @@ Feel free to use the code (in package ```de.platon42.intellij.jupiter```) for yo
|
||||
|
||||
## Changelog
|
||||
|
||||
#### V1.4 (25-Aug-19)
|
||||
- Minor fix for highlighting of JoinVarArgsContains inspection.
|
||||
- Extended AssertThatSize inspection to Maps, too.
|
||||
- Extended AssertThatCollectionOrMap inspection for several ```assertThat(map.get())``` cases as suggested by Stefan H.
|
||||
|
||||
#### V1.3 (03-Aug-19)
|
||||
- New JoinVarArgsContains inspection that will detect multiple ```.contains()```, ```.doesNotContain()```,
|
||||
and ```.containsOnlyOnce()``` calls within the same statement that could be joined together using variadic arguments.
|
||||
- AssertJ 3.13.0 broke some inspections due to new ```AbstractStringAssert::isEqualTo()``` method.
|
||||
- AssertThatJava8Optional and AssertThatGuavaOptional inspections do not longer try to fix
|
||||
```assertThat(optional).isEqualTo(Optional.fromNullable(expression))``` to ```contains()```
|
||||
when ```expression``` is not a non-null constant expression.
|
||||
|
||||
#### V1.2 (23-Jun-19)
|
||||
- Due to popular demand the JoinAssertThatStatements inspection will now add line breaks on joining statements.
|
||||
The amount of statements joined without causing line breaks can be configured but defaults to 1 (always).
|
||||
@@ -582,7 +629,7 @@ Feel free to use the code (in package ```de.platon42.intellij.jupiter```) for yo
|
||||
#### V0.3 (07-Apr-19)
|
||||
- New inspection AssertThatBinaryExpressionIsTrueOrFalse that will find and fix common binary expressions and ```equals()``` statements (more than 150 combinations) inside ```assertThat()```.
|
||||
- Merged AssertThatObjectIsNull and AssertThatObjectIsNotNull to AssertThatObjectIsNullOrNotNull.
|
||||
- Support for ```hasSizeLessThan()```, ```hasSizeLessThanOrEqualTo()```, ```hasSizeGreaterThanOrEqualTo()```, and ```hasSizeGreaterThan()``` for AssertThatSizeInspection (with AssertJ >=13.2.0).
|
||||
- Support for ```hasSizeLessThan()```, ```hasSizeLessThanOrEqualTo()```, ```hasSizeGreaterThanOrEqualTo()```, and ```hasSizeGreaterThan()``` for AssertThatSizeInspection (with AssertJ >=3.12.0).
|
||||
- Really fixed highlighting for JUnit conversion. Sorry.
|
||||
|
||||
#### V0.2 (01-Apr-19)
|
||||
|
||||
+13
-11
@@ -1,13 +1,13 @@
|
||||
plugins {
|
||||
id 'java'
|
||||
id 'org.jetbrains.intellij' version '0.4.9'
|
||||
id 'org.jetbrains.kotlin.jvm' version '1.3.40'
|
||||
id 'org.jetbrains.intellij' version '0.4.10'
|
||||
id 'org.jetbrains.kotlin.jvm' version '1.3.50'
|
||||
id 'jacoco'
|
||||
id 'com.github.kt3k.coveralls' version '2.8.2'
|
||||
id 'com.github.kt3k.coveralls' version '2.8.4'
|
||||
}
|
||||
|
||||
group 'de.platon42'
|
||||
version '1.2'
|
||||
version '1.4'
|
||||
|
||||
repositories {
|
||||
mavenCentral()
|
||||
@@ -20,10 +20,10 @@ repositories {
|
||||
|
||||
dependencies {
|
||||
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8"
|
||||
testCompile "org.assertj:assertj-core:3.12.2"
|
||||
testCompile "org.assertj:assertj-core:3.13.2"
|
||||
testCompile "org.assertj:assertj-guava:3.2.1"
|
||||
testImplementation 'org.junit.jupiter:junit-jupiter-api:5.5.0-RC2'
|
||||
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.5.0-RC2'
|
||||
testImplementation 'org.junit.jupiter:junit-jupiter-api:5.5.1'
|
||||
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.5.1'
|
||||
testImplementation "org.jetbrains.kotlin:kotlin-test"
|
||||
// testImplementation "org.jetbrains.kotlin:kotlin-test-junit"
|
||||
}
|
||||
@@ -35,17 +35,19 @@ compileTestKotlin {
|
||||
kotlinOptions.jvmTarget = "1.8"
|
||||
}
|
||||
intellij {
|
||||
version '2019.1.3'
|
||||
version '2019.2.1'
|
||||
// pluginName 'Concise AssertJ Optimizing Nitpicker (Cajon)'
|
||||
updateSinceUntilBuild false
|
||||
plugins = ['java']
|
||||
}
|
||||
|
||||
patchPluginXml {
|
||||
changeNotes """
|
||||
<h4>V1.2 (23-Jun-19)</h4>
|
||||
<h4>V1.4 (25-Aug-19)</h4>
|
||||
<ul>
|
||||
<li>Due to popular demand the JoinAssertThatStatements inspection will now add line breaks on joining statements.
|
||||
The amount of statements joined without causing line breaks can be configured but defaults to 1 (always).
|
||||
<li>Minor fix for highlighting of JoinVarArgsContains inspection.
|
||||
<li>Extended AssertThatSize inspection to Maps, too.
|
||||
<li>Extended AssertThatCollectionOrMap inspection for several assertThat(map.get()) cases as suggested by Stefan H.
|
||||
</ul>
|
||||
<p>Full changelog available at <a href="https://github.com/chrisly42/cajon-plugin#changelog">Github project site</a>.</p>
|
||||
"""
|
||||
|
||||
@@ -30,6 +30,12 @@ class AssertJClassNames {
|
||||
@NonNls
|
||||
const val ABSTRACT_INTEGER_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractIntegerAssert"
|
||||
@NonNls
|
||||
const val ABSTRACT_LONG_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractLongAssert"
|
||||
@NonNls
|
||||
const val ABSTRACT_FLOAT_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractFloatAssert"
|
||||
@NonNls
|
||||
const val ABSTRACT_DOUBLE_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractDoubleAssert"
|
||||
@NonNls
|
||||
const val ABSTRACT_COMPARABLE_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractComparableAssert"
|
||||
@NonNls
|
||||
const val ABSTRACT_STRING_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractStringAssert"
|
||||
|
||||
@@ -36,14 +36,18 @@ val MORE_EXTENSION_POINTS = CallMatcher.instanceCall(
|
||||
"hasOnlyOneElementSatisfying", "anyMatch", "noneMatch", "anySatisfy", "noneSatisfy"
|
||||
)!!
|
||||
|
||||
val NOT_ACTUAL_ASSERTIONS = CallMatcher.anyOf(
|
||||
ALL_ASSERT_THAT_MATCHERS,
|
||||
val COMPLEX_CALLS_THAT_MAKES_STUFF_TRICKY = CallMatcher.anyOf(
|
||||
DESCRIBED_AS,
|
||||
WITH_REPRESENTATION_AND_SUCH,
|
||||
USING_COMPARATOR,
|
||||
IN_HEXADECIMAL_OR_BINARY
|
||||
)!!
|
||||
|
||||
val NOT_ACTUAL_ASSERTIONS = CallMatcher.anyOf(
|
||||
ALL_ASSERT_THAT_MATCHERS,
|
||||
COMPLEX_CALLS_THAT_MAKES_STUFF_TRICKY
|
||||
)!!
|
||||
|
||||
val KNOWN_METHODS_WITH_SIDE_EFFECTS = CallMatcher.anyOf(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_ITERATOR, "next")
|
||||
)!!
|
||||
@@ -106,7 +106,7 @@ fun PsiMethodCallExpression.getExpectedNullNonNullResult(): Boolean? {
|
||||
if (isNull || isNotNull) {
|
||||
return isNotNull
|
||||
} else {
|
||||
val isEqualTo = AbstractAssertJInspection.IS_EQUAL_TO_OBJECT.test(this)
|
||||
val isEqualTo = CallMatcher.anyOf(AbstractAssertJInspection.IS_EQUAL_TO_OBJECT, AbstractAssertJInspection.IS_EQUAL_TO_STRING).test(this)
|
||||
val isNotEqualTo = AbstractAssertJInspection.IS_NOT_EQUAL_TO_OBJECT.test(this)
|
||||
if ((isEqualTo || isNotEqualTo) && firstArg.type == PsiType.NULL) {
|
||||
return isNotEqualTo
|
||||
|
||||
@@ -86,6 +86,8 @@ class MethodNames {
|
||||
@NonNls
|
||||
const val CONTAINS = "contains"
|
||||
@NonNls
|
||||
const val CONTAINS_ONLY_ONCE = "containsOnlyOnce"
|
||||
@NonNls
|
||||
const val DOES_NOT_CONTAIN = "doesNotContain"
|
||||
@NonNls
|
||||
const val CONTAINS_EXACTLY = "containsExactly"
|
||||
|
||||
+30
-8
@@ -9,10 +9,13 @@ import com.intellij.psi.search.GlobalSearchScope
|
||||
import com.intellij.psi.tree.IElementType
|
||||
import com.intellij.psi.util.PsiTypesUtil
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_BOOLEAN_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_COMPARABLE_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_DOUBLE_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_FLOAT_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_INTEGER_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_LONG_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_STRING_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ASSERTIONS_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ASSERT_INTERFACE
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ENUMERABLE_ASSERT_INTERFACE
|
||||
@@ -81,13 +84,32 @@ open class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
|
||||
val IS_EQUAL_TO_OBJECT = CallMatcher.instanceCall(ASSERT_INTERFACE, MethodNames.IS_EQUAL_TO)
|
||||
.parameterTypes(CommonClassNames.JAVA_LANG_OBJECT)!!
|
||||
val IS_NOT_EQUAL_TO_OBJECT = CallMatcher.instanceCall(ASSERT_INTERFACE, MethodNames.IS_NOT_EQUAL_TO)
|
||||
.parameterTypes(CommonClassNames.JAVA_LANG_OBJECT)!!
|
||||
val IS_EQUAL_TO_STRING = CallMatcher.instanceCall(ABSTRACT_STRING_ASSERT_CLASSNAME, MethodNames.IS_EQUAL_TO)
|
||||
.parameterTypes(CommonClassNames.JAVA_LANG_STRING)!!
|
||||
val IS_EQUAL_TO_INT = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, MethodNames.IS_EQUAL_TO)
|
||||
.parameterTypes("int")!!
|
||||
val IS_EQUAL_TO_LONG = CallMatcher.instanceCall(ABSTRACT_LONG_ASSERT_CLASSNAME, MethodNames.IS_EQUAL_TO)
|
||||
.parameterTypes("long")!!
|
||||
val IS_EQUAL_TO_FLOAT = CallMatcher.instanceCall(ABSTRACT_FLOAT_ASSERT_CLASSNAME, MethodNames.IS_EQUAL_TO)
|
||||
.parameterTypes("float")!!
|
||||
val IS_EQUAL_TO_DOUBLE = CallMatcher.instanceCall(ABSTRACT_DOUBLE_ASSERT_CLASSNAME, MethodNames.IS_EQUAL_TO)
|
||||
.parameterTypes("double")!!
|
||||
val IS_EQUAL_TO_BOOLEAN = CallMatcher.instanceCall(ABSTRACT_BOOLEAN_ASSERT_CLASSNAME, MethodNames.IS_EQUAL_TO)
|
||||
.parameterTypes("boolean")!!
|
||||
val IS_NOT_EQUAL_TO_BOOLEAN =
|
||||
CallMatcher.instanceCall(ABSTRACT_BOOLEAN_ASSERT_CLASSNAME, MethodNames.IS_NOT_EQUAL_TO)
|
||||
.parameterTypes("boolean")!!
|
||||
|
||||
val IS_NOT_EQUAL_TO_OBJECT = CallMatcher.instanceCall(ASSERT_INTERFACE, MethodNames.IS_NOT_EQUAL_TO)
|
||||
.parameterTypes(CommonClassNames.JAVA_LANG_OBJECT)!!
|
||||
val IS_NOT_EQUAL_TO_BOOLEAN = CallMatcher.instanceCall(ABSTRACT_BOOLEAN_ASSERT_CLASSNAME, MethodNames.IS_NOT_EQUAL_TO)
|
||||
.parameterTypes("boolean")!!
|
||||
val IS_NOT_EQUAL_TO_INT = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, MethodNames.IS_NOT_EQUAL_TO)
|
||||
.parameterTypes("int")!!
|
||||
val IS_NOT_EQUAL_TO_LONG = CallMatcher.instanceCall(ABSTRACT_LONG_ASSERT_CLASSNAME, MethodNames.IS_NOT_EQUAL_TO)
|
||||
.parameterTypes("long")!!
|
||||
val IS_NOT_EQUAL_TO_FLOAT = CallMatcher.instanceCall(ABSTRACT_FLOAT_ASSERT_CLASSNAME, MethodNames.IS_NOT_EQUAL_TO)
|
||||
.parameterTypes("float")!!
|
||||
val IS_NOT_EQUAL_TO_DOUBLE = CallMatcher.instanceCall(ABSTRACT_DOUBLE_ASSERT_CLASSNAME, MethodNames.IS_NOT_EQUAL_TO)
|
||||
.parameterTypes("double")!!
|
||||
|
||||
val IS_SAME_AS_OBJECT = CallMatcher.instanceCall(ASSERT_INTERFACE, MethodNames.IS_SAME_AS)
|
||||
.parameterTypes(CommonClassNames.JAVA_LANG_OBJECT)!!
|
||||
val IS_NOT_SAME_AS_OBJECT = CallMatcher.instanceCall(ASSERT_INTERFACE, MethodNames.IS_NOT_SAME_AS)
|
||||
@@ -103,8 +125,6 @@ open class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
val HAS_SIZE = CallMatcher.instanceCall(ENUMERABLE_ASSERT_INTERFACE, MethodNames.HAS_SIZE)
|
||||
.parameterTypes("int")!!
|
||||
|
||||
val IS_EQUAL_TO_INT = CallMatcher.instanceCall(ABSTRACT_ASSERT_CLASSNAME, MethodNames.IS_EQUAL_TO)
|
||||
.parameterTypes("int")!!
|
||||
val IS_GREATER_THAN_INT = CallMatcher.instanceCall(ABSTRACT_COMPARABLE_ASSERT_CLASSNAME, MethodNames.IS_GREATER_THAN)
|
||||
.parameterTypes("int")!!
|
||||
val IS_GREATER_THAN_OR_EQUAL_TO_INT = CallMatcher.instanceCall(ABSTRACT_COMPARABLE_ASSERT_CLASSNAME, MethodNames.IS_GREATER_THAN_OR_EQUAL_TO)
|
||||
@@ -127,6 +147,8 @@ open class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
|
||||
val COLLECTION_SIZE = CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_COLLECTION, "size")
|
||||
.parameterCount(0)!!
|
||||
val MAP_SIZE = CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_MAP, "size")
|
||||
.parameterCount(0)!!
|
||||
val CHAR_SEQUENCE_LENGTH = CallMatcher.instanceCall("java.lang.CharSequence", "length")
|
||||
.parameterCount(0)!!
|
||||
val OBJECT_EQUALS = CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_OBJECT, "equals")
|
||||
|
||||
+47
-7
@@ -11,6 +11,26 @@ class AssertThatCollectionOrMapExpressionInspection : AbstractAssertJInspection(
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Asserting a collection or map specific expression"
|
||||
|
||||
private val MAP_GET_MATCHER = CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_MAP, "get").parameterCount(1)
|
||||
|
||||
private val ANY_IS_EQUAL_TO_MATCHER = CallMatcher.anyOf(
|
||||
IS_EQUAL_TO_OBJECT,
|
||||
IS_EQUAL_TO_STRING,
|
||||
IS_EQUAL_TO_INT,
|
||||
IS_EQUAL_TO_LONG,
|
||||
IS_EQUAL_TO_FLOAT,
|
||||
IS_EQUAL_TO_DOUBLE,
|
||||
IS_EQUAL_TO_BOOLEAN
|
||||
)
|
||||
private val ANY_IS_NOT_EQUAL_TO_MATCHER = CallMatcher.anyOf(
|
||||
IS_NOT_EQUAL_TO_OBJECT,
|
||||
IS_NOT_EQUAL_TO_INT,
|
||||
IS_NOT_EQUAL_TO_LONG,
|
||||
IS_NOT_EQUAL_TO_FLOAT,
|
||||
IS_NOT_EQUAL_TO_DOUBLE,
|
||||
IS_NOT_EQUAL_TO_BOOLEAN
|
||||
)
|
||||
|
||||
private val MAPPINGS = listOf(
|
||||
Mapping(
|
||||
CallMatcher.anyOf(
|
||||
@@ -46,17 +66,37 @@ class AssertThatCollectionOrMapExpressionInspection : AbstractAssertJInspection(
|
||||
super.visitExpressionStatement(statement)
|
||||
if (!statement.hasAssertThat()) return
|
||||
val staticMethodCall = statement.findStaticMethodCall() ?: return
|
||||
if (!ASSERT_THAT_BOOLEAN.test(staticMethodCall)) return
|
||||
|
||||
val assertThatArgument = staticMethodCall.firstArg as? PsiMethodCallExpression ?: return
|
||||
val mapping = MAPPINGS.firstOrNull { it.callMatcher.test(assertThatArgument) } ?: return
|
||||
|
||||
val expectedCallExpression = statement.findOutmostMethodCall() ?: return
|
||||
val expectedResult = expectedCallExpression.getAllTheSameExpectedBooleanConstants() ?: return
|
||||
if (MAP_GET_MATCHER.test(assertThatArgument)) {
|
||||
val nullOrNotNull = expectedCallExpression.getAllTheSameNullNotNullConstants()
|
||||
if (nullOrNotNull != null) {
|
||||
val replacementMethod = nullOrNotNull.map("containsKey", "doesNotContainKey")
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, replacementMethod) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method, useNullNonNull = true)
|
||||
}
|
||||
} else {
|
||||
if (ANY_IS_EQUAL_TO_MATCHER.test(expectedCallExpression)) {
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, "containsEntry") { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method, keepExpectedAsSecondArgument = true)
|
||||
}
|
||||
} else if (ANY_IS_NOT_EQUAL_TO_MATCHER.test(expectedCallExpression)) {
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, "doesNotContainEntry") { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method, keepExpectedAsSecondArgument = true)
|
||||
}
|
||||
}
|
||||
}
|
||||
} else {
|
||||
if (!ASSERT_THAT_BOOLEAN.test(staticMethodCall)) return
|
||||
val mapping = MAPPINGS.firstOrNull { it.callMatcher.test(assertThatArgument) } ?: return
|
||||
|
||||
val replacementMethod = if (expectedResult) mapping.replacementForTrue else mapping.replacementForFalse ?: return
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, replacementMethod) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method)
|
||||
val expectedResult = expectedCallExpression.getAllTheSameExpectedBooleanConstants() ?: return
|
||||
|
||||
val replacementMethod = if (expectedResult) mapping.replacementForTrue else mapping.replacementForFalse ?: return
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, replacementMethod) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
+4
-1
@@ -30,7 +30,7 @@ class AssertThatGuavaOptionalInspection : AbstractAssertJInspection() {
|
||||
val outmostMethodCall = statement.findOutmostMethodCall() ?: return
|
||||
if (GUAVA_OPTIONAL_GET.test(actualExpression)) {
|
||||
val expectedCallExpression = staticMethodCall.gatherAssertionCalls().singleOrNull() ?: return
|
||||
if (IS_EQUAL_TO_OBJECT.test(expectedCallExpression)) {
|
||||
if (CallMatcher.anyOf(IS_EQUAL_TO_OBJECT, IS_EQUAL_TO_STRING).test(expectedCallExpression)) {
|
||||
registerMoveOutMethod(holder, outmostMethodCall, actualExpression, MethodNames.CONTAINS) { desc, method ->
|
||||
QuickFixWithPostfixDelegate(
|
||||
RemoveActualOutmostMethodCallQuickFix(desc, method),
|
||||
@@ -70,6 +70,9 @@ class AssertThatGuavaOptionalInspection : AbstractAssertJInspection() {
|
||||
if (IS_EQUAL_TO_OBJECT.test(expression)) {
|
||||
val innerExpectedCall = expression.firstArg as? PsiMethodCallExpression ?: return
|
||||
if (CallMatcher.anyOf(GUAVA_OPTIONAL_OF, GUAVA_OPTIONAL_FROM_NULLABLE).test(innerExpectedCall)) {
|
||||
if (GUAVA_OPTIONAL_FROM_NULLABLE.test(innerExpectedCall)) {
|
||||
innerExpectedCall.firstArg.calculateConstantValue() ?: return
|
||||
}
|
||||
registerRemoveExpectedOutmostMethod(holder, expression, expression, MethodNames.CONTAINS) { desc, method ->
|
||||
QuickFixWithPostfixDelegate(
|
||||
UnwrapExpectedStaticMethodCallQuickFix(desc, method),
|
||||
|
||||
+4
-1
@@ -28,7 +28,7 @@ class AssertThatJava8OptionalInspection : AbstractAssertJInspection() {
|
||||
val outmostMethodCall = statement.findOutmostMethodCall() ?: return
|
||||
if (OPTIONAL_GET.test(actualExpression)) {
|
||||
val expectedCallExpression = staticMethodCall.gatherAssertionCalls().singleOrNull() ?: return
|
||||
if (IS_EQUAL_TO_OBJECT.test(expectedCallExpression)) {
|
||||
if (CallMatcher.anyOf(IS_EQUAL_TO_OBJECT, IS_EQUAL_TO_STRING).test(expectedCallExpression)) {
|
||||
registerMoveOutMethod(holder, outmostMethodCall, actualExpression, MethodNames.CONTAINS) { desc, method ->
|
||||
RemoveActualOutmostMethodCallQuickFix(desc, method)
|
||||
}
|
||||
@@ -60,6 +60,9 @@ class AssertThatJava8OptionalInspection : AbstractAssertJInspection() {
|
||||
if (IS_EQUAL_TO_OBJECT.test(expression)) {
|
||||
val innerExpectedCall = expression.firstArg as? PsiMethodCallExpression ?: return
|
||||
if (CallMatcher.anyOf(OPTIONAL_OF, OPTIONAL_OF_NULLABLE).test(innerExpectedCall)) {
|
||||
if (OPTIONAL_OF_NULLABLE.test(innerExpectedCall)) {
|
||||
innerExpectedCall.firstArg.calculateConstantValue() ?: return
|
||||
}
|
||||
registerRemoveExpectedOutmostMethod(holder, expression, expression, MethodNames.CONTAINS, ::UnwrapExpectedStaticMethodCallQuickFix)
|
||||
} else if (OPTIONAL_EMPTY.test(innerExpectedCall)) {
|
||||
registerSimplifyMethod(holder, expression, MethodNames.IS_NOT_PRESENT)
|
||||
|
||||
+1
-1
@@ -38,7 +38,7 @@ class AssertThatObjectExpressionInspection : AbstractAssertJInspection() {
|
||||
}
|
||||
}
|
||||
OBJECT_TO_STRING.test(assertThatArgument) -> {
|
||||
staticMethodCall.findFluentCallTo(IS_EQUAL_TO_OBJECT) ?: return
|
||||
staticMethodCall.findFluentCallTo(IS_EQUAL_TO_OBJECT) ?: staticMethodCall.findFluentCallTo(IS_EQUAL_TO_STRING) ?: return
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, MethodNames.HAS_TO_STRING) { desc, method ->
|
||||
RemoveActualOutmostMethodCallQuickFix(desc, method)
|
||||
}
|
||||
|
||||
+2
-1
@@ -2,6 +2,7 @@ package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.*
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.MethodNames
|
||||
import de.platon42.intellij.plugins.cajon.firstArg
|
||||
import de.platon42.intellij.plugins.cajon.hasAssertThat
|
||||
@@ -21,7 +22,7 @@ class AssertThatObjectIsNullOrNotNullInspection : AbstractAssertJInspection() {
|
||||
super.visitMethodCallExpression(expression)
|
||||
if (!expression.hasAssertThat()) return
|
||||
val isNotEqualTo = IS_NOT_EQUAL_TO_OBJECT.test(expression)
|
||||
val isEqualTo = IS_EQUAL_TO_OBJECT.test(expression)
|
||||
val isEqualTo = CallMatcher.anyOf(IS_EQUAL_TO_OBJECT, IS_EQUAL_TO_STRING).test(expression)
|
||||
val isLastExpression = expression.parent is PsiStatement
|
||||
if (!((isEqualTo && isLastExpression) || isNotEqualTo)) return
|
||||
|
||||
|
||||
+14
-10
@@ -11,7 +11,7 @@ import de.platon42.intellij.plugins.cajon.quickfixes.ReplaceSizeMethodCallQuickF
|
||||
class AssertThatSizeInspection : AbstractAssertJInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Asserting the size of an collection, array or string"
|
||||
private const val DISPLAY_NAME = "Asserting the size of an collection, map, array or string"
|
||||
private const val REMOVE_SIZE_DESCRIPTION_TEMPLATE = "Remove size determination of expected expression and replace %s() with %s()"
|
||||
private const val REMOVE_ALL_MESSAGE = "Try to operate on the iterable itself rather than its size"
|
||||
|
||||
@@ -26,13 +26,15 @@ class AssertThatSizeInspection : AbstractAssertJInspection() {
|
||||
|
||||
private fun isCollectionSize(expression: PsiExpression) = (expression is PsiMethodCallExpression) && COLLECTION_SIZE.test(expression)
|
||||
|
||||
private fun isMapSize(expression: PsiExpression) = (expression is PsiMethodCallExpression) && MAP_SIZE.test(expression)
|
||||
|
||||
private fun isArrayLength(expression: PsiExpression): Boolean {
|
||||
val psiReferenceExpression = expression as? PsiReferenceExpression ?: return false
|
||||
return ((psiReferenceExpression.qualifierExpression?.type is PsiArrayType)
|
||||
&& ((psiReferenceExpression.resolve() as? PsiField)?.name == "length"))
|
||||
}
|
||||
|
||||
fun getMatch(expression: PsiMethodCallExpression, isForArrayOrCollection: Boolean, isForString: Boolean): Match? {
|
||||
fun getMatch(expression: PsiMethodCallExpression, isForArrayCollectionOrMap: Boolean, isForString: Boolean): Match? {
|
||||
val isLastExpression = expression.parent is PsiStatement
|
||||
val constValue = expression.calculateConstantParameterValue(0)
|
||||
if (IS_EQUAL_TO_INT.test(expression)) {
|
||||
@@ -40,8 +42,10 @@ class AssertThatSizeInspection : AbstractAssertJInspection() {
|
||||
Match(expression, MethodNames.IS_EMPTY, noExpectedExpression = true)
|
||||
} else {
|
||||
val equalToExpression = expression.firstArg
|
||||
if (isForArrayOrCollection && (isCollectionSize(equalToExpression) || isArrayLength(equalToExpression)) ||
|
||||
isForString && (isCollectionSize(equalToExpression) || isArrayLength(equalToExpression) || isCharSequenceLength(equalToExpression))
|
||||
val equalsArrayCollectionOrMapSize = isArrayLength(equalToExpression) ||
|
||||
isCollectionSize(equalToExpression) || isMapSize(equalToExpression)
|
||||
if (isForArrayCollectionOrMap && equalsArrayCollectionOrMapSize ||
|
||||
isForString && (equalsArrayCollectionOrMapSize || isCharSequenceLength(equalToExpression))
|
||||
) {
|
||||
Match(expression, MethodNames.HAS_SAME_SIZE_AS, expectedIsCollection = true)
|
||||
} else {
|
||||
@@ -59,7 +63,7 @@ class AssertThatSizeInspection : AbstractAssertJInspection() {
|
||||
val replacementMethod = isTestForEmpty.map(MethodNames.IS_EMPTY, MethodNames.IS_NOT_EMPTY)
|
||||
return Match(expression, replacementMethod, noExpectedExpression = true)
|
||||
} else if (hasAssertJMethod(expression, ABSTRACT_ITERABLE_ASSERT_CLASSNAME, MethodNames.HAS_SIZE_LESS_THAN)) {
|
||||
// new stuff in AssertJ 13.2.0
|
||||
// new stuff in AssertJ 3.12.0
|
||||
val replacementMethod = BONUS_EXPRESSIONS_CALL_MATCHER_MAP.find { it.first.test(expression) }?.second ?: return null
|
||||
return Match(expression, replacementMethod)
|
||||
}
|
||||
@@ -79,12 +83,12 @@ class AssertThatSizeInspection : AbstractAssertJInspection() {
|
||||
if (!ASSERT_THAT_INT.test(staticMethodCall)) return
|
||||
|
||||
val actualExpression = staticMethodCall.firstArg
|
||||
val isForArrayOrCollection = isArrayLength(actualExpression) || isCollectionSize(actualExpression)
|
||||
val isForArrayCollectionOrMap = isArrayLength(actualExpression) || isCollectionSize(actualExpression) || isMapSize(actualExpression)
|
||||
val isForString = isCharSequenceLength(actualExpression)
|
||||
if (!(isForArrayOrCollection || isForString)) return
|
||||
if (!(isForArrayCollectionOrMap || isForString)) return
|
||||
|
||||
val matches = staticMethodCall.collectMethodCallsUpToStatement()
|
||||
.mapNotNull { getMatch(it, isForArrayOrCollection, isForString) }
|
||||
.mapNotNull { getMatch(it, isForArrayCollectionOrMap, isForString) }
|
||||
.toList()
|
||||
if (matches.isNotEmpty()) {
|
||||
if (matches.size == 1) {
|
||||
@@ -112,9 +116,9 @@ class AssertThatSizeInspection : AbstractAssertJInspection() {
|
||||
if (!HAS_SIZE.test(expression)) return
|
||||
val actualExpression = expression.firstArg
|
||||
|
||||
val isForArrayOrCollection = isArrayLength(actualExpression) || isCollectionSize(actualExpression)
|
||||
val isForArrayCollectionOrMap = isArrayLength(actualExpression) || isCollectionSize(actualExpression) || isMapSize(actualExpression)
|
||||
val isForString = isCharSequenceLength(actualExpression)
|
||||
if (!(isForArrayOrCollection
|
||||
if (!(isForArrayCollectionOrMap
|
||||
|| (isForString && checkAssertedType(expression, ABSTRACT_CHAR_SEQUENCE_ASSERT_CLASSNAME)))
|
||||
) return
|
||||
|
||||
|
||||
+2
-1
@@ -5,6 +5,7 @@ import com.intellij.psi.JavaElementVisitor
|
||||
import com.intellij.psi.PsiElementVisitor
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.intellij.psi.PsiStatement
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_CHAR_SEQUENCE_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.MethodNames
|
||||
import de.platon42.intellij.plugins.cajon.calculateConstantParameterValue
|
||||
@@ -23,7 +24,7 @@ class AssertThatStringIsEmptyInspection : AbstractAssertJInspection() {
|
||||
override fun visitMethodCallExpression(expression: PsiMethodCallExpression) {
|
||||
super.visitMethodCallExpression(expression)
|
||||
if (!expression.hasAssertThat()) return
|
||||
val isEqual = IS_EQUAL_TO_OBJECT.test(expression)
|
||||
val isEqual = CallMatcher.anyOf(IS_EQUAL_TO_OBJECT, IS_EQUAL_TO_STRING).test(expression)
|
||||
val hasSize = HAS_SIZE.test(expression)
|
||||
val isLastExpression = expression.parent is PsiStatement
|
||||
if (!((isEqual || hasSize) && isLastExpression)) return
|
||||
|
||||
+1
-1
@@ -29,7 +29,7 @@ class ImplicitAssertionInspection : AbstractAssertJInspection() {
|
||||
|
||||
private val OBJECT_ENUMERABLE_ANY_CONTENT_ASSERTIONS = CallMatcher.instanceCall(
|
||||
AssertJClassNames.OBJECT_ENUMERABLE_ASSERT_INTERFACE,
|
||||
MethodNames.CONTAINS, "containsOnly", "containsOnlyNulls", "containsOnlyOnce",
|
||||
MethodNames.CONTAINS, "containsOnly", "containsOnlyNulls", MethodNames.CONTAINS_ONLY_ONCE,
|
||||
"containsExactly", "containsExactlyInAnyOrder", "containsExactlyInAnyOrderElementsOf",
|
||||
"containsAll", "containsAnyOf",
|
||||
"containsAnyElementsOf", "containsExactlyElementsOf", "containsOnlyElementsOf",
|
||||
|
||||
+53
@@ -0,0 +1,53 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.openapi.util.TextRange
|
||||
import com.intellij.psi.JavaElementVisitor
|
||||
import com.intellij.psi.PsiElementVisitor
|
||||
import com.intellij.psi.PsiExpressionStatement
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.intellij.psi.util.PsiTreeUtil
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.JoinVarArgsContainsQuickFix
|
||||
|
||||
class JoinVarArgsContainsInspection : AbstractAssertJInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Join arguments to variadic for contains()/containsOnlyOnce()/doesNotContain()"
|
||||
private const val JOIN_VARARGS_MESSAGE = "Calls to same methods may be joined to variadic version"
|
||||
|
||||
private val MATCHERS = listOf(MethodNames.CONTAINS, MethodNames.CONTAINS_ONLY_ONCE, MethodNames.DOES_NOT_CONTAIN)
|
||||
.map { CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_ITERABLE_ASSERT_CLASSNAME, it) }
|
||||
}
|
||||
|
||||
override fun getDisplayName() = DISPLAY_NAME
|
||||
|
||||
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitExpressionStatement(statement: PsiExpressionStatement) {
|
||||
super.visitStatement(statement)
|
||||
if (!statement.hasAssertThat()) return
|
||||
val assertThatCall = PsiTreeUtil.findChildrenOfType(statement, PsiMethodCallExpression::class.java).find { ALL_ASSERT_THAT_MATCHERS.test(it) } ?: return
|
||||
|
||||
val allCalls = assertThatCall.collectMethodCallsUpToStatement().toList()
|
||||
|
||||
if (allCalls.find(COMPLEX_CALLS_THAT_MAKES_STUFF_TRICKY::test) != null) return
|
||||
|
||||
val onlyAssertionCalls = allCalls
|
||||
.filterNot { NOT_ACTUAL_ASSERTIONS.test(it) }
|
||||
.toList()
|
||||
|
||||
for (methodMatcher in MATCHERS) {
|
||||
if (onlyAssertionCalls.count(methodMatcher::test) > 1) {
|
||||
val outmostMethodCall = statement.findOutmostMethodCall() ?: return
|
||||
val quickFix = JoinVarArgsContainsQuickFix(MATCHERS)
|
||||
val textRange = TextRange(assertThatCall.textLength, outmostMethodCall.textLength)
|
||||
holder.registerProblem(outmostMethodCall, textRange, JOIN_VARARGS_MESSAGE, quickFix)
|
||||
return
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
+38
@@ -0,0 +1,38 @@
|
||||
package de.platon42.intellij.plugins.cajon.quickfixes
|
||||
|
||||
import com.intellij.codeInspection.ProblemDescriptor
|
||||
import com.intellij.openapi.project.Project
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
|
||||
class JoinVarArgsContainsQuickFix(private val matchers: Iterable<CallMatcher>) : AbstractCommonQuickFix(JOIN_VARARGS_DESCRIPTION) {
|
||||
|
||||
companion object {
|
||||
private const val JOIN_VARARGS_DESCRIPTION = "Join multiple arguments to variadic argument method calls"
|
||||
}
|
||||
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
var outmostCallExpression = descriptor.startElement as? PsiMethodCallExpression ?: return
|
||||
|
||||
for (matcher in matchers) {
|
||||
val assertThatMethodCall = outmostCallExpression.findStaticMethodCall() ?: return
|
||||
val methodsToFix = assertThatMethodCall.gatherAssertionCalls()
|
||||
val matchedCalls = methodsToFix.filter(matcher::test)
|
||||
if (matchedCalls.size > 1) {
|
||||
val mainCall = matchedCalls.first()
|
||||
val args = mutableListOf(*mainCall.argumentList.expressions)
|
||||
for (secondaryCall in matchedCalls.asSequence().drop(1)) {
|
||||
args.addAll(secondaryCall.argumentList.expressions)
|
||||
}
|
||||
val newMainCall = createExpectedMethodCall(mainCall, mainCall.methodExpression.qualifiedName, *args.toTypedArray())
|
||||
newMainCall.replaceQualifierFromMethodCall(mainCall)
|
||||
mainCall.replace(newMainCall)
|
||||
for (secondaryCall in matchedCalls.asSequence().drop(1)) {
|
||||
val newQualifier = secondaryCall.qualifierExpression
|
||||
outmostCallExpression = secondaryCall.replace(newQualifier).findOutmostMethodCall() ?: return
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
+23
-11
@@ -9,7 +9,8 @@ class MoveOutMethodCallExpressionQuickFix(
|
||||
description: String,
|
||||
private val replacementMethod: String,
|
||||
private val useNullNonNull: Boolean = false,
|
||||
private val noExpectedExpression: Boolean = false
|
||||
private val noExpectedExpression: Boolean = false,
|
||||
private val keepExpectedAsSecondArgument: Boolean = false
|
||||
) :
|
||||
AbstractCommonQuickFix(description) {
|
||||
|
||||
@@ -27,17 +28,28 @@ class MoveOutMethodCallExpressionQuickFix(
|
||||
val assertExpression = assertThatMethodCall.firstArg as? PsiMethodCallExpression ?: return
|
||||
val assertExpressionArg = if (noExpectedExpression) null else assertExpression.getArgOrNull(0)?.copy()
|
||||
|
||||
val methodsToFix = assertThatMethodCall.collectMethodCallsUpToStatement()
|
||||
.filter { (if (useNullNonNull) it.getExpectedNullNonNullResult() else it.getExpectedBooleanResult()) != null }
|
||||
.toList()
|
||||
if (keepExpectedAsSecondArgument) {
|
||||
assertExpressionArg ?: return
|
||||
val secondArg = outmostCallExpression.getArgOrNull(0)?.copy() ?: return
|
||||
|
||||
assertExpression.replace(assertExpression.qualifierExpression)
|
||||
assertExpression.replace(assertExpression.qualifierExpression)
|
||||
|
||||
methodsToFix
|
||||
.forEach {
|
||||
val expectedExpression = createExpectedMethodCall(it, replacementMethod, *listOfNotNull(assertExpressionArg).toTypedArray())
|
||||
expectedExpression.replaceQualifierFromMethodCall(it)
|
||||
it.replace(expectedExpression)
|
||||
}
|
||||
val expectedExpression = createExpectedMethodCall(outmostCallExpression, replacementMethod, assertExpressionArg, secondArg)
|
||||
expectedExpression.replaceQualifierFromMethodCall(outmostCallExpression)
|
||||
outmostCallExpression.replace(expectedExpression)
|
||||
} else {
|
||||
val methodsToFix = assertThatMethodCall.collectMethodCallsUpToStatement()
|
||||
.filter { (if (useNullNonNull) it.getExpectedNullNonNullResult() else it.getExpectedBooleanResult()) != null }
|
||||
.toList()
|
||||
|
||||
assertExpression.replace(assertExpression.qualifierExpression)
|
||||
|
||||
methodsToFix
|
||||
.forEach {
|
||||
val expectedExpression = createExpectedMethodCall(it, replacementMethod, *listOfNotNull(assertExpressionArg).toTypedArray())
|
||||
expectedExpression.replaceQualifierFromMethodCall(it)
|
||||
it.replace(expectedExpression)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
+2
-2
@@ -15,7 +15,7 @@ class ReplaceHasSizeMethodCallQuickFix(description: String, private val replacem
|
||||
override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
|
||||
val methodCallExpression = descriptor.startElement as? PsiMethodCallExpression ?: return
|
||||
|
||||
replaceCollectionSizeOrArrayLength(methodCallExpression.firstArg)
|
||||
replaceCollectionAndMapSizeOrArrayLength(methodCallExpression.firstArg)
|
||||
|
||||
val expectedExpression = createExpectedMethodCall(methodCallExpression, replacementMethod, methodCallExpression.firstArg)
|
||||
|
||||
@@ -23,7 +23,7 @@ class ReplaceHasSizeMethodCallQuickFix(description: String, private val replacem
|
||||
methodCallExpression.replace(expectedExpression)
|
||||
}
|
||||
|
||||
private fun replaceCollectionSizeOrArrayLength(assertExpression: PsiExpression) {
|
||||
private fun replaceCollectionAndMapSizeOrArrayLength(assertExpression: PsiExpression) {
|
||||
assertExpression.replace(
|
||||
when (assertExpression) {
|
||||
is PsiReferenceExpression -> assertExpression.qualifierExpression!!
|
||||
|
||||
+3
-3
@@ -26,10 +26,10 @@ class ReplaceSizeMethodCallQuickFix(
|
||||
val outmostCallExpression = descriptor.startElement as? PsiMethodCallExpression ?: return
|
||||
val assertThatMethodCall = outmostCallExpression.findStaticMethodCall() ?: return
|
||||
val assertExpression = assertThatMethodCall.firstArg
|
||||
replaceCollectionSizeOrArrayLength(assertExpression)
|
||||
replaceCollectionAndMapSizeOrArrayLength(assertExpression)
|
||||
|
||||
if (expectedIsCollection) {
|
||||
replaceCollectionSizeOrArrayLength(outmostCallExpression.firstArg)
|
||||
replaceCollectionAndMapSizeOrArrayLength(outmostCallExpression.firstArg)
|
||||
}
|
||||
|
||||
val args = if (noExpectedExpression) emptyArray() else arrayOf(outmostCallExpression.firstArg)
|
||||
@@ -39,7 +39,7 @@ class ReplaceSizeMethodCallQuickFix(
|
||||
outmostCallExpression.replace(expectedExpression)
|
||||
}
|
||||
|
||||
private fun replaceCollectionSizeOrArrayLength(assertExpression: PsiExpression) {
|
||||
private fun replaceCollectionAndMapSizeOrArrayLength(assertExpression: PsiExpression) {
|
||||
assertExpression.replace(
|
||||
when (assertExpression) {
|
||||
is PsiReferenceExpression -> assertExpression.qualifierExpression!!
|
||||
|
||||
+6
@@ -7,6 +7,7 @@ import com.intellij.psi.*
|
||||
import com.intellij.psi.util.PropertyUtilBase
|
||||
import com.intellij.psi.util.PsiTreeUtil
|
||||
import com.intellij.psi.util.PsiTypesUtil
|
||||
import com.intellij.util.ArrayUtil
|
||||
import com.intellij.util.ProcessingContext
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
@@ -70,6 +71,11 @@ class ExtractorReferenceContributor : PsiReferenceContributor() {
|
||||
class ExtractorReference(literal: PsiLiteralExpression, range: TextRange, private val targets: List<PsiElement>) :
|
||||
PsiPolyVariantReferenceBase<PsiLiteralExpression>(literal, range, true) {
|
||||
|
||||
// Do not remove due to compatiblity issue with IDEA <= 2018.2
|
||||
override fun getVariants(): Array<Any> {
|
||||
return ArrayUtil.EMPTY_OBJECT_ARRAY
|
||||
}
|
||||
|
||||
override fun resolve(): PsiElement? {
|
||||
return multiResolve(false).map(ResolveResult::getElement).firstOrNull()
|
||||
}
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
<idea-plugin>
|
||||
<id>de.platon42.cajon</id>
|
||||
<name>Concise AssertJ Optimizing Nitpicker (Cajon)</name>
|
||||
<vendor email="chrisly@platon42.de" url="https://github.com/chrisly42/cajon-plugin">Platon42</vendor>
|
||||
<vendor email="chrisly@platon42.de" url="https://github.com/chrisly42/cajon-plugin">Chris 'platon42' Hodges</vendor>
|
||||
|
||||
<description><![CDATA[
|
||||
Cajon is an IntelliJ IDEA Plugin for shortening and optimizing AssertJ assertions.
|
||||
@@ -48,6 +48,8 @@
|
||||
|
||||
<localInspection groupPath="Java" shortName="JoinAssertThatStatements" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.JoinAssertThatStatementsInspection"/>
|
||||
<localInspection groupPath="Java" shortName="JoinVarArgsContains" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.JoinVarArgsContainsInspection"/>
|
||||
<localInspection groupPath="Java" shortName="AssumeThatInsteadOfReturn" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssumeThatInsteadOfReturnInspection"/>
|
||||
|
||||
|
||||
@@ -1,8 +1,10 @@
|
||||
<html>
|
||||
<body>
|
||||
Turns assertThat(collectionOrMap.someMethod(arg)).isTrue/isFalse() into assertThat(collectionOrMap).someMethod(arg).
|
||||
Turns assertThat(collectionOrMap.someMethod(arg)).isTrue/isFalse() into assertThat(collectionOrMap).someMethod(arg) and
|
||||
assertThat(map.get(key)).isEqualTo/isNotEqualTo(value) into assertThat(map).containsEntry(key, value).
|
||||
<!-- tooltip end -->
|
||||
<br>someMethod() can be isEmpty(), contains(), and containsAll() for collections and
|
||||
isEmpty(), containsKey(), and containsValue() for maps.
|
||||
get() may be transformed into containsKey(), doesNotContainKey(), containsEntry() or doesNotContainEntry().
|
||||
</body>
|
||||
</html>
|
||||
@@ -1,7 +1,7 @@
|
||||
<html>
|
||||
<body>
|
||||
Makes assertions on sizes of arrays, collections, strings, or CharSequences more concise by replacing them with isEmpty(), isNotEmpty(), hasSize(), or hasSameSizeAs().
|
||||
Makes assertions on sizes of arrays, collections, maps, strings, or CharSequences more concise by replacing them with isEmpty(), isNotEmpty(), hasSize(), or hasSameSizeAs().
|
||||
<!-- tooltip end -->
|
||||
<br>Several more conversions are available with AssertJ 13.2.0 or later.
|
||||
<br>Several more conversions are available with AssertJ 3.12.0 or later.
|
||||
</body>
|
||||
</html>
|
||||
@@ -0,0 +1,11 @@
|
||||
<html>
|
||||
<body>
|
||||
Finds assertions where multiple .contains(), .containsOnlyOnce() or .doesNotContain() are
|
||||
used in a single statement that could be joined together.
|
||||
<!-- tooltip end -->
|
||||
Only works when variadic arguments are possible and will not be performed on more complex
|
||||
statements with .extracting() or .as() to avoid changing semantics.
|
||||
<br>
|
||||
Note that the quickfix does not handle comments very well and might remove them during the operation.
|
||||
</body>
|
||||
</html>
|
||||
@@ -11,7 +11,7 @@ import com.intellij.openapi.vfs.VirtualFile;
|
||||
import com.intellij.testFramework.*;
|
||||
import com.intellij.testFramework.fixtures.IdeaTestExecutionPolicy;
|
||||
import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture;
|
||||
import com.intellij.testFramework.fixtures.LightCodeInsightFixtureTestCase;
|
||||
import com.intellij.testFramework.fixtures.LightJavaCodeInsightFixtureTestCase;
|
||||
import org.jetbrains.annotations.NotNull;
|
||||
import org.junit.jupiter.api.extension.*;
|
||||
import org.junit.jupiter.api.extension.ExtensionContext.Namespace;
|
||||
@@ -88,7 +88,6 @@ public class LightCodeInsightExtension implements ParameterResolver, AfterTestEx
|
||||
TestLoggerFactory.onTestFinished(true);
|
||||
} catch (Throwable e) {
|
||||
TestLoggerFactory.onTestFinished(false);
|
||||
e.fillInStackTrace();
|
||||
throwables[0] = e;
|
||||
}
|
||||
};
|
||||
@@ -112,7 +111,7 @@ public class LightCodeInsightExtension implements ParameterResolver, AfterTestEx
|
||||
}
|
||||
}
|
||||
|
||||
private static class LightCodeInsightFixtureTestCaseWrapper extends LightCodeInsightFixtureTestCase {
|
||||
private static class LightCodeInsightFixtureTestCaseWrapper extends LightJavaCodeInsightFixtureTestCase {
|
||||
private final ExtensionContext extensionContext;
|
||||
|
||||
private LightCodeInsightFixtureTestCaseWrapper(ExtensionContext extensionContext) {
|
||||
@@ -159,7 +158,7 @@ public class LightCodeInsightExtension implements ParameterResolver, AfterTestEx
|
||||
};
|
||||
}
|
||||
|
||||
protected void addJarContaining(ModifiableRootModel model, Class clazz) {
|
||||
void addJarContaining(ModifiableRootModel model, Class clazz) {
|
||||
try {
|
||||
Path jarPath = Paths.get(clazz.getProtectionDomain().getCodeSource().getLocation().toURI());
|
||||
|
||||
|
||||
+4
@@ -22,6 +22,10 @@ internal class AssertThatCollectionOrMapExpressionInspectionTest : AbstractCajon
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove contains() of actual expression and use assertThat().doesNotContain() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsKey() of actual expression and use assertThat().doesNotContainKey() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsValue() of actual expression and use assertThat().doesNotContainValue() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 4)
|
||||
myFixture.checkResultByFile("CollectionMapExpressionAfter.java")
|
||||
}
|
||||
}
|
||||
+15
-15
@@ -12,25 +12,25 @@ internal class AssertThatSizeInspectionTest : AbstractCajonTest() {
|
||||
|
||||
@Test
|
||||
@TestDataSubPath("inspections/Size")
|
||||
internal fun assertThat_size_of_array_or_collection_can_be_simplified(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
internal fun assertThat_size_of_array_collection_or_map_can_be_simplified(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
myFixture.enableInspections(AssertThatSizeInspection::class.java)
|
||||
myFixture.configureByFile("SizeBefore.java")
|
||||
assertThat(myFixture.doHighlighting()).extrakting { it.description }.containsOnlyOnce("Try to operate on the iterable itself rather than its size")
|
||||
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isZero() with isEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotZero() with isNotEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThan() with isNotEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThanOrEqualTo() with isNotEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThan() with isEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThanOrEqualTo() with isEmpty()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with hasSameSizeAs()"), 12)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with hasSize()"), 8)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThan() with hasSizeGreaterThan()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThanOrEqualTo() with hasSizeGreaterThanOrEqualTo()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThan() with hasSizeLessThan()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThanOrEqualTo() with hasSizeLessThanOrEqualTo()"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove size determination of expected expression and replace hasSize() with hasSameSizeAs()"), 14)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with isEmpty()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isZero() with isEmpty()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isNotZero() with isNotEmpty()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThan() with isNotEmpty()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThanOrEqualTo() with isNotEmpty()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThan() with isEmpty()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThanOrEqualTo() with isEmpty()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with hasSameSizeAs()"), 19)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with hasSize()"), 11)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThan() with hasSizeGreaterThan()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThanOrEqualTo() with hasSizeGreaterThanOrEqualTo()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThan() with hasSizeLessThan()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThanOrEqualTo() with hasSizeLessThanOrEqualTo()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove size determination of expected expression and replace hasSize() with hasSameSizeAs()"), 21)
|
||||
myFixture.checkResultByFile("SizeAfter.java")
|
||||
}
|
||||
}
|
||||
+19
@@ -0,0 +1,19 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
|
||||
import de.platon42.intellij.jupiter.MyFixture
|
||||
import de.platon42.intellij.jupiter.TestDataSubPath
|
||||
import de.platon42.intellij.plugins.cajon.AbstractCajonTest
|
||||
import org.junit.jupiter.api.Test
|
||||
|
||||
internal class JoinVarArgsContainsInspectionTest : AbstractCajonTest() {
|
||||
|
||||
@Test
|
||||
@TestDataSubPath("inspections/JoinVarArgsContains")
|
||||
internal fun join_contains_and_doesNotContain_together_where_possible(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
myFixture.enableInspections(JoinVarArgsContainsInspection::class.java)
|
||||
myFixture.configureByFile("JoinVarArgsContainsBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Join multiple arguments to variadic argument method calls"), 3)
|
||||
myFixture.checkResultByFile("JoinVarArgsContainsAfter.java")
|
||||
}
|
||||
}
|
||||
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class BinaryExpression {
|
||||
|
||||
@@ -196,7 +197,7 @@ public class BinaryExpression {
|
||||
|
||||
assertThat(numberObjAct.equals(numberObjExp)).as("doh!").isTrue().isEqualTo(true);
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(stringAct, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class BinaryExpression {
|
||||
|
||||
@@ -196,7 +197,7 @@ public class BinaryExpression {
|
||||
|
||||
assertThat(numberObjAct.equals(numberObjExp)).as("doh!").isTrue().isEqualTo(true);
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(stringAct, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class BooleanCondition {
|
||||
|
||||
@@ -32,7 +33,7 @@ public class BooleanCondition {
|
||||
assertThat(primitive).isTrue().as("foo").isTrue().as("bar").isTrue().isFalse();
|
||||
|
||||
assertThat(object).isEqualTo(Boolean.TYPE);
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(object, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class BooleanCondition {
|
||||
|
||||
@@ -32,7 +33,7 @@ public class BooleanCondition {
|
||||
assertThat(primitive).isEqualTo(Boolean.TRUE).as("foo").isEqualTo(true).as("bar").isTrue().isFalse();
|
||||
|
||||
assertThat(object).isEqualTo(Boolean.TYPE);
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(object, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
+17
-1
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
import java.util.*;
|
||||
|
||||
@@ -37,11 +38,26 @@ public class CollectionMapExpression {
|
||||
assertThat(keyValueMap).doesNotContainValue(2);
|
||||
assertThat(keyValueMap).doesNotContainValue(2);
|
||||
|
||||
assertThat(keyValueMap).containsEntry("foo", 2);
|
||||
assertThat(keyValueMap).doesNotContainEntry("foo", 3);
|
||||
assertThat(keyValueMap).doesNotContainKey("foo");
|
||||
assertThat(keyValueMap).doesNotContainKey("foo");
|
||||
assertThat(keyValueMap).containsKey("foo");
|
||||
assertThat(keyValueMap).containsKey("foo");
|
||||
|
||||
Map<String, String> stringStringMap = new HashMap<>();
|
||||
assertThat(stringStringMap).containsEntry("foo", "bar");
|
||||
assertThat(stringStringMap).doesNotContainEntry("foo", "bar");
|
||||
assertThat(stringStringMap).doesNotContainKey("foo");
|
||||
assertThat(stringStringMap).doesNotContainKey("foo");
|
||||
assertThat(stringStringMap).containsKey("foo");
|
||||
assertThat(stringStringMap).containsKey("foo");
|
||||
|
||||
assertThat(stringList).as("foo").isNotEmpty().as("bar").isNotEmpty();
|
||||
assertThat(stringList.isEmpty()).as("foo").isEqualTo(false).as("bar").isTrue();
|
||||
assertThat(stringList.isEmpty()).as("foo").satisfies(it -> it.booleanValue()).as("bar").isFalse();
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(stringList, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
+17
-1
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
import java.util.*;
|
||||
|
||||
@@ -37,11 +38,26 @@ public class CollectionMapExpression {
|
||||
assertThat(keyValueMap.containsValue(2)).isEqualTo(false);
|
||||
assertThat(keyValueMap.containsValue(2)).isFalse();
|
||||
|
||||
assertThat(keyValueMap.get("foo")).isEqualTo(2);
|
||||
assertThat(keyValueMap.get("foo")).isNotEqualTo(3);
|
||||
assertThat(keyValueMap.get("foo")).isEqualTo(null);
|
||||
assertThat(keyValueMap.get("foo")).isNull();
|
||||
assertThat(keyValueMap.get("foo")).isNotEqualTo(null);
|
||||
assertThat(keyValueMap.get("foo")).isNotNull();
|
||||
|
||||
Map<String, String> stringStringMap = new HashMap<>();
|
||||
assertThat(stringStringMap.get("foo")).isEqualTo("bar");
|
||||
assertThat(stringStringMap.get("foo")).isNotEqualTo("bar");
|
||||
assertThat(stringStringMap.get("foo")).isEqualTo(null);
|
||||
assertThat(stringStringMap.get("foo")).isNull();
|
||||
assertThat(stringStringMap.get("foo")).isNotEqualTo(null);
|
||||
assertThat(stringStringMap.get("foo")).isNotNull();
|
||||
|
||||
assertThat(stringList.isEmpty()).as("foo").isEqualTo(false).as("bar").isFalse();
|
||||
assertThat(stringList.isEmpty()).as("foo").isEqualTo(false).as("bar").isTrue();
|
||||
assertThat(stringList.isEmpty()).as("foo").satisfies(it -> it.booleanValue()).as("bar").isFalse();
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(stringList, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import java.util.ArrayList;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class EnumerableIsEmpty {
|
||||
|
||||
@@ -17,7 +18,7 @@ public class EnumerableIsEmpty {
|
||||
|
||||
assertThat("string").as("foo").hasSize(0).hasSameSizeAs("foo").isEmpty();
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat("foo", null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import java.util.ArrayList;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class EnumerableIsEmpty {
|
||||
|
||||
@@ -17,7 +18,7 @@ public class EnumerableIsEmpty {
|
||||
|
||||
assertThat("string").as("foo").hasSize(0).hasSameSizeAs("foo").hasSize(0);
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat("foo", null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import com.google.common.base.Optional;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
import static org.assertj.guava.api.Assertions.assertThat;
|
||||
|
||||
public class GuavaOptional {
|
||||
@@ -30,8 +31,21 @@ public class GuavaOptional {
|
||||
assertThat(opt).isPresent();
|
||||
assertThat(opt).isPresent();
|
||||
|
||||
//assertThat(opt.get()).isEqualTo(opt.get()); // there's a better version than contains(opt.get())
|
||||
assertThat(opt.orNull()).isEqualTo(opt.get());
|
||||
//assertThat(opt.get()).isEqualTo(opt.orNull()); // there's a better version than contains(opt.orNull())
|
||||
|
||||
assertThat(opt).contains(opt.get());
|
||||
assertThat(opt).contains(opt.orNull());
|
||||
|
||||
String possibleNullString = System.getProperty("username");
|
||||
String notNullString = "Narf";
|
||||
|
||||
assertThat(opt).as("foo").contains("foo");
|
||||
assertThat(opt).contains("foo");
|
||||
assertThat(opt).isEqualTo(Optional.fromNullable(null));
|
||||
assertThat(opt).isEqualTo(Optional.fromNullable(possibleNullString));
|
||||
assertThat(opt).isEqualTo(Optional.fromNullable(notNullString));
|
||||
assertThat(opt).isNotEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).isNotEqualTo(Optional.fromNullable("foo"));
|
||||
|
||||
@@ -59,7 +73,7 @@ public class GuavaOptional {
|
||||
|
||||
assertThat(opt.orNull()).as("foo").isEqualTo(null).isNotNull();
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(opt, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import com.google.common.base.Optional;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
import static org.assertj.guava.api.Assertions.assertThat;
|
||||
|
||||
public class GuavaOptional {
|
||||
@@ -30,8 +31,21 @@ public class GuavaOptional {
|
||||
assertThat(opt.orNull()).isNotEqualTo(null);
|
||||
assertThat(opt.orNull()).isNotNull();
|
||||
|
||||
//assertThat(opt.get()).isEqualTo(opt.get()); // there's a better version than contains(opt.get())
|
||||
assertThat(opt.orNull()).isEqualTo(opt.get());
|
||||
//assertThat(opt.get()).isEqualTo(opt.orNull()); // there's a better version than contains(opt.orNull())
|
||||
|
||||
assertThat(opt).contains(opt.get());
|
||||
assertThat(opt).contains(opt.orNull());
|
||||
|
||||
String possibleNullString = System.getProperty("username");
|
||||
String notNullString = "Narf";
|
||||
|
||||
assertThat(opt).as("foo").isEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).isEqualTo(Optional.fromNullable("foo"));
|
||||
assertThat(opt).isEqualTo(Optional.fromNullable(null));
|
||||
assertThat(opt).isEqualTo(Optional.fromNullable(possibleNullString));
|
||||
assertThat(opt).isEqualTo(Optional.fromNullable(notNullString));
|
||||
assertThat(opt).isNotEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).isNotEqualTo(Optional.fromNullable("foo"));
|
||||
|
||||
@@ -59,7 +73,7 @@ public class GuavaOptional {
|
||||
|
||||
assertThat(opt.orNull()).as("foo").isEqualTo(null).isNotNull();
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(opt, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -6,6 +6,7 @@ import java.util.Optional;
|
||||
import java.util.function.Consumer;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
import static org.assertj.guava.api.Assertions.assertThat;
|
||||
|
||||
public class ImplicitAssertion {
|
||||
@@ -285,7 +286,7 @@ public class ImplicitAssertion {
|
||||
assertThat(guavaOptional).extractingValue().isEqualTo("foo");
|
||||
assertThat(guavaOptional).extractingCharSequence().isEqualTo("foo");
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(string, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -6,6 +6,7 @@ import java.util.Optional;
|
||||
import java.util.function.Consumer;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
import static org.assertj.guava.api.Assertions.assertThat;
|
||||
|
||||
public class ImplicitAssertion {
|
||||
@@ -285,7 +286,7 @@ public class ImplicitAssertion {
|
||||
assertThat(guavaOptional).isPresent().extractingValue().isEqualTo("foo");
|
||||
assertThat(guavaOptional).isPresent().extractingCharSequence().isEqualTo("foo");
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(string, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class InstanceOf {
|
||||
|
||||
@@ -22,7 +23,7 @@ public class InstanceOf {
|
||||
assertThat(object).as("foo").isInstanceOf(Boolean.class).as("bar").isInstanceOf(Boolean.class);
|
||||
assertThat(object instanceof Boolean).as("foo").isEqualTo(Boolean.TRUE).as("bar").isEqualTo(false);
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(object, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class InstanceOf {
|
||||
|
||||
@@ -22,7 +23,7 @@ public class InstanceOf {
|
||||
assertThat(object instanceof Boolean).as("foo").isEqualTo(Boolean.TRUE).as("bar").isEqualTo(true);
|
||||
assertThat(object instanceof Boolean).as("foo").isEqualTo(Boolean.TRUE).as("bar").isEqualTo(false);
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(object, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
+2
-1
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class InvertedBooleanCondition {
|
||||
|
||||
@@ -36,7 +37,7 @@ public class InvertedBooleanCondition {
|
||||
assertThat(primitive).as("foo").isFalse().as("bar").isFalse();
|
||||
assertThat(primitive).as("foo").isFalse().as("bar").isTrue();
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(object, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
+2
-1
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class InvertedBooleanCondition {
|
||||
|
||||
@@ -36,7 +37,7 @@ public class InvertedBooleanCondition {
|
||||
assertThat(!primitive).as("foo").isEqualTo(Boolean.TRUE).as("bar").isNotEqualTo(false);
|
||||
assertThat(!primitive).as("foo").isEqualTo(Boolean.TRUE).as("bar").isNotEqualTo(true);
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(object, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import java.util.Optional;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class Java8Optional {
|
||||
|
||||
@@ -29,8 +30,21 @@ public class Java8Optional {
|
||||
assertThat(opt).isPresent();
|
||||
assertThat(opt).isPresent();
|
||||
|
||||
//assertThat(opt.get()).isEqualTo(opt.get()); // there's a better version than contains(opt.get())
|
||||
assertThat(opt.orElse(null)).isEqualTo(opt.get());
|
||||
//assertThat(opt.get()).isEqualTo(opt.orElse(null)); // there's a better version than contains(opt.orElse(null))
|
||||
|
||||
assertThat(opt).contains(opt.get());
|
||||
assertThat(opt).contains(opt.orElse(null));
|
||||
|
||||
String possibleNullString = System.getProperty("username");
|
||||
String notNullString = "Narf";
|
||||
|
||||
assertThat(opt).as("foo").contains("foo");
|
||||
assertThat(opt).contains("foo");
|
||||
assertThat(opt).isEqualTo(Optional.ofNullable(null));
|
||||
assertThat(opt).isEqualTo(Optional.ofNullable(possibleNullString));
|
||||
assertThat(opt).isEqualTo(Optional.ofNullable(notNullString));
|
||||
assertThat(opt).isNotEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).isNotEqualTo(Optional.ofNullable("foo"));
|
||||
|
||||
@@ -46,7 +60,7 @@ public class Java8Optional {
|
||||
|
||||
assertThat(opt.orElse(null)).as("foo").isEqualTo(null).isNotNull();
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(opt, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import java.util.Optional;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class Java8Optional {
|
||||
|
||||
@@ -29,8 +30,21 @@ public class Java8Optional {
|
||||
assertThat(opt.orElse(null)).isNotEqualTo(null);
|
||||
assertThat(opt.orElse(null)).isNotNull();
|
||||
|
||||
//assertThat(opt.get()).isEqualTo(opt.get()); // there's a better version than contains(opt.get())
|
||||
assertThat(opt.orElse(null)).isEqualTo(opt.get());
|
||||
//assertThat(opt.get()).isEqualTo(opt.orElse(null)); // there's a better version than contains(opt.orElse(null))
|
||||
|
||||
assertThat(opt).contains(opt.get());
|
||||
assertThat(opt).contains(opt.orElse(null));
|
||||
|
||||
String possibleNullString = System.getProperty("username");
|
||||
String notNullString = "Narf";
|
||||
|
||||
assertThat(opt).as("foo").isEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).isEqualTo(Optional.ofNullable("foo"));
|
||||
assertThat(opt).isEqualTo(Optional.ofNullable(null));
|
||||
assertThat(opt).isEqualTo(Optional.ofNullable(possibleNullString));
|
||||
assertThat(opt).isEqualTo(Optional.ofNullable(notNullString));
|
||||
assertThat(opt).isNotEqualTo(Optional.of("foo"));
|
||||
assertThat(opt).isNotEqualTo(Optional.ofNullable("foo"));
|
||||
|
||||
@@ -46,7 +60,7 @@ public class Java8Optional {
|
||||
|
||||
assertThat(opt.orElse(null)).as("foo").isEqualTo(null).isNotNull();
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(opt, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -66,7 +66,7 @@ public class JoinStatements {
|
||||
assertThat(list.get(--i)).isEqualTo("foo");
|
||||
assertThat(list.get(--i)).isEqualTo("foo");
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(list, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -63,7 +63,7 @@ public class JoinStatements {
|
||||
assertThat(list.get(--i)).isEqualTo("foo");
|
||||
assertThat(list.get(--i)).isEqualTo("foo");
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(list, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,22 @@
|
||||
import java.util.*;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class JoinVarArgsContains {
|
||||
|
||||
private void joinVarArgsContains() {
|
||||
List<String> list = new ArrayList<>();
|
||||
|
||||
assertThat(list).contains("foo", "bar", "etc").hasSize(2);
|
||||
assertThat(list).contains("foo").as("narf").contains("bar");
|
||||
assertThat(list).doesNotContain("foo", "bar");
|
||||
assertThat(list).containsOnlyOnce("foo", "etc") // will we lose this comment?
|
||||
.hasSize(2).contains("bar", "narf", "1", "2", "3").doesNotContain("puit", "Jens Stoltenberg is a war-monger", "and an atomic playboy") /* inline */; // the final comment
|
||||
|
||||
assertThat(list).contains("foo").doesNotContain("bar").containsOnlyOnce("narf");
|
||||
|
||||
org.junit.Assert.assertThat(list, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,28 @@
|
||||
import java.util.*;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class JoinVarArgsContains {
|
||||
|
||||
private void joinVarArgsContains() {
|
||||
List<String> list = new ArrayList<>();
|
||||
|
||||
assertThat(list).contains("foo").contains(/* foo */ "bar" /* bar */).hasSize(2).contains("etc");
|
||||
assertThat(list).contains("foo").as("narf").contains("bar");
|
||||
assertThat(list).doesNotContain("foo").doesNotContain("bar");
|
||||
assertThat(list).containsOnlyOnce()
|
||||
.containsOnlyOnce("foo") // will we lose this comment?
|
||||
.hasSize(2) // this is part of the contains("bar")
|
||||
.contains("bar").containsOnlyOnce("etc") /* where does this go? */
|
||||
.contains("narf") // what about this one?
|
||||
.doesNotContain("puit", "Jens Stoltenberg is a war-monger")
|
||||
.doesNotContain("and an atomic playboy")
|
||||
.contains("1", "2", "3") /* inline */; // the final comment
|
||||
|
||||
assertThat(list).contains("foo").doesNotContain("bar").containsOnlyOnce("narf");
|
||||
|
||||
org.junit.Assert.assertThat(list, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class ObjectExpression {
|
||||
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class ObjectExpression {
|
||||
|
||||
|
||||
+2
-1
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class ObjectIsNull {
|
||||
|
||||
@@ -14,7 +15,7 @@ public class ObjectIsNull {
|
||||
assertThat(new Object()).as("foo").isNotNull().as("bar").isEqualTo(new Object()).as("etc").isNull();
|
||||
assertThat(new Object()).as("foo").isEqualTo(null).as("bar").isEqualTo(new Object()).as("etc").isNotNull();
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat("foo", null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
+2
-1
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class ObjectIsNull {
|
||||
|
||||
@@ -14,7 +15,7 @@ public class ObjectIsNull {
|
||||
assertThat(new Object()).as("foo").isNotEqualTo(null).as("bar").isEqualTo(new Object()).as("etc").isEqualTo(null);
|
||||
assertThat(new Object()).as("foo").isEqualTo(null).as("bar").isEqualTo(new Object()).as("etc").isNotEqualTo(null);
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat("foo", null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,6 +1,9 @@
|
||||
import java.util.ArrayList;
|
||||
import java.util.HashMap;
|
||||
import java.util.Map;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class Size {
|
||||
|
||||
@@ -11,6 +14,8 @@ public class Size {
|
||||
long[] otherArray = new long[4];
|
||||
String string = "string";
|
||||
StringBuilder stringBuilder = new StringBuilder();
|
||||
Map<String, Integer> map = new HashMap<>();
|
||||
Map<String, Integer> otherMap = new HashMap<>();
|
||||
|
||||
assertThat(list).isEmpty();
|
||||
assertThat(list).isEmpty();
|
||||
@@ -23,6 +28,7 @@ public class Size {
|
||||
assertThat(list).hasSameSizeAs(array);
|
||||
assertThat(list).hasSize(string.length());
|
||||
assertThat(list).hasSize(stringBuilder.length());
|
||||
assertThat(list).hasSameSizeAs(map);
|
||||
assertThat(list).hasSize(1);
|
||||
assertThat(list).hasSizeGreaterThan(otherList.size() * 2);
|
||||
assertThat(list).hasSizeGreaterThanOrEqualTo(otherList.size() * 2);
|
||||
@@ -32,6 +38,7 @@ public class Size {
|
||||
assertThat(list).hasSameSizeAs(array);
|
||||
assertThat(list).hasSize(string.length());
|
||||
assertThat(list).hasSize(stringBuilder.length());
|
||||
assertThat(list).hasSameSizeAs(map);
|
||||
|
||||
assertThat(array).isEmpty();
|
||||
assertThat(array).isEmpty();
|
||||
@@ -44,6 +51,7 @@ public class Size {
|
||||
assertThat(array).hasSameSizeAs(otherArray);
|
||||
assertThat(array).hasSize(string.length());
|
||||
assertThat(array).hasSize(stringBuilder.length());
|
||||
assertThat(array).hasSameSizeAs(map);
|
||||
assertThat(array).hasSize(1);
|
||||
assertThat(array).hasSizeGreaterThan(otherArray.length - 1);
|
||||
assertThat(array).hasSizeGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
@@ -53,6 +61,7 @@ public class Size {
|
||||
assertThat(array).hasSameSizeAs(otherArray);
|
||||
assertThat(array).hasSize(string.length());
|
||||
assertThat(array).hasSize(stringBuilder.length());
|
||||
assertThat(array).hasSameSizeAs(map);
|
||||
|
||||
assertThat(string).isEmpty();
|
||||
assertThat(string).isEmpty();
|
||||
@@ -62,18 +71,20 @@ public class Size {
|
||||
assertThat(string).isEmpty();
|
||||
assertThat(string).isEmpty();
|
||||
assertThat(string).hasSameSizeAs(list);
|
||||
assertThat(string).hasSameSizeAs(otherArray);
|
||||
assertThat(string).hasSameSizeAs(string);
|
||||
assertThat(string).hasSameSizeAs(stringBuilder);
|
||||
assertThat(string).hasSize(1);
|
||||
assertThat(string).hasSizeGreaterThan(otherArray.length - 1);
|
||||
assertThat(string).hasSizeGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
assertThat(string).hasSizeLessThan(otherArray.length - 3);
|
||||
assertThat(string).hasSizeLessThanOrEqualTo(1 - otherArray.length);
|
||||
assertThat(string).hasSameSizeAs(otherList);
|
||||
assertThat(string).hasSameSizeAs(array);
|
||||
assertThat(string).hasSameSizeAs(string);
|
||||
assertThat(string).hasSameSizeAs(stringBuilder);
|
||||
assertThat(string).hasSameSizeAs(map);
|
||||
assertThat(string).hasSize(1);
|
||||
assertThat(string).hasSizeGreaterThan(array.length - 1);
|
||||
assertThat(string).hasSizeGreaterThanOrEqualTo(array.length + 1);
|
||||
assertThat(string).hasSizeLessThan(array.length - 3);
|
||||
assertThat(string).hasSizeLessThanOrEqualTo(1 - array.length);
|
||||
assertThat(string).hasSameSizeAs(list);
|
||||
assertThat(string).hasSameSizeAs(array);
|
||||
assertThat(string).hasSameSizeAs(string);
|
||||
assertThat(string).hasSameSizeAs(stringBuilder);
|
||||
assertThat(string).hasSameSizeAs(map);
|
||||
|
||||
assertThat(stringBuilder).isEmpty();
|
||||
assertThat(stringBuilder).isEmpty();
|
||||
@@ -83,18 +94,43 @@ public class Size {
|
||||
assertThat(stringBuilder).isEmpty();
|
||||
assertThat(stringBuilder).isEmpty();
|
||||
assertThat(stringBuilder).hasSameSizeAs(list);
|
||||
assertThat(stringBuilder).hasSameSizeAs(otherArray);
|
||||
assertThat(stringBuilder).hasSameSizeAs(string);
|
||||
assertThat(stringBuilder).hasSameSizeAs(stringBuilder);
|
||||
assertThat(stringBuilder).hasSize(1);
|
||||
assertThat(stringBuilder).hasSizeGreaterThan(otherArray.length - 1);
|
||||
assertThat(stringBuilder).hasSizeGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
assertThat(stringBuilder).hasSizeLessThan(otherArray.length - 3);
|
||||
assertThat(stringBuilder).hasSizeLessThanOrEqualTo(1 - otherArray.length);
|
||||
assertThat(stringBuilder).hasSameSizeAs(otherList);
|
||||
assertThat(stringBuilder).hasSameSizeAs(array);
|
||||
assertThat(stringBuilder).hasSameSizeAs(string);
|
||||
assertThat(stringBuilder).hasSameSizeAs(stringBuilder);
|
||||
assertThat(stringBuilder).hasSameSizeAs(map);
|
||||
assertThat(stringBuilder).hasSize(1);
|
||||
assertThat(stringBuilder).hasSizeGreaterThan(array.length - 1);
|
||||
assertThat(stringBuilder).hasSizeGreaterThanOrEqualTo(array.length + 1);
|
||||
assertThat(stringBuilder).hasSizeLessThan(array.length - 3);
|
||||
assertThat(stringBuilder).hasSizeLessThanOrEqualTo(1 - array.length);
|
||||
assertThat(stringBuilder).hasSameSizeAs(list);
|
||||
assertThat(stringBuilder).hasSameSizeAs(array);
|
||||
assertThat(stringBuilder).hasSameSizeAs(string);
|
||||
assertThat(stringBuilder).hasSameSizeAs(stringBuilder);
|
||||
assertThat(stringBuilder).hasSameSizeAs(map);
|
||||
|
||||
assertThat(map).isEmpty();
|
||||
assertThat(map).isEmpty();
|
||||
assertThat(map).isNotEmpty();
|
||||
assertThat(map).as("hi").isNotEmpty();
|
||||
assertThat(map).isNotEmpty();
|
||||
assertThat(map).isEmpty();
|
||||
assertThat(map).isEmpty();
|
||||
assertThat(map).hasSameSizeAs(list);
|
||||
assertThat(map).hasSameSizeAs(array);
|
||||
assertThat(map).hasSize(string.length());
|
||||
assertThat(map).hasSize(stringBuilder.length());
|
||||
assertThat(map).hasSameSizeAs(otherMap);
|
||||
assertThat(map).hasSize(1);
|
||||
assertThat(map).hasSizeGreaterThan(array.length - 1);
|
||||
assertThat(map).hasSizeGreaterThanOrEqualTo(array.length + 1);
|
||||
assertThat(map).hasSizeLessThan(array.length - 3);
|
||||
assertThat(map).hasSizeLessThanOrEqualTo(1 - array.length);
|
||||
assertThat(map).hasSameSizeAs(list);
|
||||
assertThat(map).hasSameSizeAs(array);
|
||||
assertThat(map).hasSize(string.length());
|
||||
assertThat(map).hasSize(stringBuilder.length());
|
||||
assertThat(map).hasSameSizeAs(otherMap);
|
||||
|
||||
assertThat(stringBuilder.length()).as("foo").isEqualTo(0).isZero().as("bar").isNotZero().isEqualTo(10);
|
||||
|
||||
@@ -104,7 +140,7 @@ public class Size {
|
||||
assertThat(foo).isEqualTo(0);
|
||||
assertThat(string.length()).isPositive();
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(string, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,6 +1,9 @@
|
||||
import java.util.ArrayList;
|
||||
import java.util.HashMap;
|
||||
import java.util.Map;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class Size {
|
||||
|
||||
@@ -11,6 +14,8 @@ public class Size {
|
||||
long[] otherArray = new long[4];
|
||||
String string = "string";
|
||||
StringBuilder stringBuilder = new StringBuilder();
|
||||
Map<String, Integer> map = new HashMap<>();
|
||||
Map<String, Integer> otherMap = new HashMap<>();
|
||||
|
||||
assertThat(list.size()).isEqualTo(0);
|
||||
assertThat(list.size()).isZero();
|
||||
@@ -23,6 +28,7 @@ public class Size {
|
||||
assertThat(list.size()).isEqualTo(array.length);
|
||||
assertThat(list.size()).isEqualTo(string.length());
|
||||
assertThat(list.size()).isEqualTo(stringBuilder.length());
|
||||
assertThat(list.size()).isEqualTo(map.size());
|
||||
assertThat(list.size()).isEqualTo(1);
|
||||
assertThat(list.size()).isGreaterThan(otherList.size() * 2);
|
||||
assertThat(list.size()).isGreaterThanOrEqualTo(otherList.size() * 2);
|
||||
@@ -32,6 +38,7 @@ public class Size {
|
||||
assertThat(list).hasSize(array.length);
|
||||
assertThat(list).hasSize(string.length());
|
||||
assertThat(list).hasSize(stringBuilder.length());
|
||||
assertThat(list).hasSize(map.size());
|
||||
|
||||
assertThat(array.length).isEqualTo(0);
|
||||
assertThat(array.length).isZero();
|
||||
@@ -44,6 +51,7 @@ public class Size {
|
||||
assertThat(array.length).isEqualTo(otherArray.length);
|
||||
assertThat(array.length).isEqualTo(string.length());
|
||||
assertThat(array.length).isEqualTo(stringBuilder.length());
|
||||
assertThat(array.length).isEqualTo(map.size());
|
||||
assertThat(array.length).isEqualTo(1);
|
||||
assertThat(array.length).isGreaterThan(otherArray.length - 1);
|
||||
assertThat(array.length).isGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
@@ -53,6 +61,7 @@ public class Size {
|
||||
assertThat(array).hasSize(otherArray.length);
|
||||
assertThat(array).hasSize(string.length());
|
||||
assertThat(array).hasSize(stringBuilder.length());
|
||||
assertThat(array).hasSize(map.size());
|
||||
|
||||
assertThat(string.length()).isEqualTo(0);
|
||||
assertThat(string.length()).isZero();
|
||||
@@ -62,18 +71,20 @@ public class Size {
|
||||
assertThat(string.length()).isLessThan(1);
|
||||
assertThat(string.length()).isLessThanOrEqualTo(0);
|
||||
assertThat(string.length()).isEqualTo(list.size());
|
||||
assertThat(string.length()).isEqualTo(otherArray.length);
|
||||
assertThat(string.length()).isEqualTo(array.length);
|
||||
assertThat(string.length()).isEqualTo(string.length());
|
||||
assertThat(string.length()).isEqualTo(stringBuilder.length());
|
||||
assertThat(string.length()).isEqualTo(map.size());
|
||||
assertThat(string.length()).isEqualTo(1);
|
||||
assertThat(string.length()).isGreaterThan(otherArray.length - 1);
|
||||
assertThat(string.length()).isGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
assertThat(string.length()).isLessThan(otherArray.length - 3);
|
||||
assertThat(string.length()).isLessThanOrEqualTo(1 - otherArray.length);
|
||||
assertThat(string).hasSize(otherList.size());
|
||||
assertThat(string.length()).isGreaterThan(array.length - 1);
|
||||
assertThat(string.length()).isGreaterThanOrEqualTo(array.length + 1);
|
||||
assertThat(string.length()).isLessThan(array.length - 3);
|
||||
assertThat(string.length()).isLessThanOrEqualTo(1 - array.length);
|
||||
assertThat(string).hasSize(list.size());
|
||||
assertThat(string).hasSize(array.length);
|
||||
assertThat(string).hasSize(string.length());
|
||||
assertThat(string).hasSize(stringBuilder.length());
|
||||
assertThat(string).hasSize(map.size());
|
||||
|
||||
assertThat(stringBuilder.length()).isEqualTo(0);
|
||||
assertThat(stringBuilder.length()).isZero();
|
||||
@@ -83,18 +94,43 @@ public class Size {
|
||||
assertThat(stringBuilder.length()).isLessThan(1);
|
||||
assertThat(stringBuilder.length()).isLessThanOrEqualTo(0);
|
||||
assertThat(stringBuilder.length()).isEqualTo(list.size());
|
||||
assertThat(stringBuilder.length()).isEqualTo(otherArray.length);
|
||||
assertThat(stringBuilder.length()).isEqualTo(array.length);
|
||||
assertThat(stringBuilder.length()).isEqualTo(string.length());
|
||||
assertThat(stringBuilder.length()).isEqualTo(stringBuilder.length());
|
||||
assertThat(stringBuilder.length()).isEqualTo(map.size());
|
||||
assertThat(stringBuilder.length()).isEqualTo(1);
|
||||
assertThat(stringBuilder.length()).isGreaterThan(otherArray.length - 1);
|
||||
assertThat(stringBuilder.length()).isGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
assertThat(stringBuilder.length()).isLessThan(otherArray.length - 3);
|
||||
assertThat(stringBuilder.length()).isLessThanOrEqualTo(1 - otherArray.length);
|
||||
assertThat(stringBuilder).hasSize(otherList.size());
|
||||
assertThat(stringBuilder.length()).isGreaterThan(array.length - 1);
|
||||
assertThat(stringBuilder.length()).isGreaterThanOrEqualTo(array.length + 1);
|
||||
assertThat(stringBuilder.length()).isLessThan(array.length - 3);
|
||||
assertThat(stringBuilder.length()).isLessThanOrEqualTo(1 - array.length);
|
||||
assertThat(stringBuilder).hasSize(list.size());
|
||||
assertThat(stringBuilder).hasSize(array.length);
|
||||
assertThat(stringBuilder).hasSize(string.length());
|
||||
assertThat(stringBuilder).hasSize(stringBuilder.length());
|
||||
assertThat(stringBuilder).hasSize(map.size());
|
||||
|
||||
assertThat(map.size()).isEqualTo(0);
|
||||
assertThat(map.size()).isZero();
|
||||
assertThat(map.size()).isNotZero();
|
||||
assertThat(map.size()).as("hi").isGreaterThan(0);
|
||||
assertThat(map.size()).isGreaterThanOrEqualTo(1);
|
||||
assertThat(map.size()).isLessThan(1);
|
||||
assertThat(map.size()).isLessThanOrEqualTo(0);
|
||||
assertThat(map.size()).isEqualTo(list.size());
|
||||
assertThat(map.size()).isEqualTo(array.length);
|
||||
assertThat(map.size()).isEqualTo(string.length());
|
||||
assertThat(map.size()).isEqualTo(stringBuilder.length());
|
||||
assertThat(map.size()).isEqualTo(otherMap.size());
|
||||
assertThat(map.size()).isEqualTo(1);
|
||||
assertThat(map.size()).isGreaterThan(array.length - 1);
|
||||
assertThat(map.size()).isGreaterThanOrEqualTo(array.length + 1);
|
||||
assertThat(map.size()).isLessThan(array.length - 3);
|
||||
assertThat(map.size()).isLessThanOrEqualTo(1 - array.length);
|
||||
assertThat(map).hasSize(list.size());
|
||||
assertThat(map).hasSize(array.length);
|
||||
assertThat(map).hasSize(string.length());
|
||||
assertThat(map).hasSize(stringBuilder.length());
|
||||
assertThat(map).hasSize(otherMap.size());
|
||||
|
||||
assertThat(stringBuilder.length()).as("foo").isEqualTo(0).isZero().as("bar").isNotZero().isEqualTo(10);
|
||||
|
||||
@@ -104,7 +140,7 @@ public class Size {
|
||||
assertThat(foo).isEqualTo(0);
|
||||
assertThat(string.length()).isPositive();
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(string, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class StringExpression {
|
||||
|
||||
@@ -50,7 +51,7 @@ public class StringExpression {
|
||||
assertThat(string.endsWith("foo")).as("foo").isEqualTo(false).as("bar").isTrue();
|
||||
assertThat(string.endsWith("foo")).as("foo").satisfies(it -> it.booleanValue()).as("bar").isFalse();
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(string, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class StringExpression {
|
||||
|
||||
@@ -50,7 +51,7 @@ public class StringExpression {
|
||||
assertThat(string.endsWith("foo")).as("foo").isEqualTo(false).as("bar").isTrue();
|
||||
assertThat(string.endsWith("foo")).as("foo").satisfies(it -> it.booleanValue()).as("bar").isFalse();
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(string, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class StringIsEmpty {
|
||||
|
||||
@@ -19,7 +20,7 @@ public class StringIsEmpty {
|
||||
assertThat(string).as("foo").isEqualTo("").as("bar").hasSize(0).hasSameSizeAs("foo").isEmpty();
|
||||
assertThat(string).as("foo").isEqualTo("").as("bar").hasSize(0).hasSameSizeAs("foo").isEmpty();
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(string, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class StringIsEmpty {
|
||||
|
||||
@@ -19,7 +20,7 @@ public class StringIsEmpty {
|
||||
assertThat(string).as("foo").isEqualTo("").as("bar").hasSize(0).hasSameSizeAs("foo").isEqualTo("");
|
||||
assertThat(string).as("foo").isEqualTo("").as("bar").hasSize(0).hasSameSizeAs("foo").hasSize(0);
|
||||
|
||||
org.junit.Assert.assertThat(foo, null);
|
||||
org.junit.Assert.assertThat(string, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user