Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
2f0d855d1e | ||
|
|
6dab8ad552 | ||
|
|
1983750077 | ||
|
|
a0ed4eab76 | ||
|
|
acc81863f5 | ||
|
|
2b97494c17 | ||
|
|
e3444db213 | ||
|
|
855fb03f7c | ||
|
|
8d678411b5 |
@@ -189,12 +189,39 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
|
||||
from: assertThat(stringActual.endsWith(stringExpected)).isTrue();
|
||||
to: assertThat(stringActual).endsWith(stringExpected);
|
||||
|
||||
from: assertThat(stringActual.matches(stringExpected)).isTrue();
|
||||
to: assertThat(stringActual).matches(stringExpected);
|
||||
```
|
||||
Analogously with ```isFalse()```.
|
||||
|
||||
More funny stuff (excerpt):
|
||||
|
||||
```
|
||||
from: assertThat(stringActual.compareToIgnoreCase(stringExpected)).isEqualTo(0);
|
||||
to: assertThat(stringActual).isEqualToIgnoringCase(stringExpected);
|
||||
|
||||
from: assertThat(stringActual.indexOf(stringExpected)).isEqualTo(0);
|
||||
from: assertThat(stringActual.indexOf(stringExpected)).isZero();
|
||||
to: assertThat(stringActual).startsWith(stringExpected);
|
||||
|
||||
from: assertThat(stringActual.indexOf(stringExpected)).isNotZero();
|
||||
to: assertThat(stringActual).doesNotStartWith(stringExpected);
|
||||
|
||||
from: assertThat(stringActual.indexOf(stringExpected)).isEqualTo(-1);
|
||||
from: assertThat(stringActual.indexOf(stringExpected)).isNegative();
|
||||
to: assertThat(stringActual).doesNotContain(stringExpected);
|
||||
|
||||
from: assertThat(stringActual.indexOf(stringExpected)).isGreaterThanOrEqualTo(0);
|
||||
to: assertThat(stringActual).contains(stringExpected);
|
||||
|
||||
from: assertThat(stringActual.trim()).isNotEmpty();
|
||||
to: assertThat(stringActual).isNotBlank();
|
||||
```
|
||||
|
||||
- AssertThatObjectExpression
|
||||
|
||||
Handles equals(), toString() and hashCode() inside an expected expression.
|
||||
Handles ```equals()```, ```toString()``` and ```hashCode()``` inside an expected expression.
|
||||
|
||||
```
|
||||
from: assertThat(objActual.equals(objExpected)).isTrue();
|
||||
@@ -209,7 +236,7 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
|
||||
- AssertThatCollectionOrMapExpression
|
||||
|
||||
Moves collection and map operations inside ```assertThat()``` out.
|
||||
Moves ```Collection``` and ```Map``` operations inside ```assertThat()``` out.
|
||||
|
||||
```
|
||||
from: assertThat(collection.isEmpty()).isTrue();
|
||||
@@ -232,7 +259,7 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
```
|
||||
Analogously with ```isFalse()``` (except for ```containsAll()```).
|
||||
|
||||
Additional transformations for maps:
|
||||
Additional transformations for ```Map``` instances:
|
||||
|
||||
```
|
||||
from: assertThat(map.get(key)).isEqualTo(value);
|
||||
@@ -247,6 +274,64 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
from: assertThat(map.get(key)).isNull();
|
||||
to: assertThat(map).doesNotContainKey(key);
|
||||
```
|
||||
|
||||
The last transformation is the default, but may not be 100% equivalent depending whether the map
|
||||
is a degenerated case with ```null``` values, where ```map.get(key)``` returns ```null```,
|
||||
but ```containsKey(key)``` is ```true```.
|
||||
For that special case (which usually is the result of a bad design decision!)
|
||||
the quickfix should rather generate ```assertThat(map).containsEntry(key, null)```.
|
||||
Therefore, the behavior can be configured in the settings for this inspection to either
|
||||
create the default case (```doesNotContainKey```), the degenerated case (```containsEntry```),
|
||||
choosing between both fixes (does not work well for batch processing), or ignore this edge case
|
||||
altogether (just to be sure to not break any code).
|
||||
|
||||
- AssertThatFileExpression
|
||||
|
||||
Moves ```File``` method calls inside ```assertThat()``` out.
|
||||
|
||||
```
|
||||
from: assertThat(file.canRead()).isTrue();
|
||||
to: assertThat(file).canRead();
|
||||
|
||||
from: assertThat(file.canWrite()).isTrue();
|
||||
to: assertThat(file).canWrite();
|
||||
|
||||
from: assertThat(file.exists()).isTrue();
|
||||
to: assertThat(file).exists();
|
||||
|
||||
from: assertThat(file.exists()).isFalse();
|
||||
to: assertThat(file).doesNotExist();
|
||||
|
||||
from: assertThat(file.isAbsolute()).isTrue();
|
||||
to: assertThat(file).isAbsolute();
|
||||
|
||||
from: assertThat(file.isAbsolute()).isFalse();
|
||||
to: assertThat(file).isRelative();
|
||||
|
||||
from: assertThat(file.isDirectory()).isTrue();
|
||||
to: assertThat(file).isDirectory();
|
||||
|
||||
from: assertThat(file.isFile()).isTrue();
|
||||
to: assertThat(file).isFile();
|
||||
|
||||
from: assertThat(file.getName()).isEqualTo(filename);
|
||||
to: assertThat(file).hasName(filename);
|
||||
|
||||
from: assertThat(file.getParent()).isEqualTo(pathname);
|
||||
to: assertThat(file).hasParent(pathname);
|
||||
|
||||
from: assertThat(file.getParent()).isNull();
|
||||
from: assertThat(file.getParentFile()).isNull();
|
||||
to: assertThat(file).hasNoParent();
|
||||
|
||||
from: assertThat(file.list()).isEmpty();
|
||||
from: assertThat(file.listFiles()).isEmpty();
|
||||
to: assertThat(file).isEmptyDirectory();
|
||||
|
||||
from: assertThat(file.list()).isNotEmpty();
|
||||
from: assertThat(file.listFiles()).isNotEmpty();
|
||||
to: assertThat(file).isNotEmptyDirectory();
|
||||
```
|
||||
|
||||
- AssertThatEnumerableIsEmpty
|
||||
|
||||
@@ -259,8 +344,8 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
|
||||
- AssertThatSize
|
||||
|
||||
Makes assertions on sizes of arrays, collections, maps, strings,
|
||||
or ```CharSequence```s more concise.
|
||||
Makes assertions on sizes on ```Array```, ```Collection```,
|
||||
```Map```, ```String```, or ```CharSequence``` instances more concise.
|
||||
|
||||
```
|
||||
from: assertThat(array.length).isEqualTo(0);
|
||||
@@ -296,14 +381,15 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
from: assertThat(array.length).isGreaterThanOrEqualTo(expression);
|
||||
to: assertThat(array).hasSizeGreaterThanOrEqualTo(expression);
|
||||
```
|
||||
and analogously for collections, maps, strings and CharSequences, e.g:
|
||||
and analogously for ```Collection```, ```Map```, ```String``` and
|
||||
```CharSequence``` objects, e.g:
|
||||
|
||||
```
|
||||
from: assertThat("string".length()).isLessThan(1);
|
||||
to: assertThat("string").isEmpty();
|
||||
|
||||
from: assertThat("string".length()).isEqualTo(map.size())
|
||||
to: assertThat("string").hasSameSizeAs(map);
|
||||
from: assertThat(map.size()).isEqualTo(anotherMap.size())
|
||||
to: assertThat(map).hasSameSizeAs(anotherMap);
|
||||
|
||||
from: assertThat("string".length()).hasSize("strong".length())
|
||||
to: assertThat("string").hasSameSizeAs("strong");
|
||||
@@ -423,7 +509,7 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
to: assertThat(opt).isPresent();
|
||||
```
|
||||
|
||||
AssertJ for Guava needs to be available in the classpath.
|
||||
AssertJ for Guava needs to be available in the classpath for this inspection to work.
|
||||
|
||||
- AssumeThatInsteadOfReturn
|
||||
|
||||
@@ -516,6 +602,8 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
|
||||
### Implemented referencing
|
||||
|
||||
You can ctrl-click on references inside .extracting() method parameters to go the
|
||||
referencing method definition.
|
||||
```
|
||||
.extracting("field")
|
||||
.extracting("outerField.fieldInsideObjectTypeOfOuterField.andSoOn")
|
||||
@@ -529,7 +617,7 @@ You can toggle the various inspections in the Settings/Editor/Inspections in the
|
||||
.flatExtracting(Extractors.byName("fieldOrPropertyOrBareMethod.orAPathLikeAbove")
|
||||
.flatExtracting(Extractors.resultOf("bareMethod")
|
||||
```
|
||||
Works on both POJOs and ```Iterable```s/```Array```s.
|
||||
This works on both POJOs and ```Iterable```s/```Array```s.
|
||||
Implementation is very basic though and does not work with fancy cascaded ```.extracting()``` sequences.
|
||||
If there's demand, I could add it.
|
||||
|
||||
@@ -542,10 +630,10 @@ The IntelliJ framework actually uses the JUnit 3 TestCase for plugin testing and
|
||||
Feel free to use the code (in package ```de.platon42.intellij.jupiter```) for your projects (with attribution).
|
||||
|
||||
## Planned features
|
||||
- More Optional fixes such as opt1.get() == opt2.get() etc.
|
||||
- More moving out of methods for File, Path, LocalDate/Time etc.
|
||||
- More Optional fixes such as ```opt1.get() == opt2.get()``` etc.
|
||||
- More moving out of methods for Path, LocalDate/Time etc.
|
||||
- Converting ```foo.compareTo(bar) == 0``` to ```isEqualTo()``` (yes, I've *really* seen code like that)
|
||||
- Extraction with property names to lambda with Java 8
|
||||
- Extraction with property names to lambda/method reference with Java 8
|
||||
|
||||
```
|
||||
from: assertThat(object).extracting("propOne", "propNoGetter", "propTwo.innerProp")...
|
||||
@@ -554,10 +642,30 @@ Feel free to use the code (in package ```de.platon42.intellij.jupiter```) for yo
|
||||
|
||||
## Changelog
|
||||
|
||||
#### V1.6 (30-Sep-19)
|
||||
- Really fixed AssertThatGuavaOptional inspections to avoid conversions from ```.get()``` to ```.contains()```
|
||||
for array types. Sigh. Shouldn't be working >12h a day and then do some more stuff at home.
|
||||
- Fixed a bug in AssertThatBinaryExpression inspection for ```assertThat(null != expression)``` and related
|
||||
that would not correctly invert the condition on transformation.
|
||||
- Added new AssertThatFileExpression to move out many common methods from inside the
|
||||
```assertThat()``` expression (```exists(), getName(), getParent()```, and many more).
|
||||
- Added several transformations to AssertThatStringExpression inspection.
|
||||
Specifically, uses of ```matches()```, ```compareToIgnoreCase()```, ```indexOf()```, and ```trim()```.
|
||||
|
||||
#### V1.5 (24-Sep-19)
|
||||
- Fix for AssertThatCollectionOrMap inspection sometimes causing an index out of bounds exception.
|
||||
- AssertThatGuavaOptional inspections will now avoid conversions from ```.get()``` to ```.contains()```
|
||||
for array types (currently not correctly supported by ```contains()``` in AssertJ-Guava).
|
||||
- Added an settings option for AssertThatCollectionOrMap inspection respecting the degenerated case of maps with ```null``` values.
|
||||
It is now possible to change the behavior for ```map.get(key) == null```, so it can offer either ```.doesNotContainKey()``` (default)
|
||||
or ```.containsEntry(key, null)```, or even both.
|
||||
- Fixes to AssertThatSize inspection after extending it for Maps in previous release as not all
|
||||
combinations for ```.hasSameSizeAs()``` are supported.
|
||||
|
||||
#### V1.4 (25-Aug-19)
|
||||
- Minor fix for highlighting of JoinVarArgsContains inspection.
|
||||
- Extended AssertThatSize inspection to Maps, too.
|
||||
- Extended AssertThatCollectionOrMap inspection for several ```assertThat(map.get())``` cases as suggested by Stefan H.
|
||||
- Extended AssertThatCollectionOrMap inspection for several ```assertThat(map.get())``` cases as suggested by Georgij G.
|
||||
|
||||
#### V1.3 (03-Aug-19)
|
||||
- New JoinVarArgsContains inspection that will detect multiple ```.contains()```, ```.doesNotContain()```,
|
||||
|
||||
+13
-8
@@ -7,7 +7,7 @@ plugins {
|
||||
}
|
||||
|
||||
group 'de.platon42'
|
||||
version '1.4'
|
||||
version '1.6'
|
||||
|
||||
repositories {
|
||||
mavenCentral()
|
||||
@@ -22,8 +22,8 @@ dependencies {
|
||||
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8"
|
||||
testCompile "org.assertj:assertj-core:3.13.2"
|
||||
testCompile "org.assertj:assertj-guava:3.2.1"
|
||||
testImplementation 'org.junit.jupiter:junit-jupiter-api:5.5.1'
|
||||
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.5.1'
|
||||
testImplementation 'org.junit.jupiter:junit-jupiter-api:5.5.2'
|
||||
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.5.2'
|
||||
testImplementation "org.jetbrains.kotlin:kotlin-test"
|
||||
// testImplementation "org.jetbrains.kotlin:kotlin-test-junit"
|
||||
}
|
||||
@@ -35,7 +35,7 @@ compileTestKotlin {
|
||||
kotlinOptions.jvmTarget = "1.8"
|
||||
}
|
||||
intellij {
|
||||
version '2019.2.1'
|
||||
version '2019.2.3'
|
||||
// pluginName 'Concise AssertJ Optimizing Nitpicker (Cajon)'
|
||||
updateSinceUntilBuild false
|
||||
plugins = ['java']
|
||||
@@ -43,11 +43,16 @@ intellij {
|
||||
|
||||
patchPluginXml {
|
||||
changeNotes """
|
||||
<h4>V1.4 (25-Aug-19)</h4>
|
||||
<h4>V1.6 (30-Sep-19)</h4>
|
||||
<ul>
|
||||
<li>Minor fix for highlighting of JoinVarArgsContains inspection.
|
||||
<li>Extended AssertThatSize inspection to Maps, too.
|
||||
<li>Extended AssertThatCollectionOrMap inspection for several assertThat(map.get()) cases as suggested by Stefan H.
|
||||
<li>Really fixed AssertThatGuavaOptional inspections to avoid conversions from .get() to .contains()
|
||||
for array types. Sigh. Shouldn't be working >12h a day and then do some more stuff at home.
|
||||
<li>Fixed a bug in AssertThatBinaryExpression inspection for assertThat(null != expression) and related
|
||||
that would not correctly invert the condition on transformation.
|
||||
<li>Added new AssertThatFileExpression to move out many common methods from inside the
|
||||
assertThat() expression (exists(), getName(), getParent() and many more).
|
||||
<li>Added several transformations to AssertThatStringExpression inspection.
|
||||
Specifically, uses of matches(), compareToIgnoreCase(), indexOf(), and trim().
|
||||
</ul>
|
||||
<p>Full changelog available at <a href="https://github.com/chrisly42/cajon-plugin#changelog">Github project site</a>.</p>
|
||||
"""
|
||||
|
||||
@@ -42,6 +42,10 @@ class AssertJClassNames {
|
||||
@NonNls
|
||||
const val ABSTRACT_CHAR_SEQUENCE_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractCharSequenceAssert"
|
||||
@NonNls
|
||||
const val ABSTRACT_MAP_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractMapAssert"
|
||||
@NonNls
|
||||
const val ABSTRACT_OBJECT_ARRAY_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractObjectArrayAssert"
|
||||
@NonNls
|
||||
const val ABSTRACT_ITERABLE_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractIterableAssert"
|
||||
@NonNls
|
||||
const val ABSTRACT_OPTIONAL_ASSERT_CLASSNAME = "org.assertj.core.api.AbstractOptionalAssert"
|
||||
|
||||
@@ -102,6 +102,10 @@ class MethodNames {
|
||||
@NonNls
|
||||
const val DOES_NOT_CONTAIN_VALUE = "doesNotContainValue"
|
||||
@NonNls
|
||||
const val CONTAINS_ENTRY = "containsEntry"
|
||||
@NonNls
|
||||
const val DOES_NOT_CONTAIN_ENTRY = "doesNotContainEntry"
|
||||
@NonNls
|
||||
const val IS_EQUAL_TO_IC = "isEqualToIgnoringCase"
|
||||
@NonNls
|
||||
const val IS_NOT_EQUAL_TO_IC = "isNotEqualToIgnoringCase"
|
||||
|
||||
+25
-1
@@ -25,7 +25,7 @@ import de.platon42.intellij.plugins.cajon.MethodNames
|
||||
import de.platon42.intellij.plugins.cajon.qualifierExpression
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.ReplaceSimpleMethodCallQuickFix
|
||||
|
||||
open class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
abstract class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
|
||||
companion object {
|
||||
const val SIMPLIFY_MESSAGE_TEMPLATE = "%s() can be simplified to %s()"
|
||||
@@ -120,6 +120,8 @@ open class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
val IS_NOT_NULL = CallMatcher.instanceCall(ASSERT_INTERFACE, MethodNames.IS_NOT_NULL)
|
||||
.parameterCount(0)!!
|
||||
|
||||
val IS_EMPTY = CallMatcher.instanceCall(ENUMERABLE_ASSERT_INTERFACE, MethodNames.IS_EMPTY)
|
||||
.parameterCount(0)!!
|
||||
val IS_NOT_EMPTY = CallMatcher.instanceCall(ENUMERABLE_ASSERT_INTERFACE, MethodNames.IS_NOT_EMPTY)
|
||||
.parameterCount(0)!!
|
||||
val HAS_SIZE = CallMatcher.instanceCall(ENUMERABLE_ASSERT_INTERFACE, MethodNames.HAS_SIZE)
|
||||
@@ -139,6 +141,14 @@ open class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
.parameterCount(0)!!
|
||||
val IS_NOT_ZERO = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, MethodNames.IS_NOT_ZERO)
|
||||
.parameterCount(0)!!
|
||||
val IS_NEGATIVE = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, "isNegative")
|
||||
.parameterCount(0)!!
|
||||
val IS_NOT_NEGATIVE = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, "isNotNegative")
|
||||
.parameterCount(0)!!
|
||||
val IS_POSITIVE = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, "isPositive")
|
||||
.parameterCount(0)!!
|
||||
val IS_NOT_POSITIVE = CallMatcher.instanceCall(ABSTRACT_INTEGER_ASSERT_CLASSNAME, "isNotPositive")
|
||||
.parameterCount(0)!!
|
||||
|
||||
val IS_TRUE = CallMatcher.instanceCall(ABSTRACT_BOOLEAN_ASSERT_CLASSNAME, MethodNames.IS_TRUE)
|
||||
.parameterCount(0)!!
|
||||
@@ -227,6 +237,20 @@ open class AbstractAssertJInspection : AbstractBaseJavaLocalInspectionTool() {
|
||||
holder.registerProblem(expression, message, quickfix)
|
||||
}
|
||||
|
||||
protected fun registerMoveOutMethod(
|
||||
holder: ProblemsHolder,
|
||||
expression: PsiMethodCallExpression,
|
||||
oldActualExpression: PsiMethodCallExpression,
|
||||
replacementMethod: String,
|
||||
quickFixSupplier: (String) -> List<LocalQuickFix>
|
||||
) {
|
||||
val originalMethod = getOriginalMethodName(oldActualExpression) ?: return
|
||||
val description = MOVE_ACTUAL_EXPRESSION_DESCRIPTION_TEMPLATE.format(originalMethod, replacementMethod)
|
||||
val message = MOVING_OUT_MESSAGE_TEMPLATE.format(originalMethod)
|
||||
val quickfixes = quickFixSupplier(description)
|
||||
holder.registerProblem(expression, message, *quickfixes.toTypedArray())
|
||||
}
|
||||
|
||||
protected fun registerReplaceMethod(
|
||||
holder: ProblemsHolder,
|
||||
expression: PsiMethodCallExpression,
|
||||
|
||||
+62
@@ -0,0 +1,62 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.PsiExpressionStatement
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.MoveOutMethodCallExpressionQuickFix
|
||||
|
||||
abstract class AbstractMoveOutInspection : AbstractAssertJInspection() {
|
||||
|
||||
protected fun createInspectionsForMappings(
|
||||
statement: PsiExpressionStatement,
|
||||
holder: ProblemsHolder,
|
||||
mappings: List<MoveOutMapping>
|
||||
) {
|
||||
if (!statement.hasAssertThat()) return
|
||||
|
||||
val staticMethodCall = statement.findStaticMethodCall() ?: return
|
||||
|
||||
val assertThatArgument = staticMethodCall.getArgOrNull(0) as? PsiMethodCallExpression ?: return
|
||||
val expectedCallExpression = statement.findOutmostMethodCall() ?: return
|
||||
|
||||
for (mapping in mappings.filter { it.callMatcher.test(assertThatArgument) }) {
|
||||
if (mapping.expectBoolean && ASSERT_THAT_BOOLEAN.test(staticMethodCall)) {
|
||||
val expectedBooleanResult = expectedCallExpression.getAllTheSameExpectedBooleanConstants() ?: continue
|
||||
if (mapping.additionalCondition?.invoke(statement, expectedCallExpression) == false) continue
|
||||
val replacementMethod = if (expectedBooleanResult) mapping.replacementForTrue else mapping.replacementForFalse ?: return
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, replacementMethod) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method)
|
||||
}
|
||||
} else if (mapping.expectNullNonNull != null) {
|
||||
val expectedNullNonNullResult = expectedCallExpression.getExpectedNullNonNullResult() ?: continue
|
||||
if (mapping.additionalCondition?.invoke(statement, expectedCallExpression) == false) continue
|
||||
val replacementMethod = if (expectedNullNonNullResult xor mapping.expectNullNonNull) mapping.replacementForTrue else mapping.replacementForFalse ?: continue
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, replacementMethod) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method, useNullNonNull = true)
|
||||
}
|
||||
} else if (mapping.expectedMatcher?.test(expectedCallExpression) == true) {
|
||||
if (mapping.additionalCondition?.invoke(statement, expectedCallExpression) == false) continue
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, mapping.replacementForTrue) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(
|
||||
desc, method,
|
||||
replaceOnlyThisMethod = mapping.expectedMatcher,
|
||||
replaceFromOriginalMethod = mapping.replaceFromOriginalMethod
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
class MoveOutMapping(
|
||||
val callMatcher: CallMatcher,
|
||||
val replacementForTrue: String,
|
||||
val replacementForFalse: String? = null,
|
||||
val expectBoolean: Boolean = false,
|
||||
val expectNullNonNull: Boolean? = null,
|
||||
val expectedMatcher: CallMatcher? = null,
|
||||
val replaceFromOriginalMethod: Boolean = false,
|
||||
val additionalCondition: ((PsiExpressionStatement, PsiMethodCallExpression) -> Boolean)? = null
|
||||
)
|
||||
}
|
||||
+7
-1
@@ -38,7 +38,13 @@ class AssertThatBinaryExpressionInspection : AbstractAssertJInspection() {
|
||||
|
||||
if (isLeftNull && isRightNull) return
|
||||
if (isLeftNull || isRightNull) {
|
||||
val replacementMethod = expectedResult.map(MethodNames.IS_NULL, MethodNames.IS_NOT_NULL)
|
||||
val expectedResultOnOp =
|
||||
when (binaryExpression.operationTokenType) {
|
||||
JavaTokenType.EQEQ -> expectedResult
|
||||
JavaTokenType.NE -> !expectedResult
|
||||
else -> return
|
||||
}
|
||||
val replacementMethod = expectedResultOnOp.map(MethodNames.IS_NULL, MethodNames.IS_NOT_NULL)
|
||||
registerSplitMethod(holder, expectedCallExpression, replacementMethod) { desc, method ->
|
||||
SplitBinaryExpressionMethodCallQuickFix(desc, method, pickRightOperand = isLeftNull, noExpectedExpression = true)
|
||||
}
|
||||
|
||||
+86
-38
@@ -1,15 +1,22 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.openapi.ui.ComboBox
|
||||
import com.intellij.psi.*
|
||||
import com.intellij.util.ui.FormBuilder
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.MoveOutMethodCallExpressionQuickFix
|
||||
import java.awt.BorderLayout
|
||||
import javax.swing.JComponent
|
||||
import javax.swing.JPanel
|
||||
|
||||
class AssertThatCollectionOrMapExpressionInspection : AbstractAssertJInspection() {
|
||||
|
||||
class AssertThatCollectionOrMapExpressionInspection : AbstractMoveOutInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Asserting a collection or map specific expression"
|
||||
private const val DEFAULT_MAP_VALUES_NEVER_NULL = 2
|
||||
|
||||
private val MAP_GET_MATCHER = CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_MAP, "get").parameterCount(1)
|
||||
|
||||
@@ -32,34 +39,37 @@ class AssertThatCollectionOrMapExpressionInspection : AbstractAssertJInspection(
|
||||
)
|
||||
|
||||
private val MAPPINGS = listOf(
|
||||
Mapping(
|
||||
MoveOutMapping(
|
||||
CallMatcher.anyOf(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_COLLECTION, "isEmpty").parameterCount(0),
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_MAP, "isEmpty").parameterCount(0)
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_COLLECTION, MethodNames.IS_EMPTY).parameterCount(0),
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_MAP, MethodNames.IS_EMPTY).parameterCount(0)
|
||||
),
|
||||
MethodNames.IS_EMPTY, MethodNames.IS_NOT_EMPTY
|
||||
MethodNames.IS_EMPTY, MethodNames.IS_NOT_EMPTY, expectBoolean = true
|
||||
),
|
||||
Mapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_COLLECTION, "contains").parameterCount(1),
|
||||
MethodNames.CONTAINS, MethodNames.DOES_NOT_CONTAIN
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_COLLECTION, MethodNames.CONTAINS).parameterCount(1),
|
||||
MethodNames.CONTAINS, MethodNames.DOES_NOT_CONTAIN, expectBoolean = true
|
||||
),
|
||||
Mapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_COLLECTION, "containsAll").parameterCount(1),
|
||||
MethodNames.CONTAINS_ALL, null
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_COLLECTION, MethodNames.CONTAINS_ALL).parameterCount(1),
|
||||
MethodNames.CONTAINS_ALL, expectBoolean = true
|
||||
),
|
||||
Mapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_MAP, "containsKey").parameterCount(1),
|
||||
MethodNames.CONTAINS_KEY, MethodNames.DOES_NOT_CONTAIN_KEY
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_MAP, MethodNames.CONTAINS_KEY).parameterCount(1),
|
||||
MethodNames.CONTAINS_KEY, MethodNames.DOES_NOT_CONTAIN_KEY, expectBoolean = true
|
||||
),
|
||||
Mapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_MAP, "containsValue").parameterCount(1),
|
||||
MethodNames.CONTAINS_VALUE, MethodNames.DOES_NOT_CONTAIN_VALUE
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_UTIL_MAP, MethodNames.CONTAINS_VALUE).parameterCount(1),
|
||||
MethodNames.CONTAINS_VALUE, MethodNames.DOES_NOT_CONTAIN_VALUE, expectBoolean = true
|
||||
)
|
||||
)
|
||||
}
|
||||
|
||||
override fun getDisplayName() = DISPLAY_NAME
|
||||
|
||||
@JvmField
|
||||
var behaviorForMapValueEqualsNull: Int = DEFAULT_MAP_VALUES_NEVER_NULL
|
||||
|
||||
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitExpressionStatement(statement: PsiExpressionStatement) {
|
||||
@@ -67,44 +77,82 @@ class AssertThatCollectionOrMapExpressionInspection : AbstractAssertJInspection(
|
||||
if (!statement.hasAssertThat()) return
|
||||
val staticMethodCall = statement.findStaticMethodCall() ?: return
|
||||
|
||||
val assertThatArgument = staticMethodCall.firstArg as? PsiMethodCallExpression ?: return
|
||||
val expectedCallExpression = statement.findOutmostMethodCall() ?: return
|
||||
val assertThatArgument = staticMethodCall.getArgOrNull(0) as? PsiMethodCallExpression ?: return
|
||||
if (MAP_GET_MATCHER.test(assertThatArgument)) {
|
||||
val expectedCallExpression = statement.findOutmostMethodCall() ?: return
|
||||
val nullOrNotNull = expectedCallExpression.getAllTheSameNullNotNullConstants()
|
||||
if (nullOrNotNull != null) {
|
||||
val replacementMethod = nullOrNotNull.map("containsKey", "doesNotContainKey")
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, replacementMethod) { desc, method ->
|
||||
if (nullOrNotNull == true) {
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, MethodNames.CONTAINS_KEY) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method, useNullNonNull = true)
|
||||
}
|
||||
} else if (nullOrNotNull == false) {
|
||||
when (behaviorForMapValueEqualsNull) {
|
||||
1 -> // warning only
|
||||
registerMoveOutMethod(
|
||||
holder,
|
||||
expectedCallExpression,
|
||||
assertThatArgument,
|
||||
""
|
||||
) { _ -> emptyList() }
|
||||
2 -> // as doesNotContainKey(key)
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, MethodNames.DOES_NOT_CONTAIN_KEY) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method, useNullNonNull = true)
|
||||
}
|
||||
3 -> // as containsEntry(key, null)
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, MethodNames.CONTAINS_ENTRY) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method, keepExpectedAsSecondArgument = true, useNullNonNull = true)
|
||||
}
|
||||
4 -> // both
|
||||
registerMoveOutMethod(
|
||||
holder,
|
||||
expectedCallExpression,
|
||||
assertThatArgument,
|
||||
MethodNames.DOES_NOT_CONTAIN_KEY + "/" + MethodNames.CONTAINS_ENTRY
|
||||
) { _ ->
|
||||
listOf(
|
||||
MoveOutMethodCallExpressionQuickFix(
|
||||
"Remove get() of actual expression and use assertThat().doesNotContainKey() instead (regular map)",
|
||||
MethodNames.DOES_NOT_CONTAIN_KEY,
|
||||
useNullNonNull = true
|
||||
),
|
||||
MoveOutMethodCallExpressionQuickFix(
|
||||
"Remove get() of actual expression and use assertThat().containsEntry(key, null) instead (degenerated map)",
|
||||
MethodNames.CONTAINS_ENTRY,
|
||||
keepExpectedAsSecondArgument = true,
|
||||
useNullNonNull = true
|
||||
)
|
||||
)
|
||||
}
|
||||
}
|
||||
} else {
|
||||
if (ANY_IS_EQUAL_TO_MATCHER.test(expectedCallExpression)) {
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, "containsEntry") { desc, method ->
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, MethodNames.CONTAINS_ENTRY) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method, keepExpectedAsSecondArgument = true)
|
||||
}
|
||||
} else if (ANY_IS_NOT_EQUAL_TO_MATCHER.test(expectedCallExpression)) {
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, "doesNotContainEntry") { desc, method ->
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, MethodNames.DOES_NOT_CONTAIN_ENTRY) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method, keepExpectedAsSecondArgument = true)
|
||||
}
|
||||
}
|
||||
}
|
||||
} else {
|
||||
if (!ASSERT_THAT_BOOLEAN.test(staticMethodCall)) return
|
||||
val mapping = MAPPINGS.firstOrNull { it.callMatcher.test(assertThatArgument) } ?: return
|
||||
|
||||
val expectedResult = expectedCallExpression.getAllTheSameExpectedBooleanConstants() ?: return
|
||||
|
||||
val replacementMethod = if (expectedResult) mapping.replacementForTrue else mapping.replacementForFalse ?: return
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, replacementMethod) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method)
|
||||
}
|
||||
createInspectionsForMappings(statement, holder, MAPPINGS)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private class Mapping(
|
||||
val callMatcher: CallMatcher,
|
||||
val replacementForTrue: String,
|
||||
val replacementForFalse: String?
|
||||
)
|
||||
override fun createOptionsPanel(): JComponent {
|
||||
val comboBox = ComboBox(
|
||||
arrayOf("ignore", "warning only, no fixes", "as doesNotContainKey(key)", "as containsEntry(key, null)", "both choices")
|
||||
)
|
||||
comboBox.selectedIndex = behaviorForMapValueEqualsNull
|
||||
comboBox.addActionListener { behaviorForMapValueEqualsNull = comboBox.selectedIndex }
|
||||
val panel = JPanel(BorderLayout())
|
||||
panel.add(
|
||||
FormBuilder.createFormBuilder().addLabeledComponent("Fix get() on maps expecting null values:", comboBox).panel,
|
||||
BorderLayout.NORTH
|
||||
)
|
||||
return panel
|
||||
}
|
||||
}
|
||||
+87
@@ -0,0 +1,87 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.CommonClassNames
|
||||
import com.intellij.psi.JavaElementVisitor
|
||||
import com.intellij.psi.PsiElementVisitor
|
||||
import com.intellij.psi.PsiExpressionStatement
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames
|
||||
import de.platon42.intellij.plugins.cajon.MethodNames
|
||||
|
||||
|
||||
class AssertThatFileExpressionInspection : AbstractMoveOutInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Asserting a file specific expression"
|
||||
|
||||
private val MAPPINGS = listOf(
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "canRead"),
|
||||
"canRead", expectBoolean = true
|
||||
),
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "canWrite"),
|
||||
"canWrite", expectBoolean = true
|
||||
),
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "exists"),
|
||||
"exists", "doesNotExist", expectBoolean = true
|
||||
),
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "isAbsolute"),
|
||||
"isAbsolute", "isRelative", expectBoolean = true
|
||||
),
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "isDirectory"),
|
||||
"isDirectory", expectBoolean = true
|
||||
),
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "isFile"),
|
||||
"isFile", expectBoolean = true
|
||||
),
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "getName"),
|
||||
"hasName",
|
||||
expectedMatcher = CallMatcher.anyOf(IS_EQUAL_TO_OBJECT, IS_EQUAL_TO_STRING)
|
||||
),
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "getParent", "getParentFile"),
|
||||
"hasNoParent", expectNullNonNull = true
|
||||
),
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "getParent"),
|
||||
"hasParent",
|
||||
expectedMatcher = CallMatcher.anyOf(IS_EQUAL_TO_OBJECT, IS_EQUAL_TO_STRING)
|
||||
),
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "getParentFile"),
|
||||
"hasParent",
|
||||
expectedMatcher = IS_EQUAL_TO_OBJECT
|
||||
),
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "list", "listFiles"),
|
||||
"isEmptyDirectory",
|
||||
expectedMatcher = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_OBJECT_ARRAY_ASSERT_CLASSNAME, MethodNames.IS_EMPTY)
|
||||
.parameterCount(0)!!
|
||||
),
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_IO_FILE, "list", "listFiles"),
|
||||
"isNotEmptyDirectory",
|
||||
expectedMatcher = CallMatcher.instanceCall(AssertJClassNames.ABSTRACT_OBJECT_ARRAY_ASSERT_CLASSNAME, MethodNames.IS_NOT_EMPTY)
|
||||
.parameterCount(0)!!
|
||||
)
|
||||
)
|
||||
}
|
||||
|
||||
override fun getDisplayName() = DISPLAY_NAME
|
||||
|
||||
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitExpressionStatement(statement: PsiExpressionStatement) {
|
||||
super.visitExpressionStatement(statement)
|
||||
createInspectionsForMappings(statement, holder, MAPPINGS)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
+1
@@ -29,6 +29,7 @@ class AssertThatGuavaOptionalInspection : AbstractAssertJInspection() {
|
||||
val actualExpression = staticMethodCall.firstArg as? PsiMethodCallExpression ?: return
|
||||
val outmostMethodCall = statement.findOutmostMethodCall() ?: return
|
||||
if (GUAVA_OPTIONAL_GET.test(actualExpression)) {
|
||||
if (actualExpression.type is PsiArrayType) return
|
||||
val expectedCallExpression = staticMethodCall.gatherAssertionCalls().singleOrNull() ?: return
|
||||
if (CallMatcher.anyOf(IS_EQUAL_TO_OBJECT, IS_EQUAL_TO_STRING).test(expectedCallExpression)) {
|
||||
registerMoveOutMethod(holder, outmostMethodCall, actualExpression, MethodNames.CONTAINS) { desc, method ->
|
||||
|
||||
+21
-25
@@ -5,10 +5,8 @@ import com.intellij.psi.*
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.HasHashCodeQuickFix
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.MoveOutMethodCallExpressionQuickFix
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.RemoveActualOutmostMethodCallQuickFix
|
||||
|
||||
class AssertThatObjectExpressionInspection : AbstractAssertJInspection() {
|
||||
class AssertThatObjectExpressionInspection : AbstractMoveOutInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Asserting equals(), toString(), or hashCode()"
|
||||
@@ -16,6 +14,17 @@ class AssertThatObjectExpressionInspection : AbstractAssertJInspection() {
|
||||
|
||||
private val OBJECT_TO_STRING = CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_OBJECT, "toString").parameterCount(0)
|
||||
private val OBJECT_HASHCODE = CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_OBJECT, "hashCode").parameterCount(0)
|
||||
|
||||
private val MAPPINGS = listOf(
|
||||
MoveOutMapping(
|
||||
OBJECT_EQUALS,
|
||||
MethodNames.IS_EQUAL_TO, MethodNames.IS_NOT_EQUAL_TO, expectBoolean = true
|
||||
),
|
||||
MoveOutMapping(
|
||||
OBJECT_TO_STRING,
|
||||
MethodNames.HAS_TO_STRING, expectedMatcher = CallMatcher.anyOf(IS_EQUAL_TO_OBJECT, IS_EQUAL_TO_STRING)
|
||||
)
|
||||
)
|
||||
}
|
||||
|
||||
override fun getDisplayName() = DISPLAY_NAME
|
||||
@@ -25,31 +34,18 @@ class AssertThatObjectExpressionInspection : AbstractAssertJInspection() {
|
||||
override fun visitExpressionStatement(statement: PsiExpressionStatement) {
|
||||
super.visitExpressionStatement(statement)
|
||||
if (!statement.hasAssertThat()) return
|
||||
|
||||
val staticMethodCall = statement.findStaticMethodCall() ?: return
|
||||
|
||||
val assertThatArgument = staticMethodCall.firstArg as? PsiMethodCallExpression ?: return
|
||||
val expectedCallExpression = statement.findOutmostMethodCall() ?: return
|
||||
when {
|
||||
OBJECT_EQUALS.test(assertThatArgument) -> {
|
||||
val expectedResult = expectedCallExpression.getAllTheSameExpectedBooleanConstants() ?: return
|
||||
val replacementMethod = expectedResult.map(MethodNames.IS_EQUAL_TO, MethodNames.IS_NOT_EQUAL_TO)
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, replacementMethod) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method)
|
||||
}
|
||||
}
|
||||
OBJECT_TO_STRING.test(assertThatArgument) -> {
|
||||
staticMethodCall.findFluentCallTo(IS_EQUAL_TO_OBJECT) ?: staticMethodCall.findFluentCallTo(IS_EQUAL_TO_STRING) ?: return
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, MethodNames.HAS_TO_STRING) { desc, method ->
|
||||
RemoveActualOutmostMethodCallQuickFix(desc, method)
|
||||
}
|
||||
}
|
||||
OBJECT_HASHCODE.test(assertThatArgument) -> {
|
||||
val isEqualTo = staticMethodCall.findFluentCallTo(IS_EQUAL_TO_INT) ?: return
|
||||
val expectedExpression = isEqualTo.firstArg as? PsiMethodCallExpression ?: return
|
||||
if (OBJECT_HASHCODE.test(expectedExpression)) {
|
||||
holder.registerProblem(expectedCallExpression, HASHCODE_MESSAGE_TEMPLATE, HasHashCodeQuickFix())
|
||||
}
|
||||
if (OBJECT_HASHCODE.test(assertThatArgument)) {
|
||||
val expectedCallExpression = statement.findOutmostMethodCall() ?: return
|
||||
val isEqualTo = staticMethodCall.findFluentCallTo(IS_EQUAL_TO_INT) ?: return
|
||||
val expectedExpression = isEqualTo.firstArg as? PsiMethodCallExpression ?: return
|
||||
if (OBJECT_HASHCODE.test(expectedExpression)) {
|
||||
holder.registerProblem(expectedCallExpression, HASHCODE_MESSAGE_TEMPLATE, HasHashCodeQuickFix())
|
||||
}
|
||||
} else {
|
||||
createInspectionsForMappings(statement, holder, MAPPINGS)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
+15
-10
@@ -5,6 +5,7 @@ import com.intellij.psi.*
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_CHAR_SEQUENCE_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_ITERABLE_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.AssertJClassNames.Companion.ABSTRACT_MAP_ASSERT_CLASSNAME
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.ReplaceHasSizeMethodCallQuickFix
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.ReplaceSizeMethodCallQuickFix
|
||||
|
||||
@@ -34,7 +35,7 @@ class AssertThatSizeInspection : AbstractAssertJInspection() {
|
||||
&& ((psiReferenceExpression.resolve() as? PsiField)?.name == "length"))
|
||||
}
|
||||
|
||||
fun getMatch(expression: PsiMethodCallExpression, isForArrayCollectionOrMap: Boolean, isForString: Boolean): Match? {
|
||||
fun getMatch(expression: PsiMethodCallExpression, isForArrayOrCollection: Boolean, isForMap: Boolean, isForString: Boolean): Match? {
|
||||
val isLastExpression = expression.parent is PsiStatement
|
||||
val constValue = expression.calculateConstantParameterValue(0)
|
||||
if (IS_EQUAL_TO_INT.test(expression)) {
|
||||
@@ -42,10 +43,11 @@ class AssertThatSizeInspection : AbstractAssertJInspection() {
|
||||
Match(expression, MethodNames.IS_EMPTY, noExpectedExpression = true)
|
||||
} else {
|
||||
val equalToExpression = expression.firstArg
|
||||
val equalsArrayCollectionOrMapSize = isArrayLength(equalToExpression) ||
|
||||
isCollectionSize(equalToExpression) || isMapSize(equalToExpression)
|
||||
if (isForArrayCollectionOrMap && equalsArrayCollectionOrMapSize ||
|
||||
isForString && (equalsArrayCollectionOrMapSize || isCharSequenceLength(equalToExpression))
|
||||
val equalsArrayOrCollectionSize = isArrayLength(equalToExpression) ||
|
||||
isCollectionSize(equalToExpression)
|
||||
if ((isForArrayOrCollection && equalsArrayOrCollectionSize)
|
||||
|| (isForMap && (equalsArrayOrCollectionSize || isMapSize(equalToExpression)))
|
||||
|| (isForString && (equalsArrayOrCollectionSize || isCharSequenceLength(equalToExpression)))
|
||||
) {
|
||||
Match(expression, MethodNames.HAS_SAME_SIZE_AS, expectedIsCollection = true)
|
||||
} else {
|
||||
@@ -83,12 +85,13 @@ class AssertThatSizeInspection : AbstractAssertJInspection() {
|
||||
if (!ASSERT_THAT_INT.test(staticMethodCall)) return
|
||||
|
||||
val actualExpression = staticMethodCall.firstArg
|
||||
val isForArrayCollectionOrMap = isArrayLength(actualExpression) || isCollectionSize(actualExpression) || isMapSize(actualExpression)
|
||||
val isForArrayOrCollection = isArrayLength(actualExpression) || isCollectionSize(actualExpression)
|
||||
val isForMap = isMapSize(actualExpression)
|
||||
val isForString = isCharSequenceLength(actualExpression)
|
||||
if (!(isForArrayCollectionOrMap || isForString)) return
|
||||
if (!(isForArrayOrCollection || isForMap || isForString)) return
|
||||
|
||||
val matches = staticMethodCall.collectMethodCallsUpToStatement()
|
||||
.mapNotNull { getMatch(it, isForArrayCollectionOrMap, isForString) }
|
||||
.mapNotNull { getMatch(it, isForArrayOrCollection, isForMap, isForString) }
|
||||
.toList()
|
||||
if (matches.isNotEmpty()) {
|
||||
if (matches.size == 1) {
|
||||
@@ -116,9 +119,11 @@ class AssertThatSizeInspection : AbstractAssertJInspection() {
|
||||
if (!HAS_SIZE.test(expression)) return
|
||||
val actualExpression = expression.firstArg
|
||||
|
||||
val isForArrayCollectionOrMap = isArrayLength(actualExpression) || isCollectionSize(actualExpression) || isMapSize(actualExpression)
|
||||
val isForArrayOrCollection = isArrayLength(actualExpression) || isCollectionSize(actualExpression)
|
||||
val isForMap = isMapSize(actualExpression)
|
||||
val isForString = isCharSequenceLength(actualExpression)
|
||||
if (!(isForArrayCollectionOrMap
|
||||
if (!(isForArrayOrCollection
|
||||
|| (isForMap && checkAssertedType(expression, ABSTRACT_MAP_ASSERT_CLASSNAME))
|
||||
|| (isForString && checkAssertedType(expression, ABSTRACT_CHAR_SEQUENCE_ASSERT_CLASSNAME)))
|
||||
) return
|
||||
|
||||
|
||||
+113
-35
@@ -3,41 +3,138 @@ package de.platon42.intellij.plugins.cajon.inspections
|
||||
import com.intellij.codeInspection.ProblemsHolder
|
||||
import com.intellij.psi.*
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
import de.platon42.intellij.plugins.cajon.quickfixes.MoveOutMethodCallExpressionQuickFix
|
||||
import de.platon42.intellij.plugins.cajon.MethodNames
|
||||
import de.platon42.intellij.plugins.cajon.calculateConstantValue
|
||||
import de.platon42.intellij.plugins.cajon.firstArg
|
||||
|
||||
class AssertThatStringExpressionInspection : AbstractAssertJInspection() {
|
||||
class AssertThatStringExpressionInspection : AbstractMoveOutInspection() {
|
||||
|
||||
companion object {
|
||||
private const val DISPLAY_NAME = "Asserting a string specific expression"
|
||||
|
||||
private val ARG_IS_ZERO_CONST: (PsiExpressionStatement, PsiMethodCallExpression) -> Boolean = { _, call -> call.firstArg.calculateConstantValue() == 0 }
|
||||
private val ARG_IS_MINUS_ONE_CONST: (PsiExpressionStatement, PsiMethodCallExpression) -> Boolean = { _, call -> call.firstArg.calculateConstantValue() == -1 }
|
||||
|
||||
private val STRING_COMPARE_TO_IGNORE_CASE =
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "compareToIgnoreCase").parameterTypes(CommonClassNames.JAVA_LANG_STRING)
|
||||
private val STRING_INDEX_OF = CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "indexOf").parameterTypes(CommonClassNames.JAVA_LANG_STRING)
|
||||
private val STRING_TRIM = CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "trim").parameterCount(0)
|
||||
|
||||
private val MAPPINGS = listOf(
|
||||
Mapping(
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "isEmpty").parameterCount(0),
|
||||
MethodNames.IS_EMPTY, MethodNames.IS_NOT_EMPTY
|
||||
MethodNames.IS_EMPTY, MethodNames.IS_NOT_EMPTY, expectBoolean = true
|
||||
),
|
||||
Mapping(
|
||||
MoveOutMapping(
|
||||
CallMatcher.anyOf(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "equals").parameterCount(1),
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "contentEquals").parameterCount(1)
|
||||
),
|
||||
MethodNames.IS_EQUAL_TO, MethodNames.IS_NOT_EQUAL_TO
|
||||
MethodNames.IS_EQUAL_TO, MethodNames.IS_NOT_EQUAL_TO, expectBoolean = true
|
||||
),
|
||||
Mapping(
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "equalsIgnoreCase").parameterTypes(CommonClassNames.JAVA_LANG_STRING),
|
||||
MethodNames.IS_EQUAL_TO_IC, MethodNames.IS_NOT_EQUAL_TO_IC
|
||||
MethodNames.IS_EQUAL_TO_IC, MethodNames.IS_NOT_EQUAL_TO_IC, expectBoolean = true
|
||||
),
|
||||
Mapping(
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "contains").parameterCount(1),
|
||||
MethodNames.CONTAINS, MethodNames.DOES_NOT_CONTAIN
|
||||
MethodNames.CONTAINS, MethodNames.DOES_NOT_CONTAIN, expectBoolean = true
|
||||
),
|
||||
Mapping(
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "startsWith").parameterTypes(CommonClassNames.JAVA_LANG_STRING),
|
||||
MethodNames.STARTS_WITH, MethodNames.DOES_NOT_START_WITH
|
||||
MethodNames.STARTS_WITH, MethodNames.DOES_NOT_START_WITH, expectBoolean = true
|
||||
),
|
||||
Mapping(
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "endsWith").parameterTypes(CommonClassNames.JAVA_LANG_STRING),
|
||||
MethodNames.ENDS_WITH, MethodNames.DOES_NOT_END_WITH
|
||||
MethodNames.ENDS_WITH, MethodNames.DOES_NOT_END_WITH, expectBoolean = true
|
||||
),
|
||||
MoveOutMapping(
|
||||
CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_STRING, "matches").parameterTypes(CommonClassNames.JAVA_LANG_STRING),
|
||||
"matches", "doesNotMatch", expectBoolean = true
|
||||
),
|
||||
|
||||
MoveOutMapping(
|
||||
STRING_COMPARE_TO_IGNORE_CASE,
|
||||
MethodNames.IS_EQUAL_TO_IC, expectedMatcher = IS_EQUAL_TO_INT, replaceFromOriginalMethod = true,
|
||||
additionalCondition = ARG_IS_ZERO_CONST
|
||||
),
|
||||
MoveOutMapping(
|
||||
STRING_COMPARE_TO_IGNORE_CASE,
|
||||
MethodNames.IS_EQUAL_TO_IC, expectedMatcher = IS_ZERO, replaceFromOriginalMethod = true
|
||||
),
|
||||
MoveOutMapping(
|
||||
STRING_COMPARE_TO_IGNORE_CASE,
|
||||
MethodNames.IS_NOT_EQUAL_TO_IC, expectedMatcher = IS_NOT_EQUAL_TO_INT, replaceFromOriginalMethod = true,
|
||||
additionalCondition = ARG_IS_ZERO_CONST
|
||||
),
|
||||
MoveOutMapping(
|
||||
STRING_COMPARE_TO_IGNORE_CASE,
|
||||
MethodNames.IS_NOT_EQUAL_TO_IC, expectedMatcher = IS_NOT_ZERO, replaceFromOriginalMethod = true
|
||||
),
|
||||
|
||||
MoveOutMapping(
|
||||
STRING_INDEX_OF,
|
||||
MethodNames.STARTS_WITH, expectedMatcher = IS_EQUAL_TO_INT, replaceFromOriginalMethod = true,
|
||||
additionalCondition = ARG_IS_ZERO_CONST
|
||||
),
|
||||
MoveOutMapping(
|
||||
STRING_INDEX_OF,
|
||||
MethodNames.STARTS_WITH, expectedMatcher = IS_ZERO, replaceFromOriginalMethod = true
|
||||
),
|
||||
|
||||
MoveOutMapping(
|
||||
STRING_INDEX_OF,
|
||||
MethodNames.DOES_NOT_START_WITH, expectedMatcher = IS_NOT_EQUAL_TO_INT, replaceFromOriginalMethod = true,
|
||||
additionalCondition = ARG_IS_ZERO_CONST
|
||||
),
|
||||
MoveOutMapping(
|
||||
STRING_INDEX_OF,
|
||||
MethodNames.DOES_NOT_START_WITH, expectedMatcher = IS_NOT_ZERO, replaceFromOriginalMethod = true
|
||||
),
|
||||
|
||||
MoveOutMapping(
|
||||
STRING_INDEX_OF,
|
||||
MethodNames.CONTAINS, expectedMatcher = IS_NOT_NEGATIVE, replaceFromOriginalMethod = true
|
||||
),
|
||||
MoveOutMapping(
|
||||
STRING_INDEX_OF,
|
||||
MethodNames.CONTAINS, expectedMatcher = IS_NOT_EQUAL_TO_INT, replaceFromOriginalMethod = true,
|
||||
additionalCondition = ARG_IS_MINUS_ONE_CONST
|
||||
),
|
||||
MoveOutMapping(
|
||||
STRING_INDEX_OF,
|
||||
MethodNames.CONTAINS, expectedMatcher = IS_GREATER_THAN_OR_EQUAL_TO_INT, replaceFromOriginalMethod = true,
|
||||
additionalCondition = ARG_IS_ZERO_CONST
|
||||
),
|
||||
MoveOutMapping(
|
||||
STRING_INDEX_OF,
|
||||
MethodNames.CONTAINS, expectedMatcher = IS_GREATER_THAN_INT, replaceFromOriginalMethod = true,
|
||||
additionalCondition = ARG_IS_MINUS_ONE_CONST
|
||||
),
|
||||
|
||||
MoveOutMapping(
|
||||
STRING_INDEX_OF,
|
||||
MethodNames.DOES_NOT_CONTAIN, expectedMatcher = IS_EQUAL_TO_INT, replaceFromOriginalMethod = true,
|
||||
additionalCondition = ARG_IS_MINUS_ONE_CONST
|
||||
),
|
||||
MoveOutMapping(
|
||||
STRING_INDEX_OF,
|
||||
MethodNames.DOES_NOT_CONTAIN, expectedMatcher = IS_NEGATIVE, replaceFromOriginalMethod = true
|
||||
),
|
||||
MoveOutMapping(
|
||||
STRING_INDEX_OF,
|
||||
MethodNames.DOES_NOT_CONTAIN, expectedMatcher = IS_LESS_THAN_INT, replaceFromOriginalMethod = true,
|
||||
additionalCondition = ARG_IS_ZERO_CONST
|
||||
),
|
||||
MoveOutMapping(
|
||||
STRING_INDEX_OF,
|
||||
MethodNames.DOES_NOT_CONTAIN, expectedMatcher = IS_LESS_THAN_OR_EQUAL_TO_INT, replaceFromOriginalMethod = true,
|
||||
additionalCondition = ARG_IS_MINUS_ONE_CONST
|
||||
),
|
||||
|
||||
MoveOutMapping(
|
||||
STRING_TRIM,
|
||||
"isNotBlank", expectedMatcher = IS_NOT_EMPTY
|
||||
)
|
||||
)
|
||||
}
|
||||
@@ -48,27 +145,8 @@ class AssertThatStringExpressionInspection : AbstractAssertJInspection() {
|
||||
return object : JavaElementVisitor() {
|
||||
override fun visitExpressionStatement(statement: PsiExpressionStatement) {
|
||||
super.visitExpressionStatement(statement)
|
||||
if (!statement.hasAssertThat()) return
|
||||
val staticMethodCall = statement.findStaticMethodCall() ?: return
|
||||
if (!ASSERT_THAT_BOOLEAN.test(staticMethodCall)) return
|
||||
|
||||
val assertThatArgument = staticMethodCall.firstArg as? PsiMethodCallExpression ?: return
|
||||
val mapping = MAPPINGS.firstOrNull { it.callMatcher.test(assertThatArgument) } ?: return
|
||||
|
||||
val expectedCallExpression = statement.findOutmostMethodCall() ?: return
|
||||
val expectedResult = expectedCallExpression.getAllTheSameExpectedBooleanConstants() ?: return
|
||||
|
||||
val replacementMethod = if (expectedResult) mapping.replacementForTrue else mapping.replacementForFalse
|
||||
registerMoveOutMethod(holder, expectedCallExpression, assertThatArgument, replacementMethod) { desc, method ->
|
||||
MoveOutMethodCallExpressionQuickFix(desc, method)
|
||||
}
|
||||
createInspectionsForMappings(statement, holder, MAPPINGS)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private class Mapping(
|
||||
val callMatcher: CallMatcher,
|
||||
val replacementForTrue: String,
|
||||
val replacementForFalse: String
|
||||
)
|
||||
}
|
||||
+47
-20
@@ -2,7 +2,10 @@ package de.platon42.intellij.plugins.cajon.quickfixes
|
||||
|
||||
import com.intellij.codeInspection.ProblemDescriptor
|
||||
import com.intellij.openapi.project.Project
|
||||
import com.intellij.psi.JavaPsiFacade
|
||||
import com.intellij.psi.PsiExpression
|
||||
import com.intellij.psi.PsiMethodCallExpression
|
||||
import com.siyeh.ig.callMatcher.CallMatcher
|
||||
import de.platon42.intellij.plugins.cajon.*
|
||||
|
||||
class MoveOutMethodCallExpressionQuickFix(
|
||||
@@ -10,7 +13,9 @@ class MoveOutMethodCallExpressionQuickFix(
|
||||
private val replacementMethod: String,
|
||||
private val useNullNonNull: Boolean = false,
|
||||
private val noExpectedExpression: Boolean = false,
|
||||
private val keepExpectedAsSecondArgument: Boolean = false
|
||||
private val keepExpectedAsSecondArgument: Boolean = false,
|
||||
private val replaceOnlyThisMethod: CallMatcher? = null,
|
||||
private val replaceFromOriginalMethod: Boolean = false
|
||||
) :
|
||||
AbstractCommonQuickFix(description) {
|
||||
|
||||
@@ -26,30 +31,52 @@ class MoveOutMethodCallExpressionQuickFix(
|
||||
val outmostCallExpression = descriptor.startElement as? PsiMethodCallExpression ?: return
|
||||
val assertThatMethodCall = outmostCallExpression.findStaticMethodCall() ?: return
|
||||
val assertExpression = assertThatMethodCall.firstArg as? PsiMethodCallExpression ?: return
|
||||
val assertExpressionArg = if (noExpectedExpression) null else assertExpression.getArgOrNull(0)?.copy()
|
||||
val assertExpressionArg = if (noExpectedExpression) null else assertExpression.getArgOrNull(0)?.copy() as PsiExpression?
|
||||
|
||||
if (keepExpectedAsSecondArgument) {
|
||||
assertExpressionArg ?: return
|
||||
val secondArg = outmostCallExpression.getArgOrNull(0)?.copy() ?: return
|
||||
when {
|
||||
replaceOnlyThisMethod != null -> {
|
||||
val methodsToFix = assertThatMethodCall.collectMethodCallsUpToStatement()
|
||||
.filter(replaceOnlyThisMethod::test)
|
||||
.toList()
|
||||
|
||||
assertExpression.replace(assertExpression.qualifierExpression)
|
||||
assertExpression.replace(assertExpression.qualifierExpression)
|
||||
|
||||
val expectedExpression = createExpectedMethodCall(outmostCallExpression, replacementMethod, assertExpressionArg, secondArg)
|
||||
expectedExpression.replaceQualifierFromMethodCall(outmostCallExpression)
|
||||
outmostCallExpression.replace(expectedExpression)
|
||||
} else {
|
||||
val methodsToFix = assertThatMethodCall.collectMethodCallsUpToStatement()
|
||||
.filter { (if (useNullNonNull) it.getExpectedNullNonNullResult() else it.getExpectedBooleanResult()) != null }
|
||||
.toList()
|
||||
methodsToFix
|
||||
.forEach {
|
||||
val expectedExpression = createExpectedMethodCall(
|
||||
it,
|
||||
replacementMethod,
|
||||
*if (replaceFromOriginalMethod) arrayOf(assertExpressionArg!!) else it.argumentList.expressions
|
||||
)
|
||||
expectedExpression.replaceQualifierFromMethodCall(it)
|
||||
it.replace(expectedExpression)
|
||||
}
|
||||
}
|
||||
keepExpectedAsSecondArgument -> {
|
||||
assertExpressionArg ?: return
|
||||
val secondArg =
|
||||
if (useNullNonNull) JavaPsiFacade.getElementFactory(project).createExpressionFromText("null", null) else outmostCallExpression.getArgOrNull(0)?.copy() ?: return
|
||||
|
||||
assertExpression.replace(assertExpression.qualifierExpression)
|
||||
assertExpression.replace(assertExpression.qualifierExpression)
|
||||
|
||||
methodsToFix
|
||||
.forEach {
|
||||
val expectedExpression = createExpectedMethodCall(it, replacementMethod, *listOfNotNull(assertExpressionArg).toTypedArray())
|
||||
expectedExpression.replaceQualifierFromMethodCall(it)
|
||||
it.replace(expectedExpression)
|
||||
}
|
||||
val expectedExpression = createExpectedMethodCall(outmostCallExpression, replacementMethod, assertExpressionArg, secondArg)
|
||||
expectedExpression.replaceQualifierFromMethodCall(outmostCallExpression)
|
||||
outmostCallExpression.replace(expectedExpression)
|
||||
}
|
||||
else -> {
|
||||
val methodsToFix = assertThatMethodCall.collectMethodCallsUpToStatement()
|
||||
.filter { (if (useNullNonNull) it.getExpectedNullNonNullResult() else it.getExpectedBooleanResult()) != null }
|
||||
.toList()
|
||||
|
||||
assertExpression.replace(assertExpression.qualifierExpression)
|
||||
|
||||
methodsToFix
|
||||
.forEach {
|
||||
val expectedExpression = createExpectedMethodCall(it, replacementMethod, *listOfNotNull(assertExpressionArg).toTypedArray())
|
||||
expectedExpression.replaceQualifierFromMethodCall(it)
|
||||
it.replace(expectedExpression)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -45,6 +45,8 @@
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatStringExpressionInspection"/>
|
||||
<localInspection groupPath="Java" shortName="AssertThatCollectionOrMapExpression" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatCollectionOrMapExpressionInspection"/>
|
||||
<localInspection groupPath="Java" shortName="AssertThatFileExpression" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.AssertThatFileExpressionInspection"/>
|
||||
|
||||
<localInspection groupPath="Java" shortName="JoinAssertThatStatements" enabledByDefault="true" level="WARNING"
|
||||
implementationClass="de.platon42.intellij.plugins.cajon.inspections.JoinAssertThatStatementsInspection"/>
|
||||
|
||||
@@ -6,5 +6,13 @@ assertThat(map.get(key)).isEqualTo/isNotEqualTo(value) into assertThat(map).cont
|
||||
<br>someMethod() can be isEmpty(), contains(), and containsAll() for collections and
|
||||
isEmpty(), containsKey(), and containsValue() for maps.
|
||||
get() may be transformed into containsKey(), doesNotContainKey(), containsEntry() or doesNotContainEntry().
|
||||
<br>
|
||||
If you are using degenerated maps in your project that may contain null values (i.e.
|
||||
map.contains(key) == true AND map.get(key) == null
|
||||
is valid for some entries in your map), the default behavior of the quickfix
|
||||
assertThat(map.get(key)).isNull() turning into assertThat(map).doesNotContainKey(key)
|
||||
is not an equivalent transformation. The settings below can change this behavior to instead transform it into
|
||||
assertThat(map).containsEntry(key, null) for those cases, create both quickfix choices or simply ignore this
|
||||
case altogether (if in doubt).
|
||||
</body>
|
||||
</html>
|
||||
@@ -0,0 +1,8 @@
|
||||
<html>
|
||||
<body>
|
||||
Operates on assertions on objects of type File. Turns assertThat(file.someMethod(arg)).someAssertion() into assertThat(file).someMethod(arg).
|
||||
<!-- tooltip end -->
|
||||
<br>someMethod() can be canRead(), canWrite(), exists(), isAbsolute(), isDirectory(), isFile(),
|
||||
getName(), getParent(), getParentFile(), list() and listFiles().
|
||||
</body>
|
||||
</html>
|
||||
@@ -2,6 +2,7 @@
|
||||
<body>
|
||||
Turns assertThat(string.someMethod(arg)).isTrue/isFalse() into assertThat(string).someMethod(arg).
|
||||
<!-- tooltip end -->
|
||||
<br>someMethod() can be isEmpty(), equals(), equalsIgnoreCase(), contentEquals(), contains(), startsWith(), and endsWith().
|
||||
<br>someMethod() can be isEmpty(), equals(), equalsIgnoreCase(), contentEquals(), contains(), startsWith(), endsWith(),
|
||||
matches(), compareToIgnoreCase(), indexOf(), and trim().
|
||||
</body>
|
||||
</html>
|
||||
@@ -1,5 +1,6 @@
|
||||
package de.platon42.intellij.plugins.cajon
|
||||
|
||||
import com.intellij.codeInsight.intention.IntentionAction
|
||||
import com.intellij.pom.java.LanguageLevel
|
||||
import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
|
||||
import de.platon42.intellij.jupiter.AddLocalJarToModule
|
||||
@@ -21,10 +22,20 @@ import java.lang.reflect.Method
|
||||
abstract class AbstractCajonTest {
|
||||
|
||||
protected fun executeQuickFixes(myFixture: JavaCodeInsightTestFixture, regex: Regex, expectedFixes: Int) {
|
||||
val quickfixes = getQuickFixes(myFixture, regex, expectedFixes)
|
||||
assertThat(quickfixes.groupBy { it.familyName }).hasSize(1)
|
||||
quickfixes.forEach(myFixture::launchAction)
|
||||
}
|
||||
|
||||
protected fun executeQuickFixesNoFamilyNameCheck(myFixture: JavaCodeInsightTestFixture, regex: Regex, expectedFixes: Int) {
|
||||
val quickfixes = getQuickFixes(myFixture, regex, expectedFixes)
|
||||
quickfixes.forEach(myFixture::launchAction)
|
||||
}
|
||||
|
||||
protected fun getQuickFixes(myFixture: JavaCodeInsightTestFixture, regex: Regex, expectedFixes: Int): List<IntentionAction> {
|
||||
val quickfixes = myFixture.getAllQuickFixes().filter { it.text.matches(regex) }
|
||||
assertThat(quickfixes).`as`("Fixes matched by $regex: ${myFixture.getAllQuickFixes().map { it.text }}").hasSize(expectedFixes)
|
||||
quickfixes.forEach { it.familyName }
|
||||
quickfixes.forEach(myFixture::launchAction)
|
||||
return quickfixes
|
||||
}
|
||||
|
||||
class CutOffFixtureDisplayNameGenerator : DisplayNameGenerator.ReplaceUnderscores() {
|
||||
|
||||
+1
-1
@@ -13,7 +13,7 @@ internal class AssertThatBinaryExpressionInspectionTest : AbstractCajonTest() {
|
||||
internal fun assertThat_of_binary_expression_can_be_moved_out(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
myFixture.enableInspections(AssertThatBinaryExpressionInspection::class.java)
|
||||
myFixture.configureByFile("BinaryExpressionBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Split binary expression out of assertThat()"), 149)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Split binary expression out of assertThat()"), 161)
|
||||
myFixture.checkResultByFile("BinaryExpressionAfter.java")
|
||||
}
|
||||
}
|
||||
+74
-1
@@ -4,12 +4,13 @@ import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
|
||||
import de.platon42.intellij.jupiter.MyFixture
|
||||
import de.platon42.intellij.jupiter.TestDataSubPath
|
||||
import de.platon42.intellij.plugins.cajon.AbstractCajonTest
|
||||
import org.assertj.core.api.Assertions.assertThat
|
||||
import org.junit.jupiter.api.Test
|
||||
|
||||
@TestDataSubPath("inspections/CollectionMapExpression")
|
||||
internal class AssertThatCollectionOrMapExpressionInspectionTest : AbstractCajonTest() {
|
||||
|
||||
@Test
|
||||
@TestDataSubPath("inspections/CollectionMapExpression")
|
||||
internal fun assertThat_with_certain_Collection_and_Map_methods(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
myFixture.enableInspections(AssertThatCollectionOrMapExpressionInspection::class.java)
|
||||
myFixture.configureByFile("CollectionMapExpressionBefore.java")
|
||||
@@ -28,4 +29,76 @@ internal class AssertThatCollectionOrMapExpressionInspectionTest : AbstractCajon
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 4)
|
||||
myFixture.checkResultByFile("CollectionMapExpressionAfter.java")
|
||||
}
|
||||
|
||||
@Test
|
||||
internal fun assertThat_with_certain_Collection_and_Map_methods_with_Null_values(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
val inspection = AssertThatCollectionOrMapExpressionInspection()
|
||||
inspection.behaviorForMapValueEqualsNull = 3
|
||||
myFixture.enableInspections(inspection)
|
||||
myFixture.configureByFile("CollectionMapExpressionBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isEmpty() instead"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove contains() of actual expression and use assertThat().contains() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsAll() of actual expression and use assertThat().containsAll() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsKey() of actual expression and use assertThat().containsKey() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsValue() of actual expression and use assertThat().containsValue() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isNotEmpty() instead"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove contains() of actual expression and use assertThat().doesNotContain() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsKey() of actual expression and use assertThat().doesNotContainKey() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove containsValue() of actual expression and use assertThat().doesNotContainValue() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 6)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 0)
|
||||
myFixture.checkResultByFile("CollectionMapExpressionWithNullValuesAfter.java")
|
||||
}
|
||||
|
||||
@Test
|
||||
internal fun assertThat_with_certain_Collection_and_Map_methods_with_no_quickfixes_for_get_equals_null(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
val inspection = AssertThatCollectionOrMapExpressionInspection()
|
||||
inspection.behaviorForMapValueEqualsNull = 0
|
||||
|
||||
myFixture.enableInspections(inspection)
|
||||
myFixture.configureByFile("CollectionMapExpressionBefore.java")
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 2)
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 0)
|
||||
}
|
||||
|
||||
@Test
|
||||
internal fun assertThat_with_certain_Collection_and_Map_methods_with_only_warnings_for_get_equals_null(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
val inspection = AssertThatCollectionOrMapExpressionInspection()
|
||||
inspection.behaviorForMapValueEqualsNull = 1
|
||||
|
||||
myFixture.enableInspections(inspection)
|
||||
myFixture.configureByFile("CollectionMapExpressionBefore.java")
|
||||
val highlights = myFixture.doHighlighting()
|
||||
.asSequence()
|
||||
.filter { it.description == "Moving get() expression out of assertThat() would be more concise" }
|
||||
.filter {
|
||||
it.quickFixActionRanges?.any { innerit -> innerit.first.action.text.contains("Inspection 'Asserting a collection or map specific expression") } ?: true
|
||||
}
|
||||
.toList()
|
||||
assertThat(highlights).hasSize(4)
|
||||
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 2)
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 0)
|
||||
}
|
||||
|
||||
@Test
|
||||
internal fun assertThat_with_certain_Collection_and_Map_methods_with_both_quickfixes_for_get_equals_null(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
val inspection = AssertThatCollectionOrMapExpressionInspection()
|
||||
inspection.behaviorForMapValueEqualsNull = 4
|
||||
|
||||
myFixture.enableInspections(inspection)
|
||||
myFixture.configureByFile("CollectionMapExpressionBefore.java")
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry() instead"), 2)
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead (regular map)"), 4)
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsEntry(key, null) instead (degenerated map)"), 4)
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainEntry() instead"), 2)
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().containsKey() instead"), 4)
|
||||
getQuickFixes(myFixture, Regex.fromLiteral("Remove get() of actual expression and use assertThat().doesNotContainKey() instead"), 0)
|
||||
}
|
||||
}
|
||||
+35
@@ -0,0 +1,35 @@
|
||||
package de.platon42.intellij.plugins.cajon.inspections
|
||||
|
||||
import com.intellij.testFramework.fixtures.JavaCodeInsightTestFixture
|
||||
import de.platon42.intellij.jupiter.MyFixture
|
||||
import de.platon42.intellij.jupiter.TestDataSubPath
|
||||
import de.platon42.intellij.plugins.cajon.AbstractCajonTest
|
||||
import org.junit.jupiter.api.Test
|
||||
|
||||
internal class AssertThatFileExpressionInspectionTest : AbstractCajonTest() {
|
||||
|
||||
@Test
|
||||
@TestDataSubPath("inspections/FileExpression")
|
||||
internal fun assertThat_with_certain_File_methods(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
myFixture.enableInspections(AssertThatFileExpressionInspection::class.java)
|
||||
myFixture.configureByFile("FileExpressionBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove canRead() of actual expression and use assertThat().canRead() instead"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove canWrite() of actual expression and use assertThat().canWrite() instead"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove exists() of actual expression and use assertThat().exists() instead"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove exists() of actual expression and use assertThat().doesNotExist() instead"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove isAbsolute() of actual expression and use assertThat().isAbsolute() instead"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove isAbsolute() of actual expression and use assertThat().isRelative() instead"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove isDirectory() of actual expression and use assertThat().isDirectory() instead"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove isFile() of actual expression and use assertThat().isFile() instead"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove getName() of actual expression and use assertThat().hasName() instead"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove getParent() of actual expression and use assertThat().hasNoParent() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove getParentFile() of actual expression and use assertThat().hasNoParent() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove getParent() of actual expression and use assertThat().hasParent() instead"), 1)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove getParentFile() of actual expression and use assertThat().hasParent() instead"), 1)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove listFiles() of actual expression and use assertThat().isEmptyDirectory() instead"), 1)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove listFiles() of actual expression and use assertThat().isNotEmptyDirectory() instead"), 1)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove list() of actual expression and use assertThat().isEmptyDirectory() instead"), 1)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove list() of actual expression and use assertThat().isNotEmptyDirectory() instead"), 1)
|
||||
myFixture.checkResultByFile("FileExpressionAfter.java")
|
||||
}
|
||||
}
|
||||
+4
-4
@@ -31,8 +31,8 @@ internal class AssertThatGuavaOptionalInspectionTest : AbstractCajonTest() {
|
||||
internal fun adds_missing_Guava_import_any_order(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
myFixture.enableInspections(AssertThatGuavaOptionalInspection::class.java)
|
||||
myFixture.configureByFile("WithoutPriorGuavaImportBefore.java")
|
||||
executeQuickFixes(myFixture, Regex(".*eplace .* with .*"), 4)
|
||||
executeQuickFixes(myFixture, Regex("Remove .*"), 3)
|
||||
executeQuickFixesNoFamilyNameCheck(myFixture, Regex(".*eplace .* with .*"), 4)
|
||||
executeQuickFixesNoFamilyNameCheck(myFixture, Regex("Remove .*"), 3)
|
||||
myFixture.checkResultByFile("WithoutPriorGuavaImportAfter.java")
|
||||
}
|
||||
|
||||
@@ -41,8 +41,8 @@ internal class AssertThatGuavaOptionalInspectionTest : AbstractCajonTest() {
|
||||
myFixture.enableInspections(AssertThatGuavaOptionalInspection::class.java)
|
||||
myFixture.configureByFile("WithoutPriorGuavaImportBefore.java")
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with Guava assertThat().isAbsent()"), 1)
|
||||
executeQuickFixes(myFixture, Regex(".*eplace .* with .*"), 3)
|
||||
executeQuickFixes(myFixture, Regex("Remove .*"), 3)
|
||||
executeQuickFixesNoFamilyNameCheck(myFixture, Regex(".*eplace .* with .*"), 3)
|
||||
executeQuickFixesNoFamilyNameCheck(myFixture, Regex("Remove .*"), 3)
|
||||
myFixture.checkResultByFile("WithoutPriorGuavaImportAfter.java")
|
||||
}
|
||||
}
|
||||
+3
-3
@@ -24,13 +24,13 @@ internal class AssertThatSizeInspectionTest : AbstractCajonTest() {
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThanOrEqualTo() with isNotEmpty()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThan() with isEmpty()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThanOrEqualTo() with isEmpty()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with hasSameSizeAs()"), 19)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with hasSize()"), 11)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with hasSameSizeAs()"), 15)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isEqualTo() with hasSize()"), 15)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThan() with hasSizeGreaterThan()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isGreaterThanOrEqualTo() with hasSizeGreaterThanOrEqualTo()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThan() with hasSizeLessThan()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Replace isLessThanOrEqualTo() with hasSizeLessThanOrEqualTo()"), 5)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove size determination of expected expression and replace hasSize() with hasSameSizeAs()"), 21)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove size determination of expected expression and replace hasSize() with hasSameSizeAs()"), 17)
|
||||
myFixture.checkResultByFile("SizeAfter.java")
|
||||
}
|
||||
}
|
||||
+9
@@ -20,6 +20,8 @@ internal class AssertThatStringExpressionInspectionTest : AbstractCajonTest() {
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove contains() of actual expression and use assertThat().contains() instead"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove startsWith() of actual expression and use assertThat().startsWith() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove endsWith() of actual expression and use assertThat().endsWith() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove matches() of actual expression and use assertThat().matches() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove matches() of actual expression and use assertThat().doesNotMatch() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove isEmpty() of actual expression and use assertThat().isNotEmpty() instead"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove equals() of actual expression and use assertThat().isNotEqualTo() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove equalsIgnoreCase() of actual expression and use assertThat().isNotEqualToIgnoringCase() instead"), 2)
|
||||
@@ -27,6 +29,13 @@ internal class AssertThatStringExpressionInspectionTest : AbstractCajonTest() {
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove contains() of actual expression and use assertThat().doesNotContain() instead"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove startsWith() of actual expression and use assertThat().doesNotStartWith() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove endsWith() of actual expression and use assertThat().doesNotEndWith() instead"), 3)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove compareToIgnoreCase() of actual expression and use assertThat().isEqualToIgnoringCase() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove compareToIgnoreCase() of actual expression and use assertThat().isNotEqualToIgnoringCase() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove indexOf() of actual expression and use assertThat().startsWith() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove indexOf() of actual expression and use assertThat().doesNotStartWith() instead"), 2)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove indexOf() of actual expression and use assertThat().contains() instead"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove indexOf() of actual expression and use assertThat().doesNotContain() instead"), 4)
|
||||
executeQuickFixes(myFixture, Regex.fromLiteral("Remove trim() of actual expression and use assertThat().isNotBlank() instead"), 1)
|
||||
myFixture.checkResultByFile("StringExpressionAfter.java")
|
||||
}
|
||||
}
|
||||
+3
-3
@@ -16,9 +16,9 @@ internal class ImplicitAssertionInspectionTest : AbstractCajonTest() {
|
||||
internal fun implicit_assertions_can_be_removed(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
myFixture.enableInspections(ImplicitAssertionInspection::class.java)
|
||||
myFixture.configureByFile("ImplicitAssertionBefore.java")
|
||||
executeQuickFixes(myFixture, Regex("Delete implicit isNotNull\\(\\) covered by .*"), 101)
|
||||
executeQuickFixes(myFixture, Regex("Delete implicit isNotEmpty\\(\\) covered by .*"), 17)
|
||||
executeQuickFixes(myFixture, Regex("Delete implicit isPresent\\(\\) covered by .*"), 8)
|
||||
executeQuickFixesNoFamilyNameCheck(myFixture, Regex("Delete implicit isNotNull\\(\\) covered by .*"), 101)
|
||||
executeQuickFixesNoFamilyNameCheck(myFixture, Regex("Delete implicit isNotEmpty\\(\\) covered by .*"), 17)
|
||||
executeQuickFixesNoFamilyNameCheck(myFixture, Regex("Delete implicit isPresent\\(\\) covered by .*"), 8)
|
||||
myFixture.checkResultByFile("ImplicitAssertionAfter.java")
|
||||
}
|
||||
}
|
||||
+2
-2
@@ -17,8 +17,8 @@ internal class JUnitAssertToAssertJInspectionTest : AbstractCajonTest() {
|
||||
internal fun junit_Assertions_can_be_converted_into_AssertJ(@MyFixture myFixture: JavaCodeInsightTestFixture) {
|
||||
myFixture.enableInspections(JUnitAssertToAssertJInspection::class.java)
|
||||
myFixture.configureByFile("JUnitAssertToAssertJInspectionBefore.java")
|
||||
executeQuickFixes(myFixture, Regex("Convert assert.*\\(\\) to assertThat\\(\\).*"), 48)
|
||||
executeQuickFixes(myFixture, Regex("Convert assume.*\\(\\) to assumeThat\\(\\).*"), 7)
|
||||
executeQuickFixesNoFamilyNameCheck(myFixture, Regex("Convert assert.*\\(\\) to assertThat\\(\\).*"), 48)
|
||||
executeQuickFixesNoFamilyNameCheck(myFixture, Regex("Convert assume.*\\(\\) to assumeThat\\(\\).*"), 7)
|
||||
myFixture.checkResultByFile("JUnitAssertToAssertJInspectionAfter.java")
|
||||
}
|
||||
}
|
||||
@@ -189,6 +189,20 @@ public class BinaryExpression {
|
||||
assertThat(stringAct).isNotNull();
|
||||
assertThat(stringAct).isNotNull();
|
||||
|
||||
assertThat(stringAct).as("doh!").isNotNull();
|
||||
assertThat(stringAct).isNotNull();
|
||||
assertThat(stringAct).isNotNull();
|
||||
assertThat(stringAct).isNull();
|
||||
assertThat(stringAct).isNull();
|
||||
assertThat(stringAct).isNull();
|
||||
|
||||
assertThat(stringAct).as("doh!").isNotNull();
|
||||
assertThat(stringAct).isNotNull();
|
||||
assertThat(stringAct).isNotNull();
|
||||
assertThat(stringAct).isNull();
|
||||
assertThat(stringAct).isNull();
|
||||
assertThat(stringAct).isNull();
|
||||
|
||||
assertThat(null == null).isTrue();
|
||||
assertThat(!false).isTrue();
|
||||
|
||||
|
||||
@@ -189,6 +189,20 @@ public class BinaryExpression {
|
||||
assertThat(null == stringAct).isEqualTo(false);
|
||||
assertThat(null == stringAct).isNotEqualTo(true);
|
||||
|
||||
assertThat(stringAct != null).as("doh!").isTrue();
|
||||
assertThat(stringAct != null).isEqualTo(true);
|
||||
assertThat(stringAct != null).isNotEqualTo(false);
|
||||
assertThat(stringAct != null).isFalse();
|
||||
assertThat(stringAct != null).isEqualTo(false);
|
||||
assertThat(stringAct != null).isNotEqualTo(true);
|
||||
|
||||
assertThat(null != stringAct).as("doh!").isTrue();
|
||||
assertThat(null != stringAct).isEqualTo(true);
|
||||
assertThat(null != stringAct).isNotEqualTo(false);
|
||||
assertThat(null != stringAct).isFalse();
|
||||
assertThat(null != stringAct).isEqualTo(false);
|
||||
assertThat(null != stringAct).isNotEqualTo(true);
|
||||
|
||||
assertThat(null == null).isTrue();
|
||||
assertThat(!false).isTrue();
|
||||
|
||||
|
||||
+63
@@ -0,0 +1,63 @@
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
import java.util.*;
|
||||
|
||||
public class CollectionMapExpression {
|
||||
|
||||
private void collectionMapExpression() {
|
||||
List<String> stringList = new ArrayList<>();
|
||||
List<String> anotherList = new ArrayList<>();
|
||||
Map<String, Integer> keyValueMap = new HashMap<>();
|
||||
|
||||
assertThat(stringList).as("foo").isEmpty();
|
||||
assertThat(stringList).isEmpty();
|
||||
assertThat(stringList).contains("foo");
|
||||
assertThat(stringList).contains("foo");
|
||||
assertThat(stringList).containsAll(anotherList);
|
||||
assertThat(stringList).containsAll(anotherList);
|
||||
|
||||
assertThat(stringList).as("foo").isNotEmpty();
|
||||
assertThat(stringList).isNotEmpty();
|
||||
assertThat(stringList).doesNotContain("foo");
|
||||
assertThat(stringList).doesNotContain("foo");
|
||||
assertThat(stringList.containsAll(anotherList)).isEqualTo(false);
|
||||
assertThat(stringList.containsAll(anotherList)).isFalse();
|
||||
|
||||
assertThat(keyValueMap).as("foo").isEmpty();
|
||||
assertThat(keyValueMap).isEmpty();
|
||||
assertThat(keyValueMap).containsKey("foo");
|
||||
assertThat(keyValueMap).containsKey("foo");
|
||||
assertThat(keyValueMap).containsValue(2);
|
||||
assertThat(keyValueMap).containsValue(2);
|
||||
|
||||
assertThat(keyValueMap).as("foo").isNotEmpty();
|
||||
assertThat(keyValueMap).isNotEmpty();
|
||||
assertThat(keyValueMap).doesNotContainKey("foo");
|
||||
assertThat(keyValueMap).doesNotContainKey("foo");
|
||||
assertThat(keyValueMap).doesNotContainValue(2);
|
||||
assertThat(keyValueMap).doesNotContainValue(2);
|
||||
|
||||
assertThat(keyValueMap).containsEntry("foo", 2);
|
||||
assertThat(keyValueMap).doesNotContainEntry("foo", 3);
|
||||
assertThat(keyValueMap).containsEntry("foo", null);
|
||||
assertThat(keyValueMap).containsEntry("foo", null);
|
||||
assertThat(keyValueMap).containsKey("foo");
|
||||
assertThat(keyValueMap).containsKey("foo");
|
||||
|
||||
Map<String, String> stringStringMap = new HashMap<>();
|
||||
assertThat(stringStringMap).containsEntry("foo", "bar");
|
||||
assertThat(stringStringMap).doesNotContainEntry("foo", "bar");
|
||||
assertThat(stringStringMap).containsEntry("foo", null);
|
||||
assertThat(stringStringMap).containsEntry("foo", null);
|
||||
assertThat(stringStringMap).containsKey("foo");
|
||||
assertThat(stringStringMap).containsKey("foo");
|
||||
|
||||
assertThat(stringList).as("foo").isNotEmpty().as("bar").isNotEmpty();
|
||||
assertThat(stringList.isEmpty()).as("foo").isEqualTo(false).as("bar").isTrue();
|
||||
assertThat(stringList.isEmpty()).as("foo").satisfies(it -> it.booleanValue()).as("bar").isFalse();
|
||||
|
||||
org.junit.Assert.assertThat(stringList, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,95 @@
|
||||
import java.io.File;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class FileExpression {
|
||||
|
||||
private void fileExpression() {
|
||||
File file = new File("foo");
|
||||
|
||||
assertThat(file).as("foo").canRead();
|
||||
assertThat(file).canRead();
|
||||
assertThat(file).canRead();
|
||||
assertThat(file.canRead()).as("foo").isEqualTo(false);
|
||||
assertThat(file.canRead()).isNotEqualTo(true);
|
||||
assertThat(file.canRead()).isFalse();
|
||||
|
||||
assertThat(file).as("foo").canWrite();
|
||||
assertThat(file).canWrite();
|
||||
assertThat(file).canWrite();
|
||||
assertThat(file.canWrite()).as("foo").isEqualTo(false);
|
||||
assertThat(file.canWrite()).isNotEqualTo(true);
|
||||
assertThat(file.canWrite()).isFalse();
|
||||
|
||||
assertThat(file).as("foo").exists();
|
||||
assertThat(file).exists();
|
||||
assertThat(file).exists();
|
||||
assertThat(file).as("foo").doesNotExist();
|
||||
assertThat(file).doesNotExist();
|
||||
assertThat(file).doesNotExist();
|
||||
|
||||
assertThat(file).as("foo").isAbsolute();
|
||||
assertThat(file).isAbsolute();
|
||||
assertThat(file).isAbsolute();
|
||||
assertThat(file).as("foo").isRelative();
|
||||
assertThat(file).isRelative();
|
||||
assertThat(file).isRelative();
|
||||
|
||||
assertThat(file).as("foo").isDirectory();
|
||||
assertThat(file).isDirectory();
|
||||
assertThat(file).isDirectory();
|
||||
assertThat(file.isDirectory()).as("foo").isEqualTo(false);
|
||||
assertThat(file.isDirectory()).isNotEqualTo(true);
|
||||
assertThat(file.isDirectory()).isFalse();
|
||||
|
||||
assertThat(file).as("foo").isFile();
|
||||
assertThat(file).isFile();
|
||||
assertThat(file).isFile();
|
||||
assertThat(file.isFile()).as("foo").isEqualTo(false);
|
||||
assertThat(file.isFile()).isNotEqualTo(true);
|
||||
assertThat(file.isFile()).isFalse();
|
||||
|
||||
assertThat(file).hasName("foo");
|
||||
assertThat(file.getName()).isNotEqualTo("foo");
|
||||
assertThat(file).hasName(null);
|
||||
assertThat(file.getName()).isNull();
|
||||
assertThat(file.getName()).isNotEqualTo(null);
|
||||
assertThat(file.getName()).isNotNull();
|
||||
assertThat(file.getName()).isEmpty();
|
||||
assertThat(file.getName()).isNotEmpty();
|
||||
|
||||
assertThat(file).hasParent("foo");
|
||||
assertThat(file.getParent()).isNotEqualTo("foo");
|
||||
assertThat(file).hasNoParent();
|
||||
assertThat(file).hasNoParent();
|
||||
assertThat(file.getParent()).isNotEqualTo(null);
|
||||
assertThat(file.getParent()).isNotNull();
|
||||
assertThat(file.getParent()).isEmpty();
|
||||
assertThat(file.getParent()).isNotEmpty();
|
||||
|
||||
assertThat(file).hasParent(new File("foo"));
|
||||
assertThat(file.getParentFile()).isNotEqualTo(new File("foo"));
|
||||
assertThat(file).hasNoParent();
|
||||
assertThat(file).hasNoParent();
|
||||
assertThat(file.getParentFile()).isNotEqualTo(null);
|
||||
assertThat(file.getParentFile()).isNotNull();
|
||||
|
||||
assertThat(file.listFiles()).isNull();
|
||||
assertThat(file.listFiles()).isNullOrEmpty();
|
||||
assertThat(file).isEmptyDirectory();
|
||||
assertThat(file).isNotEmptyDirectory();
|
||||
|
||||
assertThat(file.list()).isNull();
|
||||
assertThat(file.list()).isNullOrEmpty();
|
||||
assertThat(file).isEmptyDirectory();
|
||||
assertThat(file).isNotEmptyDirectory();
|
||||
|
||||
assertThat(file.getName()).endsWith(".foo"); // could be turned into .hasExtension("foo"), but not always.
|
||||
|
||||
assertThat(file).as("foo").hasName("foo").as("bar").hasName("bar");
|
||||
|
||||
org.junit.Assert.assertThat(file, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,95 @@
|
||||
import java.io.File;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.assertj.core.api.Assertions.fail;
|
||||
|
||||
public class FileExpression {
|
||||
|
||||
private void fileExpression() {
|
||||
File file = new File("foo");
|
||||
|
||||
assertThat(file.canRead()).as("foo").isEqualTo(true);
|
||||
assertThat(file.canRead()).isNotEqualTo(false);
|
||||
assertThat(file.canRead()).isTrue();
|
||||
assertThat(file.canRead()).as("foo").isEqualTo(false);
|
||||
assertThat(file.canRead()).isNotEqualTo(true);
|
||||
assertThat(file.canRead()).isFalse();
|
||||
|
||||
assertThat(file.canWrite()).as("foo").isEqualTo(true);
|
||||
assertThat(file.canWrite()).isNotEqualTo(false);
|
||||
assertThat(file.canWrite()).isTrue();
|
||||
assertThat(file.canWrite()).as("foo").isEqualTo(false);
|
||||
assertThat(file.canWrite()).isNotEqualTo(true);
|
||||
assertThat(file.canWrite()).isFalse();
|
||||
|
||||
assertThat(file.exists()).as("foo").isEqualTo(true);
|
||||
assertThat(file.exists()).isNotEqualTo(false);
|
||||
assertThat(file.exists()).isTrue();
|
||||
assertThat(file.exists()).as("foo").isEqualTo(false);
|
||||
assertThat(file.exists()).isNotEqualTo(true);
|
||||
assertThat(file.exists()).isFalse();
|
||||
|
||||
assertThat(file.isAbsolute()).as("foo").isEqualTo(true);
|
||||
assertThat(file.isAbsolute()).isNotEqualTo(false);
|
||||
assertThat(file.isAbsolute()).isTrue();
|
||||
assertThat(file.isAbsolute()).as("foo").isEqualTo(false);
|
||||
assertThat(file.isAbsolute()).isNotEqualTo(true);
|
||||
assertThat(file.isAbsolute()).isFalse();
|
||||
|
||||
assertThat(file.isDirectory()).as("foo").isEqualTo(true);
|
||||
assertThat(file.isDirectory()).isNotEqualTo(false);
|
||||
assertThat(file.isDirectory()).isTrue();
|
||||
assertThat(file.isDirectory()).as("foo").isEqualTo(false);
|
||||
assertThat(file.isDirectory()).isNotEqualTo(true);
|
||||
assertThat(file.isDirectory()).isFalse();
|
||||
|
||||
assertThat(file.isFile()).as("foo").isEqualTo(true);
|
||||
assertThat(file.isFile()).isNotEqualTo(false);
|
||||
assertThat(file.isFile()).isTrue();
|
||||
assertThat(file.isFile()).as("foo").isEqualTo(false);
|
||||
assertThat(file.isFile()).isNotEqualTo(true);
|
||||
assertThat(file.isFile()).isFalse();
|
||||
|
||||
assertThat(file.getName()).isEqualTo("foo");
|
||||
assertThat(file.getName()).isNotEqualTo("foo");
|
||||
assertThat(file.getName()).isEqualTo(null);
|
||||
assertThat(file.getName()).isNull();
|
||||
assertThat(file.getName()).isNotEqualTo(null);
|
||||
assertThat(file.getName()).isNotNull();
|
||||
assertThat(file.getName()).isEmpty();
|
||||
assertThat(file.getName()).isNotEmpty();
|
||||
|
||||
assertThat(file.getParent()).isEqualTo("foo");
|
||||
assertThat(file.getParent()).isNotEqualTo("foo");
|
||||
assertThat(file.getParent()).isEqualTo(null);
|
||||
assertThat(file.getParent()).isNull();
|
||||
assertThat(file.getParent()).isNotEqualTo(null);
|
||||
assertThat(file.getParent()).isNotNull();
|
||||
assertThat(file.getParent()).isEmpty();
|
||||
assertThat(file.getParent()).isNotEmpty();
|
||||
|
||||
assertThat(file.getParentFile()).isEqualTo(new File("foo"));
|
||||
assertThat(file.getParentFile()).isNotEqualTo(new File("foo"));
|
||||
assertThat(file.getParentFile()).isEqualTo(null);
|
||||
assertThat(file.getParentFile()).isNull();
|
||||
assertThat(file.getParentFile()).isNotEqualTo(null);
|
||||
assertThat(file.getParentFile()).isNotNull();
|
||||
|
||||
assertThat(file.listFiles()).isNull();
|
||||
assertThat(file.listFiles()).isNullOrEmpty();
|
||||
assertThat(file.listFiles()).isEmpty();
|
||||
assertThat(file.listFiles()).isNotEmpty();
|
||||
|
||||
assertThat(file.list()).isNull();
|
||||
assertThat(file.list()).isNullOrEmpty();
|
||||
assertThat(file.list()).isEmpty();
|
||||
assertThat(file.list()).isNotEmpty();
|
||||
|
||||
assertThat(file.getName()).endsWith(".foo"); // could be turned into .hasExtension("foo"), but not always.
|
||||
|
||||
assertThat(file.getName()).as("foo").isEqualTo("foo").as("bar").isEqualTo("bar");
|
||||
|
||||
org.junit.Assert.assertThat(file, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
}
|
||||
@@ -73,6 +73,8 @@ public class GuavaOptional {
|
||||
|
||||
assertThat(opt.orNull()).as("foo").isEqualTo(null).isNotNull();
|
||||
|
||||
assertThat(Optional.of(new byte[] { 2, 3 }).get()).isEqualTo(new byte[] { 2, 3 }); // not working with assertj-guava 3.2.1
|
||||
|
||||
org.junit.Assert.assertThat(opt, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
|
||||
@@ -73,6 +73,8 @@ public class GuavaOptional {
|
||||
|
||||
assertThat(opt.orNull()).as("foo").isEqualTo(null).isNotNull();
|
||||
|
||||
assertThat(Optional.of(new byte[] { 2, 3 }).get()).isEqualTo(new byte[] { 2, 3 }); // not working with assertj-guava 3.2.1
|
||||
|
||||
org.junit.Assert.assertThat(opt, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
|
||||
@@ -26,9 +26,9 @@ public class Size {
|
||||
assertThat(list).isEmpty();
|
||||
assertThat(list).hasSameSizeAs(otherList);
|
||||
assertThat(list).hasSameSizeAs(array);
|
||||
assertThat(list).hasSize(string.length());
|
||||
assertThat(list).hasSize(stringBuilder.length());
|
||||
assertThat(list).hasSameSizeAs(map);
|
||||
assertThat(list).hasSize(string.length()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(list).hasSize(stringBuilder.length()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(list).hasSize(map.size()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(list).hasSize(1);
|
||||
assertThat(list).hasSizeGreaterThan(otherList.size() * 2);
|
||||
assertThat(list).hasSizeGreaterThanOrEqualTo(otherList.size() * 2);
|
||||
@@ -36,9 +36,9 @@ public class Size {
|
||||
assertThat(list).hasSizeLessThanOrEqualTo(otherList.size() * 2);
|
||||
assertThat(list).hasSameSizeAs(otherList);
|
||||
assertThat(list).hasSameSizeAs(array);
|
||||
assertThat(list).hasSize(string.length());
|
||||
assertThat(list).hasSize(stringBuilder.length());
|
||||
assertThat(list).hasSameSizeAs(map);
|
||||
assertThat(list).hasSize(string.length()); // currently unsupported in assertj
|
||||
assertThat(list).hasSize(stringBuilder.length()); // currently unsupported in assertj
|
||||
assertThat(list).hasSize(map.size()); // currently unsupported in assertj
|
||||
|
||||
assertThat(array).isEmpty();
|
||||
assertThat(array).isEmpty();
|
||||
@@ -49,9 +49,9 @@ public class Size {
|
||||
assertThat(array).isEmpty();
|
||||
assertThat(array).hasSameSizeAs(list);
|
||||
assertThat(array).hasSameSizeAs(otherArray);
|
||||
assertThat(array).hasSize(string.length());
|
||||
assertThat(array).hasSize(stringBuilder.length());
|
||||
assertThat(array).hasSameSizeAs(map);
|
||||
assertThat(array).hasSize(string.length()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(array).hasSize(stringBuilder.length()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(array).hasSize(map.size()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(array).hasSize(1);
|
||||
assertThat(array).hasSizeGreaterThan(otherArray.length - 1);
|
||||
assertThat(array).hasSizeGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
@@ -59,9 +59,9 @@ public class Size {
|
||||
assertThat(array).hasSizeLessThanOrEqualTo(1 - otherArray.length);
|
||||
assertThat(array).hasSameSizeAs(list);
|
||||
assertThat(array).hasSameSizeAs(otherArray);
|
||||
assertThat(array).hasSize(string.length());
|
||||
assertThat(array).hasSize(stringBuilder.length());
|
||||
assertThat(array).hasSameSizeAs(map);
|
||||
assertThat(array).hasSize(string.length()); // currently unsupported in assertj
|
||||
assertThat(array).hasSize(stringBuilder.length()); // currently unsupported in assertj
|
||||
assertThat(array).hasSize(map.size()); // currently unsupported in assertj
|
||||
|
||||
assertThat(string).isEmpty();
|
||||
assertThat(string).isEmpty();
|
||||
@@ -74,7 +74,7 @@ public class Size {
|
||||
assertThat(string).hasSameSizeAs(array);
|
||||
assertThat(string).hasSameSizeAs(string);
|
||||
assertThat(string).hasSameSizeAs(stringBuilder);
|
||||
assertThat(string).hasSameSizeAs(map);
|
||||
assertThat(string).hasSize(map.size()); // currently unsupported in assertj
|
||||
assertThat(string).hasSize(1);
|
||||
assertThat(string).hasSizeGreaterThan(array.length - 1);
|
||||
assertThat(string).hasSizeGreaterThanOrEqualTo(array.length + 1);
|
||||
@@ -84,7 +84,7 @@ public class Size {
|
||||
assertThat(string).hasSameSizeAs(array);
|
||||
assertThat(string).hasSameSizeAs(string);
|
||||
assertThat(string).hasSameSizeAs(stringBuilder);
|
||||
assertThat(string).hasSameSizeAs(map);
|
||||
assertThat(string).hasSize(map.size()); // currently unsupported in assertj
|
||||
|
||||
assertThat(stringBuilder).isEmpty();
|
||||
assertThat(stringBuilder).isEmpty();
|
||||
@@ -97,7 +97,7 @@ public class Size {
|
||||
assertThat(stringBuilder).hasSameSizeAs(array);
|
||||
assertThat(stringBuilder).hasSameSizeAs(string);
|
||||
assertThat(stringBuilder).hasSameSizeAs(stringBuilder);
|
||||
assertThat(stringBuilder).hasSameSizeAs(map);
|
||||
assertThat(stringBuilder).hasSize(map.size()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(stringBuilder).hasSize(1);
|
||||
assertThat(stringBuilder).hasSizeGreaterThan(array.length - 1);
|
||||
assertThat(stringBuilder).hasSizeGreaterThanOrEqualTo(array.length + 1);
|
||||
@@ -107,7 +107,7 @@ public class Size {
|
||||
assertThat(stringBuilder).hasSameSizeAs(array);
|
||||
assertThat(stringBuilder).hasSameSizeAs(string);
|
||||
assertThat(stringBuilder).hasSameSizeAs(stringBuilder);
|
||||
assertThat(stringBuilder).hasSameSizeAs(map);
|
||||
assertThat(stringBuilder).hasSize(map.size()); // currently unsupported in assertj
|
||||
|
||||
assertThat(map).isEmpty();
|
||||
assertThat(map).isEmpty();
|
||||
@@ -118,8 +118,8 @@ public class Size {
|
||||
assertThat(map).isEmpty();
|
||||
assertThat(map).hasSameSizeAs(list);
|
||||
assertThat(map).hasSameSizeAs(array);
|
||||
assertThat(map).hasSize(string.length());
|
||||
assertThat(map).hasSize(stringBuilder.length());
|
||||
assertThat(map).hasSize(string.length()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(map).hasSize(stringBuilder.length()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(map).hasSameSizeAs(otherMap);
|
||||
assertThat(map).hasSize(1);
|
||||
assertThat(map).hasSizeGreaterThan(array.length - 1);
|
||||
@@ -128,8 +128,8 @@ public class Size {
|
||||
assertThat(map).hasSizeLessThanOrEqualTo(1 - array.length);
|
||||
assertThat(map).hasSameSizeAs(list);
|
||||
assertThat(map).hasSameSizeAs(array);
|
||||
assertThat(map).hasSize(string.length());
|
||||
assertThat(map).hasSize(stringBuilder.length());
|
||||
assertThat(map).hasSize(string.length()); // currently unsupported in assertj
|
||||
assertThat(map).hasSize(stringBuilder.length()); // currently unsupported in assertj
|
||||
assertThat(map).hasSameSizeAs(otherMap);
|
||||
|
||||
assertThat(stringBuilder.length()).as("foo").isEqualTo(0).isZero().as("bar").isNotZero().isEqualTo(10);
|
||||
|
||||
@@ -26,9 +26,9 @@ public class Size {
|
||||
assertThat(list.size()).isLessThanOrEqualTo(0);
|
||||
assertThat(list.size()).isEqualTo(otherList.size());
|
||||
assertThat(list.size()).isEqualTo(array.length);
|
||||
assertThat(list.size()).isEqualTo(string.length());
|
||||
assertThat(list.size()).isEqualTo(stringBuilder.length());
|
||||
assertThat(list.size()).isEqualTo(map.size());
|
||||
assertThat(list.size()).isEqualTo(string.length()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(list.size()).isEqualTo(stringBuilder.length()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(list.size()).isEqualTo(map.size()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(list.size()).isEqualTo(1);
|
||||
assertThat(list.size()).isGreaterThan(otherList.size() * 2);
|
||||
assertThat(list.size()).isGreaterThanOrEqualTo(otherList.size() * 2);
|
||||
@@ -36,9 +36,9 @@ public class Size {
|
||||
assertThat(list.size()).isLessThanOrEqualTo(otherList.size() * 2);
|
||||
assertThat(list).hasSize(otherList.size());
|
||||
assertThat(list).hasSize(array.length);
|
||||
assertThat(list).hasSize(string.length());
|
||||
assertThat(list).hasSize(stringBuilder.length());
|
||||
assertThat(list).hasSize(map.size());
|
||||
assertThat(list).hasSize(string.length()); // currently unsupported in assertj
|
||||
assertThat(list).hasSize(stringBuilder.length()); // currently unsupported in assertj
|
||||
assertThat(list).hasSize(map.size()); // currently unsupported in assertj
|
||||
|
||||
assertThat(array.length).isEqualTo(0);
|
||||
assertThat(array.length).isZero();
|
||||
@@ -49,9 +49,9 @@ public class Size {
|
||||
assertThat(array.length).isLessThanOrEqualTo(0);
|
||||
assertThat(array.length).isEqualTo(list.size());
|
||||
assertThat(array.length).isEqualTo(otherArray.length);
|
||||
assertThat(array.length).isEqualTo(string.length());
|
||||
assertThat(array.length).isEqualTo(stringBuilder.length());
|
||||
assertThat(array.length).isEqualTo(map.size());
|
||||
assertThat(array.length).isEqualTo(string.length()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(array.length).isEqualTo(stringBuilder.length()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(array.length).isEqualTo(map.size()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(array.length).isEqualTo(1);
|
||||
assertThat(array.length).isGreaterThan(otherArray.length - 1);
|
||||
assertThat(array.length).isGreaterThanOrEqualTo(otherArray.length + 1);
|
||||
@@ -59,9 +59,9 @@ public class Size {
|
||||
assertThat(array.length).isLessThanOrEqualTo(1 - otherArray.length);
|
||||
assertThat(array).hasSize(list.size());
|
||||
assertThat(array).hasSize(otherArray.length);
|
||||
assertThat(array).hasSize(string.length());
|
||||
assertThat(array).hasSize(stringBuilder.length());
|
||||
assertThat(array).hasSize(map.size());
|
||||
assertThat(array).hasSize(string.length()); // currently unsupported in assertj
|
||||
assertThat(array).hasSize(stringBuilder.length()); // currently unsupported in assertj
|
||||
assertThat(array).hasSize(map.size()); // currently unsupported in assertj
|
||||
|
||||
assertThat(string.length()).isEqualTo(0);
|
||||
assertThat(string.length()).isZero();
|
||||
@@ -74,7 +74,7 @@ public class Size {
|
||||
assertThat(string.length()).isEqualTo(array.length);
|
||||
assertThat(string.length()).isEqualTo(string.length());
|
||||
assertThat(string.length()).isEqualTo(stringBuilder.length());
|
||||
assertThat(string.length()).isEqualTo(map.size());
|
||||
assertThat(string.length()).isEqualTo(map.size()); // currently unsupported in assertj
|
||||
assertThat(string.length()).isEqualTo(1);
|
||||
assertThat(string.length()).isGreaterThan(array.length - 1);
|
||||
assertThat(string.length()).isGreaterThanOrEqualTo(array.length + 1);
|
||||
@@ -84,7 +84,7 @@ public class Size {
|
||||
assertThat(string).hasSize(array.length);
|
||||
assertThat(string).hasSize(string.length());
|
||||
assertThat(string).hasSize(stringBuilder.length());
|
||||
assertThat(string).hasSize(map.size());
|
||||
assertThat(string).hasSize(map.size()); // currently unsupported in assertj
|
||||
|
||||
assertThat(stringBuilder.length()).isEqualTo(0);
|
||||
assertThat(stringBuilder.length()).isZero();
|
||||
@@ -97,7 +97,7 @@ public class Size {
|
||||
assertThat(stringBuilder.length()).isEqualTo(array.length);
|
||||
assertThat(stringBuilder.length()).isEqualTo(string.length());
|
||||
assertThat(stringBuilder.length()).isEqualTo(stringBuilder.length());
|
||||
assertThat(stringBuilder.length()).isEqualTo(map.size());
|
||||
assertThat(stringBuilder.length()).isEqualTo(map.size()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(stringBuilder.length()).isEqualTo(1);
|
||||
assertThat(stringBuilder.length()).isGreaterThan(array.length - 1);
|
||||
assertThat(stringBuilder.length()).isGreaterThanOrEqualTo(array.length + 1);
|
||||
@@ -107,7 +107,7 @@ public class Size {
|
||||
assertThat(stringBuilder).hasSize(array.length);
|
||||
assertThat(stringBuilder).hasSize(string.length());
|
||||
assertThat(stringBuilder).hasSize(stringBuilder.length());
|
||||
assertThat(stringBuilder).hasSize(map.size());
|
||||
assertThat(stringBuilder).hasSize(map.size()); // currently unsupported in assertj
|
||||
|
||||
assertThat(map.size()).isEqualTo(0);
|
||||
assertThat(map.size()).isZero();
|
||||
@@ -118,8 +118,8 @@ public class Size {
|
||||
assertThat(map.size()).isLessThanOrEqualTo(0);
|
||||
assertThat(map.size()).isEqualTo(list.size());
|
||||
assertThat(map.size()).isEqualTo(array.length);
|
||||
assertThat(map.size()).isEqualTo(string.length());
|
||||
assertThat(map.size()).isEqualTo(stringBuilder.length());
|
||||
assertThat(map.size()).isEqualTo(string.length()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(map.size()).isEqualTo(stringBuilder.length()); // does currently not support hasSameSizeAs() in assertj
|
||||
assertThat(map.size()).isEqualTo(otherMap.size());
|
||||
assertThat(map.size()).isEqualTo(1);
|
||||
assertThat(map.size()).isGreaterThan(array.length - 1);
|
||||
@@ -128,8 +128,8 @@ public class Size {
|
||||
assertThat(map.size()).isLessThanOrEqualTo(1 - array.length);
|
||||
assertThat(map).hasSize(list.size());
|
||||
assertThat(map).hasSize(array.length);
|
||||
assertThat(map).hasSize(string.length());
|
||||
assertThat(map).hasSize(stringBuilder.length());
|
||||
assertThat(map).hasSize(string.length()); // currently unsupported in assertj
|
||||
assertThat(map).hasSize(stringBuilder.length()); // currently unsupported in assertj
|
||||
assertThat(map).hasSize(otherMap.size());
|
||||
|
||||
assertThat(stringBuilder.length()).as("foo").isEqualTo(0).isZero().as("bar").isNotZero().isEqualTo(10);
|
||||
|
||||
@@ -26,6 +26,8 @@ public class StringExpression {
|
||||
assertThat(string).startsWith("foo");
|
||||
assertThat(string).endsWith("foo");
|
||||
assertThat(string).endsWith("foo");
|
||||
assertThat(string).matches("foo");
|
||||
assertThat(string).matches("foo");
|
||||
|
||||
assertThat(string).as("foo").isNotEmpty();
|
||||
assertThat(string).isNotEmpty();
|
||||
@@ -46,11 +48,43 @@ public class StringExpression {
|
||||
assertThat(string).doesNotStartWith("foo");
|
||||
assertThat(string).doesNotEndWith("foo");
|
||||
assertThat(string).doesNotEndWith("foo");
|
||||
assertThat(string).doesNotMatch("foo");
|
||||
assertThat(string).doesNotMatch("foo");
|
||||
|
||||
assertThat(string).as("foo").doesNotEndWith("foo").as("bar").doesNotEndWith("foo");
|
||||
assertThat(string.endsWith("foo")).as("foo").isEqualTo(false).as("bar").isTrue();
|
||||
assertThat(string.endsWith("foo")).as("foo").satisfies(it -> it.booleanValue()).as("bar").isFalse();
|
||||
|
||||
assertThat(string).isEqualToIgnoringCase("foo");
|
||||
assertThat(string).isEqualToIgnoringCase("foo");
|
||||
assertThat(string.compareToIgnoreCase("foo")).isEqualTo(1);
|
||||
assertThat(string.compareToIgnoreCase("foo")).isLessThan(0);
|
||||
|
||||
assertThat(string).isNotEqualToIgnoringCase("foo");
|
||||
assertThat(string).isNotEqualToIgnoringCase("foo");
|
||||
assertThat(string.compareToIgnoreCase("foo")).isNotEqualTo(1);
|
||||
assertThat(string.compareToIgnoreCase("foo")).isGreaterThan(0);
|
||||
|
||||
assertThat(string).startsWith("foo");
|
||||
assertThat(string).doesNotStartWith("foo");
|
||||
assertThat(string).startsWith("foo");
|
||||
assertThat(string.indexOf("foo")).isEqualTo(1);
|
||||
assertThat(string).doesNotContain("foo");
|
||||
assertThat(string).doesNotStartWith("foo");
|
||||
assertThat(string.indexOf("foo")).isNotEqualTo(1);
|
||||
assertThat(string).contains("foo");
|
||||
assertThat(string).doesNotContain("foo");
|
||||
assertThat(string).doesNotContain("foo");
|
||||
assertThat(string).contains("foo");
|
||||
assertThat(string).contains("foo");
|
||||
assertThat(string).doesNotContain("foo");
|
||||
assertThat(string.indexOf("foo")).isPositive();
|
||||
assertThat(string).contains("foo");
|
||||
assertThat(string.indexOf("foo")).isNotPositive();
|
||||
|
||||
assertThat(string.trim()).isEmpty(); // would turn into isJavaBlank(), which is deprecated. Should be isNotNull().isBlank() then...
|
||||
assertThat(string).isNotBlank();
|
||||
|
||||
org.junit.Assert.assertThat(string, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
|
||||
@@ -26,6 +26,8 @@ public class StringExpression {
|
||||
assertThat(string.startsWith("foo")).isTrue();
|
||||
assertThat(string.endsWith("foo")).isEqualTo(true);
|
||||
assertThat(string.endsWith("foo")).isTrue();
|
||||
assertThat(string.matches("foo")).isEqualTo(true);
|
||||
assertThat(string.matches("foo")).isTrue();
|
||||
|
||||
assertThat(string.isEmpty()).as("foo").isEqualTo(false);
|
||||
assertThat(string.isEmpty()).isNotEqualTo(true);
|
||||
@@ -46,11 +48,43 @@ public class StringExpression {
|
||||
assertThat(string.startsWith("foo")).isFalse();
|
||||
assertThat(string.endsWith("foo")).isEqualTo(false);
|
||||
assertThat(string.endsWith("foo")).isFalse();
|
||||
assertThat(string.matches("foo")).isEqualTo(false);
|
||||
assertThat(string.matches("foo")).isFalse();
|
||||
|
||||
assertThat(string.endsWith("foo")).as("foo").isEqualTo(false).as("bar").isFalse();
|
||||
assertThat(string.endsWith("foo")).as("foo").isEqualTo(false).as("bar").isTrue();
|
||||
assertThat(string.endsWith("foo")).as("foo").satisfies(it -> it.booleanValue()).as("bar").isFalse();
|
||||
|
||||
assertThat(string.compareToIgnoreCase("foo")).isEqualTo(0);
|
||||
assertThat(string.compareToIgnoreCase("foo")).isZero();
|
||||
assertThat(string.compareToIgnoreCase("foo")).isEqualTo(1);
|
||||
assertThat(string.compareToIgnoreCase("foo")).isLessThan(0);
|
||||
|
||||
assertThat(string.compareToIgnoreCase("foo")).isNotEqualTo(0);
|
||||
assertThat(string.compareToIgnoreCase("foo")).isNotZero();
|
||||
assertThat(string.compareToIgnoreCase("foo")).isNotEqualTo(1);
|
||||
assertThat(string.compareToIgnoreCase("foo")).isGreaterThan(0);
|
||||
|
||||
assertThat(string.indexOf("foo")).isZero();
|
||||
assertThat(string.indexOf("foo")).isNotZero();
|
||||
assertThat(string.indexOf("foo")).isEqualTo(0);
|
||||
assertThat(string.indexOf("foo")).isEqualTo(1);
|
||||
assertThat(string.indexOf("foo")).isEqualTo(-1);
|
||||
assertThat(string.indexOf("foo")).isNotEqualTo(0);
|
||||
assertThat(string.indexOf("foo")).isNotEqualTo(1);
|
||||
assertThat(string.indexOf("foo")).isNotEqualTo(-1);
|
||||
assertThat(string.indexOf("foo")).isLessThan(0);
|
||||
assertThat(string.indexOf("foo")).isLessThanOrEqualTo(-1);
|
||||
assertThat(string.indexOf("foo")).isGreaterThan(-1);
|
||||
assertThat(string.indexOf("foo")).isGreaterThanOrEqualTo(0);
|
||||
assertThat(string.indexOf("foo")).isNegative();
|
||||
assertThat(string.indexOf("foo")).isPositive();
|
||||
assertThat(string.indexOf("foo")).isNotNegative();
|
||||
assertThat(string.indexOf("foo")).isNotPositive();
|
||||
|
||||
assertThat(string.trim()).isEmpty(); // would turn into isJavaBlank(), which is deprecated. Should be isNotNull().isBlank() then...
|
||||
assertThat(string.trim()).isNotEmpty();
|
||||
|
||||
org.junit.Assert.assertThat(string, null);
|
||||
fail("oh no!");
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user