AssertBetweenInconvertibleTypes false positive generated when AbstractAssert#isEqualTo follows AbstractIterableAssert#first() #12

New Issue

MrQueasy · 2023-09-20T19:28:44+02:00

MrQueasy commented

2023-09-20 19:28:44 +02:00

The warning 'isEqualTo()' between objects of inconvertible types 'ArrayList<Integer>' and 'int'

is being generated by the following code:

final var test = new ArrayList<Integer>();
test.add(1);
assertThat(test).first().isEqualTo(1);

This is happening no matter what the generic type ends up being.

This code does not produce the warning:

final var test = new ArrayList<Integer>();
test.add(1);
final ListAssert<Integer> listAssert = assertThat(test);
final ObjectAssert<Integer> objAssert = listAssert.first();
objAssert.isEqualTo(1);

The warning `'isEqualTo()' between objects of inconvertible types 'ArrayList<Integer>' and 'int'` is being generated by the following code: ```java final var test = new ArrayList<Integer>(); test.add(1); assertThat(test).first().isEqualTo(1); ``` This is happening no matter what the generic type ends up being. This code _does not_ produce the warning: ```java final var test = new ArrayList<Integer>(); test.add(1); final ListAssert<Integer> listAssert = assertThat(test); final ObjectAssert<Integer> objAssert = listAssert.first(); objAssert.isEqualTo(1); ```

MrQueasy commented

2023-09-20 19:30:33 +02:00

Installation info:
IntelliJ IDEA 2023.2.1 (Ultimate Edition)
Build #IU-232.9559.62, built on August 22, 2023
Runtime version: 17.0.8+7-b1000.8 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.

Installation info: IntelliJ IDEA 2023.2.1 (Ultimate Edition) Build #IU-232.9559.62, built on August 22, 2023 Runtime version: 17.0.8+7-b1000.8 x86_64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.

chrisly42 commented

2023-10-01 15:56:47 +02:00

Hi Mr. Queasy,

I'm not sure what your report is about. The AssertBetweenInconvertibleTypes inspection is, as far as I know, an inspection of the IntelliJ core and not generated by Cajon. Thus, this should be addressed to Jetbrains rather than me.

Please clarify, otherwise I will close this issue as invalid. Thank you.

Hi Mr. Queasy, I'm not sure what your report is about. The AssertBetweenInconvertibleTypes inspection is, as far as I know, an inspection of the IntelliJ core and not generated by Cajon. Thus, this should be addressed to Jetbrains rather than me. Please clarify, otherwise I will close this issue as invalid. Thank you.

chrisly42 commented

2023-10-04 13:21:23 +02:00

Not sure you saw my reply, I had email notifications disabled, but they should be working now (hopefully).

chrisly42 added the

invalid

label 2023-10-10 21:05:55 +02:00

chrisly42 closed this issue

2023-10-10 21:05:55 +02:00

Sign in to join this conversation.