chrisly42/PretrackerRaspberryCasket
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Optimized SongInit a bit #1

Closed
emoon wants to merge 1 commits from song-init-opt into main
pull from: song-init-opt
merge into: chrisly42:main
Conversation 1 Commits 1 Files Changed 1 +3 -1
emoon commented 2022-12-28 16:53:45 +01:00 (Migrated from github.com)
Copy Link

I just had a quick look at the code and noticed the mul with 15 and figured that it can be replaced with shift + sub instead. I haven't done any testing of this code, but I figured I could just do a PR with it and you use it if you want.

If I done my math right it saves 20 cycles each iteration, but it does add 4 bytes in size.

I just had a quick look at the code and noticed the mul with `15` and figured that it can be replaced with shift + sub instead. I haven't done any testing of this code, but I figured I could just do a PR with it and you use it if you want. If I done my math right it saves 20 cycles each iteration, but it does add 4 bytes in size.
chrisly42 commented 2022-12-28 19:00:31 +01:00 (Migrated from github.com)
Copy Link

Thanks for looking into it. SongInit is optimized for size, not for speed, especially as this case is called at most 23 times. Filesize is two bytes larger, but the shrinkled size three bytes more, so I'd rather not change the code as I see no benefit.

Thanks for looking into it. SongInit is optimized for size, not for speed, especially as this case is called at most 23 times. Filesize is two bytes larger, but the shrinkled size three bytes more, so I'd rather not change the code as I see no benefit.
👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
chrisly42
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: chrisly42/PretrackerRaspberryCasket#1
No description provided.
Delete Branch "song-init-opt"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?